Flask of Enhancement works perfectly now

Shaman Weapon buffs still work the same way. Need to have them in the correct order on the list, otherwise its still buffing main hand with whatever buff is highest on the list, then buffs offhand correctly.

The weapon buff is a minor glitch, since it can be corrected by just moving the buffs into correct order.

Good job on the flask fixes tho, i know you couldnt test them, but they are now working correctly.

Ya, not sure why Blizzard wanted to go with 3 different spell names for the same flask (buff).

Flask of the North had 1 buff name / spell id for all 3 buffs. New Flask of Enhancement uses unique buff names.

Hopefully not too difficult of a fix.

Didnt even know this was an option lol.

But yes, this completely fixes the weapon buffing issue i was having. Works flawlessly now

Using 4.0e Dev3, still having the same issue with Flask of Enhancement. I believe there are 3 spells that can activate with this flask:

-Enhanced Intellect (Spell ID 79640)
-Enhanced Agility (Spell ID 79639)
-Enhanced Strength (Spell ID 79638)

Depending on your highest stat. Currently Smartbuff still tries to cast Flask of Enhancement, after receiving the Enhanced Intellect buff and Enhanced Agility buff. Was unable to test Enhanced Strength.


Also, and this is just a typo on the Addon Info page, all the versions are listed as SmartDebuff not Smartbuff ;p (Might confused some people).

As always, thanks for keeping this mod updated and working. I know i have been using it for several years


EDIT: A completely different issue with enhancement shaman weapon buffing, if you find some time to look at it.

Windfury Weapon is primarily a main hand enchant, but can also be used in the offhand.

Frostbrand Weapon is primarily a main hand enchant for pvp.

Flametongue Weapon in this expansion will always be used as an offhand enchant. Can't think of any reasons for it to be a mainhand (for enhancement).


The Problem: Whichever weapon enchant gets applied first, goes onto the main hand, and the second enchant will go onto the offhand.

So currently, even if you set Flametongue Weapon to buff offhand, and then set Frostbrand to mainhand, Smartbuff will always buff Flametongue first because its placed above Frostbrand in the order of buffs to apply. This results in a Flametongue mainhand, Flametongue offhand enchants. Will never get to buffing Frostbrand because the mainhand was given Flametongue.

This is never an issue for Windfury / Flametongue because Windfury is above Flametongue in the buff order list.


I believe the simplest fix would to just move Frostbrand above Flametongue in the buff order.

Hope all that made some kind of sense ;p

Something is wrong with the newest update. If I chose in group to use cata buff-food, it's activated for alle other templates, solo, raid, bg etc. If I close Smartbuff Window the hook on the food is disappeared.

Still something a little wonky with newest update and notifications.

If i use Flask of Enhancement, and have it set to notify when 3 minutes is left on the flask, it will constantly notify me saying i need the flask

It will also constantly try to use the flask even with the flask on. I couldnt find a fix at all, but i am no good at lua ;p


One thing to note about Flask of Enhancement (the new infinite alchy flask, replacement for Flask of the North), is that you can not overwrite it, with itself.

If you still have 2 minutes on the flask, you must wait 2 minutes before reapplying this buff (or canceling it). Not sure if this is a bliizzard bug or intended (im sure its a bug), and this may be whats causing Smart Buff to want to continuously try to rebuff this at all times?


EDIT: A completely different issue with enhancement shaman weapon buffing, if you find some time to look at it.

Flametongue weapon will 100% go on the offhand weapon, never on the main hand, and you will never use double Flametongue (atleast not for anything i can think of).

Windfury will always go main hand, and Frostbrand will always go mainhand (Frostbrand more used for pvp).

The current problem is, whichever weapon enchant gets applied first, goes onto the main hand, and the second enchant will go onto the second weapon.

So currently, even if you set Flametongue Weapon to buff offhand, and then set Frostbrand to mainhand, Smartbuff will always do Flametongue / Flametongue.

This is never an issue for Windfury / Flametongue because Windfury is above Flametongue in the buff order list.


I believe the simplist fix would to just move Frostbrand above Flametongue in the buff order.

Hope all that made some kind of sense ;p

Ok, i was able to get Smart Buff to correctly use Flask of Enhancement.

Interface > Addons > Smartbuff > SmartBuff.buffs

Change:

SMARTBUFF_FLASKCT6 = GetItemInfo(80724); --"Flask of Enhancement"

To:

SMARTBUFF_FLASKCT6 = GetItemInfo(58149); --"Flask of Enhancement"



I have a feeling alot of the newer flask items will have the wrong ID. I didnt check them all, but i looked at Flask of Flowing Waters and it also appears to have the wrong ID (tho not tested since i didnt have the flask). Just comparing the ID numbers from wowhead to what is in the lua file, and they dont match.

Not sure which Smartbuff is most up to date.

This one, or the one linked on the description page?



Flask of Enhancement (new alchy profession buff), is not working with either version sadly.

A further revelation: after turning Shadow Protection and prayer of Shadow Protection off entirely in /sbm, SmartBuff STILL wanted to cast them when the timers from the previous round began to run out.

I can confirm that Prayer of Shadow Protection is sometimes cast multiple times in raids. I believe it may have something to do with the old re-cast timer not being cleared properly, as it only seems to happen on re-buffs. That is to say, the first time POSP is cast, there have not been issues that I can recall, but the next time, i almost always have to check each click to avoid wasting candles.

I have also noticed that using /sb sync (or /sbo sync in the latest version -- is that a typo?) will usually fix the problem until the next round of rebuffs.