Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(3 Kb)
Download
Updated: 06-15-09 03:57 AM
Pictures
File Info
Updated:06-15-09 03:57 AM
Created:12-17-08 02:01 PM
Downloads:2,233
Favorites:43
MD5:
TabardChampion
Version: 1.1
by: yess [More]
about:
I don't like tabards and I have missed allot reputation because of forgetting to equip the tabard after entering an instance...

What it does:

This addon will make you a Tabard Champion and will equip a tabard (that you have set) any time you enter an 5-man instance.
And it will take off the tabard if you leave an instance.
Or you cant set a tabard to be equipped when not in an instance.

Usage:
/tc
-----------------------------------------------------------------------
r13 | yess | 2009-05-26 14:41:04 +0000 (Tue, 26 May 2009) | 1 line
Changed paths:
M /trunk/TabardChampion.lua

fixed instance tabard could not be set
------------------------------------------------------------------------
r12 | yess | 2009-05-24 22:27:13 +0000 (Sun, 24 May 2009) | 1 line
Changed paths:
M /trunk/TabardChampion.lua
M /trunk/TabardChampion.toc

replaced console commands with InterfaceOptionsFrame gui
------------------------------------------------------------------------
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Author
Date
r6
2kB
yess
12-18-08 11:13 PM
r4
2kB
yess
12-17-08 02:01 PM


Post A Reply Comment Options
Unread 12-22-11, 10:38 AM  
def9
A Cobalt Mageweaver
 
def9's Avatar
AddOn Author - Click to view AddOns

Forum posts: 203
File comments: 104
Uploads: 2
This unfortunately doesn't work for me at all. Actually every time I opened the options to make sure I'd set my tabards it created a new entry in my gui. Also even though it listed the tabards I'd selected it never switched them upon entering heroics (I didn't try with regular or raids).

__________________
Krendis, level 90 Prot Paladin
Simkin level 90 Combat Rogue
Feldeemus, level 90 Frost Mage
def9 is offline Report comment to moderator  
Reply With Quote
Unread 06-15-09, 06:19 AM  
marvellos
A Kobold Labourer

Forum posts: 0
File comments: 14
Uploads: 0
great addon
marvellos is offline Report comment to moderator  
Reply With Quote
Unread 12-22-08, 10:35 PM  
shobu
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 5
File comments: 83
Uploads: 1
This addon rules!! Thanks!
shobu is offline Report comment to moderator  
Reply With Quote
Unread 12-20-08, 01:11 PM  
Freki
A Deviate Faerie Dragon
 
Freki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 94
Uploads: 6
Originally posted by yess
Well I did it that way, did some testing and tough "hey it works", fine I am done
I told a friend its done and he's like "OK but what if you get a dc in an instance and log in again?"
The addon will think you are entering an instance and set the OriginalTabard
to the one you are wearing. But you are wearing the InstanceTabard already...

There are several ways to check for that too but we did come up with other problems like when you change your tabard an then logout. Now on your next login the event PLAYER_ENTERING_WORLD will fire and the addon will equip your old tabard because it thinks you left an instance and the new one was never saved before. Or it will take off your tabard if there isn't a saved one.

That's why I thought it would be easier to register the event for inventory updates and save it that way.
I had a version where you can set the 2. tabard manually finished therefore I released that and postponed that feature^^

You can join development on my version if you like. Its on wowace svn://svn.wowace.com/wow/ihatetabards/mainline/trunk (lol the old name) and anyone can commit to the repository
Ah yes, good ol' disconnects will ruin it. You're right.. not much you can do to avoid that. Your way is probably the best way for the masses. I'll keep my version and hope that I don't disconnect
Freki is offline Report comment to moderator  
Reply With Quote
Unread 12-20-08, 12:57 AM  
yess
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 42
Uploads: 4
Originally posted by Freki
Hi yess, I spent an hour or so earlier today making a mod that did this exact same thing before I realized you had made this. You beat me to it I guess Anyways, what was the problem you had with "remembering" the tabard they wore before the switch? This is how I did it in my addon and I didn't run into any problems with the (limited) testing I did.

Here's the relevent code I used to do this:
Code:
function TabardChamp:PLAYER_DEAD()
    TabardChamp_Saved.Dead = true
end

function TabardChamp:PLAYER_ENTERING_WORLD()
    if TabardChamp_Saved.InstanceTabard then
        local inInstance, instanceType = IsInInstance()
        if inInstance and instanceType == "party" then
            if not TabardChamp_Saved.Dead then
                TabardChamp_Saved.OriginalTabard = GetItemInfo(GetInventoryItemLink("player", 19))
            elseif not UnitIsDead("player") then
                TabardChamp_Saved.Dead = nil
            end
            EquipItemByName(TabardChamp_Saved.InstanceTabard)
        elseif TabardChamp_Saved.OriginalTabard then
            EquipItemByName(TabardChamp_Saved.OriginalTabard)
        end
    end
end
This seems to work fine in my addon. Is this the same way you were going about doing it?

Edit: Tried to change it to realize the being dead issue you seemed to recognize taking a look at your code. Not sure if it works I'll have to test.
Well I did it that way, did some testing and tough "hey it works", fine I am done
I told a friend its done and he's like "OK but what if you get a dc in an instance and log in again?"
The addon will think you are entering an instance and set the OriginalTabard
to the one you are wearing. But you are wearing the InstanceTabard already...

There are several ways to check for that too but we did come up with other problems like when you change your tabard an then logout. Now on your next login the event PLAYER_ENTERING_WORLD will fire and the addon will equip your old tabard because it thinks you left an instance and the new one was never saved before. Or it will take off your tabard if there isn't a saved one.

That's why I thought it would be easier to register the event for inventory updates and save it that way.
I had a version where you can set the 2. tabard manually finished therefore I released that and postponed that feature^^

You can join development on my version if you like. Its on wowace svn://svn.wowace.com/wow/ihatetabards/mainline/trunk (lol the old name) and anyone can commit to the repository
Last edited by yess : 12-20-08 at 12:58 AM.
yess is offline Report comment to moderator  
Reply With Quote
Unread 12-19-08, 11:20 PM  
Freki
A Deviate Faerie Dragon
 
Freki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 94
Uploads: 6
Originally posted by yess
I tried that but there are some problems doing it that way. I could check for inventory updates and save the tabard if it has changed outside of an instance. Maybe in a future version.
Hi yess, I spent an hour or so earlier today making a mod that did this exact same thing before I realized you had made this. You beat me to it I guess Anyways, what was the problem you had with "remembering" the tabard they wore before the switch? This is how I did it in my addon and I didn't run into any problems with the (limited) testing I did.

Here's the relevent code I used to do this:
Code:
function TabardChamp:PLAYER_DEAD()
    TabardChamp_Saved.Dead = true
end

function TabardChamp:PLAYER_ENTERING_WORLD()
    if TabardChamp_Saved.InstanceTabard then
        local inInstance, instanceType = IsInInstance()
        if inInstance and instanceType == "party" then
            if not TabardChamp_Saved.Dead then
                TabardChamp_Saved.OriginalTabard = GetItemInfo(GetInventoryItemLink("player", 19))
            elseif not UnitIsDead("player") then
                TabardChamp_Saved.Dead = nil
            end
            EquipItemByName(TabardChamp_Saved.InstanceTabard)
        elseif TabardChamp_Saved.OriginalTabard then
            EquipItemByName(TabardChamp_Saved.OriginalTabard)
        end
    end
end
This seems to work fine in my addon. Is this the same way you were going about doing it?

Edit: Tried to change it to realize the being dead issue you seemed to recognize taking a look at your code. Not sure if it works I'll have to test.
Last edited by Freki : 12-19-08 at 11:37 PM.
Freki is offline Report comment to moderator  
Reply With Quote
Unread 12-18-08, 11:34 PM  
yess
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 42
Uploads: 4
Originally posted by stqn
Just make it remember which tabard, if any, the player had on him/her when entering the (lvl 80) instance, and restore it when leaving, or remove the rep tabard if the player wasn't wearing one before.
I tried that but there are some problems doing it that way. I could check for inventory updates and save the tabard if it has changed outside of an instance. Maybe in a future version.
yess is offline Report comment to moderator  
Reply With Quote
Unread 12-18-08, 07:07 AM  
stqn
A Deviate Faerie Dragon

Forum posts: 10
File comments: 76
Uploads: 0
Just make it remember which tabard, if any, the player had on him/her when entering the (lvl 80) instance, and restore it when leaving, or remove the rep tabard if the player wasn't wearing one before.
stqn is offline Report comment to moderator  
Reply With Quote
Unread 12-17-08, 08:57 PM  
yess
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 42
Uploads: 4
Originally posted by Tyrolit
Hmmm

As a guild leader I Love a Tabard ( the guild one ) and ask my guild to wear it at all times out of 80 instances.

However I am allways forgeting to equip my rep tabard as i enter 80 instances, so this addon is begining to sound like something I realy need.

Make it Recognise the Guild Tabbard, and swap / put back on after run. Please
OK I will add an option to (optionality) set a second tabard that will be equipped on leaving an instance.
But maybe I should rename the addon then lol. Any ideas?
yess is offline Report comment to moderator  
Reply With Quote
Unread 12-17-08, 06:17 PM  
Miralen
A Rage Talon Dragon Guard
 
Miralen's Avatar

Forum posts: 330
File comments: 79
Uploads: 0
I would definitely say make swapping the guild tabard on when out of an instance an option, don't make it an absolute thing where it will for sure do it some people out there (me and I am sure others) refuse to wear guild tabards for many reasons.
__________________
"Freedom is never more than one generation away from extinction. We didn't pass it to our children in the bloodstream. It must be fought for, protected, and handed on for them to do the same, or one day we will spend our sunset years telling our children and our children's children what it was once like in the United States where men were free." - Ronald Reagan
Miralen is offline Report comment to moderator  
Reply With Quote
Unread 12-17-08, 05:57 PM  
Tyrolit
A Black Drake
 
Tyrolit's Avatar
AddOn Author - Click to view AddOns

Forum posts: 88
File comments: 13
Uploads: 3
Hmmm

As a guild leader I Love a Tabard ( the guild one ) and ask my guild to wear it at all times out of 80 instances.

However I am allways forgeting to equip my rep tabard as i enter 80 instances, so this addon is begining to sound like something I realy need.

Make it Recognise the Guild Tabbard, and swap / put back on after run. Please
__________________
click HERE for the ultimate idiot test.
Last edited by Tyrolit : 12-17-08 at 05:57 PM.
Tyrolit is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: