Download
(26 Kb)
Download
Updated: 09-11-13 03:39 AM
Pictures
File Info
Compatibility:
Siege of Orgrimmar (5.4)
Escalation (5.3)
Thunder Isle (5.2)
Landfall (5.1)
Mists of Pandaria (5.0.4)
Updated:09-11-13 03:39 AM
Created:01-04-09 10:55 AM
Downloads:47,442
Favorites:748
MD5:
Categories:Data Broker, TradeSkill Mods
5.4
Ara Broker Tradeskills  Popular! (More than 5000 hits)
Version: 540.1
by: Aranarth, Alyred
This data broker plugin provides easy access to tradeskills & tracked CDs (now stable, thanks to beta testers ).

Supported languages: English, French, German, Chinese, Korean. Looking for Russian, Italian, Spanish, Latin American Spanish localizations!

The first time you use this addon, you will have to scan for existing CDs, or craft them. Then, CD tracking will be automatic.

New in 540.1:
- Added new crafting skill cooldowns (Tailoring, Blacksmithing, Leatherworking, Engineering).
- Updated TOC for 5.4.

New in R505.21:
- German localization complete.
- Added back in Lockpicking as a displayable skill on Rogues.

New in R44Beta:
Mostly fixes for MoP. Added in most of the new cooldowns.

Block interactions:
- Click to open the last selected tradeskill.
- Right-click to access the config menu.


The list has 3 categories: tradeskills, cooldowns and shortcuts. The ingame hints show how you can interact on each entry. Here is a list:


Tradeskill interactions:
- Click to open the tradeskill panel.
- Shift+Click to link in chat.
- Right-click to scan for CDs.
- Middle-click to hide it from the list.

Cooldown interactions:
- Click to craft; if it's cooling down, it opens the tradeskill panel and scroll to the CD instead.
- Right-click to open the tradeskill window and scroll to the CD.
- Control+click to set or remove an alias.
- Middle-click to remove (only remove ready CD, unless you set the option to bypass this protection).

Shortcuts interactions:
- Click to craft.
- Shift+Click to craft all. (also works with buttons 4-5 and no modifiers)
- Right-Click to open the associated panel and scroll to it.
- Control+Click to set or remove an alias.
- Middle-Click to remove.

Config menu:
- Filter tradeskills (2 filtering levels).
- Track a particular profession.
- Include ready CDs when scanning: by default, when you scan a profession, it only adds cooling down CDs.
- Show/Hide hints.
- Show/Hide alts skills.
- Show only primary skills in the alt. tooltip (can be combined).
- Show only professions that have a craft window (can be combined).
- Remove alts data.
- Display the number of ready CD (instead of the last selected tradeskill).
- Edit signaletic colors (see below).

I went overboard with colors ._. and you can edit 7 different ones:
- Headers
- Name of interactive skills (with panel)
- Name of informative skills (without panel)
- CDs belonging to the current player
- CDs belonging to an alt.
- Last selected skill
- Highlight

Default tradeskill signaletic:
- Orange entry is the tracked or last selected profession.
- Yellow/gold entries have a panel and can be clicked.
- Darker yellow/gold entries only provide information (they have no panel).

Default cooldown signaletic:
- Yellow/gold entries are CDs owned by the current character.
- Darker yellow/gold entries are CDs owned by your other characters.

If you have AddonLoader, the loading of this addon will be delayed.
If you have Skinner, this plugin will be automatically skinned.
If you have ProfessionsBook, an entry to open it will be added to the list.
r530.2
More updates to the cooldown tracking and timers. Added the Serpent's Heart.

r530.11b BETA
Minor update to the Magnificence cooldown group. Think this should work better.

r530.1b BETA
Well... I got a cooldown workaround working! Guess it took a few months, sorry about that. Still may be a bit of a problem with both of the leatherworking magnificence cooldowns going on CD once the other is (they should), so that needs some testing there, and I don't have a leatherworker at 90 yet. Also test the cooldown time reporting in general. It should work. Let me know what you guys think.

r530.01b BETA
Updated TOC, added in Lightning Steel and Magnificence cooldowns (The lightning steel I had already built, the Magnificence cooldowns, I hadn't -- thanks Griffin224), finished the shared group so that the cooldown for the scales and leather should show up. Has some minor debugging messages still in it, as I still haven't had time to finish and fix the cooldown code. It was still returning errors last I tried it in 5.1, but I haven't checked since and the issues may be fixed. I will try to revisit it soon.

Please treat this as a beta. Some things won't work, but most of the cooldowns and shortcuts do.

Things to work on still:
- Cooldown timing fixed up, either using Blizzard's native code if it's finally working or hacking a better method using some other addons' methods.
- Storage of cooking skills (This is a blizzard interface error as well).

r505.23
Minor update, added Living Steel to the transmute cooldown group. Haven't had time to look into displaying lockpicking on alt rogues or the minor checkmark issue in the config menu.
- Path fixed to include the addon folder from earlier version of this release (31/OCT/12)

r505.22
-Fix for rogue detection in gender-specific languages, though at this time only German is implemented. Please test and let me know!

r505.21
Couple more bugfixes.
- German localization and rogue detection localization complete (I think -- this needs to be tested and let me know if anything in the translation looks wrong).
ToDo: Fix checkbox toggle when choosing skills to track, display Lockpicking on rogues in alt panel.

r505.2
I've quashed most of the bugs, and pretty sure I have a good system in-place to get herbalism back in the list for non-english locales -- please test this for me!
- Added back in support to show Lockpicking for rogues, since I always forget and don't want to think about math in my game time (hah)! It can be toggled on or off as any skill.
- Quashed a bug when selecting Runeforging or Lockpicking as the main tracked skill.

Next to work on:
- Clicking a skill to track it also clicks the checkbox next to tracking, which shouldn't happen.
- More robust German localization.
- Other localizations. Volunteers needed!

r505.1Beta
Think I have almost everything originally listed fixed. I thought that called for a bump of the version number to match the version of the WoW client.
- Fixed Herbalism and Fishing for localization, I think (though this is a VERY hacky fix; I'll need to verify it works for most of the other localizations -- don't have other clients to test it on. Feedback is necessary!)
- Fixed green boxes appearing in the config menu.

r44Beta
- Fixed Herbalism and Fishing not appearing in list, and icon for fishing.
- Added cooldowns (thanks for the assist in the groupname and icon, Uggers).
- Fixed scanning in skills with subheaders.
- Think I fixed the error thrown while caging pets (Not completely sure as I couldn't get it to error myself)
- If the error still occurs, please post relevant details. Not sure what I can do at this time if it is a localization issue).

r43
- Removed debug messages left in r41. :o

r42
- Fixed disappearing professions for real (implemented GetProfessions).
- Fixed tailoring CDs (dream of Ragnaros & Azshara).
- Changed Fire Prism CD to 20 hours.
- Removed cataclysm rare gem transmutes from CD list.


r41
- Fixed disappearing professions (@Goncyn: not using GetProfessions yet, for several reasons).
- Added cataclym tradeskill CDs (not tested).
- Changed Mysterious Egg / Disgusting Jar duration to 72 hours.
- Fixed goblal functions to be local.


r40
- Fixed a graphical issue introduced with r38 (the highlight was covered by the alt list).


r39
- Fixed alchemy research to reset the 3rd midnight after the research.
- Fixed a stupid mistake that was considering all cooldowns as not ready, thus preventing the craft action.


r38
- Long alt list now break into a second row instead of going out of screen. (Adjust automatically by default, but could be forced to break after the 5th character).
- Fixed the craft all action (was closing panel immediatly).
- Fixed tradeskill panel not showing when first opened externally.
- Fixed German skill tracking.
- Fixed: tooltip stuck on screen if after a ctrl+mousewheel the mouse was outside.
- Fixed: alt mining skill shown as smelting.
- Fixed: clicking on a non-ready cooldown wouldn't point to it if no panel was open at that time.
- Fixed: clicking on a zero quantity shortcut wouldn't point to it if no panel was open at that time.


r37
- Added back alchemy transmutes for epic gems.
- Added ctrl+mousewheel to change the tooltip scale.
- Changed 20 hours CDs to "reset at midnight" CDs (not error proof if you're crafting in an instance).
- Fixed alias dialog not showing if the config menu was not opened previously.
- Fixed linking alt. professions in chat.
- Fixed actions to properly highlight and scroll to recipes, keep panel visibility to the state it was before the action, unless the action requires the panel to stay open.
- Fixed possible wrong placements of hints with a tooltip scale above or below 100%.


r36
- Fixed craft links not saving after the first one.
- Added archaeology.
- Removed combat skills.
- Removed alchemy CDs: gem transmute.
- Removed lockpicking.
- Changed background: more opaque.
- Improved config menu.
- Code tweaking.


r35
- Added the number of items you can craft on shortcuts.
- Fixed the craft all functionality (shift+click or button 4/5).
- If a cooldown has some missing reagents, "Reagents!" will be displayed instead of "Ready!".
- Changed the default background a bit.


r34
- Tracking options are now handled like "Professions" and "Combat Skills" options: to toggle tracking, click the menu item; to select what to track, click a submenu item.
- Added experimental "Auto" tracking. For now, the tracked profession will be automatically set on selection (secondary professions are also selectable in this mode). In the future, you may be able to control if it auto switch on skill up and/or selection.
- Fixed a global variable that was causing some addon conflicts.
- Fixed previous tracking errors (but I probably added fresh ones!).
- Changed the scaling options to only affect clickable tooltips.
- Removed unnecessary Skinner and SharedMedia optional dependencies, it was also creating Skinner problems. (Credits goes to Jncl).


r33
- Fixed the "Tooltip Size" > "Custom..." option.
- Removed the DockingStation fix, it was affecting some non-DockingStation users.


r32
- Added CD: Glacial Bag.
- Removed CDs: Ebonweave, Moonshroud, Spellweave, Smelt Titansteel.
- Now usable even if flagged in combat.
- Fixed the following issue: if an entry was removed, thus shortening the main tooltip enough for the mouse to be outside, thus hiding the main tooltip, the alt. tooltip was still visible.
- To get around a DockingStation limitation(*) I had to make tooltips undetectable from it. The downside is this plugin won't benefits from the DockingStation's scaling option until that display is fixed.
- Added scaling options.
- Added a "Restore default colors" option.
- Updated zhTW translations.
- Fixed a deDE translation.
- Added support for MMOUI Minion in the TOC file.

(*) Because the DockingStation's handling of "tooltip"/"OnTooltipShow" and "OnEnter/OnLeave" is not uncoupled, plugins that need exclusive access to Show/Hide for complexe UI logic are floutted. :mad:


r31
- Fixed an issue introduced with r30. It now saves correctly the icon and spell ID of your last transmute.
- Added "Shift+Click to craft all" on shortcuts (also works with buttons 4-5).
- Added an alt option to only show professions with a craft window (can be combined with "Primary only").
- Changed the config menu: alt options are now gathered in a submenu.
- Updated zhTW translations (thanks to Launcelot).


r30
- Added an option to track a skill, displaying its value in real time.
- Added "iconCoords" for LDB displays that handle it.
- Removed Titanium transmute from CD list.
- Fixed dead CD errors (like Titanium transmute).
- Fixed the 2+ alchemists problem where only one transmute CD was visible.
- Fixed a rare issue where the list may not hide properly if alts were hidden (is that correct grammar ?).
- Fixed a minor issue where clicking the profession of an alt, and then clicking the same profession but from another alt, was closing the panel.
- Fixed support for Disgusting Jar and Mysterious Egg (still untested!).


r29
- Added 6 alchemy transmute: Ametrine, Cardinal Ruby, Dreadstone, Eye of Zul, King's Amber and Majestic Zircon.
- Added support for Disgusting Jar and Mysterious Egg (untested). Activate when one of these items is bought.


r28
- Fixed an error that war occuring for players with a primal mooncloth, shadowcloth and/or spellcloth in their list of CDs.


r27
- Fixed files not being in the addon folder.


r26
- Added support for ProfessionsBook.
- Removed the useless "Force CD removal" option. Middle-clicking a CD will now always remove it.
- Removed Primal Mooncloth, Shadowcloth and Spellcloth from the list of tracked CDs.


r25
- Changed the alt. skills tooltip to a clickable one. Open a character tradeskill panel to be able to access and link it from your other characters.
- Changed the way tradeskills are sorted: primary skills are now on top of secondary skills.
- Fixed a weird bug that was occuring for players with Skinner.
- Removed the useless "Hide alt. skill names" option.


r24
- Fixed an issue with the number of ready CDs that could be off by one in some random cases.


r23
- Changed the integration of the "Click to create a shortcut." hint. It's now added to the main tooltip.


r22
- Added Korean (koKR) translations (courtesy of shwy73 and mrgyver).


r21
- Cafting a CD while in "x/y CDs" mode will now instantly refresh the display.
- Changed the backdrop of the alt. tooltip to match the main tooltip.
- Skinner now includes the alt. tooltip and refresh the skin at mouseover time instead of just applying it once at load time.


r20
- Fixed an error that occured on log out by removing the "ExpandSkillHeader(0)" line.
- Fixed a logical error that occured when saving player skills for alts tooltip.


r19
- Removed a debug message left in r18. Im awake now !


r18
- Fixed a display issue where the number of CDs up was including all transmutes. My bad :p


r17
- Fixed a display issue where the total number of CDs was including all transmutes.


r16
- Fixed an error where the Blizzard TradeSkillUI wasn't loaded when I was trying to modify it.
- Fixed an issue where transmutes weren't properly showing that they were cooling down.


r15
- Shortcuts are now sorted (by skill then by name).
- Updated zhTW translations (thanks to Launcelot).
- Added an option for alts to only display primary skills.


r14
- Added a "Shortcuts" section. You can add a shortcut to a craft by clicking its icon in the associated panel.
- Updated the translations file along with frFR.


r13
- Added an option to remove alts from database.
- Fixed display issues in CD mode (it was sometimes reverting to tradeskill names, or not updating icon).


r12
- Fixed the cooldown hint issue that occured right after a scan. It was showing "Click to show CD in panel" instead of "Click to craft" for ready CDs.


r11
- Fixed a table recycling error
- Fixed an issue where linking to chat wasn't properly linking when a tradeskill panel was open.


r10
- Added the ability to Shift+Click a tradeskill to link in chat.
- Added an option to display the number of ready CD.


r9
- Added a separate tooltip so you can see both alts & hints at the same time.
- Removed a "collectgarbage" that could potentialy freeze your computer.


r8
- Code tweak / code cleanup.
- Re-added libs.


r7
- Added a simple display for alt skills.
- Updated zhTW translations.
- Removed libs (displays provide these already, right ?)


r6
- Changed the color formula curve from linear to inverse exponential to account for the difficulty of the last points (and easiness of the first ones).
- This formula also fixed a color bug that occured when the difference between current and max value was over 75 (ie. 55/150), it was representing a greenish value instead of a reddish one.
- Removed version checking that was necessary pre 3.0.8 to get the correct cooldown durations for titan-steel transmute and alchemy research.
- Removed value colors from config since color coding does the job.


r5
- Fixed color coding (underestimated the problem :p).


r4
- Added color coding for tradeskill values (experimental).
- Changed behavior for groups of CDs (like transmutes): click to cast the previous transmute used, right-click to show it in panel.
- Translations: added zhTW, added partial deDE, updated frFR.


r3
- Fixed issues with cooldown icons (was retrieving spell icon instead of item icon, wasn't saving it properly in some cases).
- Fixed an error with Cooking (was using the bad ID).
- Added check marks to show/hide tradeskills and combat skills categories.
- Added global handling of special cases where spell name doesnt match skill name (Smelting/Mining, german Kochen/Kochkunst, french Runeforge/Runeforger).


r2
- Fixed an error that occured when a CD was crafted before a scan can retrieve icons and names.
- Fixed an error where no transmute icons were available at display time.
- Added some strings to translate (see comments in "Translations.lua").
- Added support for SupplyAndDemand and ForkliftGnome (untested).


r1
- Initial release.
Optional Files (1)
File Name
Version
Size
Author
Date
Type
r505.24
25kB
06-08-13 09:29 AM
Patch


Archived Files (31)
File Name
Version
Size
Author
Date
530.2
26kB
Aranarth
07-12-13 03:19 AM
530.11b
26kB
Aranarth
06-28-13 03:28 AM
530.1b
26kB
Aranarth
06-28-13 02:27 AM
530.01b
25kB
Aranarth
06-26-13 09:44 PM
505.23
25kB
Aranarth
10-31-12 12:57 PM
505.23
24kB
Aranarth
10-30-12 04:53 PM
505.22
24kB
Aranarth
10-12-12 01:36 AM
505.21
24kB
Aranarth
10-10-12 09:33 PM
505.2
23kB
Aranarth
10-09-12 11:52 PM
505.1beta
23kB
Aranarth
10-09-12 03:34 AM
r44Beta
23kB
Aranarth
10-06-12 05:37 PM
r43
23kB
Aranarth
01-17-11 10:22 AM
r42
23kB
Aranarth
01-10-11 07:29 PM
r41
23kB
Aranarth
12-11-10 12:13 PM
r40
22kB
Aranarth
11-18-10 05:56 AM
r39
22kB
Aranarth
11-17-10 08:22 AM
r38
22kB
Aranarth
11-13-10 07:22 AM
r37
22kB
Aranarth
10-19-10 05:22 AM
r36
21kB
Aranarth
10-12-10 02:11 AM
r35
22kB
Aranarth
07-05-10 09:55 AM
r34
22kB
Aranarth
04-20-10 09:25 AM
r33
21kB
Aranarth
03-27-10 06:29 AM
r31
21kB
Aranarth
01-20-10 04:37 PM
r29
19kB
Aranarth
08-04-09 11:18 AM
r28
19kB
Aranarth
07-16-09 02:04 PM
r25
19kB
Aranarth
05-30-09 06:51 AM
r23
19kB
Aranarth
05-28-09 10:24 AM
r8
16kB
Aranarth
03-08-09 09:00 AM
r6
15kB
Aranarth
02-04-09 07:12 PM
r5
16kB
Aranarth
01-13-09 10:43 AM
r1
14kB
Aranarth
01-04-09 10:55 AM


Post A Reply Comment Options
Old 06-25-13, 01:08 PM  
griffin224
Premium Member
 
griffin224's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 40
Uploads: 1
Originally Posted by oscarucb
Also, for those seeking up-to-date tracking for the new trade CDs, check out SavedInstances.
I actually have SavedInstances, but like the tooltip having exactly what CD is on what toon, as well as the clickable menu for alt tradeskills. As well as the fact that I added information (as well as an updated patch) to include the new CD's.
griffin224 is offline Report comment to moderator  
Reply With Quote
Old 06-12-13, 08:31 AM  
oscarucb
A Murloc Raider
 
oscarucb's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 15
Uploads: 1
I noticed this addon has plugin support for the long-abandoned ProfessionsBook mod.

Have you considered updating this to the successor addon, ProfessionsVault?

Also, for those seeking up-to-date tracking for the new trade CDs, check out SavedInstances.
oscarucb is offline Report comment to moderator  
Reply With Quote
Old 06-08-13, 09:13 AM  
griffin224
Premium Member
 
griffin224's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 40
Uploads: 1
Added CD's

I absolutely LOVE this addon but was upset that the new cooldowns are not added, so I did a bit of poking around and managed to add them myself.....

Part One:
Code:
    change:
local HOUR, DAY, MIDNIGHT = 3600, 86400, -1
local TRANSMUTE_G1 = { skill= L.Alchemy, CD= MIDNIGHT, group= "Transmutes" }
local JCRESEARCH_G1 = { skill= L.Jewelcrafting, CD=MIDNIGHT, group="Facets of Research" } -- (Thanks for the research name, Uggers!)

     to:
local HOUR, DAY, MIDNIGHT = 3600, 86400, -1
local TRANSMUTE_G1 = { skill= L.Alchemy, CD= MIDNIGHT, group= "Transmutes" }
local JCRESEARCH_G1 = { skill= L.Jewelcrafting, CD=MIDNIGHT, group="Facets of Research" } -- (Thanks for the research name, Uggers!)
local LWHIDE_G1 = {skill= L.Leatherworking, CD=MIDNIGHT, group= "Magnificent Hide" }
local BSINGOT_G1 = {skill= L.Blacksmithing, CD=MIDNIGHT, group= "Lightning Steel Ingot" }
Part Two:
Code:
     change:
	-------------------------------------- PANDARIA ---------------------------------
	-- Jewelcrafting
	[131593]= JCRESEARCH_G1, -- { skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- River's Heart (Blue)
	[131695]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Sun's Radiance (Yellow)
	[131690]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Vermilion Onyx (Orange)
	[131686]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Primordial Ruby (Red)
	[131691]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Imperial Amethyst (Purple)
	[131688]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Wild Jade (Green)
	-- Alchemy
	[114780]= TRANSMUTE_G1, -- Transmute: Living Steel (Thanks Xanatandor!)
	-- Enchanting
	[116499]= { skill= L.Enchanting, CD=   MIDNIGHT }, -- Sha Crystal
	--Tailoring
	[125557]= { skill= L.Tailoring, CD=   MIDNIGHT }, -- Imperial Silk
	--Inscription
	[112996]= { skill= L.Inscription, CD= MIDNIGHT }, -- Scroll of Wisdom

     to:
	-------------------------------------- PANDARIA ---------------------------------
	-- Jewelcrafting
	[131593]= JCRESEARCH_G1, -- { skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- River's Heart (Blue)
	[131695]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Sun's Radiance (Yellow)
	[131690]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Vermilion Onyx (Orange)
	[131686]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Primordial Ruby (Red)
	[131691]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Imperial Amethyst (Purple)
	[131688]= JCRESEARCH_G1, --{ skill= L.Jewelcrafting,	CD=   MIDNIGHT }, -- Wild Jade (Green)
	-- Alchemy
	[114780]= TRANSMUTE_G1, -- Transmute: Living Steel (Thanks Xanatandor!)
	-- Enchanting
	[116499]= { skill= L.Enchanting, CD=   MIDNIGHT }, -- Sha Crystal
	--Tailoring
	[125557]= { skill= L.Tailoring, CD=   MIDNIGHT }, -- Imperial Silk
	--Inscription
	[112996]= { skill= L.Inscription, CD= MIDNIGHT }, -- Scroll of Wisdom
	--Blacksmithing
	[138646]= { skill= L.Blacksmithing, CD= MIDNIGHT }, -- Lightning Steel Ingot
	--Leatherworking
	[140040]= { skill= L.Leatherworking, CD=MIDNIGHT }, -- Magnificence of Leather
	[140041]= { skill= L.Leatherworking, CD=MIDNIGHT }, -- Magnificence of Scales
If I have missed any new cooldowns please let me know so I can do them and add them ;-)
Added my changes to an optional update that can be found in the files section of the addon.
Last edited by griffin224 : 06-08-13 at 09:33 AM.
griffin224 is offline Report comment to moderator  
Reply With Quote
Old 05-26-13, 02:20 AM  
Pax0707
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
CD resets

Any update on this?
Pax0707 is offline Report comment to moderator  
Reply With Quote
Old 03-31-13, 04:23 PM  
mstrjonathan
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
Add new cooldown - Lightning steel ingot

Blacksmiths craft this item which resets on the standard 24 hour clock
mstrjonathan is offline Report comment to moderator  
Reply With Quote
Old 12-27-12, 04:37 PM  
Alyred
A Kobold Labourer

Forum posts: 0
File comments: 54
Uploads: 0
Originally Posted by Alyred
Code:
	if duration < 0 then -- reset after Dawn
		local hours, minutes = GetGameTime()
		if hours<=3 then
			duration = (3-hours)*HOUR - minutes*60 - 30
		else
			duration = (27-hours)*HOUR - minutes*60 - 30
		end
	end
Wanted to expand on this a bit for those confused.

Essentially, you're doing a quick hack to determine if the time is before or after the cooldown reset time of your realm. Let's use my example above with some sample values: Let's say the clock returns that it is 02:00 hours, and the reset is at 3. Between midnight and 3 you'll always get a correct value, because the clock shows 2, the reset time is 3, so 3-2 is 1 hour until the cooldown is ready.

The problem comes when you do your cooldown between 3:00 AM and 23:59 (~Midnight), say at 4:00 AM. The clock shows 04:00, and the cooldown is at 03:00 (23 hours away rounded), so your cooldown timer takes 3-4 and comes up with -1, which bombs the logic.

So, the hacky way to fix it is my if-then-else above, adding 24+cooldown reset time if the time displayed is more than the cooldown reset time. This could all be done with a variable at the beginning as well, as suggested -- however, this doesn't solve the problem of multiple realm characters and making an addon that the user doesn't have to code into to get done.

Once I get time to construct the logic (and I'm not dead tired), it'll essentially get the time remaining for the skill cooldown, convert it to seconds (after trimming out all the color formatting characters, WTF Blizzard?), figure out when the realm reset time is (by comparing the reset time remaining with the current realm time, this makes it so that your local PC time is taken out of the equation) and write that to the file instead. SHOULD be able to be built by component and plugged into the existing code, as the existing code takes current time and figures out the time to midnight in seconds, and saves that.

Hopefully I'll get some time to work on it soon. Until then, Ara_broker_Tradeskills is more about cooldown shortcuts than actual timers. At LEAST most of that part is still working.
Alyred is offline Report comment to moderator  
Reply With Quote
Old 12-26-12, 11:22 PM  
Alyred
A Kobold Labourer

Forum posts: 0
File comments: 54
Uploads: 0
Originally Posted by napouser
k didnt work

still says 17:55 after a transmute

also for some wierd reason cooldowns are 20hours isntead of 24 in the code

i am puzzled as to whats going on
Been pretty busy this holiday season, and haven't had time to concentrate on this at all. I did some preliminary work, but the way it calculates dates and times is currently tied to decoding the "current time" on a computer, which is to say local time, and extrapolating that out to a future date (there's some conversions in seconds-since-origin time, current, and adding the cooldowns). Unfortunately, since "realm time" and "reset time" are now independent (they reset at 3:00 AM PST no matter what zone your realm is in), it makes it a PITA to decode.

There's a newer function called GetTradeskillCooldown in the API that returns the length of time before the cooldown is up, but that returns it in a format such as 6h 23m 33sec, which needs some substring conversion between that and the amount of seconds left. I was working on this but Blizzard threw two wrenches into the operation: 1. the GetTradeskillCooldown returns bad info the first time a skill goes into cooldown, until the UI resets (It's still returning midnight realm) and blizzard oh-so-kindly included a color formatting string for the time left that changes depending on the time. I decided to switch to GetQuestResetTime(), which at least returns valid info, but that's when I found the string formatting when I was getting wacky numbers in my parse.

There's at least two places that the cooldowns need to be checked in Aranarth's code: f:UNIT_SPELLCAST_STOP() event function which handles the code for "Did I just use a skill with a cooldown ok set the timer" and the TRADE_SKILL_SHOW event function, under the "scan" portion, that scans the professions for cooldowns that are active. There may be more, but those are the two I will eventually attack.

As for the 20 hour cooldowns, they're old and should be updated, but those aren't used that much anymore, so never got around to it.

As for your solution to just adding the time for your local realm, that should work -- so long as your playing only on realms in the same Timezone. However, when factoring times, you'll need to check to see if the hours in your game time is less than <your realm reset time> hours. The code I put in place for my issue is as follows (in the f:UNIT_SPELLCAST_STOP event function, and I'm in PST so my reset time is 3 AM):
Code:
	if duration < 0 then -- reset after Dawn
		local hours, minutes = GetGameTime()
		if hours<=3 then
			duration = (3-hours)*HOUR - minutes*60 - 30
		else
			duration = (27-hours)*HOUR - minutes*60 - 30
		end
	end
I can't give you an exact line number since I've moved a lot of code around on my current copy to test some of this, and haven't uploaded that copy yet as it's VERY comment-y and doesn't work any better anyway.

A lot of Aranarth's code is old and difficult to follow, and this addon could probably use a whole rewrite... but that's a bit beyond my level at this time.

I've shelved it for a couple weeks until I get some time again, probably early January.
Alyred is offline Report comment to moderator  
Reply With Quote
Old 12-23-12, 04:44 AM  
napouser
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
k didnt work

still says 17:55 after a transmute

also for some wierd reason cooldowns are 20hours isntead of 24 in the code

i am puzzled as to whats going on
napouser is offline Report comment to moderator  
Reply With Quote
Old 12-23-12, 02:47 AM  
napouser
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
might have a solution in hand

made a custom variable that adds some extra time in my case -6 hours since its us east (-3 from pasific wich is -3 from midnight) and used that variable in 3 occurancies that i found in ur addon

will test it further with dreamcloths and some other cooldown tonight

as long as it works then u can just create an option for the user to add his own offset to the option wich will point to my variable and gg

altho it seems to work my sha crystal went from 21 hours to 1d 01h (25) and the rest Ready! cooldowns(thats wrong by 6 hours) became correct 1h 19mins

only thing left is to verify it works in the next transmute and cloths and crystals
and if it works with complete reset of addon
napouser is offline Report comment to moderator  
Reply With Quote
Old 12-07-12, 05:27 PM  
Alyred
A Kobold Labourer

Forum posts: 0
File comments: 54
Uploads: 0
Originally Posted by tordenflesk
Tradeskills no longer reset at 00:00. They have a set cooldown now. This confuses the addon.
Correct. I stated this in the previous comment.

As a status update, unfortunately, since the cooldowns are all done via pacific time (or GMT I believe, in Europe) no matter what timezone the server is in, it's difficult to correlate server time zone to "reset" time for the region. There's no Blizzard API that will report this information to an addon, only time and server name.

This being the case, the only way I can think of to handle this is to code a module that reports which server the addon is being run on, and then lookup on a table what timezone the server is in and what time the resets are done. Right now, I don't have time to do that, with the holidays and extra workload at my real job (lots of people take the holidays off here, so the rest have to pick up the slack).

I have a partially-working version, that can calculate the time with a fixed region (though there's still a bit left to do on this one as well) that I'm considering releasing with instructions for how to customize it yourself for your own server, as an interim release. Digging through this code for more than an added cooldown is pretty complex still at this point. Aranarth is a mad genius and I'm still having to work through a lot of his notations in the technical stuff, with very little comments to guide me.
Alyred is offline Report comment to moderator  
Reply With Quote
Old 12-07-12, 04:31 PM  
tordenflesk
A Deviate Faerie Dragon

Forum posts: 10
File comments: 152
Uploads: 0
Tradeskills no longer reset at 00:00. They have a set cooldown now. This confuses the addon.
tordenflesk is offline Report comment to moderator  
Reply With Quote
Old 11-30-12, 03:44 AM  
Alyred
A Kobold Labourer

Forum posts: 0
File comments: 54
Uploads: 0
New Patch, New Problems

Hey everyone.

Cooldowns are a bit messed up right now. Thought I could have a working patch in place, but then I realized that they are the same cooldown times for ALL regions -- unfortunately, this means I need to figure out what timezone the server is and patch it up for that. May take a while.

Haven't had a lot of time lately to do any coding or learning. Holidays, yay. :P
Alyred is offline Report comment to moderator  
Reply With Quote
Old 11-01-12, 03:59 AM  
Alyred
A Kobold Labourer

Forum posts: 0
File comments: 54
Uploads: 0
Originally Posted by hjp426
Originally Posted by Alyred
Originally Posted by hjp426
Originally Posted by Csalago
addon will not display the new subclasses of Pandaran cooking.
I'm having the same issue; it will display them correctly if I'm on that specific toon that has them, but if I'm on an alt, it will just display the "everyday cooking" recipes. Do i just need to delete and do a fresh install of ABT?
Ah! Now this is a helpful report. No, it appears the subclasses of Pandaria cooking are not showing for some reason for alts. Hmm, will need to look into this. Nothing pops to mind immediately as to why this wouldn't be working properly, though. Likely something in the way it is recording the alts in the WTF lua files. I had been meaning to take a look at that anyway for the Rogue stuff.
Thank you for the prompt response, will wait for an update. ^^
Had some time to look into it tonight, and unfortunately, this looks like a bug in Blizz's interface for linking tradeskills, specifically with the cooking tradeskill.

The code essentially "saves" a copy of the tradeskill link (in a compressed alphanumeric format) to the ara_broker_tradeskill.lua file in the appropriate WTF folder, using the in-game functions for linking a tradeskill. This is what I did to test: Unloaded the addon on both of my accounts and linked Cooking across between two characters that were online at the same time, using all the in-game tools. Looks as though for some reason, Blizz doesn't include any of the Pandaria recipes (aside from everyday cooking) with the tradeskill link.

The good news is that once Blizz fixes that little bug, the addon SHOULD pick it right up the next time you open your cooking tradeskill on that character, and save the proper link information to the WTF file when you log out so that it is available to other characters.

Another upside: got the lockpicking skill to save and show in the alt pane. Need to spend some time to tidy that up (no sense in showing the "Min/Max", for instance) I'll update the addon with that patch. Still need to work on having it properly update when you level, right away, and for that darn checkbox annoyance...
Alyred is offline Report comment to moderator  
Reply With Quote
Old 10-31-12, 08:18 PM  
hjp426
A Kobold Labourer
 
hjp426's Avatar

Forum posts: 0
File comments: 32
Uploads: 0
Originally Posted by Alyred
Originally Posted by hjp426
Originally Posted by Csalago
addon will not display the new subclasses of Pandaran cooking.
I'm having the same issue; it will display them correctly if I'm on that specific toon that has them, but if I'm on an alt, it will just display the "everyday cooking" recipes. Do i just need to delete and do a fresh install of ABT?
Ah! Now this is a helpful report. No, it appears the subclasses of Pandaria cooking are not showing for some reason for alts. Hmm, will need to look into this. Nothing pops to mind immediately as to why this wouldn't be working properly, though. Likely something in the way it is recording the alts in the WTF lua files. I had been meaning to take a look at that anyway for the Rogue stuff.
Thank you for the prompt response, will wait for an update. ^^
hjp426 is offline Report comment to moderator  
Reply With Quote
Old 10-31-12, 01:00 PM  
Alyred
A Kobold Labourer

Forum posts: 0
File comments: 54
Uploads: 0
Originally Posted by hjp426
Originally Posted by Csalago
addon will not display the new subclasses of Pandaran cooking.
I'm having the same issue; it will display them correctly if I'm on that specific toon that has them, but if I'm on an alt, it will just display the "everyday cooking" recipes. Do i just need to delete and do a fresh install of ABT?
Ah! Now this is a helpful report. No, it appears the subclasses of Pandaria cooking are not showing for some reason for alts. Hmm, will need to look into this. Nothing pops to mind immediately as to why this wouldn't be working properly, though. Likely something in the way it is recording the alts in the WTF lua files. I had been meaning to take a look at that anyway for the Rogue stuff.
Alyred is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: