Is there a way to remove that extra line with "+" that was mentioned before? Any chance to make procurement manager optional? I like the resizable window, but don't care much about procurement.

jobber.lua:157: 'for' limit must be a number

When I am leveling some professions I like to keep the trainers dialog box open as well so that I can pick up anything new while I gain levels.

Jobber forces the trainers dialog box to only show my professions when they are open at the same time. I hope I explained that well enough.

Also

How do I delete the items that are in the procurement manager. I have a number of items that I no longer need there.

__________________
Show me your friends and I will show you your future

Are there any plans to fix the seemingly random LUA error?

When that happens I have to reload my UI or I can't see any recipes.

Jobber doesn't play quite nicely with Lil' Sparky's Workshop. I think it would be fine if the window were a bit wider. I tried experimentally widening the window a bit, and it helped, but it also looked bad because not all the items in the window were placed correctly then. 400 wasn't quite wide enough, but looked closer.

... and yes, the little triangle in the corner does the job. Nevermind.

Hello Maul,

I posted an error over at Altoholic's comments pages and was told that it's probably a jobber issue?
Thanks!

Whenever I open Jobber I get this error....

[2009/06/18 19:19:44-300-x1]: Interface\FrameXML\UIDropDownMenu.lua:514: attempt to index local 'frame' (a nil value):
Altoholic-v3.1.003b\Frames\Skills.lua:377: in function `SaveActiveFilters'
Altoholic-v3.1.003b\Frames\Skills.lua:466: in function `Scan'
Altoholic-v3.1.003b\Frames\Skills.lua:605: in function <Interface\AddOns\Altoholic\Frames\Skills.lua:596>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0-3:91: in function `Fire'
AceEvent-3.0-3 (Altoholic):119: in function <...\AddOns\Altoholic\libs\AceEvent-3.0\AceEvent-3.0.lua:118>
<in C code>: in function `UseAction'
Interface\FrameXML\SecureTemplates.lua:258: in function `handler':
Interface\FrameXML\SecureTemplates.lua:460: in function <Interface\FrameXML\SecureTemplates.lua:417>:

---

__________________

Nice addon, and I also dislike the queue system and other fluff that tradeskill mods tend to add.

However, I do not dislike the search capabilities they provide I'm completely addicted to it, in fact. Is there any chance you could add a search functionality in there? Or am I blind and I can't see it?

Any chance of Jobber being made compatible with GemJar? GemJar colors gem recipes by the rarity of the gem with the crafting counters colored according to crafting difficulty. That way you can tell at a glance which gems are purples, blues, or greens. Unfortunately when used in conjunction with Jobber the recipe coloration returns to Blizzard's default which means that at max skill level you're looking at page after page of grey recipes with no indication of gem quality.

I like TradeTabs too, so I hacked the TradeTabs code into the Jobber.lua and it seems to work ok I tested it with a bunch of professions and had no problems.

Warnings, disclaimers and thanks: The TradeTabs code is tardmrr's work, all I did was cut bits out and put it into Jobber. Make sure you back up your Jobber.lua file before you do this so you can put it back to normal if you have a problem. It shouldn't, but if your WoW/Windows/PC explodes in a fiery ball of death don't blame me :P

The Hack:
Open Jobber.lua in a decent text editor and find the frameShow() function and add the following line right at it's end (line 779 for me);

TradeTabs:Initialize()

Now, right at the end of jobber.lua paste the following code:

--Adding TradeTabs stuff
local TradeTabs = CreateFrame("Frame","TradeTabs")

local tradeSpells = { -- Spell order in this table determines the tab order
28596, -- Alchemy
29844, -- Blacksmithing
28029, -- Enchanting
30350, -- Engineering
45357, -- Inscription
28897, -- Jewel Crafting
32549, -- Leatherworking
53428, -- Runeforging
2656, -- Smelting
26790, -- Tailoring

33359, -- Cooking
27028, -- First Aid

13262, -- Disenchant
51005, -- Milling
31252, -- Prospecting
818, -- Basic Campfire
}

function TradeTabs:Initialize()
if self.initialized then return end -- Shouldn't need this, but I'm paranoid

for i=1,#tradeSpells do
local n = GetSpellInfo(tradeSpells[i])
tradeSpells[n] = -1
tradeSpells[i] = n
end

local parent = JobberFrame
self:UnregisterAllEvents()

for i=1,MAX_SPELLS do
local n = GetSpellName(i,"spell")
if tradeSpells[n] then
tradeSpells[n] = i
end
end

local prev
for i,spell in ipairs(tradeSpells) do
local spellid = tradeSpells[spell]
if type(spellid) == "number" and spellid > 0 then
local tab = self:CreateTab(spell,spellid,parent)
local point,relPoint,x,y = "TOPLEFT","BOTTOMLEFT",0,-17
if not prev then
prev,relPoint,x,y = parent,"TOPRIGHT",-33,-44
end
tab:SetPoint(point,prev,relPoint,x,y)
prev = tab
end
end

self.initialized = true
end

local function onEnter(self)
GameTooltip:SetOwner(self,"ANCHOR_RIGHT") GameTooltip:SetText(self.tooltip)
self:GetParent():LockHighlight()
end

local function onLeave(self)
GameTooltip:Hide()
self:GetParent():UnlockHighlight()
end

local function updateSelection(self)
if IsCurrentSpell(self.spellID,"spell") then
self:SetChecked(true)
self.clickStopper:Show()
else
self:SetChecked(false)
self.clickStopper:Hide()
end
end

local function createClickStopper(button)
local f = CreateFrame("Frame",nil,button)
f:SetAllPoints(button)
f:EnableMouse(true)
f:SetScript("OnEnter",onEnter)
f:SetScript("OnLeave",onLeave)
button.clickStopper = f
f.tooltip = button.tooltip
f:Hide()
end


function TradeTabs:CreateTab(spell,spellID,parent)
local button = CreateFrame("CheckButton",nil,parent,"SpellBookSkillLineTabTemplate,SecureActionButtonTemplate")
button.tooltip = spell
button:Show()
button:SetAttribute("type","spell")
button:SetAttribute("spell",spell)
button.spellID = spellID
button:SetNormalTexture(GetSpellTexture(spellID, "spell"))

button:SetScript("OnEvent",updateSelection)
button:RegisterEvent("TRADE_SKILL_SHOW")
button:RegisterEvent("TRADE_SKILL_CLOSE")
button:RegisterEvent("CURRENT_SPELL_CAST_CHANGED")

createClickStopper(button)
updateSelection(button)
return button
end
-- End TradeTabs stuff

I removed a little bit of non-essential code (like skillet support) and I'm sure there are more bits that can be cleaned up, but hey it's a copy-paste hack to get TradeTabs working with Jobber

__________________

sometime i get the same error

Gotta say I like it, a few requests though. Could you add an option to sort items by effect? For instance by +hit or mp5 etc. Second could you make the jobber frame move over other frames? I like having my tradeskill frame on the left side and when I talk to a supplies vendor I want the vendor stuff to open on the right of the jobber frame. Thanks again and so far I really like this mod

Get an error from Jobber randomly. I'm not even sure what causes it. I normally get it just standing around.

[15:46:50] 1. [2009/06/03 15:46:44-316-x2]: Jobber-30100.2\Jobber.lua:157: 'for' limit must be a number
Jobber-30100.2\Jobber.lua:1924: in function `ProcurementManager_OnEvent'
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

---

Nice addon.
Can you eventually look for compatybility with Recipe Radar addon?
After installing Jobber when I open Recipe Radar I get message:

..\AddOns\RecipeRadar\SkillDB.lua line 173:
attempt to call global 'TradeSkillFrame_Update' (a nil value)

Thank you.

I believe that if you click it, it would show your Procurement panel. Maybe.

The + widget also blocks other UI elements that may appear over it. It looks like it's on a different frame level or strata than the balance of Jobber/s UI.

The Procurement panel may need some love. Depending upon where you are (AH, Bank, Vendor that sells things on your Procurement list, Tradeskill UI) you open/view it through different means. And I'm constantly (unintentionally) adding things to the Procurement list. I'm trying hard to think of a suggestion to make it more consistent, but I'm also just confused about what it's supposed to be doing for me (if anything). If it's just showing me a list of things I want to obtain, it may be better served by a moveable/floating or anchored panel that I can place wherever I want and open separately from Jobber's main UI.

__________________
-- æsir

Would it be possible to have the mod look at your bank and determine what mats you have and show it next to the items of what you can make?

Basically

XYZ pot (0/3)

because you don't have the mats in your bags, however you have the mats in your bank.

Thank you