Download
(23 Kb)
Download
Updated: 06-04-09 03:54 AM
Patch for:
Fishbringer.
Pictures
File Info
Updated:06-04-09 03:54 AM
Created:05-12-09 03:34 PM
Downloads:3,103
Favorites:55
MD5:
Fishbringer
Version: 3.1.1
by: Bruners [More]
Updated Fishbringer with a new method for pole checking (all future poles) and new zones.
- Added support for LibSharedMedia-3.0
- Added support for localization, Spanish (esES), Korean (koKR) and French (frFR) ready for testing
- Added some colors to the font changing thingie [/b]
- As requested, frame position is now saved in the db instead of smashing it to the center
- Russian (ruRU)

To list available fonts type:

/fishbringer font

and to change font face type (testing the ABF font):

/fishbringer font ABF


Let me know if it doesn't work as expected i will try to fix it.

Translation of this AddOn is currently in the works, to contribute with your language visit http://wow.curseforge.com/projects/fishbringer/localization/

Thanks to:
LoloMac aka Traulen for the French (frFR) translation
chkid for the Korean (koKR) translation
StiviS for the Spanish (esES) translation
StingerSoft for the Russian (ruRU) translation
frFR update

------------------------------------------------------------------------
r19 | bruners | 2009-05-17 04:38:35 +0000 (Sun, 17 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Save frame position in the db when moving is done.
------------------------------------------------------------------------
r18 | bruners | 2009-05-17 04:12:48 +0000 (Sun, 17 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Clean up font changing and add some shiny colors to the list
------------------------------------------------------------------------
r16 | bruners | 2009-05-16 04:11:51 +0000 (Sat, 16 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Use GetSpellInfo to get the localized name for Fishing, thanks to Phanx for the tip.
------------------------------------------------------------------------
r14 | bruners | 2009-05-15 23:31:00 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/Fishbringer.toc

Add localization.lua to the toc
------------------------------------------------------------------------
r13 | bruners | 2009-05-15 22:19:16 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

frFR update, Add spell "Fishing" to the localization table
------------------------------------------------------------------------
r12 | bruners | 2009-05-15 20:39:32 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/.pkgmeta
M /trunk/Fishbringer.toc
M /trunk/embeds.xml
M /trunk/fishy.lua
A /trunk/localization.lua

Add support for localization with AceLocale-3.0
------------------------------------------------------------------------
r11 | bruners | 2009-05-15 16:53:55 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

make font local
------------------------------------------------------------------------
r9 | bruners | 2009-05-15 15:47:05 +0000 (Fri, 15 May 2009) | 1 line
Changed paths:
M /trunk/.pkgmeta

fix .pkgmeta externals
------------------------------------------------------------------------
r7 | bruners | 2009-05-15 15:34:01 +0000 (Fri, 15 May 2009) | 4 lines
Changed paths:
M /trunk/.pkgmeta
M /trunk/Fishbringer.toc
A /trunk/embeds.xml
M /trunk/fishy.lua

- Rewritten management of the DB so that we can expand it later without to much clutter.
- Add support for LibSharedMedia-3.0 and slash commands to change font.
- Help text on /fbr help
- Redone displayed text to avoid some word wrapping
------------------------------------------------------------------------
r5 | bruners | 2009-05-12 12:55:08 +0000 (Tue, 12 May 2009) | 2 lines
Changed paths:
M /trunk/fishy.lua

Correctly remove % of % fish caught when at max rank
Fix FishFormula()
------------------------------------------------------------------------
r3 | bruners | 2009-05-12 12:09:02 +0000 (Tue, 12 May 2009) | 1 line
Changed paths:
M /trunk/fishy.lua

Fix UpdateSkill() bug
------------------------------------------------------------------------
r2 | bruners | 2009-05-12 12:01:40 +0000 (Tue, 12 May 2009) | 1 line
Changed paths:
A /trunk/.pkgmeta
A /trunk/Fishbringer.toc
A /trunk/fishy.lua

Update toc, new method for pole checking, new zones.
------------------------------------------------------------------------
r1 | root | 2008-12-13 22:19:58 +0000 (Sat, 13 Dec 2008) | 1 line
Changed paths:
A /branches
A /tags
A /trunk

"fishbringer/mainline: Initial Import"
------------------------------------------------------------------------
Archived Files (6)
File Name
Version
Size
Author
Date
3.1.0
23kB
Bruners
05-19-09 03:25 PM
Beta 5
21kB
Bruners
05-16-09 10:46 PM
v3.0.4 Beta 4
21kB
Bruners
05-16-09 10:07 AM
v3.0.4 Beta 3
18kB
Bruners
05-15-09 06:07 PM
v3.0.4 Beta 2
12kB
Bruners
05-15-09 10:04 AM
v3.0.3
4kB
Bruners
05-12-09 03:34 PM


Post A Reply Comment Options
Old 06-15-09, 11:36 PM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by Frayol
Finally got a chance to test this out and I am now officially confused! With Fishbringer and SharedMedia as the only two addons loaded the font saving worked. So I then put back every addon I was previously using and the font saving still works. The only difference between the first set of testing I carried out where it didn't work and now is that the version is now 3.1.1 as opposed to 3.1.0.
The only change from 3.1.1 and 3.1.0 is a localization update which is done automatically by the packager, so no human change on the code between those version.
Bruners is offline Report comment to moderator  
Reply With Quote
Old 06-14-09, 09:47 AM  
Frayol
A Deviate Faerie Dragon
 
Frayol's Avatar
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 127
Uploads: 4
Originally posted by Bruners
Could you try to disable all your AddOns and only run Fishbringer, then try to change fonts? It's the only way to try finding out why this happens.
Finally got a chance to test this out and I am now officially confused! With Fishbringer and SharedMedia as the only two addons loaded the font saving worked. So I then put back every addon I was previously using and the font saving still works. The only difference between the first set of testing I carried out where it didn't work and now is that the version is now 3.1.1 as opposed to 3.1.0.
Frayol is offline Report comment to moderator  
Reply With Quote
Old 06-11-09, 06:12 AM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by Frayol
Currently using version 3.1.0 and the font changing only works for the current session, once logged out (or even a reloadui) the font reverts back to the default "Friz Quadrata TT". I have tested with several of the fonts that fishbringer lists as a available and each time it changes to that font for the session and then reverts on reload. Also wiped my saved variables and retested just to make sure it wasn't a corruption within those, but the font change still fails to stick and the saved variables list the saved font option as "Friz Quadrata TT" too.

That said, thank you for the update to this as it is much appreciated. Hopefully the font change issue will be easy to fix, but for now I have modified my copy to use a set font instead.
Could you try to disable all your AddOns and only run Fishbringer, then try to change fonts? It's the only way to try finding out why this happens.
Bruners is offline Report comment to moderator  
Reply With Quote
Old 06-10-09, 10:57 AM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Re: Error Message

Originally posted by Twidget
Hi,
I get the following error from Fishbringer any time I do a /reloadui :

Date: 2009-06-04 14:10:21
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Fishbringer\fishy.lua line 328:
attempt to index global 'Fishbringer' (a nil value)
Debug:
[C]: ?
Fishbringer\fishy.lua:328:
Fishbringer\fishy.lua:314
Fishbringer\fishy.lua:437:
Fishbringer\fishy.lua:431
[C]: ExpandSkillHeader()
...ill-4.0\LibLordFarlander-SpecialEvents-Skill-4.0.lua:126: GetSkillList()
...ill-4.0\LibLordFarlander-SpecialEvents-Skill-4.0.lua:156: GetSkillLevel()
Coconuts\Coconuts.lua:2201: GetPlayersMounts()
Coconuts\Coconuts.lua:1548: OnProfileChanged()
Coconuts\Coconuts.lua:1713:
Coconuts\Coconuts.lua:1553
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9:
[string "safecall Dispatcher[1]"]:5
(tail call): ?
Ace3\AceAddon-3.0\AceAddon-3.0.lua:365: EnableAddon()
Ace3\AceAddon-3.0\AceAddon-3.0.lua:435:
Ace3\AceAddon-3.0\AceAddon-3.0.lua:421
[C]: LoadAddOn()
..\FrameXML\UIParent.lua:229: UIParentLoadAddOn()
..\FrameXML\UIParent.lua:252: CombatLog_LoadUI()
..\FrameXML\UIParent.lua:497:
..\FrameXML\UIParent.lua:469
AddOns:

It is fine the rest of the time. Only throws this error when I reload the UI.

Thanks,
Twidget
I'm not sure why this happens, but it has something to do with LibLordFarlander-SpecialEvents-Skill-4.0
Last edited by Bruners : 06-10-09 at 01:20 PM.
Bruners is offline Report comment to moderator  
Reply With Quote
Old 06-10-09, 10:54 AM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by lodewijk
i'm having the exact same problem.
I have no idea how to fix this issue as it is working as intended here.

You could try to manually edit the savedvariables to another font.
Last edited by Bruners : 06-10-09 at 10:59 AM.
Bruners is offline Report comment to moderator  
Reply With Quote
Old 06-04-09, 12:12 PM  
Twidget
An Aku'mai Servant
 
Twidget's Avatar

Forum posts: 33
File comments: 404
Uploads: 0
Exclamation Error Message

Hi,
I get the following error from Fishbringer any time I do a /reloadui :

Date: 2009-06-04 14:10:21
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Fishbringer\fishy.lua line 328:
attempt to index global 'Fishbringer' (a nil value)
Debug:
[C]: ?
Fishbringer\fishy.lua:328:
Fishbringer\fishy.lua:314
Fishbringer\fishy.lua:437:
Fishbringer\fishy.lua:431
[C]: ExpandSkillHeader()
...ill-4.0\LibLordFarlander-SpecialEvents-Skill-4.0.lua:126: GetSkillList()
...ill-4.0\LibLordFarlander-SpecialEvents-Skill-4.0.lua:156: GetSkillLevel()
Coconuts\Coconuts.lua:2201: GetPlayersMounts()
Coconuts\Coconuts.lua:1548: OnProfileChanged()
Coconuts\Coconuts.lua:1713:
Coconuts\Coconuts.lua:1553
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9:
[string "safecall Dispatcher[1]"]:5
(tail call): ?
Ace3\AceAddon-3.0\AceAddon-3.0.lua:365: EnableAddon()
Ace3\AceAddon-3.0\AceAddon-3.0.lua:435:
Ace3\AceAddon-3.0\AceAddon-3.0.lua:421
[C]: LoadAddOn()
..\FrameXML\UIParent.lua:229: UIParentLoadAddOn()
..\FrameXML\UIParent.lua:252: CombatLog_LoadUI()
..\FrameXML\UIParent.lua:497:
..\FrameXML\UIParent.lua:469
AddOns:

It is fine the rest of the time. Only throws this error when I reload the UI.

Thanks,
Twidget
Twidget is offline Report comment to moderator  
Reply With Quote
Old 06-04-09, 10:14 AM  
lodewijk
A Deviate Faerie Dragon

Forum posts: 13
File comments: 122
Uploads: 0
Originally posted by Frayol
Currently using version 3.1.0 and the font changing only works for the current session, once logged out (or even a reloadui) the font reverts back to the default "Friz Quadrata TT". I have tested with several of the fonts that fishbringer lists as a available and each time it changes to that font for the session and then reverts on reload. Also wiped my saved variables and retested just to make sure it wasn't a corruption within those, but the font change still fails to stick and the saved variables list the saved font option as "Friz Quadrata TT" too.
i'm having the exact same problem.
lodewijk is offline Report comment to moderator  
Reply With Quote
Old 05-28-09, 04:32 PM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by Traulen
Hello, I am modifying the translations

New comments:
- What is "%d of %d fish caught" for ? I always have "0 of 1 fish caught"
- A strange thing: in teldrassil it tells me I need 25 in fishing for 100%. So, I raise my fishing skill to 25 but FBR tells me that my success rate is 94% (it turned to 100% at 28 in skill...)

I'll keep the comments coming...

Traulen
the "%d of %d fish caught" should tell you how many fishes you have caught since the last skill up, giving you a approximate value for next skill up. In other words you can get a skill up on "10 fish of 13 caught". Why this isn't working for you is something i have to look into.

The formula for catch rate might be a bit off and has been reported by someone else already. As i haven't written the current calculations i cant tell you much about it, but i will look into it.
Bruners is offline Report comment to moderator  
Reply With Quote
Old 05-27-09, 11:39 PM  
Traulen
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Hello, I am modifying the translations

New comments:
- What is "%d of %d fish caught" for ? I always have "0 of 1 fish caught"
- A strange thing: in teldrassil it tells me I need 25 in fishing for 100%. So, I raise my fishing skill to 25 but FBR tells me that my success rate is 94% (it turned to 100% at 28 in skill...)

I'll keep the comments coming...

Traulen
Last edited by Traulen : 05-27-09 at 11:41 PM.
Traulen is offline Report comment to moderator  
Reply With Quote
Old 05-27-09, 08:04 PM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by Traulen
It was the problem !
Now I am going to test it...

Some early comments:
- Replace "%d en pêche nécessaire pour pêcher" by "%d nécessaire en pêche" to avoid a line return
- What does "%d fish needed at this level" means ? That I need %d fish to gain +1 skill ?

Thx,
Traulen
"%d fish needed at this level" means that you need %d fish to gain a skillpoint at that level.

Feel free to edit the translations you have made if they look off in game.
As i dont understand French i can't really do anything good with them.

http://wow.curseforge.com/projects/f...lization/frFR/
Bruners is offline Report comment to moderator  
Reply With Quote
Old 05-27-09, 11:40 AM  
Traulen
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Originally posted by Bruners
in localization.lua locate and find

Code:
|c%s%s|r
%d en pêche nécessaire pour pêcher
(%d pour être à 100%%)
make sure 100% is noted as 100%%
It was the problem !
Now I am going to test it...

Some early comments:
- Replace "%d en pêche nécessaire pour pêcher" by "%d nécessaire en pêche" to avoid a line return
- What does "%d fish needed at this level" means ? That I need %d fish to gain +1 skill ?

Thx,
Traulen
Traulen is offline Report comment to moderator  
Reply With Quote
Old 05-27-09, 04:23 AM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by Traulen
Hello,Fishbringer isn't working for me (french).
console :
I have the following error at launch : fishy.lua:313:invalid option in 'format'

Improved error frame :
Erreur : invalid option in `format'
Fichier : Interface\AddOns\Fishbringer\fishy.lua
Ligne : 313
Nombre : 1
[C]: in function `SetFormattedText'
Interface\AddOns\Fishbringer\fishy.lua:313: in function <Interface\AddOns\Fishbringer\fishy.lua:280>
Interface\AddOns\Fishbringer\fishy.lua:444: in function <Interface\AddOns\Fishbringer\fishy.lua:434>
in localization.lua locate and find

Code:
|c%s%s|r
%d en pêche nécessaire pour pêcher
(%d pour être à 100%%)
make sure 100% is noted as 100%%
Bruners is offline Report comment to moderator  
Reply With Quote
Old 05-26-09, 10:53 AM  
Traulen
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Hello,

Fishbringer isn't working for me (french).
console :
I have the following error at launch : fishy.lua:313:invalid option in 'format'

Improved error frame :
Erreur : invalid option in `format'
Fichier : Interface\AddOns\Fishbringer\fishy.lua
Ligne : 313
Nombre : 1
[C]: in function `SetFormattedText'
Interface\AddOns\Fishbringer\fishy.lua:313: in function <Interface\AddOns\Fishbringer\fishy.lua:280>
Interface\AddOns\Fishbringer\fishy.lua:444: in function <Interface\AddOns\Fishbringer\fishy.lua:434>
Last edited by Traulen : 05-26-09 at 10:55 AM.
Traulen is offline Report comment to moderator  
Reply With Quote
Old 05-25-09, 09:09 AM  
Bruners
A Flamescale Wyrmkin
 
Bruners's Avatar
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 69
Uploads: 11
Originally posted by Frayol
Currently using version 3.1.0 and the font changing only works for the current session, once logged out (or even a reloadui) the font reverts back to the default "Friz Quadrata TT". I have tested with several of the fonts that fishbringer lists as a available and each time it changes to that font for the session and then reverts on reload. Also wiped my saved variables and retested just to make sure it wasn't a corruption within those, but the font change still fails to stick and the saved variables list the saved font option as "Friz Quadrata TT" too.

That said, thank you for the update to this as it is much appreciated. Hopefully the font change issue will be easy to fix, but for now I have modified my copy to use a set font instead.
I have tested this several times now with v.3.1.0 and the font is changed and saved each time here. I have tried all different methods there is to try really.
Bruners is offline Report comment to moderator  
Reply With Quote
Old 05-23-09, 12:34 AM  
Frayol
A Deviate Faerie Dragon
 
Frayol's Avatar
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 127
Uploads: 4
Currently using version 3.1.0 and the font changing only works for the current session, once logged out (or even a reloadui) the font reverts back to the default "Friz Quadrata TT". I have tested with several of the fonts that fishbringer lists as a available and each time it changes to that font for the session and then reverts on reload. Also wiped my saved variables and retested just to make sure it wasn't a corruption within those, but the font change still fails to stick and the saved variables list the saved font option as "Friz Quadrata TT" too.

That said, thank you for the update to this as it is much appreciated. Hopefully the font change issue will be easy to fix, but for now I have modified my copy to use a set font instead.
Frayol is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: