TradeFilter 

Could we have seperate white/black lists per major channel? I'd just like a bit better control over what's let through and what's not.

Also...the 'in bed' filter...currently blacklists anyone who links any gem with "inscribed" listed in the name. Might wanna redo the regex to be a little more specific by default.

Also - if you were to make seperate black/white lists, some little pre-set regex list to be able to add/remove to each black/white list would make setting it up really easy.

The defaults are amazing right now otherwise, just some minor quirks and I'm a control freak.

Hi,

I've had a chance to test special channel filtering and it seems to work fine. If I've interpreted TradeFilter's bevahior correctly, however, the black list does not (yet) apply to special channels and the hidden guild add-on channel. If the black list is used for special channels, too, I must've set something incorrectly. I couldn't find any suspicios options though. In case this behavior is intended, could you modify TradeFilter so that special channels don't bypass the black list anymore?

While I was testing EverTrade with a guildie I missed the appropriate output in the SPAM and DEBUG chat frames. In case EverTrade messages indeed aren't displayed in those chat frames yet, could you change TradeFilter so that those messages are displayed there?

The bottom line is that special channels support is already working great. Makes the combination of EverTrade (and others) and TradeFilter a lot nicer than with former TradeFilter versions.

As for the sorting mechanism, it's way better than before. Now the sorting is predictable since it's always alphabetically from a to z. If possible, a next step in sorting greatness might be to actually save the player's sorting. That way players who prefer to group their filter and black list entries by context can retain their custom sorting, too. As in "here's everything about dungeons", "here's everything about obscenities" and "here's the valid profession stuff".

Keep it up! ;-)

All the best

I've added German translations for the four new strings. Looks like the key RPTBYPASSD has a mistake, namely "Allow strings that match your a pattern in your whitelist to bypass the repeat filter." Nothing else to bitch and moan about though ;-)

Hi,

see, now I get it ;-) Now that I know it's because of the Ace localization system it's all good. I didn't have that in mind when thinking about the possible advantages of table dictionaries over table arrays. As for the duplicate strings, they're no big deal. I wanted to make sure this wasn't a mistake or an oversight.

Hi,

I don't quite get it with arrays and dictionaries. I've read the page you linked and the way I understand it you could declare your tables as arrays instead of dictionaries. That'd allow you to read from them with the ipairs() function instead of the pairs() function. You would then get the properly ordered array contents; ordered the same way they were last saved.

Like so:Or did I get that part wrong and table arrays are only possible with numbers and if you wanna save arbitrary strings you have to use table dictionaries? I mean I understand now that table dictionaries are output in a random order in Lua. Howevr, I don't get why dictionaries make more sense than arrays for TradeFilter's purposes.

Don't get me wrong here. This isn't actually an issue. I've been living with this behavior ever since and it won't impact me negatively if it stays this way ;-) It's more of a curiosity thing now that I know why the input fields get reordered every time I hit the Accept button.

All the best,

Contiki

//Edit: just realized on the localization page that you've changed the Notes key to "Not just any old filter". I've changed the German translation accordingly. However, only recently you've added the key NJAOF. Both are identical now. Wouldn't it be easier to maintain if you used just one key instead of two?

Nope, not yet.

On a side note, I was just looking through a text file named tradefilter.txt I had on my desktop. Was wondering what was in there and lo and behold, during the last weeks I had jotted down suggestions and strange/unwanted behavior in TradeFilter I had totally forgotten about. So here goes.

• A while ago you changed TradeFilter's slogan from "Filter the shit outta Trade channel!" to "Not just any old filter!" Initially only on the WowAce homepage, later here on wowinterface, too. I like that slogan better than the former one and was wondering what you'd think about adding it to the TOC file, too. So for consistency's sake, what do you think about adding "Not just any old filter!" to the TOC file, too?
• This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed. Consider me entering these terms into the filter list:
  • one
    two
    three
    four
    five
  Now I hit the Accept button an bam, the list looks like this:
  • three
    five
    one
    four
    two
  I've learned to live with this bevahior and am keeping a copy of the properly ordered filter terms separate. However, wouldn't it be cool if the add-on didn't reorder the list? That way players woudn't need to keep a separate copy of their filter terms and could instead change them in the input fields ;-) By the way, when I repeatedly hit Accept without actually changing the filter terms the lists get reordered repeatedly, too. I have to admit that looks kinda funny. *wonder what's up at the top the next time I hit accept*

That's it, that's the two things I had in my text file. Going to delete it now that I've let you know.

As for helping out with feedback, reports, translations 'n' stuff, you're welcome!

All the best,

Contiki

Hi,

I see where you're coming from and especially in case of these anal this-and-this item links it makes sense. However, at lesat on my server this anal meme thingy isn't an issue.

I'm using TradeFilter to get the actual Trade channel back; the way I think it was intended. My filter list contains all the good and valid stuff that usually happens in Trade: item links, profession links and whatnot. So that's allowed. Since at least on my realm some players like to use Trade as a substitute for LFG I've put all the LFG-related stuff - among other terms - on the black list: "naxx", "ulduar", "druid", "tank" and whatnot. By now both lists work well enough to come to the right decision 98% of the time. Roughly 2% of the valid Trade stuff get's lost and roughly 2% of the non-Trade stuff shows up in Trade. That's already great and I'm further fine-tuning the lists.

One issue I see is with items such as the [Relic of Ulduar]. I can modify the black list so it does trigger with "ulduar[^%]]", meaning with any "ulduar" followed by something else than the closing brackets ("]") of the item link. That way "lf tank for ulduar 10-man" gets blacklisted while "looking for 400 [Relic of Ulduar]" passes through. Problem is (that's where part of the missing 2% come from) when players ask for relics without an item link. Then there are no brackets to check for and the very valid Trade-related question for them gets thrown out. There are quite a few more items of this kind. [Hunter's Scout of the Bandit] comes to mind which could easily be cought by the "hunter" black list entry unless players provide the item link. The list goes on quite a bit, even though these make up a minority of Trade messages.

What I'm thinking about is to allow players to "free" the white list from black list checking. Like an option "Allow white list to bypass black list". I'm aware that this option may not be the right thing for all players. There's, however, the benefit of further customizing one's lists. The white list could take the most common mistakable item names and allow them to show up in Trade.

Another benefit comes to mind. The white list could allow the links for enchant:%d+[^%a%d], item:%d+[^%a%d], spell:%d+[^%a%d] and trade:%d+[^%a%d] to pass through. That way "wts a tank's dream [Enchant Weapon - Blade Ward]" shows up in Trade where it otherwise wouldn't due to the "tank" black list entry.

On the one hand, at least in my situation an option to "Allow white list to bypass black list" would "only" add another 1% to the 98% success rate. But then, its even closer to the perfect Trade channel. Plus, when players already have a white list, and when players already customize TradeFilter, it makes sense to give them such an option, too.

Oh and I don't see any tangible benefit in such an option for the repeat filter either. As in "Allow white list to bypass repeat filter". That wouldn't make sense. Allowing that would increase clutter in Trade. If a message is white-listed and it does not get thrown out by the black list (anymore), it will show up in Trade. No need for it to show up every ten seconds.

The white list optionally bypassing the black would be neat.

All the best,

Contiki

//Edit: Added translations for the one modified and one new string.

Greetings,

thanks very much for adding this feature to TradeFilter! I've translated the new strings to German and downloaded r153. I'm going to test it with a guildie who's also using EverTrade and provide proper feedback as soon as I can.

In the localizations' Activity Log you see I've changed one of the strings' translation temporarily to "Test" and back to its correct translation. I'm using Firefox here and am seeing a glitch where the localization text boxes are shown twice. The upper text box doesn't actually work. Though it took quite some time for me track that down as the reason why I couldn't translate any string. I've found the respective bug report and read there that the second box actually works. Had to verify that for myself hence the temporary "Test" and its change back to the right translation.

As for the changes during the last revisions, I didn't notice any bugs or strange/unwanted behavior despite me monitoring the add-on's activity more or less closely. One thing I did notice, however, is in the filter priorities diagram. If I remember correctly the white list's purpose was to always allow certain messages. Once the white list triggered the message was shown no matter what. However, the diagram says that white-listed messages can still be discarded if they match something from the black list, too. Is that intended?

All the best,

Contiki