Download
(164 Kb)
Download
Updated: 11-08-12 06:29 PM
Pictures
File Info
Compatibility:
Mists of Pandaria (5.0.4)
Updated:11-08-12 06:29 PM
Created:06-11-09 12:49 AM
Downloads:3,249
Favorites:18
MD5:
TradeFilter
Version: v3.5.1
by: evonder [More]
A Simple World of Warcraft Spam Filter!
Please help localize this project Here

TradeFilter does not only filter trade but has the ability to filter General, LookingforGroup, Say and Yell channels all which are configurable through the blizzard options panel.

Channel Filters
TradeFilter has a set of patterns for trade channel and separate set of patterns for all other channels, or "base" channels as we will call them. This allows the user to define what patterns may be good for trade but not other channels and vise versa. The user also has the ability to add patterns of their own to be matched against for both trade and "base" channel filters.

Default Channel Filters

Black and White Lists
TradeFilter also has a built in Black and White list. Refer to the flowchart for how Black and White lists are checked.

Default Black/White Lists

Configuration
Code:
/tf or /filter
To Do
Nothing planned

ChangeLog
ChangeLog Page

Supported Translations
Please help localize this project Here
tag v3.5.1
1b9c097ef90300a7fec822fbd296aea4e3355589
Erik L. Vonderscheer <evonder [AT] gmail [DOT] com>
2012-11-07 18:17:21 -0800

Tagging as v3.5.1

--------------------

Erik L. Vonderscheer:
- Update changelog.txt
- Remove commit hash from AddOn list
- Update change log
- Change TOC Title to include version
- Merge
- Fix various db key typos

--------------------

tag v3.5.0
bc1e1ba6941febee7c952401bf19fbe8694aa766
Erik L. Vonderscheer <evonder [AT] gmail [DOT] com>
2012-09-19 21:18:36 -0700

Tagging as v3.5.0

--------------------

Erik L. Vonderscheer:
- Filter trade by default
- Fix various db key typos
- Fix version output in configuration panel
- TOC bump to MoP
- Create branch Mists of Pandaria
- Change version output
- Fix GetNumPartyMembers() -> GetNumSubgroupMembers()
- Fix GetNumRaidMembers() -> GetNumGroupMembers()

--------------------

tag v3.4.11
cf9bbcf3e9bf835a96862f9b791a755d93718a73
Erik L. Vonderscheer <evonder [AT] gmail [DOT] com>
2012-01-30 19:23:36 -0800

Tagging as v3.4.11

--------------------

Erik L. Vonderscheer:
- TOC Bump
- Update Docs/main.txt

--------------------

tag v3.4.10
90a5ca61f819717050798fed8099b723838bb407
Erik L. Vonderscheer <evonder [AT] gmail [DOT] com>
2011-10-06 00:03:15 -0700

Tagging as v3.4.10

--------------------

Erik L. Vonderscheer:
- TOC bump

--------------------

tag v3.4.9
8d4a8e5b13078b4024f43d4712563e32f15402d7
Erik L. Vonderscheer <evonder@gmail.com>
2011-03-02 12:59:21 -0800

Tagging as v3.4.9

--------------------

Erik L. Vonderscheer:
- Fix typo
- Changed the way TradeFilter checks for party/raid members say/yell filtration.

--------------------

tag v3.4.8
42ad7803c5a5fbd556a310d9a9d623a4152bb8a9
Erik L. Vonderscheer <evonder@gmail.com>
2011-02-10 23:31:10 -0800

Tagging as v3.4.8

--------------------

Erik L. Vonderscheer:
- Add spam keyword to Docs/main.txt for site searches
- Fix Say/Yell logic

--------------------

tag v3.4.7
7846079a084b4caaa3c3562b1f4e742ae6cf6ae1
Erik L. Vonderscheer <evonder@gmail.com>
2011-02-07 20:42:01 -0800

Tagging as v3.4.7

--------------------

Erik L. Vonderscheer:
- Change AceTimer var to global to fix callback error

--------------------

Erik L. Vonderscheer:
- Fix bad global and poor logic in GetParty() function
- No point gathering raid/party members if you do not choose to exempt them
- Push for WowAce packager
- Change version output
- Fix GetParty() raid/party exempt list AceTimer issue.(ticket 6)
- Add check to see if timer is already active.(ticket 6)
- Fix trying to GetPartyMember() on a raid member.(drycode)(ticket 6)

--------------------

tag v3.4.5
ab0b97eb0c8642611962e69612218f523e261779
Erik L. Vonderscheer <evonder@gmail.com>
2011-01-23 08:18:35 -0800

Tagging as v3.4.5

--------------------

Erik L. Vonderscheer:
- Modify GUI to hide features when disabled
- Add AceTimer-3.0 as embedded lib
- Fix missing var for registered party and raid events
- Fix Party/Raid exempt list
Add AceTimer-3.0 for said exempt list if an UNKNOWN party member is discovered
- Modify project version output
Wowinterface needs more Git keyword substitutions

--------------------

tag v3.4.4
f05f4dc83154abac2f0ee4f3d8800b3b9909246d
Erik L. Vonderscheer <evonder@gmail.com>
2011-01-15 02:23:26 -0800

Tagging as v3.4.4

--------------------

Erik L. Vonderscheer:
- Fix exempt party function from adding "unknown"

tag 3.4.3-release
69ea920d43488c1744983c8a69c41f1614f9be5e
Erik L. Vonderscheer <evonder@gmail.com>
2011-01-13 14:39:48 -0800

Tagging as 3.4.3-release

--------------------

Erik L. Vonderscheer:
- Fix unintentional wipe of current party exemption table

tag 3.4.2-release
57aae6d78e8e6b78882ccaddaefbced8ab1c1284
Erik L. Vonderscheer <evonder@gmail.com>
2011-01-10 22:01:41 -0800

Tagging as 3.4.2-release

--------------------

Erik L. Vonderscheer:
- Fix LDB counting of filtered messages when debug is off, also make sure that LDB is loaded before calling LDBUpdate()
- Code cleanup
- Remove AceTimer and AceConsole

tag 3.4.1-release
bdde9cd7cdd46f4654bbb949b432bb1f7701312e
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-24 13:24:33 -0800

Tagging as 3.4.1-release

--------------------

Erik L. Vonderscheer:
- Fix typo in GetParty() function

tag 3.4.0-release
4ca45d4c57b8e3929cda813cb2bce20533c8ebe5
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-16 20:32:14 -0800

Tagging as 3.4.0-release

--------------------

Erik L. Vonderscheer:
- Replace nil with not
- Replace various expressions
- Remove unused variables
- Add name and realm to TOC
- Fix black/white list documentation
- Fix license
- Fix allowing a blank entry into any list
- Add check in FilterFunc() for special channels
- Move profile management into TradeFilter GUI frame

tag 3.3.4-beta
35827db85a9af8be2e03c1775607bd4f717f7c75
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-09 21:07:00 -0800

Tagging as 3.3.4-beta

--------------------

Erik L. Vonderscheer:
- Fix allowing a blank entry into any list
- Add check in FilterFunc() for special channels
- Move profile management into TradeFilter GUI frame

tag 3.3.1-release
e93eb693aac8db1f2377af631b4a103e6d357d00
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-08 19:10:31 -0800

Tagging as 3.3.1-release

--------------------

Erik L. Vonderscheer:
- Fix Print() line 155

tag 3.3.0-release
f3b653fb0c1c8e497a1c4f4a8ce067ea83b84040
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-06 18:33:56 -0700

Tagging as 3.3.0-release

--------------------

Erik L. Vonderscheer:
- Fix in-game version/tag output
- Rewrite blacklist/whitelist check logic
- Fix LDB blacklist counter
- Patch 4.0.1 code changes
- Remove repeat detection and all related functions/configurations
- Add LDB now shows all Filtered/Blacklist blocks
- Remove loading message print(now prints to debug window)
- Fix party exemption list from premature table wipes
- Remove friends list initial import print(now prints to debug window)
- Fix insure all tables exist before trying to iterate them
- Fix case sensitivity
- Add allow friends/party to be filtered even if on exempt list [Ticket #5]
- Fix project version output
- Fix party exempt debug messages
- Remove X-Compatible-With:
- Fix TOC embeds
- Fix party/raid exemption spam
- Add exempt locales

tag 3.2.5-beta
4d4b5d400f55344d99138e4cafc8cd80fba7713e
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-02 23:39:43 -0700

Tagging as 3.2.5-beta

--------------------

Erik L. Vonderscheer:
- Patch 4.0.1 code changes
- Remove repeat detection and all related functions/configurations
- Add LDB now shows all Filtered/Blacklist blocks
- Remove loading message print(now prints to debug window)
- Fix party exemption list from premature table wipes
- Remove friends list initial import print(now prints to debug window)
- Fix insure all tables exist before trying to iterate them
- Fix case sensitivity

tag 3.2.4-beta
c13bd2ac8ff78e2057a13ef2bb66ddaad3152f54
Erik L. Vonderscheer <evonder@gmail.com>
2010-11-01 21:29:00 -0700

Tagging as 3.2.4-beta

--------------------

Erik L. Vonderscheer:
- Add allow friends/party to be filtered even if on exempt list [Ticket #5]
- Fix project version output

tag 3.2.2-beta
1b726c9bb4a58e2364d82875263384b2115f831e
Erik L. Vonderscheer <evonder@gmail.com>
2010-10-29 00:38:34 -0700

Tagging as 3.2.2-beta

--------------------

Erik L. Vonderscheer:
- Fix party exempt debug messages
- Remove X-Compatible-With:
- Fix TOC embeds
- Fix party/raid exemption spam
- Add exempt locales

r193 | networkerror | 2009-12-01 03:46:05 +0000 (Tue, 01 Dec 2009) | 1 line
Changed paths:
A /tags/3.1.5-release (from /trunk:192)

Tagging as 3.1.5-release
------------------------------------------------------------------------
r192 | networkerror | 2009-11-16 08:06:48 +0000 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
M /trunk/Docs/changelog.txt
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Added BG Filters
- Config GUI reorganization
------------------------------------------------------------------------
r191 | networkerror | 2009-10-22 04:41:13 +0000 (Thu, 22 Oct 2009) | 1 line
Changed paths:
A /tags/3.1.4-release (from /trunk:190)

Tagging as 3.1.4-release
------------------------------------------------------------------------
r190 | networkerror | 2009-10-19 05:49:28 +0000 (Mon, 19 Oct 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- Friends import prints to debug frame instead of default
------------------------------------------------------------------------
r189 | networkerror | 2009-10-19 05:47:37 +0000 (Mon, 19 Oct 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- Only print friends imported to exemption list if debug is enabled
------------------------------------------------------------------------
r188 | networkerror | 2009-10-06 05:23:08 +0000 (Tue, 06 Oct 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- LDB Tooltip cleanup and localization
------------------------------------------------------------------------
r187 | networkerror | 2009-09-30 02:53:38 +0000 (Wed, 30 Sep 2009) | 1 line
Changed paths:
A /tags/3.1.3-release (from /trunk:186)

Tagging as 3.1.3-release
------------------------------------------------------------------------
r186 | networkerror | 2009-09-15 14:33:13 +0000 (Tue, 15 Sep 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- Player names in debug and spam windows are now class colored and player links
------------------------------------------------------------------------
r185 | networkerror | 2009-09-06 05:22:12 +0000 (Sun, 06 Sep 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3Locale.lua

TradeFilter3
- Locale touch
------------------------------------------------------------------------
r183 | networkerror | 2009-08-31 05:03:47 +0000 (Mon, 31 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- Touch for Locale update
------------------------------------------------------------------------
r182 | networkerror | 2009-08-16 07:53:41 +0000 (Sun, 16 Aug 2009) | 1 line
Changed paths:
A /tags/3.1.1-release (from /trunk:181)

Tagging as 3.1.1-release
------------------------------------------------------------------------
r172 | networkerror | 2009-08-15 09:10:58 +0000 (Sat, 15 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Ensure DuelFilter sets on login
------------------------------------------------------------------------
r171 | networkerror | 2009-08-15 06:46:52 +0000 (Sat, 15 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Fix LDB Repeat display not resetting when count is reset through config GUI
------------------------------------------------------------------------
r168 | networkerror | 2009-08-13 23:20:34 +0000 (Thu, 13 Aug 2009) | 3 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- TOC add X-WoWI-ID
- Locale bump
------------------------------------------------------------------------
r167 | networkerror | 2009-08-08 03:08:46 +0000 (Sat, 08 Aug 2009) | 4 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Added option whitelist bypass blacklist
- Added simple duel spam block
- Fix repeat filter not actually being off
------------------------------------------------------------------------
r166 | networkerror | 2009-08-05 18:38:21 +0000 (Wed, 05 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- LDB refresh when repeats reset
------------------------------------------------------------------------
r165 | networkerror | 2009-08-05 02:34:59 +0000 (Wed, 05 Aug 2009) | 1 line
Changed paths:
A /tags/3.0.164-release (from /trunk:164)

Tagging as 3.0.164-release
------------------------------------------------------------------------
r164 | networkerror | 2009-08-04 22:50:17 +0000 (Tue, 04 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- TOC bump
------------------------------------------------------------------------
r163 | networkerror | 2009-08-04 04:32:15 +0000 (Tue, 04 Aug 2009) | 1 line
Changed paths:
A /tags/3.0.162-release (from /trunk:162)

Tagging as 3.0.162-release
------------------------------------------------------------------------
r162 | networkerror | 2009-08-04 04:05:39 +0000 (Tue, 04 Aug 2009) | 3 lines
Changed paths:
M /trunk/TradeFilter3.toc
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Reset for special filters
- AddonLoader delayed
------------------------------------------------------------------------
r161 | networkerror | 2009-08-03 03:47:13 +0000 (Mon, 03 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- small cleanup
------------------------------------------------------------------------
r160 | networkerror | 2009-07-30 05:47:29 +0000 (Thu, 30 Jul 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Sorting should work now
------------------------------------------------------------------------
r159 | networkerror | 2009-07-30 04:22:17 +0000 (Thu, 30 Jul 2009) | 2 lines
Changed paths:
M /trunk/Docs/changelog.txt
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Keep lists sorted!
------------------------------------------------------------------------
r157 | networkerror | 2009-07-29 05:51:12 +0000 (Wed, 29 Jul 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- LDB fix
------------------------------------------------------------------------
r156 | networkerror | 2009-07-29 05:30:27 +0000 (Wed, 29 Jul 2009) | 3 lines
Changed paths:
M /trunk/.pkgmeta

TradeFilter3
- LDB embed fix
- Locale touch
------------------------------------------------------------------------
r155 | networkerror | 2009-07-29 03:45:30 +0000 (Wed, 29 Jul 2009) | 4 lines
Changed paths:
M /trunk/.pkgmeta
M /trunk/Docs/changelog.txt
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3.toc
M /trunk/TradeFilter3Options.lua

TradeFilter3
- LDB support for Repeats Blocked
- Ability for Whitelist to bypass repeat filter
- GUI layout changed a little
------------------------------------------------------------------------
r154 | networkerror | 2009-07-26 04:09:26 +0000 (Sun, 26 Jul 2009) | 3 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- Locale touch
- TOC update
------------------------------------------------------------------------
r153 | networkerror | 2009-07-25 20:10:12 +0000 (Sat, 25 Jul 2009) | 5 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- GUI Icon added
- Some table fault tolerance added for pattern lists
- Initial code for AddOn Channel messages(Not fully tested)
- Added special channel filtering ability
------------------------------------------------------------------------
r150 | networkerror | 2009-07-18 16:29:25 +0000 (Sat, 18 Jul 2009) | 2 lines
Changed paths:
M /trunk/Docs/main.txt
M /trunk/TradeFilter3.lua

TradeFilter3
- Added msgID(arg11) to debug and spam output.
Archived Files (2)
File Name
Version
Size
Author
Date
v3.5.0
164kB
evonder
09-19-12 10:32 PM
v3.4.11
163kB
evonder
01-30-12 09:23 PM


Post A Reply Comment Options
Old 07-14-09, 08:48 PM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
Originally posted by KyrosKrane
OK, I think I'm finally starting to understand how this works. I've taken your priority diagram from the description and turned it into a sort of pseudo-code. Tell me if this is correct, please.
  • If speaker is on friends list, display as normal and skip the rest of these steps.
  • If speaker is self (unless self-filtering is turned on), display as normal and skip the rest of these steps.
  • If message matches whitelist, display as normal and skip the rest of these steps.
  • If message matches blacklist, discard it (don't display anywhere) and skip the rest of these steps.
  • If message has been repeated, discard it (don't display anywhere) and skip the rest of these steps.
  • Choose one:
    • If message matches the filter, display as normal; OR
    • if message does not match the filter and the spam window option is enabled, display in the spam window; OR
    • if message does not match the filter and the spam window option is disabled, discard it (don't display anywhere).

Is that about correct?
Correct
Originally posted by KyrosKrane
What I'm hoping for is a little different. Here's what I'm looking for; differences in bold.
  • If speaker is on friends list, display as normal and skip the rest of these steps.
  • If speaker is self (unless self-filtering is turned on), display as normal and skip the rest of these steps.
  • If message matches whitelist, display as normal and skip the rest of these steps.
  • If message matches blacklist, display in the spam window and skip the rest of these steps.
  • If message has been repeated, discard it (don't display anywhere) and skip the rest of these steps.
  • Else, display the message as normal.

Is this possible with your addon?
Not ATM but I will put an option to allow messages that return a match of your blacklist patterns to be shown in the SPAM frame on the "To Do" list. You can empty your Trade/Base filter lists, essentially monitoring the enabled channels but not subjecting them to the filter function

EDIT:: I have decided against this; if you would like to see the blacklisted messages you can get the latest alpha build, which is usually bug free, and enable debugging.

Originally posted by KyrosKrane
On a related note, are the regular expressions used for the filter and white/blacklists interchangeable? Can I copy the expressions from, say, the blacklist into the filter window and the addon would parse them without error?
Yes they are interchangeable but you should know how Lua patterns beforehand
Last edited by evonder : 07-15-09 at 12:08 AM.
evonder is offline Report comment to moderator  
Reply With Quote
Old 07-15-09, 01:02 PM  
Contiki
A Kobold Labourer
 
Contiki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 74
Uploads: 2
Greetings,

I've tested r144. Here's what I've got to say ;-)
  1. Translation
    • In the options menu under Repeat Filtration the tooltips for both Repeats and Time start with the untranslatable word "Usage". As in, "Usage: Filtere Zeichenketten, die x-mal innerhalb von y Sekunden im Chat erscheinen."

  2. Quirks/strange behavior
    • Black- and white-listed messages in my debug chat frame have all white spaces stripped from the text as in, "ulduarmyass" instead of "ulduar my ass". It would be neat if players could get white spaces at least visually, even if the add-on uses those stripped versions internally.

  3. Suggestions
    • Seeing the Matched reports in my debug chat frame (next to the Lua pattern that matched) is very useful. Could you add these hints for black- and white-listed messages, too?
    • When the add-on checks filters, the debug chat frame can become crowded. Could you add an option to disable the Checking for Match lines?
Greetings and all the best,

Contiki
Contiki is offline Report comment to moderator  
Reply With Quote
Old 07-15-09, 09:10 PM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
r147 Addresses the following:
Originally posted by recluse
Could we get an option to disable the 'so and so added/removed from exempt list' spam? It's not a bad feature or anything, but I have an addon which uses the friends list to determine corpse statuses, and it gets really spammy! Thanks
Friends list adding/removing messages will now only show if you have debugging enabled.

Originally posted by KyrosKrane
What I'm hoping for is a little different. Here's what I'm looking for; differences in bold.
  • If speaker is on friends list, display as normal and skip the rest of these steps.
  • If speaker is self (unless self-filtering is turned on), display as normal and skip the rest of these steps.
  • If message matches whitelist, display as normal and skip the rest of these steps.
  • If message matches blacklist, display in the spam window and skip the rest of these steps.
  • If message has been repeated, discard it (don't display anywhere) and skip the rest of these steps.
  • Else, display the message as normal.

Is this possible with your addon?
You can now output Blacklist matches to the SPAM ChatFrame, this is enabled in the Output Options in the configuration GUI.

Originally posted by Contiki
Greetings,

I've tested r144. Here's what I've got to say ;-)
  1. Translation
    • In the options menu under Repeat Filtration the tooltips for both Repeats and Time start with the untranslatable word "Usage". As in, "Usage: Filtere Zeichenketten, die x-mal innerhalb von y Sekunden im Chat erscheinen."

  2. Quirks/strange behavior
    • Black- and white-listed messages in my debug chat frame have all white spaces stripped from the text as in, "ulduarmyass" instead of "ulduar my ass". It would be neat if players could get white spaces at least visually, even if the add-on uses those stripped versions internally.

  3. Suggestions
    • Seeing the Matched reports in my debug chat frame (next to the Lua pattern that matched) is very useful. Could you add these hints for black- and white-listed messages, too?
    • When the add-on checks filters, the debug chat frame can become crowded. Could you add an option to disable the Checking for Match lines?
Greetings and all the best,

Contiki
1) "Usage:" is from the AceDBOptions library and is one of the few things that the addon localization doesn't affect.

2) Fixed

3a) Done

3b) The ability to now strip the "Checking for Match" while iterating the given pattern table is available, this is enabled in the Output Options in the configuration GUI.

Project Home
Last edited by evonder : 07-15-09 at 11:14 PM.
evonder is offline Report comment to moderator  
Reply With Quote
Old 07-22-09, 05:16 PM  
Rolzroyce
A Murloc Raider

Forum posts: 4
File comments: 9
Uploads: 0
I am having a problem where the addon is letting about 40% of the messages thru, and filtering some messages that are not spam, such as "Did that just happen?" and "Where can I find [NPC Name]?"

I restored everything to defaults and still have the problem. Any advice?
Rolzroyce is offline Report comment to moderator  
Reply With Quote
Old 07-22-09, 09:17 PM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
Originally posted by Rolzroyce
I am having a problem where the addon is letting about 40% of the messages thru, and filtering some messages that are not spam, such as "Did that just happen?" and "Where can I find [NPC Name]?"

I restored everything to defaults and still have the problem. Any advice?
Only messages that contain a match to your pattern list will be allowed to pass through the filter. "Did that just happen?" and "Where can I find [NPC Name]?" will never be allowed with the default filter pattern list.
__________________
Author: TradeFilter, CheckFearWard, Bloodsurge and more
evonder is offline Report comment to moderator  
Reply With Quote
Old 07-23-09, 04:47 PM  
Recluse
A Cliff Giant
 
Recluse's Avatar
AddOn Author - Click to view AddOns

Forum posts: 70
File comments: 112
Uploads: 14
Thank you

Originally posted by evonder
Friends list adding/removing messages will now only show if you have debugging enabled.
Thanks
__________________
We'd be together, but only diamonds last forever...
Last edited by Recluse : 07-23-09 at 04:54 PM.
Recluse is offline Report comment to moderator  
Reply With Quote
Old 07-24-09, 07:01 AM  
GreyWolfSC
A Murloc Raider

Forum posts: 5
File comments: 84
Uploads: 0
Originally posted by evonder
Only messages that contain a match to your pattern list will be allowed to pass through the filter. "Did that just happen?" and "Where can I find [NPC Name]?" will never be allowed with the default filter pattern list.
Either I'm not understanding the addon or something's not working right. It filtered "lvl 80 druid?", plus at least 5 more messages that were definitely not spam, out of General chat while I was talking about a ganker that was hounding me last night.
GreyWolfSC is offline Report comment to moderator  
Reply With Quote
Old 07-24-09, 03:21 PM  
Contiki
A Kobold Labourer
 
Contiki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 74
Uploads: 2
Greetings,

I'm trying out the add-on EverTrade which transmits Trade channel messages from players in a Trade-enabled city to players outside of Trade-enabled cities. Pretty sweet if I'm in the middle of nowhere and still want to stay in touch with what the average Joe has to offer.

Due to the way EverTrade works, TradeFilter doesn't touch its messages. It'd be really sweet if TradeFilter (optionally?) checked EverTrade's messages, too. Do you think that'd be possible/sensible?

All the best,

Contiki
Contiki is offline Report comment to moderator  
Reply With Quote
Old 07-24-09, 06:04 PM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
Originally posted by Contiki
Greetings,

I'm trying out the add-on EverTrade which transmits Trade channel messages from players in a Trade-enabled city to players outside of Trade-enabled cities. Pretty sweet if I'm in the middle of nowhere and still want to stay in touch with what the average Joe has to offer.

Due to the way EverTrade works, TradeFilter doesn't touch its messages. It'd be really sweet if TradeFilter (optionally?) checked EverTrade's messages, too. Do you think that'd be possible/sensible?

All the best,

Contiki
I will take a look at it when the time permits.

EDIT:: Now to find someone to test it with :P
EDIT2:: Pretty sure special channels filtering is working fine, but I need a person in guild running the mod to make sure that hidden channel spam through the guild channel is being filtered properly.
__________________
Author: TradeFilter, CheckFearWard, Bloodsurge and more
Last edited by evonder : 07-25-09 at 01:42 AM.
evonder is offline Report comment to moderator  
Reply With Quote
Old 07-25-09, 06:52 PM  
Contiki
A Kobold Labourer
 
Contiki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 74
Uploads: 2
Greetings,

thanks very much for adding this feature to TradeFilter! I've translated the new strings to German and downloaded r153. I'm going to test it with a guildie who's also using EverTrade and provide proper feedback as soon as I can.

In the localizations' Activity Log you see I've changed one of the strings' translation temporarily to "Test" and back to its correct translation. I'm using Firefox here and am seeing a glitch where the localization text boxes are shown twice. The upper text box doesn't actually work. Though it took quite some time for me track that down as the reason why I couldn't translate any string. I've found the respective bug report and read there that the second box actually works. Had to verify that for myself hence the temporary "Test" and its change back to the right translation.

As for the changes during the last revisions, I didn't notice any bugs or strange/unwanted behavior despite me monitoring the add-on's activity more or less closely. One thing I did notice, however, is in the filter priorities diagram. If I remember correctly the white list's purpose was to always allow certain messages. Once the white list triggered the message was shown no matter what. However, the diagram says that white-listed messages can still be discarded if they match something from the black list, too. Is that intended?

All the best,

Contiki
Contiki is offline Report comment to moderator  
Reply With Quote
Old 07-25-09, 07:42 PM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
Originally posted by Contiki
Greetings,

thanks very much for adding this feature to TradeFilter! I've translated the new strings to German and downloaded r153. I'm going to test it with a guildie who's also using EverTrade and provide proper feedback as soon as I can.
I hope that the Guild AddOn message channel is filtered properly, without having someone to test with I am kinda shooting in the dark. Using the "Global" channel in EverTrade in conjunction with TradeFilter's "Special Channel" list should work just fine.

Originally posted by Contiki

As for the changes during the last revisions, I didn't notice any bugs or strange/unwanted behavior despite me monitoring the add-on's activity more or less closely. One thing I did notice, however, is in the filter priorities diagram. If I remember correctly the white list's purpose was to always allow certain messages. Once the white list triggered the message was shown no matter what. However, the diagram says that white-listed messages can still be discarded if they match something from the black list, too. Is that intended?

All the best,

Contiki
It is intended as I believe that even though it passes our white list it still should be at the scrutiny of our black list and our repeat filter, e.g. "Anal [ITEM LINK]" or just plain repeating the same advert that passes our white list a million times without being blocked.
__________________
Author: TradeFilter, CheckFearWard, Bloodsurge and more
evonder is offline Report comment to moderator  
Reply With Quote
Old 07-26-09, 10:30 PM  
Contiki
A Kobold Labourer
 
Contiki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 74
Uploads: 2
Hi,

I see where you're coming from and especially in case of these anal this-and-this item links it makes sense. However, at lesat on my server this anal meme thingy isn't an issue.

I'm using TradeFilter to get the actual Trade channel back; the way I think it was intended. My filter list contains all the good and valid stuff that usually happens in Trade: item links, profession links and whatnot. So that's allowed. Since at least on my realm some players like to use Trade as a substitute for LFG I've put all the LFG-related stuff - among other terms - on the black list: "naxx", "ulduar", "druid", "tank" and whatnot. By now both lists work well enough to come to the right decision 98% of the time. Roughly 2% of the valid Trade stuff get's lost and roughly 2% of the non-Trade stuff shows up in Trade. That's already great and I'm further fine-tuning the lists.

One issue I see is with items such as the [Relic of Ulduar]. I can modify the black list so it does trigger with "ulduar[^%]]", meaning with any "ulduar" followed by something else than the closing brackets ("]") of the item link. That way "lf tank for ulduar 10-man" gets blacklisted while "looking for 400 [Relic of Ulduar]" passes through. Problem is (that's where part of the missing 2% come from) when players ask for relics without an item link. Then there are no brackets to check for and the very valid Trade-related question for them gets thrown out. There are quite a few more items of this kind. [Hunter's Scout of the Bandit] comes to mind which could easily be cought by the "hunter" black list entry unless players provide the item link. The list goes on quite a bit, even though these make up a minority of Trade messages.

What I'm thinking about is to allow players to "free" the white list from black list checking. Like an option "Allow white list to bypass black list". I'm aware that this option may not be the right thing for all players. There's, however, the benefit of further customizing one's lists. The white list could take the most common mistakable item names and allow them to show up in Trade.

Another benefit comes to mind. The white list could allow the links for enchant:%d+[^%a%d], item:%d+[^%a%d], spell:%d+[^%a%d] and trade:%d+[^%a%d] to pass through. That way "wts a tank's dream [Enchant Weapon - Blade Ward]" shows up in Trade where it otherwise wouldn't due to the "tank" black list entry.

On the one hand, at least in my situation an option to "Allow white list to bypass black list" would "only" add another 1% to the 98% success rate. But then, its even closer to the perfect Trade channel. Plus, when players already have a white list, and when players already customize TradeFilter, it makes sense to give them such an option, too.

Oh and I don't see any tangible benefit in such an option for the repeat filter either. As in "Allow white list to bypass repeat filter". That wouldn't make sense. Allowing that would increase clutter in Trade. If a message is white-listed and it does not get thrown out by the black list (anymore), it will show up in Trade. No need for it to show up every ten seconds.

The white list optionally bypassing the black would be neat.

All the best,

Contiki

//Edit: Added translations for the one modified and one new string.
Last edited by Contiki : 07-26-09 at 10:50 PM.
Contiki is offline Report comment to moderator  
Reply With Quote
Old 07-26-09, 11:00 PM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
Originally posted by Contiki
Hi,

**Snip**

The white list optionally bypassing the black would be neat.

All the best,
Contiki
I will add that to the "To Do" list.

Originally posted by Contiki

//Edit: Added translations for the one modified and one new string.
Thank you sir, you have been a great help not only with translations but with such well thought out descriptions of problems or possible enhancements.

EDIT:: Btw did you get a chance to see if the "Special Channel" or AddOn channel was being filtered properly?
__________________
Author: TradeFilter, CheckFearWard, Bloodsurge and more
Last edited by evonder : 07-26-09 at 11:01 PM.
evonder is offline Report comment to moderator  
Reply With Quote
Old 07-26-09, 11:49 PM  
Contiki
A Kobold Labourer
 
Contiki's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 74
Uploads: 2
Originally posted by evonder
Btw did you get a chance to see if the "Special Channel" or AddOn channel was being filtered properly?
Nope, not yet.

On a side note, I was just looking through a text file named tradefilter.txt I had on my desktop. Was wondering what was in there and lo and behold, during the last weeks I had jotted down suggestions and strange/unwanted behavior in TradeFilter I had totally forgotten about. So here goes.
  • A while ago you changed TradeFilter's slogan from "Filter the shit outta Trade channel!" to "Not just any old filter!" Initially only on the WowAce homepage, later here on wowinterface, too. I like that slogan better than the former one and was wondering what you'd think about adding it to the TOC file, too. So for consistency's sake, what do you think about adding "Not just any old filter!" to the TOC file, too?
  • This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed. Consider me entering these terms into the filter list:
    • one
      two
      three
      four
      five
    Now I hit the Accept button an bam, the list looks like this:
    • three
      five
      one
      four
      two
    I've learned to live with this bevahior and am keeping a copy of the properly ordered filter terms separate. However, wouldn't it be cool if the add-on didn't reorder the list? That way players woudn't need to keep a separate copy of their filter terms and could instead change them in the input fields ;-) By the way, when I repeatedly hit Accept without actually changing the filter terms the lists get reordered repeatedly, too. I have to admit that looks kinda funny. *wonder what's up at the top the next time I hit accept*
That's it, that's the two things I had in my text file. Going to delete it now that I've let you know.

As for helping out with feedback, reports, translations 'n' stuff, you're welcome!

All the best,

Contiki
Contiki is offline Report comment to moderator  
Reply With Quote
Old 07-27-09, 12:05 AM  
evonder
A Defias Bandit
 
evonder's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 28
Uploads: 1
Originally posted by Contiki
Nope, not yet.

On a side note, I was just looking through a text file named tradefilter.txt I had on my desktop. Was wondering what was in there and lo and behold, during the last weeks I had jotted down suggestions and strange/unwanted behavior in TradeFilter I had totally forgotten about. So here goes.
  • A while ago you changed TradeFilter's slogan from "Filter the shit outta Trade channel!" to "Not just any old filter!" Initially only on the WowAce homepage, later here on wowinterface, too. I like that slogan better than the former one and was wondering what you'd think about adding it to the TOC file, too. So for consistency's sake, what do you think about adding "Not just any old filter!" to the TOC file, too?
  • This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed. Consider me entering these terms into the filter list:
    • one
      two
      three
      four
      five
    Now I hit the Accept button an bam, the list looks like this:
    • three
      five
      one
      four
      two
    I've learned to live with this bevahior and am keeping a copy of the properly ordered filter terms separate. However, wouldn't it be cool if the add-on didn't reorder the list? That way players woudn't need to keep a separate copy of their filter terms and could instead change them in the input fields ;-) By the way, when I repeatedly hit Accept without actually changing the filter terms the lists get reordered repeatedly, too. I have to admit that looks kinda funny. *wonder what's up at the top the next time I hit accept*
That's it, that's the two things I had in my text file. Going to delete it now that I've let you know.

As for helping out with feedback, reports, translations 'n' stuff, you're welcome!

All the best,

Contiki
1) Localisation for Title has been changed, forgot all about that one
2) This is because the tables are dictionary style and as such have to use pairs to iterate over the tables, the caveat of pairs is that it does not return in a predetermined order. The reason for the table reorders itself every time you hit the accept button is the way that the table is wiped and repopulated with the given values that you supply...hence pairs iterates over it again to return you the values and poof reordered again :P
__________________
Author: TradeFilter, CheckFearWard, Bloodsurge and more
evonder is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.