Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(23 Kb)
Download
Updated: 10-24-09 12:05 PM
Pictures
File Info
Updated:10-24-09 12:05 PM
Created:08-28-09 08:38 AM
Downloads:3,135
Favorites:50
MD5:

SaneLFG (fine tuning for the LFG window)

Version: 30200.15
by: Coren [More]

A smallish addon that started out with a third option in the LFM window (players/groups selection, added "all"), but then grew into sticky LFG/LFM while relogging, dinging and grouping with the option (via button on the LFG pane) of pausing your LFG/LFM choice and restoring it to the previous setting with one click.

It also tries to parse the comment of groups for "# heal"/"heal"/"# tank"/"tank"/"# dps"/"dps" and fills that into the columns. (And it parses a special comment "?D#T#H#-" into the columns, but doesn't offer a way yet to set that up via buttons...)

WARNING:
This addon does inevitably cause taint and blocked action messages due to Blizzard's (still faulty) dropdown menu implementation. There's nothing about it that I can do besides completely duplicating the whole LFG interface, and that's currently quite some more work than I'm willing to put into this.
It seems that you can avoid being blocked on all other unit frames by being blocked on one, therefore I suggest to focus *yourself* (with the menu of your player frame) to force the Blizzard code to initialize itself properly - then your target/party/raid frames should be working.

FLFTAQ (Frequently lazily failed-to-ask question):
"I just want the 'all' thing, can I avoid the other stuff?"
If you enable the storing of pause mode across sessions (with '/sanelfg config pausesave' or the cycle button menu), clear your LFM and your LFG choices, and then enable pause with an empty LFG/LFM sheet, then it won't do anything further besides the 'all' feature.

Future plan: Include a more comprehensive mixed mode where you select *multiple* dungeons and *all* are shown. (I.e.: Looking for trial of the crusader, normal or hero => show all groups for both.) This is not that simple due to some restrictions on the server side (hardware event requirement).

(see Changelog.txt in archive for older entries)

30200.09:
- Pause status is now stored per char instead of globally
- added cycling through stored LFG set
- fixed incomplete level-up handling when in Pause mode
- initializing to "all" now also happens if started in Pause mode
- if a comment is set, a small "+" is shown left of the level column
- on only viewing groups, the member # has been corrected to the original position
- SaneLFG LFM entry tooltip: added an option to always use this routine, even if not in full mixed mode
- SaneLFG LFM entry tooltip: comment color can be set (to differentiate it more clearly)
- cycle tooltip: now shows immediately the first time you hover over the button, the following times delayed 5 seconds
- added the cycling function in key bindings

30200.10:
- heroic instance names should now be properly setup
- added output to LFM restore to inform the user if LFGQuery() could (not) be sent

30200.11:
- after leaving a party, the restore is now delayed by 30 seconds
- when paused, a tooltip on the button on the LFG tab indicates which state will be restored
- tooltips: should now output " -- none -- " for no selection (instead of ?0)
- corrected a bug when checking if all LFG data is available
- full-mixed-mode: cycle button can now work off the custom LFM set
- full-mixed-mode: now honors role filters
- full-mixed-mode: fixed not functioning scrolling

30200.12:
- colorization: dungeons/raids that are currently in lockout are colored red
- menu: separators now state what the scope of the next block of options is (global/per char)
- menu: option for cycling in mixed mode named more clearly

30200.13:
- lockout colorization: now also for the LFM tab
- workaround #3 for Blizzard's inconsistency in lockout name vs. LFG name of a dungeon...

30200.14:
- workaround #4 for Blizzard's inconsistency in lockout name vs. LFG name of a dungeon...

30200.15:
- added new per-char option "On login, start with PAUSEd LFG" (default: no)
- on restoring after leaving a group, instances the char is saved to are dropped, unless the new global option "Keep LFG entries, even if saved to it" is on (default: off)
Optional Files (0)


Archived Files (7)
File Name
Version
Size
Author
Date
30200.14
23kB
Coren
10-16-09 04:52 PM
30200.13
22kB
Coren
10-16-09 05:45 AM
30200.12
22kB
Coren
10-11-09 08:34 PM
30200.11
21kB
Coren
10-08-09 01:00 PM
30200.10
20kB
Coren
09-29-09 12:51 PM
30200.09
19kB
Coren
09-21-09 08:01 AM
30200.08
19kB
Coren
09-14-09 07:50 AM


Post A Reply Comment Options
Unread 09-13-09, 03:14 PM  
Strife[CUK]
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 314
Uploads: 6
Hi Coren,

SaneLFG is a nice addon to have, I switched on basic logging for taints and found this.

9/13 21:27:36.886 An action was blocked because of taint from SaneLFG -
9/13 21:27:36.886 LFGQuery()
9/13 21:27:36.886 Interface\FrameXML\LFGFrame.lua:653 SendLFGQuery()
9/13 21:27:36.886 Interface\FrameXML\LFGFrame.lua:60

Originally Posted by Iriel on the WoW UI forum
* To turn taint logging off: /console taintLog 0
* To turn action taint logging on: /console taintLog 1
* To turn full taint logging on: /console taintLog 2
Strife[CUK] is offline Report comment to moderator  
Reply With Quote
Unread 09-12-09, 12:56 AM  
tenchworks
A Kobold Labourer
 
tenchworks's Avatar

Forum posts: 0
File comments: 3
Uploads: 0
Originally posted by xtoq
You can set up a keybinding in the default keybind menu for setting a focus, which will keep any taint from happening to unit frames because you're not right clicking them to get that menu.
As Xtoq has pointed out you can set your focus without using the broken drop down menu since that's the only thing that seems to redflag any tainting that occurs. Thus that means if you use "/focus" you can get your focus target without getting taint errors as well as using the mentioned keybind. So if you use the command it'll focus your target or clear your focus if you have no target.

Just felt that I should point that out. Ever since tainting came into play in the game, I've had to rely on a macro on my bar (yeah I'm too lazy to type 5 letters) so I can get my unit focus without being hit with an error.

It doesn't fix the problem but it's a workaround till blizzard actually helps us and fixes the error with drop down menus.
tenchworks is offline Report comment to moderator  
Reply With Quote
Unread 09-11-09, 11:57 AM  
Coren
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 55
Uploads: 7
Originally posted by cawfee
(...)
Any idea what may be causing that, or what I could do to prevent it from happening?
I actually have no idea how that should happen. But I added an additional command '/sanelfg lfxstatus' that should show what your client thinks about your LFG status. If that output is different than you'd expect and you can reproduce how, I'd like to hear about it. (The last line should read isLFG = false, isLFM = false, if you are not LFG/LFM at that time.)
Last edited by Coren : 09-11-09 at 11:58 AM.
Coren is offline Report comment to moderator  
Reply With Quote
Unread 09-08-09, 05:50 PM  
cawfee
An Aku'mai Servant
 
cawfee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 30
File comments: 94
Uploads: 1
It seems that this addon leaves me in my previously chosen LFG-selections even after I clear them all (including un-checking all my roles) and hit Pause; I've gotten repeated whispers now from people confirming that I'm still in the LFG for instances I had selected before, but have since removed.

Any idea what may be causing that, or what I could do to prevent it from happening?
Last edited by cawfee : 09-08-09 at 05:51 PM.
cawfee is offline Report comment to moderator  
Reply With Quote
Unread 09-07-09, 09:13 AM  
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view AddOns

Forum posts: 32
File comments: 640
Uploads: 3
Originally posted by Coren
All attempts to avoid the taint seem futile: Even the most basic core of this addon (just adding the option to show LFG/LFM at the same time) is already resulting in the error.
If you really depend on the focus menu entry, you're SOL for now. Sorry.
You can set up a keybinding in the default keybind menu for setting a focus, which will keep any taint from happening to unit frames because you're not right clicking them to get that menu. It also turn soemthing that is 2-3 click into a simple click and keystroke. This is actually what Blizzard wants you to do I think, rather than use the menu....but they didn't remove it.... Regardless, I doubt Blizzard is going to "fix" this as they "broke" it to fight botting. Of course, they could have easily just had it give you a little "Sorry, you can't do this" system message instead of scary taint errors, but oh well. This is something all unit frame addons suffer from, and any addon that hooks into unit frame menus, afaik.

For an alternate solution, you might look into Player Menu whiich does something nifty to allow right click menus on unit frames. Makes another window or some such. Might help your addon out.
__________________
There is absolutely no evidence to support the theory that life is serious.
xtoq is offline Report comment to moderator  
Reply With Quote
Unread 09-05-09, 04:32 AM  
Coren
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 55
Uploads: 7
Originally posted by Kouri
Having an "All" option that combines the individual LFG and group LFM results into one window makes LFG so much easier to use, I'm amazed that it isn't in the standard Blizzard UI.
It *was* originally just the combined view, if you look at older screenshots of the LFG window...

Unfortunately, I seem to get the following taint errors when using it: (...)
As you can see, I was simply trying to set a focus target but was unable to do so. I hope there is a way to avoid this?
That looks ugly. No reference whatsoever to any line of SaneLFG... I'll look into it, and it seems this is a fundamental error on Blizzard's end. The hope of them finally and completely fixing UIDropDownMenu.lua is in vain again (since over a year now, admittedly the brokenness got less bad over time).:-(

WORKAROUND: Click on your *own* player frame menu and focus yourself. This *will* give an error, but properly initialize the parts that are missing for all other frame menu focus calls, which will then work. The focusing of yourself will stay broken, but that shouldn't be a real problem... :-)
(Unfortunately, I found no definite way - sometimes focusing various units fixes it, sometimes not - to unbreak the menus if you didn't do that, until Blizzard finally gets some clue and fixes the underlying issue. If you use the standard ugly Blizzard frames, it "fixes" itself by simply retrying.)

All attempts to avoid the taint seem futile: Even the most basic core of this addon (just adding the option to show LFG/LFM at the same time) is already resulting in the error.
If you really depend on the focus menu entry, you're SOL for now. Sorry.
Last edited by Coren : 09-05-09 at 02:25 PM.
Coren is offline Report comment to moderator  
Reply With Quote
Unread 09-03-09, 01:33 PM  
Kouri
A Kobold Labourer
 
Kouri's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 121
Uploads: 4
I'm so happy I found this mod. Having an "All" option that combines the individual LFG and group LFM results into one window makes LFG so much easier to use, I'm amazed that it isn't in the standard Blizzard UI. So thank you for making it!

Unfortunately, I seem to get the following taint errors when using it:
Code:
9/3 23:50:20.166  Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by SaneLFG - Interface\FrameXML\UIDropDownMenu.lua:38
9/3 23:50:20.166      securecall()
9/3 23:50:20.166      Interface\FrameXML\UIDropDownMenu.lua:64 UIDropDownMenu_Initialize()
9/3 23:50:20.166      Interface\FrameXML\WorldMapFrame.lua:496 WorldMapZoneDropDown_Update()
9/3 23:50:20.166      Interface\FrameXML\WorldMapFrame.lua:155
9/3 23:50:20.166  Execution tainted by SaneLFG while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:860 UIDropDownMenu_ClearAll()
9/3 23:50:20.166      Interface\FrameXML\WorldMapFrame.lua:525 WorldMapLevelDropDown_Update()
9/3 23:50:20.166      Interface\FrameXML\WorldMapFrame.lua:156
9/3 23:50:20.166  An action was blocked because of taint from SaneLFG - FocusUnit()
9/3 23:50:20.166      Interface\FrameXML\UnitPopup.lua:1206 func()
9/3 23:50:20.166      Interface\FrameXML\UIDropDownMenu.lua:563 UIDropDownMenuButton_OnClick()
9/3 23:50:20.166      DropDownList1Button2:OnClick()
As you can see, I was simply trying to set a focus target but was unable to do so. I hope there is a way to avoid this?
Last edited by Kouri : 09-04-09 at 04:22 PM.
Kouri is offline Report comment to moderator  
Reply With Quote
Unread 09-01-09, 07:57 AM  
Coren
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 55
Uploads: 7
Originally posted by Aisenfaire
(...) When you're in a group and looking through LFG, then later the group disbands, you somehow end up queued (as "individual") for the dungeon you were looking at for members when you were grouped.
Should be fixed now. If you still find this happening, please re-report.

Originally posted by Yourstruly
Could we get an option to disable the auto-rejoin on LFG or an extended option of manually rejoining last queue? (...)
Added a command to store pause status. Use '/sanelfg config pausesave' to enable it and click the pause button. That should disable all restore operations.
Coren is offline Report comment to moderator  
Reply With Quote
Unread 09-01-09, 07:01 AM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
Could we get an option to disable the auto-rejoin on LFG or an extended option of manually rejoining last queue?

I love the view feature but I only ever want to rejoin a queue on my own accord and this only happens when someone invites me the wrong group.
__________________
I stopped playing back in 2010. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, v6.
Last edited by v6o : 09-01-09 at 07:01 AM.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 08-29-09, 07:52 PM  
Aisenfaire
A Murloc Raider

Forum posts: 4
File comments: 270
Uploads: 0
Originally posted by Coren
Done. Thanks for reporting!



I'm open for suggestions. It should simply imply that this doesn't replace the window, just enhance some rough edges. For now, changing to "gloss" with next release to avoid the language confusion.
I suggest "enhancements for the LFG window", since "gloss" is the name of a texture people use to make buttons, minimaps, and buffs look shiny. They might think "gloss" is to make LFG shiny, too!


* * *

Also, I noticed something--maybe it's a bug.

When you're in a group and looking through LFG, then later the group disbands, you somehow end up queued (as "individual") for the dungeon you were looking at for members when you were grouped.
Last edited by Aisenfaire : 08-30-09 at 05:12 AM.
Aisenfaire is offline Report comment to moderator  
Reply With Quote
Unread 08-29-09, 07:49 PM  
Aisenfaire
A Murloc Raider

Forum posts: 4
File comments: 270
Uploads: 0
I've been looking for an addon that does exactly what this one does--put the groups and individuals together in one pane in the LFG window. Thanks very much!

P.S. Are there any commands for configuration? /sanelfg doesn't seem to do anything.
Aisenfaire is offline Report comment to moderator  
Reply With Quote
Unread 08-28-09, 05:32 PM  
Coren
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 55
Uploads: 7
Originally posted by Yourstruly
(...) Edit: Website says SaneLFG but ingame the name is Karma. Should probably update that. (...)
Done. Thanks for reporting!

(...)
Edit3: Description is "polish for the LFG/LFM window", now that makes you think it's an translation for the LFG system. Please try and change it to something fitting.
I'm open for suggestions. It should simply imply that this doesn't replace the window, just enhance some rough edges. For now, changing to "gloss" with next release to avoid the language confusion.
Last edited by Coren : 08-29-09 at 07:02 PM.
Coren is offline Report comment to moderator  
Reply With Quote
Unread 08-28-09, 03:48 PM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
An addon people wish Blizzard built in by default. The group / individual view was a big mistake done by them and hopefully this addon will solve it until they do.

Downloading and going to test it out now.

Edit: Website says SaneLFG but ingame the name is Karma. Should probably update that.

Edit2: Looked ingame, lovely. 2 thumbs up.

Edit3: Description is "polish for the LFG/LFM window", now that makes you think it's an translation for the LFG system. Please try and change it to something fitting.
__________________
I stopped playing back in 2010. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, v6.
Last edited by v6o : 08-28-09 at 05:32 PM.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 08-28-09, 10:38 AM  
pas06
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
nice addon i have searched for something like this since the lfg frame was changed it was boring to klick thrue individues and groups thank you for this addon (sry my englisch is bad i came from germany)
pas06 is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: