Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(847 Kb)
Download
Updated: 10-19-09 08:14 PM
Pictures
File Info
Updated:10-19-09 08:14 PM
Created:10-05-09 11:00 AM
Downloads:5,581
Favorites:35
MD5:

DoTimerFanFix  Popular! (More than 5000 hits)

Version: 2009-10-19.01
by: JMHammer [More]

This project is no longer necessary. Asheyla posted an update to DoTimer on 2010-02-02. Please get DoTimer from Asheyla's project page from now on:

http://www.wowinterface.com/download...2-DoTimer.html


====================
This is a fix for DoTimer by Asheyla:
http://www.wowinterface.com/downloads/info5302-DoTimer.html

As soon as Asheyla posts an update to his addon, I will delete this project.

I'm sure that Asheyla will eventually get around to applying corrections to DoTimer. In the meanwhile, there are some annoying glitches with the current DoTimer, most of which have been caused by changes in World of Warcraft. I think it is important to note that most of the problems users are experiencing with DoTimer are a result of changes to WoW - not bugs in DoTimer.

1- The recent addition of three Shaman spells which cast four totems simultaneously.

2- The recent changes to Hunter trap shared-cooldown categories and cooldown timing.

3- "You are not in a party" spam. Many addons are causing this problem; DoTimer is one of them. Not everyone will experience this issue, but if you are, this FanFix version of DoTimer corrects it. If you still get the spam with this version of the addon, the problem is being caused by one of your other addons. You might want to grab this addon, which suppresses the problem:
http://www.wowinterface.com/download...APartyFix.html

4- A bug in DoTimer related to profile handling.

I wish to note that I did not generate any of the fixes for DoTimer. All four fixes were made by other people. I just applied all the fixes, tested them thoroughly to be sure they work and do not cause problems of their own, and then packaged them for upload here. I give credit to:
----------
**Farmbuyer of wowinterface.com for the Shaman totem fix and the profile fix.**
**cynergy of curse.com for the Hunter trap fix.**
**coani of wowinterface.com for the "You are not in a party" spam fix.**
----------

As soon as Asheyla posts an update to his addon, I will delete this project.

2009-10-19.01
Added the "You are not in a party" spam fix. Which I somehow neglected to apply to the earlier versions. Thank you, coani.

2009-10-14.01
1- Added a fix for profile management errors. Thank you, Farmbuyer.
2- Changed the .toc files as follows:
2a- Changed Interface to 30200 (applied to both .toc files for DoTimer and DoTimer_Options).
2b- Added a note about this "FanFix" version of DoTimer (applied to both .toc files for DoTimer and DoTimer_Options).
2c- Changed the version to 4.3.6f02 (applied to the .toc file for DoTimer only).

2009-10-05.01
First release.
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Author
Date
2009-10-14.01
847kB
JMHammer
10-14-09 10:22 AM
2009-10-05.01
847kB
JMHammer
10-05-09 11:00 AM


Post A Reply Comment Options
Unread 10-07-09, 04:33 PM  
trclocke
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 1
Are you an addon author in general, or did you mostly just take these fixes and package them to help out the community? Do you plad on adding anything to this fan fix other than bug corrections?

The reason I ask - there is a change I have wanted badly for a long time that is forcing me to use another addon. When creating a custom notification as a timer, it always uses this generic "lightning" icon. I would love for it to use the icon of the spell/buff/etc that triggered the notification instead.

If this is beyond the scope of what you are willing/able to look into I understand, but I thought I'd check. Thanks for posting this bugfix package for us.
trclocke is offline Report comment to moderator  
Reply With Quote
Unread 10-07-09, 08:05 PM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
As I state in the description, "I did not generate any of the fixes for DoTimer. All three fixes were made by other people. I just applied all the fixes, tested them to be sure they work and do not cause problems of their own, and then packaged them for upload here."

I plan to perform bug fixes and changes required for compatibility with future World of Warcraft patches. I do not plan to add any features or make any substantial changes. The only thing on the "to-do" list for this project is to keep the addon working, to document the changes made, and to update the .toc file. I don't want a separate addon project that will run in parallel with DoTimer; this project is just to hold over DoTimer users until Asheyla gets back to work and posts an update.

The feature you want sounds like a useful one to add. I suggest you request it on the DoTimer project page so that Asheyla will see it. You might also send a private message to Asheyla so that your suggestion doesn't get lost on that page.


edit: Are you sure you're setting up your Notifications correctly? I use several custom timers with the Notifications module myself, and they display using the unique icons, not the generic "lightning bolt" icons that appear with the preview/test timers.

Give me an example: Describe, as thoroughly as you can, one of the custom timers you have created. Let me see if I can duplicate the issue, or if I can guide you through the process of setting it up so that the unique icon is displayed instead.
Last edited by JMHammer : 10-07-09 at 08:12 PM.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 10-08-09, 01:53 AM  
trclocke
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 1
Thanks for the reply, much appreciated! I can completely understand only wanting to correct critical bugfixes until DoTimer's author resumes maintenance, and really that's basically what I expected, but I thought I would check anyway

Originally posted by JMHammer
edit: Are you sure you're setting up your Notifications correctly? I use several custom timers with the Notifications module myself, and they display using the unique icons, not the generic "lightning bolt" icons that appear with the preview/test timers.

Give me an example: Describe, as thoroughly as you can, one of the custom timers you have created. Let me see if I can duplicate the issue, or if I can guide you through the process of setting it up so that the unique icon is displayed instead. [/b]
I'll see what I can do.

DoTimer->Notifications->Player->Buff Gain. Under event creation, the "match" parameter is Eclipse. I give it a name for the notifications menu, tell it to trigger immediately (0s). Type is timer. I give it a message, "eclipse cooldown" or something similar, with a group name like "alert!". Duration of 30 seconds. Timer anchor and setting are both DoTimer. I do not have any filter settings in place.

To clarify, eclipse is actually two separate spells:
http://www.wowhead.com/?spell=48517
http://www.wowhead.com/?spell=48518

Eclipse is applied as a buff when a druid critically hits with starfire or wrath. When the buff is applied, a hidden cooldown of 30 seconds is triggered before eclipse can be triggered again. The purpose of the notification timer is to track this 30 second cooldown.

When I create the notification above, I am always given the generic "lightning bolt" icon on the timer bar. Alert! Eclipse Cooldown 27s is how the notification reads there:
http://img104.imageshack.us/img104/8...0809014657.jpg
(you will see DoTimer all over that image, including my buffs, but the "eclipse (wrath)" bar is actually SquawkAndAwe, a moonkin addon, which I'm using as a workaround for this problem right now).

The reason an appropriate icon would be particularly useful is that both types of eclipse trigger their own cooldown, meaning that while one is cooling you can try and trigger the other. A correctly colored icon reminds me which eclipse spell I'm trying to proc.


Anyway, tried to be as detailed as I could. If you happen to have any bright ideas let me know

Edit: clarity
Last edited by trclocke : 10-08-09 at 01:55 AM.
trclocke is offline Report comment to moderator  
Reply With Quote
Unread 10-08-09, 09:21 AM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
Interestingly, I have the exact same Notification for my Druid - except I move it to a custom anchor where I display short-duration buffs and procs and important (and short) cooldowns.

And you're right: It uses the generic "lightning bolt" symbol. I honestly had never noticed it before I went in-game to check it after reading your message. I guess that in live play my attention was never drawn to it, instead focusing on the text in the timer bar and the remaining duration.

As far as I was able to determine, there is no way to change the icon using the current version of DoTimer. So this would be a great new feature to suggest to Asheyla.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 10-12-09, 09:20 AM  
Lo'oris
A Murloc Raider

Forum posts: 6
File comments: 1
Uploads: 0
actually AFAIK "the big bug" about dotimers is that it now shows buffs/debuffs of the whole raid instead of yours only.
I'm pretty confused noticing that you have made a fix but did not fix this obvious issue.

also there's an annoying bug that prevents from placing the frame where you want it: as soon as i release the mouse, it moves away somewhere else (like if it didn't get the coordinates correctly).
Lo'oris is offline Report comment to moderator  
Reply With Quote
Unread 10-12-09, 10:43 AM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
Originally posted by Lo'oris
actually AFAIK "the big bug" about dotimers is that it now shows buffs/debuffs of the whole raid instead of yours only.
I'm pretty confused noticing that you have made a fix but did not fix this obvious issue.
You're confused? The issue is obvious?

I have never experienced this issue myself. If you can track it down and suggest what code needs to be adjusted, I'll be happy to test it and incorporate it into this project. But if I can't experience the issue, I can't do anything about it unless you provide the needed changes.

It's also possible that you have the Party Buffs option set up in a way that is causing this issue. Try experimenting with those settings. Go to Interface Options->Addons->DoTimer->DoTimer and check your settings for Party Buffs and Others' Timers.

I have a feeling this is more about how you have configured (or failed to configure) DoTimer than it is a bug in the addon.


Originally posted by Lo'oris
also there's an annoying bug that prevents from placing the frame where you want it: as soon as i release the mouse, it moves away somewhere else (like if it didn't get the coordinates correctly).
Again, I have never experienced this problem. Disable all addons except DoTimer and see if that resolves the issue. If it does, it's not a problem with DoTimer. If it does not, please tell me exactly what I can do to replicate the problem. You could also put more effort into it and suggest what part of the DoTimer code needs to be changed.


If I'm not experiencing an issue myself, the only way I can know to try to create or find a fix for such a hypothetical issue is if it's described to me. Furthermore, I'm much more interested in reports from people who know something about the addon and can suggest potential fixes for the problems they report than people who just want to complain that a problem they have experienced has not yet been addressed by this project.

It's important to note that I am not "taking over" DoTimer. I'm just making a version available with fixes that Asheyla has not yet applied himself - this project is going to disappear as soon as Asheyla returns and posts an update to his project. That means I'm not going to add new features, and I'm unlikely to try to create or find a repair for every little problem.

That said, I'll respond better to, "Do you think you could incorporate a fix for this issue that I will now describe in detail and then suggest code for a specific file edit?" than to, "Hey, monkeyboy, you fixed stuff I don't care about. How could you miss this obvious problem?"
Last edited by JMHammer : 10-12-09 at 10:52 AM.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 10-13-09, 08:20 PM  
Farmbuyer
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 43
File comments: 36
Uploads: 1
I have a working-for-me fix for the profile copying bug, formally noted as Ticket 16:

http://wow.curseforge.com/addons/do-...ying-profiles/

So there's another patch that could potentially be added to this collection.
Farmbuyer is offline Report comment to moderator  
Reply With Quote
Unread 10-14-09, 07:40 AM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
Originally posted by Farmbuyer
I have a working-for-me fix for the profile copying bug, formally noted as Ticket 16:

http://wow.curseforge.com/addons/do-...ying-profiles/

So there's another patch that could potentially be added to this collection.
Thanks, Farmbuyer. I'll test it thoroughly and then incorporate it into a new download package here if it works for me and my testing doesn't discover any new issues generated by the fix.

I really appreciate the time and effort you spent to investigate, create, and post your patches.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 10-19-09, 07:33 PM  
coani
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 31
Uploads: 2
"3- "You are not in a party" spam. Many addons are causing this problem; DoTimer is one of them. Not everyone will experience this issue, but if you are, this FanFix version of DoTimer corrects it. If you still get the spam with this version of the addon, the problem is being caused by one of your other addons."

welll... the irony .. is that you messed up & forgot to apply the fix

dotimer/core/version.lua line 42:

if GetRealNumPartyMembers() > 0 then self:Ask("PARTY"); end


and there I was wondering why the heck I was getting that "You aren't in a party." spam all over again.. hehe
coani is offline Report comment to moderator  
Reply With Quote
Unread 10-19-09, 08:08 PM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
Sorry, coani. I don't know how that didn't make it in. I've got it in the file inside my own WTF folder - I must have somehow neglected to package and zip the right file.

I'll fix that right away. Thanks for pointing out my error.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 10-30-09, 04:14 PM  
puffidredz
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 21
Uploads: 1
Not recording all dots

I have an unholy dk ive been using dotimer on. problem is when i cast pestlience to spread my dots to nearby targets within 15 yards, dot timer doesnt always show all my dotted targets. sometimes it shows them all, sometimes it doesnt. there does not seem to be any pattern, rhyme or reason to it, it just sporadically happens but more often than not. it only shows dots on my current target. if i switch to one of my other targets and back to my main target, then it will update with that dotted target but still doesnt show any of the other dotted targets unless i target them.

ive tested it on target dummies in org just to make sure i wasnt crazy and it does the same thing. it doesnt update with the dotted target unless i have target them. but like i said it doesnt happen all the time. on onyxia's lair, when i dot up all the whelps with pestilence, it works fine there. it shows all the dots on all the whelps while i remain on one whelp.

any fix or suggestions for this?
Last edited by puffidredz : 10-30-09 at 04:19 PM.
puffidredz is offline Report comment to moderator  
Reply With Quote
Unread 10-31-09, 03:40 PM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
Re: Not recording all dots

This is something you should take up with Asheyla when he returns from his hiatus, because what you are experiencing is due to the way DoTimer attempts to prevent "spamming" your interface with undesirable or unneeded timers.

As you noted, if you select a unit as your target, or as your focus, or if you mouseover that unit; DoTimer will track your DoTs on that unit by putting up a timer for each one.

Units that are not your target or focus or mouseover yet happen to become affected by one of your DoTs - such as when a Death Knight spreads his diseases to a group via Pestilence - will generally not produce a timer unless you happen to mouse over that unit, or that unit is in direct combat with you.

In my opinion - and it's only my opinion - I think that it's better for DoTimer to behave in this way, as it prevents the screen from being filled with a huge number of timers in most AoE situations. It can STILL fill your screen in certain AoE situations if you don't explicitly set a limit on the number of timers that can be displayed at one time; but thanks to the built-in filtering, it doesn't happen very often.
Last edited by JMHammer : 10-31-09 at 04:24 PM.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 11-04-09, 01:11 PM  
notabene
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Hello. I have a question. What and in which lua file should I do to hide this "Cooldowns" inscription in screenshot below?
notabene is offline Report comment to moderator  
Reply With Quote
Unread 11-04-09, 05:58 PM  
JMHammer
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 308
Uploads: 1
The word "Cooldowns" in your screenshot is the name of the anchor. All you have to do is tell DoTimer to hide the anchor name - there is no need to edit the addon's files.

Go here:
Interface Options->Addons->DoTimer Anchors->Cooldowns Anchor

Now look in the configuration pane to the right for GROUP NAMES in white text. In that section you will find an option to enable or disable DISPLAY NAMES.

Un-check the box to the left of the words DISPLAY NAMES.

-----

I suggest you save your current profile, then make a new profile to use for testing purposes. You'll be amazed at all the things you can do with DoTimer - it can take the place of 10 other addons. But there are SO many options that the only way to learn to use them all is to experiment with the addon and play with the various options.
JMHammer is offline Report comment to moderator  
Reply With Quote
Unread 11-05-09, 09:38 AM  
notabene
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Ah, thank you. I didnt find it cuz i got "simple mode" checked :S Now i can test it Thanks for answer once again.
Best regards.
notabene is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: