Download
(115 Kb)
Download
Updated: 02-02-14 02:03 PM
Pictures
File Info
Compatibility:
Siege of Orgrimmar (5.4)
Escalation (5.3)
Thunder Isle (5.2)
Landfall (5.1)
Mists of Pandaria (5.0.4)
Updated:02-02-14 02:03 PM
Created:12-03-09 02:30 AM
Downloads:15,963
Favorites:146
MD5:
Categories:ToolTip, Character Advancement
5.4
WeightsWatcher  Popular! (More than 5000 hits)
Version: 1.6r8
by: IQgryn, dpsthree
WeightsWatcher gives you an easy to use way to compare gear based on the actual stats, not just the item level.

Currently, all base stats, gems in non-crafted sockets, and enchants should be handled properly. Also, gems are suggested based on the weights you have enabled. Note that crafted sockets and other "stacking" enchants are not currently handled, because they are not detectable through the WoW API.

All weights can be changed as you see fit, and you can create and enable as many or as few as you would like.

The default stat weights are provided by AskMrRobot.com, with their consent. Everything else the mod does is of our own creation, and does not use the AskMrRobot.com optimization formulas.

Endgame players will probably want to create hit- and/or expertise- capped weights, which is easily done by copying an existing weight and setting the appropriate values to 0.

Slash commands:
  • /ww config - Brings up the main configuration window
  • /ww config display - Brings up the display configuration window
  • /ww config calculation - Brings up the weight calculation configuration window
  • /ww config gems - Brings up the ideal gem configuration window
  • /ww config enchants - Brings up the ideal enchant configuration window
  • /ww weights - Brings up the weights configuration window
  • /ww version - Displays version information
  • /ww help - Displays this message

Known issues:
  • Trinkets and meta gems are not currently handled very well. Specifically:
    • The special effects on meta gems are not included in the default set of weights (but you can add them yourself)
    • "Chance on X" and some use effects on trinkets are not taken into account (these will be marked as unweighted)
      • Use effects that increase a stat by a static amount are now handled
      • Equip effects that increase a stat by a static amount, stacking up to x times are also handled
    • Other, more oddball trinket effects are not handled either (these will be marked as unweighted)
  • Similarly, enchants that have procs or other special effects are not handled well. You can weight those enchants manually, however.

Planned (eventual) features:
  • Whole-character scoring
  • Import/export weights from/to Wowhead and similar sites
    • This would have to be limited to the stats that both WW and the site(s) supported, so it would likely be an imperfect translation
  • Outfit creation based on a given weight
    • Currently best handled by using Outfitter's WeightsWatcher support
    • Ideally handling caps appropriately and suggesting changes to gems/enchants/reforging.
  • Support for reforging (suggesting; reading the stat change works already)
  • Handling unique-equipped gems, mutually-exclusive enchants and the like properly.
  • Suggestions welcome!

The authors of WeightsWatcher can be contacted at WeightsWatcher@gmail.com, or through the project page at WoWInterface.com.

We take bugs very seriously; if something is not being parsed properly, you get a nil error, or anything else goes wrong, please try to reproduce it and let us know so we can fix it.
1.6r8:
  • Fixed the handling of Titan's Grip
  • Handle Sha-Touched sockets better
  • Updated to newer gem and enchant information
  • Track all professions and reputations, not just those that could affect which enchants you can use
  • Fixed an issue causing the default weights to halfway include the (defunct) Unholy DW weights
  • Lots of code cleanup (the addon actually shrunk a little this release)
  • Marked as 5.4 compatible
  • Many small backend updates to parse items more accurately

1.6r7:
  • Fixed the names of the Confounded gems. Thanks to Cabby for the bug report.
  • Marked as 5.3 compatible
  • Many small backend updates to parse items more accurately

1.6r6:
  • Handle the new tooltip format for reforged stats
  • Handle upgraded items better
  • Fixed reputation tracking for Pandaria factions
  • Marked as 5.1 compatible
  • Enabled support for the enGB locale (I can't test it though, so let me know how things work)

1.6r5:
  • Removed some remaining references to no-longer-existing slots (should fix a nil error or two)
  • Fixed Sha-Touched gems and sockets
  • Updated to the newest weights from askmrrobot
  • A few small parser fixes
  • A few under-the-hood tweaks

1.6r4:
  • Re-added some features that were accidentally removed in 1.6r3
  • Auto-fix a missing options table
    • This will reset your options to the defaults, but only if you were getting nil errors about ww_vars.options
    • This will NOT affect weights -- they are stored elsewhere
    • I have not yet determined how this happened, so I'm taking the previous 1.6 versions down until/unless I do, to avoid more people losing their settings

1.6r3:
  • Added support for Monks

1.6r2:
  • Added support for MoP gem and enchant suggestions
  • Fixed several parser issues
  • Support PvP resilience and PvP Power
  • Fixed comparison with wands
  • May have fixed an invalid slot error

1.6r1:
  • Fixed nil error with Shaman and Warriors when looking at dual-wieldable weapons. Thanks to def9 for the bug report.
  • Fixed dual-wield detection for Hunters and Monks
  • Fixed Titan's Grip detection for Warrriors
  • Fixed comparison with ranged weapons

1.6:
  • Handle renamed stats in MoP
  • Auto-upgrade existing weights to use the renamed stats
  • Miscellaneous minor bug fixes

1.5r5:
  • Fixed a nil error for items with no text
  • Fixed the parsing of a few enchant items
  • Updated the list of gems to include all the cata epics
  • Fixed a typo in the options

1.5r4:
  • Fix a nil error when parsing certain stacking equip effects. Thanks to Fast for the bug report.
  • Handle a few trinkets that have extra text describing their effects (mostly from Molten Front)
  • Update to the new names/stats for several enchants
  • Fix a few parsing issues
  • Lowered memory usage a touch

1.5r3:
  • Changed to using weights from askmrrobot.com by default (with their permission)
    • You will need to restore your default weights to see the new defaults. Open the weight configuration screen with /ww weights and click Restore Defaults.
    • These are updated much more often than Wowhead's and we will do our best to keep our version up to date as well. Please feel free to poke us if we fall behind on that.
  • Bumped to TOC to show that we're compatible with 4.2
  • Fixed the stats on Vivid Dream Emeralds
  • Removed some debug code that was accidentally put in the released version
  • Localized some text that was missed in the enchant changes

1.5r2:
  • Added several spell-only enchants that were accidentally skipped in 1.5r1 (embroideries, runeforging, etc.) to the list of weightable stats

1.5r1:
  • WeightsWatcher now supports enchants!
    • Any enchant with "normal" stats will be suggested automatically based on your current weights
      • Those with procs and other unusual effects have been added to a list of enchants you can manually add weights for
        • With the exception of Lightweave, Darkglow, and Swordguard embroideries, all of these enchants have a value of 1 when being weighted. The mentioned ones have a value of 1 for the first rank and 2 for the second rank.
        • We eventually plan to support procs in general, but it will be another large project. When we do, we will move all the enchants we can to that method of handling.
    • WW will take the following into account when figuring out the best enchant for your gear:
      • Your level
      • The item level
      • Your professions and their level
      • Your reputation with relevant factions
      • The obvious stuff (slot, subslot, etc.)
    • The options have been given a bit of a workover to support this
      • All your current choices should carry over to the new structure
      • There are some new ones specifically for enchants as well
      • The options are still accessible via /ww config, but you can now use /ww config <submenu> to jump immediately to the submenu of your choice
        • Submenus: calculation, display, gems, and enchants
        • Note that Blizzard's code to do this has some bugs which may open you to the wrong menu if you have alot of addons using the Blizzard config UI. I recommend the addon BlizzBugsSuck to fix this issue (and a few others) until Blizzard releases their own fix.
  • Frost mages no longer have a default value for mastery rating of 700
  • Default weights have not otherwise been updated since Wowhead has not updated theirs -- if anyone can suggest a more up-to-date source for the default weights that won't take use hours of looking through forums AND handles all classes and specs, let us know!
  • Some obsolete stats have been removed from the list
  • The weights configuration window (/ww weights) is now a little smarter about what happens when it is asked to close
  • Weight normalization now only takes the "normal" stats into account to avoid individual enchants and other oddball stats skewing the numbers
  • Miscellaneous parser updates and other backend work

1.4r15:
  • Fixed some issues with deleting weights. Nothing a reloadui didn't fix before, but now you don't have to.

1.4r14:
  • Updated to the latest weights from Wowhead. You will need to restore the default weights to see these changes.
  • Affected classes/specs:
    • Balance and restoration druids
    • Marksmanship and survival hunters
    • Frost mages
    • Holy and protection paladins
    • Holy priests
    • Elemental shaman
    • Destruction warlocks
    • All warriors

1.4r13:
  • Fixed ideal gem suggestion for items with meta and/or cogwheel sockets. Thanks to dpsthree for the bug report.
    • Previously, the meta/cogwheel gems only counted towards the "follow socket colors" path, which may have resulted in best-following-color gems being suggested for the colored sockets (instead of the actual best gem), or no meta/cogwheel gem being suggested (unlikely).

1.4r12:
  • Added localization strings for the new gems in r10. Should avoid warning messages about them.

1.4r11:
  • Fixed parsing of the Ebonsteel belt buckle, which I forgot to put in r10.

1.4r10:
  • Added the new Cataclysm meta gems and a couple others that were missing
  • Fixed a nil error when running /ww version (since 1.4r8)

1.4r9:
  • Updated to the latest Wowhead weights. Use the Restore Defaults button in /ww weights to see the changes.
    • I'm not entirely sure these are all better, but they are newer. As always, using rawr or simulationcraft to get numbers tailored to your character is better anyway.
    • Updated classes/specs: hunters, arcane mages, holy paladins, shadow priests, and elemental shaman
  • Tweaked a couple of parser patterns for item changes.

1.4r8:
  • Removed the Ace2 libraries, which were both out of date and barely used.
    • There should be no functional or visible changes, but if you find one, please report it!
    • This may fix a bug reported by Zidomo.
    • Another benefit is a somewhat smaller addon.

1.4r7:
  • Fixed the quality limit for suggested gems being ignored
  • Fixed a global variable being created unnecessarily
  • Miscellaneous backend changes to make future updates easier

1.4r6:
  • Hide weights with a value of zero by default and added an option to show them
    • Other items WeightsWatcher puts into the tooltip will now only show if:
      • You have the "Show zero weights" option enabled, or
      • You have the "Show Debug Info" hotkey pressed

1.4r5:
  • Updated to new Wowhead default weights. You'll need to restore the default weights to see them.
    • Fire Mage
    • Retribution Paladin
    • Disc Priest
    • Warlock (all specs)
    • Arms Warrior (typo fix, armor went from 1 to 2)

1.4r4:
  • Added support for minimum item levels required for gems.
    • I think Blizzard made item levels always show. If not, and you see only Wrath gems even on Cataclysm items (and you've set WW to use Cata gems), please let me know.
  • Cogwheels are now properly in the Unique-Equipped group of gems.
    • I'm open to suggestions for how to handle that better than WW does currently.
  • Fixed a few dual-wield checks to be more accurate for Cataclysm.
    • Note that you need to be in the dual-wielding spec (at least warriors and shaman do) for this to work.
      • I could add an option to check both (let me know if you want one), but I don't think it's a good default.
  • Minor backend changes to support the above and remove another global variable.

1.4r3:
  • Added support for cogwheel gems. They should show up for anyone who looks at an item with cogwheel sockets.
    • This is tested as much as I can without a high-level engineer. Please let me know if it breaks!
    • I can add a filter if people really want one, but it seems unnecessary at this point.

1.4r2:
  • Fixed the nil error when viewing items with prismatic sockets. Thanks to Zidomo for the initial report and dpsthree for finding me some items to reproduce it.

1.4r1:
  • Support Cataclysm gems. There may be errors in the data (please let me know if you find any!)
    • There are now categories in /ww config to include cataclysm gems.
    • Currently, there are no item level checks for Cataclysm gems. This will be fixed in a future version, as it requires a bit of work on the backend.
    • Engineering ("cogwheel") gems/sockets are not handled yet.
  • Several (minor) parser updates. As always, please report any un- or mis-parsed items.

1.3r5:
  • Updated to newest Wowhead weights. You will have to reload the default weights to see the changes.

1.3r4:
  • Fixed a nil error that could come up when using TipTac. Thanks to Ambar0691 for the bug report.

1.3r3:
  • Added support for mastery rating
    • Added mastery to all weights, set to 100 for now
  • Minor parser tweaks
  • Changed default Death Knight weight names to reflect the fact that Blood is the tank tree now
  • Started Cata gem support

1.3r2:
  • Fixed a few nil errors when creating and deleting weights
  • Fixed some graphical spacing issues
  • Fixed some xml errors in Cataclysm clients
    • WeightsWatcher is now Cataclysm compatible
      • However, new stats such as mastery rating are not yet handled (and are marked as such)
      • Also, certain items may have new wording that is not yet handled (again, marked as such)

1.3r1:
  • Fixed several unparsed items
  • Changed the names of a few stats and added several that were not weightable previously
    • These should be auto-updated
    • Specific changes (not a complete list):
      • Melee and ranged weapons' damage, speed, and dps can now be weighted separately
      • Spell hit and crit, as well as ranged hit, crit, and haste, are now weightable
      • Disorient and fear resists are now weightable
  • Changed the organization of the weights config
  • Localized everything for enUS (laid the groundwork for other translations)
  • Updated to the latest weights from WoWhead
    • Warriors now have separate weights for arms and fury
    • Death knights now have Blood Tank and Frost Tank weights (Frost Tank is the old Tank weight)
    • You will need to restore the default weights to see these changes (click "Restore Defaults" in /ww weights)
  • Fixed marking of unweighted lines to mark all sections of multi-line (graphically) tooltip lines
  • Fixed a potential issue with the handling of invalid SavedVars data
  • Added contact information to the help

1.2b11:
  • Fixed ideal gem calculations (broken in 1.2b10). Thanks to dpsthree for the bug report.
  • Fixed the upgrade function for stun resist chance (and forced a re-run of said function).
  • Fixed a bug with triggers being "changed" even if returned to their original state (UI only).
  • Fixed a bug preventing classes in the weights config dialog from collapsing when you had deleted an "active" weight from a different character (UI only).

1.2b10:
  • Fixed handling stat weights that had decimal parts that don't exactly convert to binary. The main symptom was a weight that "changed" without you doing anything but selecting it (and no visible change).
  • Fixed a nil error when using a decimal point in stat weights (everything still worked as long as you used valid numbers).
  • Changed stun resistance to stun resist chance to match similar stats. Weights using stun resistance are automatically upgraded.
  • Lots of code cleanup (no visible changes though).

1.2b9:
  • Fixed handling of the meta gem stat "armor from items (percent)".
  • Fixed thrown weapons to have their dps marked as ranged dps instead of melee dps. Thanks to Edwilly for the bug report.

1.2b8:
  • Fixed a bug causing nil errors when creating a new, empty weight. Thanks to dpsthree for the bug report.

1.2b7:
  • Fixed a bug causing prismatic gems to not be considered as ideal gems
  • Fixed comparison values in tooltips for weapons (again). This should fix all remaining issues with weapon comparisons, but if not please let us know.
  • Added comparison values to AtlasLoot tooltips (and any future addons with tooltips that we support)
  • Added a hotkey to show everything the parser parses, defaults to never (change it in /ww config).
    • This is as much for our own use as anyone else's, but it may help people track down bugs.
    • I'm not going to heavily document this (yet), but feel free to ask questions!

1.2b6:
  • Fixed a bug causing nil errors when showing tooltip hints. This is why you should always test your default settings, kids. Thanks to Zidomo for the bug report.

1.2b5:
  • Added support for equip effects that grant a stat on certain actions, stacking up to a certain number of times.
  • Added triggers for said equip effects to each weight. The default weights have been updated to include appropriate triggers. The data upgrade function will attempt to choose the right trigger(s), but is not perfect. For example, hit-capped caster weights will almost always have the wrong triggers picked. To fix this, open /ww weights and pick the correct triggers for each weight.

1.2b4:
  • Fixed a bug affecting current weight calculations when an item's socket bonus was being used. Ideal gems and ideal weight calculations were not affected.

1.2b3:
  • Handle simple use effects
    • For now, this is only use effects that increase a stat by a static amount
  • New config option added, to allow tuning of use effect calculations
    • Set to 80% of ideal uptime by default
    • Can be set to 0% if you never remember to use your trinkets, 150% if you always use them to maximum effect, or whatever number you feel works best for you.
  • Several backend changes, mostly to support use effects

1.2b2:
  • Fixed a bug affecting (some) hunter and warrior weapon comparisons. Thanks to Zidomo for the bug report.

1.2b1:
  • Complete parser rewrite
    • All corner cases for basic stats should be handled
    • The groundwork for use effects and procs has been laid (they don't work yet, though)
    • Most enchant scrolls and formulas are now parsed properly
    • Any unweighted effect is now marked as such in the tooltip, with a total count at the bottom
  • Lots of backend cleanup
  • Newly supported/fixed stats:
    • Feral AP
    • Ranged AP (also added to the default hunter weights)
    • Mana
    • Schooled spell damage
    • Spell resistances (fixed)
    • Increased threat
    • Disarm reduction
  • You can now see comparison numbers without holding shift
    • This also fixes comparing to an empty slot
  • Minor fix to tooltip hints (the alternate gems tip used to show even with no alternate gems)

1.1b10:
  • Stopped regular gems from sometimes showing up in meta gem recommendations
  • Made the weights configuration dialog (/ww weights) expand all used classes instead of just the current class
  • Minor code cleanup

1.1b9:
  • Fixed a silly typo in the default vars. Thanks to attackfrog for the bug report.
    • Only affected new users, but caused a nil error
  • Minor fixes to weapon comparison handling
    • Properly show comparison numbers for a one-hand weapon when you currently have a two0hand weapon equipped
    • Properly compare weapons that aren't affected by Titan's Grip (only affected fury warriors)

1.1b8 (not archiving due to nil error, use 1.1b9 for these features and one less bug):
  • Added the ability to show all equally-weighted ideal gems
    • Should at least help with meta gem suggestions, still best to give weights to the meta effects you want though
    • Set to Alt key by default (but can be configured)
  • Changed the way allowed ideal gems are configured
    • Gems are now sorted by:
      • Source (vendor, pvp vendor, quest, drop, etc.)
        • This includes procced gems (like wrath perfects)
      • Restrictions (none, unique-equipped, JC-only, etc.)
      • Quality (unchanged from before)
    • Should be a fairly seamless transition, but it wouldn't hurt to check your options using /ww config
  • Various backend changes to support the above

1.1b7:
  • Fixed a MAJOR bug with ideal gem calculations
    • All ideal gem calculations were following the socket color, whether it was better to get the bonus or not
      • Yes, even if you had the options set differently
        • Yes, that's really bad (sorry!)
    • Introduced in version 1.1b1
  • Fixed a few parsing issues
    • Most notably shield block rating/value now work correctly
    • Also fixed some enchanting scrolls
  • Fixed an error when determining whether a warrior had Titan's Grip talented
    • Only affected comparison numbers when a warrior was comparing weapons
  • Miscellaneous invisible code cleanups

1.1b6:
  • Finally fixed that SCT bug. Thanks to SmuvMoney for the bug report.
  • Removed a bit of dead code

1.1b5:
  • Reduced indentation on the tooltip
  • Fixed several parsing errors

1.1b4:
  • Changed the way gems are handled. You will probably want to re-visit your gem options (/ww config, left side).
    • Split JC-only, unique-equipped, and procced (i.e. wrath "perfect") gems from the main gem quality option
      • This should be somewhat faster when finding ideal gems
      • Attempted to intelligently convert the old level to the appropriate options...but it's not really a linear conversion
  • Changed the comparison behavior when viewing an item without sockets while wearing an item with sockets
    • Holding the modifier key to show ideal weights (Shift by default) now causes the ideal weight to be compared against instead
      • Well, technically, it's the higher of the two, but usually that means the ideal one anyway
        • Unless you have a JC-only gem socketed but don't have them turned on for ideal gem calculations
          • This list is getting ridiculous...
  • Fixed some cache issues triggered by changing options and/or weights

1.1b3:
  • Fixed a typo causing a nil error when parsing certain items.

1.1b2:
  • Fixed which items' scores are compared when comparing weapons. Should do the Right Thing(tm) now.

1.1b1:
  • Fixed meta gems' weights. No default values were added, so you still have to give the meta gem effects weights if you want to use them...but they all work now.
  • Re-did caching, which has no visible difference but allowed me to:
  • Added colorized differences to the currently equipped item(s). Will pick the lower-scored item to compare to for rings, trinkets, weapons, etc.
  • Added compatibility with AtlasLoot (adds weights to its tooltips now)
  • Fixed a minor bug with the "Show Class Names" option

1.0b2: Reposted 12/8 (patch 3.3 dropped)
  • The ONLY difference from 1.0b1 is the interface version and the b1 to b2 bump
1.0b1: First public release
  • Features:
    • Tooltip display of an item's score according to the enabled weights
    • Completely customizable weights, based on each item's actual stats
Archived Files (46)
File Name
Version
Size
Author
Date
1.6r7
116kB
IQgryn
08-04-13 09:18 AM
1.6r6
117kB
IQgryn
02-03-13 08:55 AM
1.6r5
116kB
IQgryn
11-03-12 02:17 PM
1.6r4
118kB
IQgryn
10-06-12 09:11 AM
1.5r5
107kB
IQgryn
04-08-12 12:08 PM
1.5r4
106kB
IQgryn
01-07-12 02:45 PM
1.5r3
105kB
IQgryn
08-06-11 07:23 PM
1.5r2
106kB
IQgryn
06-17-11 06:16 PM
1.5r1
106kB
IQgryn
06-11-11 10:00 AM
1.4r15
65kB
IQgryn
03-06-11 06:23 PM
1.4r14
65kB
IQgryn
03-06-11 08:26 AM
1.4r13
65kB
IQgryn
02-26-11 01:06 PM
1.4r12
65kB
IQgryn
02-19-11 01:13 PM
1.4r11
65kB
IQgryn
02-18-11 11:32 PM
1.4r9
65kB
IQgryn
02-14-11 08:46 PM
1.4r8
65kB
IQgryn
01-27-11 07:28 PM
1.4r7
100kB
IQgryn
01-23-11 06:18 PM
1.4r6
99kB
IQgryn
01-22-11 11:07 AM
1.4r5
99kB
IQgryn
01-21-11 05:24 PM
1.4r4
99kB
IQgryn
01-16-11 11:22 AM
1.4r3
99kB
IQgryn
01-09-11 10:16 PM
1.4r2
99kB
IQgryn
01-09-11 12:49 PM
1.4r1
99kB
IQgryn
01-09-11 11:33 AM
1.3r5
97kB
IQgryn
12-31-10 04:49 PM
1.3r4
97kB
IQgryn
11-22-10 10:42 AM
1.3r3
97kB
IQgryn
11-11-10 08:28 PM
1.3r2
98kB
IQgryn
09-06-10 05:59 PM
1.3r1
98kB
IQgryn
08-31-10 01:33 PM
1.2b11
79kB
IQgryn
08-01-10 01:07 AM
1.2b10
79kB
IQgryn
07-28-10 11:49 PM
1.2b9
79kB
IQgryn
07-13-10 02:01 AM
1.2b8
79kB
IQgryn
06-14-10 05:13 PM
1.2b6
79kB
IQgryn
05-24-10 10:32 PM
1.2b4
77kB
IQgryn
05-17-10 01:00 PM
1.2b3
77kB
IQgryn
05-13-10 12:47 PM
1.2b2
76kB
IQgryn
04-26-10 11:53 AM
1.1b10
70kB
IQgryn
02-11-10 02:11 PM
1.1b9
70kB
IQgryn
01-20-10 09:22 PM
1.1b7
69kB
IQgryn
01-14-10 02:24 AM
1.1b6
69kB
IQgryn
01-07-10 06:09 PM
1.1b5
69kB
IQgryn
01-06-10 02:33 PM
1.1b4
69kB
IQgryn
12-18-09 03:51 PM
1.1b3
68kB
IQgryn
12-17-09 04:05 PM
1.1b1
67kB
IQgryn
12-15-09 02:48 AM
1.0b2
68kB
IQgryn
12-08-09 10:11 AM
1.0b1
68kB
IQgryn
12-07-09 02:54 PM


Post A Reply Comment Options
Unread 12-31-10, 04:53 PM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Ok, new version is up. Don't blame me if it crashes and burns...I can't test it yet!

All I updated was the default weights, so it should be fine. I'll warn you that Wowhead hasn't really updated everything yet, especially for the pure caster classes. Don't forget to reload the default weights if you want to see the new defaults.

I hope to have the new gems sorted out sometime next week, but I'll keep you guys posted.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 12-31-10, 04:24 PM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Originally posted by Zidomo
(bug bug bug)

Received the same error as posted below the other day on a Priest doing an inspect of a Paladin. As well, when any of the gem display options are enabled, get tons of "WeightsWatcher: Unknown gem ID..." text spams mousing over links, items & inspect frames.

For the "100" default mastery weights added previously, mastery has greater or lesser benefits for different classes and specs. And the other default weights in the mod don't appear to have changed between before Cata and now (doing a diff on defaults.lua from 1.3r4 & 1.3r1).

Which makes the default weights this gives now essentially useless. Sure, you can go into the /ww weights frame and manually modify everything to, say, Wowhead weights. But that's a giant hassle when you have several active characters. When other mods like this provide good Cata-adjusted default values, why bother spending the time?

Hope this is updated soon.
I'll get a new version out with Wowhead's weights as soon as I can. The other bug and the gems will unfortunately have to wait until I get my first paycheck (hopefully Monday!), since I can't actually afford my WoW subscription until then.

Thanks for the bugging; I wish I had more for you.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 12-31-10, 02:19 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
(bug bug bug)

Received the same error as posted below the other day on a Priest doing an inspect of a Paladin. As well, when any of the gem display options are enabled, get tons of "WeightsWatcher: Unknown gem ID..." text spams mousing over links, items & inspect frames.

For the "100" default mastery weights added previously, mastery has greater or lesser benefits for different classes and specs. And the other default weights in the mod don't appear to have changed between before Cata and now (doing a diff on defaults.lua from 1.3r4 & 1.3r1).

Which makes the default weights this gives now essentially useless. Sure, you can go into the /ww weights frame and manually modify everything to, say, Wowhead weights. But that's a giant hassle when you have several active characters. When other mods like this provide good Cata-adjusted default values, why bother spending the time?

Hope this is updated soon.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 12-07-10, 06:43 AM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Originally posted by Zidomo
Sorry for the response delay here.

Looking back in my BugGrabber log, that particular error did not occur with 1.3r3. A different error did, however:

<snip>

Only tried WeightsWatchers again after WoW 4.x came out as of v1.3r3, due to Mastery finally being added to the weights. And that usage only lasted a day until 1.3r4 came out, when the above error did not reoccur.

But the previously posted error still does occur with 1.3r4. In addition to the previous circumstance, have since seen it _always_ happen when SHIFT-clicking an item (that can accept gems) to open the gem-add frame on that Paladin. But this time with Libram of Valiance in the ranged slot instead of the other one.
Thank you for the update. Today's my second day at the new job, and I'm still settling in, but I will look at this first once I have time for WoW again.

On a related note, the Cata gems will be second in line. Hopefully I can get them done by the time people are ready for them, but it's not a small task. Feel free to bug me about it if I'm taking too long.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 12-06-10, 11:18 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Originally posted by IQgryn
Thank you for the very detailed bug report! I will unfortunately be unable to work on this until I finish moving, but it's on my todo list. Did this error also happen with 1.3r3, or is it new to 1.3r4?
Sorry for the response delay here.

Looking back in my BugGrabber log, that particular error did not occur with 1.3r3. A different error did, however:

Code:
["message"] = {
                "WeightsWatcher-1.3r3\\WeightsWatcher.lua:590: attempt to index local 'ttleft' (a nil value)\nWeightsWatcher-1.3r3\\WeightsWatcher.lua:325: in function <Interface\\AddOns\\WeightsWatcher\\WeightsWatcher.lua:325>\n(tail call): ?:\n<in C code>: in function `SetHyperlink'\nAtlasLoot-|cffFF8400AtlasLoot Enhanced v6.00.00|r\\Core\\LootButtons.lua:814: in function <Interface\\AddOns\\AtlasLoot\\Core\\LootButtons.lua:785>\n\nLocals:|r\nself = AtlasLootTooltipTEMP {\n 0 = <userdata>\n InspectEquipItem = \"|cffa335ee|Hitem:49983:0:0:0:0:0:0:0:15:0|h[Blood-Soaked Saronite Stompers]|h|r\"\n SetExistingSocketGem = <function> defined =[C]:-1\n SetCurrencyToken = <function> defined =[C]:-1\n SetGuildBankItem = <function> defined =[C]:-1\n hasMoney = 1\n comparing = false\n SetSocketGem = <function> defined =[C]:-1\n shownMoneyFrames = 1\n SetLootItem = <function> defined =[C]:-1\n SetQuestItem = <function> defined =[C]:-1\n SetReforgeItem = <function> defined =[C]:-1\n SetTrainerService = <function> defined =[C]:", -- [1]
                "-1\n numMoneyFrames = 1\n SetInboxItem = <function> defined =[C]:-1\n SetBuybackItem = <function> defined =[C]:-1\n SetHyperlinkCompareItem = <function> defined =[C]:-1\n SetMerchantItem = <function> defined =[C]:-1\n SetMerchantCostItem = <function> defined =[C]:-1\n SetBackpackToken = <function> defined =[C]:-1\n SetTradeTargetItem = <function> defined =[C]:-1\n SetTradePlayerItem = <function> defined =[C]:-1\n SetSendMailItem = <function> defined =[C]:-1\n updateTooltip = 0.2\n SetInventoryItem = <function> defined =[C]:-1\n SetLootRollItem = <function> defined =[C]:-1\n SetQuestLogItem = <function> defined =[C]:-1\n SetAuctionSellItem = <function> defined =[C]:-1\n SetBagItem = <function> defined =[C]:-1\n BankItemsDone = true\n Mendeleev_data_added = true\n SetHyperlink = <function> defined =[C]:-1\n SetTradeSkillItem = <function> defined =[C]:-1\n SetAuctionItem = <function> defined =[C]:-1\n}\nobjectName = \"AtlasLootTooltip\"\n\n  ---", -- [2]
            },
            ["type"] = "error",
            ["session"] = 630,
            ["counter"] = 1,
        }, -- [618]
Only tried WeightsWatchers again after WoW 4.x came out as of v1.3r3, due to Mastery finally being added to the weights. And that usage only lasted a day until 1.3r4 came out, when the above error did not reoccur.

But the previously posted error still does occur with 1.3r4. In addition to the previous circumstance, have since seen it _always_ happen when SHIFT-clicking an item (that can accept gems) to open the gem-add frame on that Paladin. But this time with Libram of Valiance in the ranged slot instead of the other one.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 11-28-10, 07:04 AM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Thank you for the very detailed bug report! I will unfortunately be unable to work on this until I finish moving, but it's on my todo list. Did this error also happen with 1.3r3, or is it new to 1.3r4?

Originally posted by Zidomo
A bug that has occurred under a certain circumstance with 1.3r4.

An 80 Paladin with Libram of the Eternal Tower equipped in the ranged/relic slot. Pull up a low level caster DPS alt's equipment through the BankItems mod (using r161).

Mouse over Cookie's Stirring Rod in the BankItems inventory list that the alt has equipped in his ranged slot. The comparison tooltip comes up (via tekKompare) & four of the following error are thrown:

<snip>

And as mentioned, 3 more "WeightsWatcher-1.3r4\\WeightsWatcher.lua:136: attempt to perform arithmetic on field '?' (a nil value)" errors occurring at the identical time. Not posted as doing so goes over the post character limit.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 11-27-10, 10:44 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
A bug that has occurred under a certain circumstance with 1.3r4.

An 80 Paladin with Libram of the Eternal Tower equipped in the ranged/relic slot. Pull up a low level caster DPS alt's equipment through the BankItems mod (using r161).

Mouse over Cookie's Stirring Rod in the BankItems inventory list that the alt has equipped in his ranged slot. The comparison tooltip comes up (via tekKompare) & four of the following error are thrown:

Code:
["message"] = {
                "WeightsWatcher-1.3r4\\WeightsWatcher.lua:136: attempt to perform arithmetic on field '?' (a nil value)\nWeightsWatcher-1.3r4\\WeightsWatcher.lua:728: in function `displayItemStats'\nWeightsWatcher-1.3r4\\WeightsWatcher.lua:325: in function <Interface\\AddOns\\WeightsWatcher\\WeightsWatcher.lua:325>\n(tail call): ?:\n<in C code>: ?\n<in C code>: ?\n<in C code>: in function `SetHyperlinkCompareItem'\nInterface\\FrameXML\\GameTooltip.lua:314: in function `GameTooltip_ShowCompareItem':\ntekKompare-3.3.0.8\\tekKompare.lua:4: in function <Interface\\AddOns\\tekKompare\\tekKompare.lua:3>\n<in C code>: ?\n<in C code>: ?\nAuc-Advanced-<%version%> (<%codename%>)\\Libs\\LibExtraTip\\LibExtraTip.lua:279: in function <...AddOns\\Auc-Advanced\\Libs\\LibExtraTip\\LibExtraTip.lua:273>\n<in C code>: ?\n<in C code>: ?\n<in C code>: ?\n<in C code>: ?\n<in C code>: in function `SetHyperlink'\nBankItems-40000\\BankItems.lua:712: in function <Interface\\AddOns\\BankItems\\BankItems.lua:691>\n\nLocals:|r\ntooltip = ShoppingTooltip", -- [1]
                "1 {\n SetReforgeItem = <function> defined =[C]:-1\n SetTrainerService = <function> defined =[C]:-1\n SetLootRollItem = <function> defined =[C]:-1\n SetInboxItem = <function> defined =[C]:-1\n SetBuybackItem = <function> defined =[C]:-1\n InspectEquipItem = \"|cffa335ee|Hitem:50968:3297:3568:3542:3542:0:0:0:80:121|h[Cataclysmic Chestguard]|h|r\"\n SetHyperlinkCompareItem = <function> defined =[C]:-1\n SetExistingSocketGem = <function> defined =[C]:-1\n SetMerchantCostItem = <function> defined =[C]:-1\n SetGuildBankItem = <function> defined =[C]:-1\n SetTradeTargetItem = <function> defined =[C]:-1\n BankItemsDone = true\n SetTradePlayerItem = <function> defined =[C]:-1\n 0 = <userdata>\n SetSendMailItem = <function> defined =[C]:-1\n SetQuestLogItem = <function> defined =[C]:-1\n updateTooltip = 0.2\n SetInventoryItem = <function> defined =[C]:-1\n SetMerchantItem = <function> defined =[C]:-1\n SetHyperlink = <function> defined =[C]:-1\n SetSocketGem = <function> defined =[C]:-1\n SetTradeSk", -- [2]
                "illItem = <function> defined =[C]:-1\n SetBackpackToken = <function> defined =[C]:-1\n SetAuctionSellItem = <function> defined =[C]:-1\n SetBagItem = <function> defined =[C]:-1\n SetCurrencyToken = <function> defined =[C]:-1\n Mendeleev_data_added = true\n SetLootItem = <function> defined =[C]:-1\n SetQuestItem = <function> defined =[C]:-1\n SetAuctionItem = <function> defined =[C]:-1\n}\nttname = \"ShoppingTooltip1\"\nbareLink = \"item:50461:0:0:0:0:0:0:0:80\"\nitemType = \"Armor\"\nstackSize = 1\nsockets = nil\ngemStats = nil\nstat = nil\nvalue = nil\nstr = \"Holy - Paladin\"\nformatStr = nil\ncompareLink = nil\ncompareBareLink = nil\ncompareLink2 = nil\ncompareBareLink2 = nil\ncompareMethod = nil\nalternateGemsExist = false\n_ = \"Libram of the Eternal Tower\"\nlink = \"|cffa335ee|Hitem:50461:0:3524:0:0:0:0:0:80:0|h[Libram of the Eternal Tower]|h|r\"\nbareItemInfo = <table> {\n normalStats = <table> {\n }\n stackingEquipEffects = <table> {\n }\n nonStats = <table> {\n }\n sockets = <table> {\n }\n useEffects = ", -- [3]
                "<table> {\n }\n socketBonusStat = <table> {\n }\n}\nshowDebugInfo = false\nshowWeights = true\nshowIdealWeights = 1\nshowIdealGems = nil\nshowIdealGemStats = true\nshowAlternateGems = nil\nstart = 2\nttleft = ShoppingTooltip1TextLeft34 {\n 0 = <userdata>\n}\norigTextL = \"Avoidance\"\ntextL = \"avoidance\"\nnumUnweightedEffects = 0\noffset = 0\n(for generator) = <function> defined =[C]:-1\n(for state) = <table> {\n 1 = \"PALADIN\"\n PALADIN = <table> {\n }\n}\n(for control) = 1\n_ = 1\nclass = \"PALADIN\"\n(for generator) = <function> defined =[C]:-1\n(for state) = <table> {\n 1 = \"Holy\"\n 2 = \"Protection\"\n 3 = \"Retribution\"\n}\n(for control) = 1\n_ = 1\nweight = \"Holy\"\ncurrentScore = 0\ncompareScore = nil\ncompareScore2 = nil\ncompareBareScore = nil\ncompareBareScore2 = nil\n(*temporary) = <table> {\n item:50968:0:0:0:0:0:0:0:80 = <table> {\n }\n item:50179:0:0:0:0:0:0:1971720064:80 = <table> {\n }\n weight = <table> {\n }\n bestGems = <table> {\n }\n item:51909:0:0:0:0:0:0:1412069760:80 = <table> {\n }\n}\n(*temporary) = S", -- [4]
                "hoppingTooltip1 {\n SetReforgeItem = <function> defined =[C]:-1\n SetTrainerService = <function> defined =[C]:-1\n SetLootRollItem = <function> defined =[C]:-1\n SetInboxItem = <function> defined =[C]:-1\n SetBuybackItem = <function> defined =[C]:-1\n InspectEquipItem = \"|cffa335ee|Hitem:50968:3297:3568:3542:3542:0:0:0:80:121|h[Cataclysmic Chestguard]|h|r\"\n SetHyperlinkCompareItem = <function> defined =[C]:-1\n SetExistingSocketGem = <function> defined =[C]:-1\n SetMerchantCostItem = <function> defined =[C]:-1\n SetGuildBankItem = <function> defined =[C]:-1\n SetTradeTargetItem = <function> defined =[C]:-1\n BankItemsDone = true\n SetTradePlayerItem = <function> defined =[C]:-1\n 0 = <userdata>\n SetSendMailItem = <function> defined =[C]:-1\n SetQuestLogItem = <function> defined =[C]:-1\n updateTooltip = 0.2\n SetInventoryItem = <function> defined =[C]:-1\n SetMerchantItem = <function> defined =[C]:-1\n SetHyperlink = <function> defined =[C]:-1\n SetSocketGem = <function> defined =[C]:", -- [5]
                "-1\n SetTradeSkillItem = <function> defined =[C]:-1\n SetBackpackToken = <function> defined =[C]:-1\n SetAuctionSellItem = <function> defined =[C]:-1\n Se\n  ---", -- [6]
            },
            ["type"] = "error",
            ["time"] = "2010/11/27 22:39:53",
            ["session"] = 717,
            ["counter"] = 2,
        }, -- [997]
And as mentioned, 3 more "WeightsWatcher-1.3r4\\WeightsWatcher.lua:136: attempt to perform arithmetic on field '?' (a nil value)" errors occurring at the identical time. Not posted as doing so goes over the post character limit.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 11-22-10, 10:48 AM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Version 1.3r4 released

This version is a bugfix-only release. It fixes a nil error that happened when using TipTac. I cannot guarantee that unparsed/unweighted lines will be marked as such when using TipTac, as I don't have enough time for thorough testing at the moment. However, the scores will show up now. Thanks to Ambar0691 for the bug report.

On a related note, I will probably be updating infrequently for the next month or so. I am moving and starting a new job shortly after Thanksgiving, and I'll be out of town for several days on either side of Thanksgiving visiting family.

As always, feedback is welcome and appreciated. Please respond here, by private message, or e-mail us at WeightsWatcher@gmail.com. This release I'm especially looking for errors that crop up with tooltip mods, whether they are nil errors or just WeightsWatcher not marking things appropriately.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 11-11-10, 08:34 PM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Version 1.3r3 Released

This update should make mastery rating work. See the change log for more information and the rest of the changes. The default weights are probably horribly inaccurate for most classes/specs until WoWHead updates theirs or I find a better source.

Death knights' default weight names changed. The weights themselves did not, except, of course, Blood DPS and non-Frost tank weights were removed. If you want the new names, you'll have to reload the default weights and delete the old ones.

As always, feedback is welcome. Please respond here, by private message, or e-mail us at WeightsWatcher@gmail.com.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 11-11-10, 03:55 PM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Re: Re: Version 1.3r2 Released

Originally posted by panga666
How are new weights going along?
Useful new weights will have to wait until WoWHead has updated theirs. They have made a token "update" that just adds mastery rating to every class/spec with a weight of 100, but no other changes that I can see.

I'll try to upload a version that will let you set a weight for mastery later today. I'll probably make mastery default to 100 for now, but the weights will be horribly inaccurate for certain classes and/or specs. I know that at least shadow priests (and the other two specs, really), value spirit way more than they used to, but I don't do enough theorycrafting to really put a useful number on it. I also don't play all 30-odd specs.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 11-11-10, 12:12 PM  
panga666
A Murloc Raider

Forum posts: 8
File comments: 31
Uploads: 0
Re: Version 1.3r2 Released

Originally posted by IQgryn
I've uploaded version 1.3r2, which contains fixes for a few nil errors introduced in 1.3r1 (creating, copying, and deleting weights). This version is Cataclysm-compatible! Note that the new stats are not handled (yet), but I'm working on that too.

See the change log for full details, and as always, feedback is welcome. Please direct any complaints, requests, questions, concerns, bug reports, or any other sort of feedback to the thread here, to me by private message, or to WeightsWatcher@gmail.com.
How are new weights going along?
panga666 is offline Report comment to moderator  
Reply With Quote
Unread 09-07-10, 10:17 AM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Originally posted by IQgryn
I'll take a look at it. If it implements its own tooltips then it may just be a matter of telling WeightsWatcher to look at those tooltips too. If it modifies the existing ones, things may get a bit trickier. Either way, I'll let you know what I come up with.
From a preliminary test, PhoenixTooltip seems to play nicely with WeightsWatcher already. It may depend on the order the addons are loaded. I'll see if I can add a line to the toc to make WeightsWatcher load first.

EDIT: Even forcing the addons to load in either order, they still seem to be working. What errors are you getting?
Last edited by IQgryn : 09-07-10 at 10:31 AM.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 09-07-10, 10:05 AM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Originally posted by kergoth
Hmm, would it be possible to add compatibility with the PhoenixTooltip addon? It changes the formatting of certain messages in the tooltip, but the new format is the same as existing stats on the item, so I expect it wouldn't be very difficult to support. Thanks.
I'll take a look at it. If it implements its own tooltips then it may just be a matter of telling WeightsWatcher to look at those tooltips too. If it modifies the existing ones, things may get a bit trickier. Either way, I'll let you know what I come up with.
IQgryn is offline Report comment to moderator  
Reply With Quote
Unread 09-07-10, 09:53 AM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Hmm, would it be possible to add compatibility with the PhoenixTooltip addon? It changes the formatting of certain messages in the tooltip, but the new format is the same as existing stats on the item, so I expect it wouldn't be very difficult to support. Thanks.
kergoth is offline Report comment to moderator  
Reply With Quote
Unread 09-06-10, 06:03 PM  
IQgryn
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 46
File comments: 94
Uploads: 1
Version 1.3r2 Released

I've uploaded version 1.3r2, which contains fixes for a few nil errors introduced in 1.3r1 (creating, copying, and deleting weights). This version is Cataclysm-compatible! Note that the new stats are not handled (yet), but I'm working on that too.

See the change log for full details, and as always, feedback is welcome. Please direct any complaints, requests, questions, concerns, bug reports, or any other sort of feedback to the thread here, to me by private message, or to WeightsWatcher@gmail.com.
IQgryn is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: