Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(1 Kb)
Download
Updated: 10-16-14 10:55 PM
Pictures
File Info
Compatibility:
Warlords of Draenor Pre-Patch (6.0.2)
Siege of Orgrimmar (5.4)
Escalation (5.3)
Updated:10-16-14 10:55 PM
Created:12-15-09 03:03 PM
Downloads:6,516
Favorites:80
MD5:

Confirm Loot Roll  Popular! (More than 5000 hits)

Version: 60000
by: Awbee [More]

Automatically confirms the "Looting this item will bind it to you." and "Disenchanting ***** will destroy it." pop-ups when you roll for BOP items in groups.

TOC updated for 6.0
Archived Files (2)
File Name
Version
Size
Author
Date
50001
1kB
Awbee
08-31-12 08:44 PM
40300
959B
Awbee
12-04-11 03:38 PM


Post A Reply Comment Options
Unread 09-04-12, 03:16 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
Originally Posted by Alexils
Why it's don't work in solo? It's work only work group loot
it only deals with rolling on items, which only happens in groups
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 09-03-12, 09:36 AM  
Alexils
A Kobold Labourer

Forum posts: 0
File comments: 31
Uploads: 0
Why it's don't work in solo? It's work only work group loot
Alexils is offline Report comment to moderator  
Reply With Quote
Unread 05-09-11, 11:21 AM  
UnlitPhoenix
A Kobold Labourer
 
UnlitPhoenix's Avatar

Forum posts: 1
File comments: 84
Uploads: 0
Ahhhhh! Screenshot is a mindf**k!
UnlitPhoenix is offline Report comment to moderator  
Reply With Quote
Unread 10-22-10, 12:37 PM  
Slaxi81
A Murloc Raider
 
Slaxi81's Avatar
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 173
Uploads: 3
thanks for this.

slaxi
__________________
Slaxi81 is offline Report comment to moderator  
Reply With Quote
Unread 01-22-10, 07:39 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
if v3 worked for you just use that.

there's only a few ways i can write such a simple addon. apparently 4 of them.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-21-10, 09:01 PM  
joshwill80
A Murloc Raider

Forum posts: 5
File comments: 144
Uploads: 0
Errors

OK, well the error happens when hiding the LFD ready dialog box. Here are the two errors I have seen:

Code:
<string>:\"*:OnHide\":7: Proposal not hidden through StaticPopupSpecial.\n<string>:\"*:OnHide\":7: in function <[string \"*:OnHide\"]:1>\n<in C code>: in function `Hide'\nInterface\\FrameXML\\StaticPopup.lua:3513: in function <Interface\\FrameXML\\StaticPopup.lua:3512>:\n<in C code>: in function `StaticPopupSpecial_Hide'\n<string>:\"*:OnClick\":2: in function <[string \"*:OnClick\"]:1>\n\nLocals:|r\nself = LFDDungeonReadyPopup {\n 0 = <userdata>\n dungeonID = 258\n}\nhidingCaller = \"Interface\\FrameXML\\StaticPopup.lua:3513: in function <Interface\\FrameXML\\StaticPopup.lua:3512>\"\n\n
Code:
<string>:\"*:OnHide\":7: Proposal not hidden through StaticPopupSpecial.\n<string>:\"*:OnHide\":7: in function <[string \"*:OnHide\"]:1>\n<in C code>: in function `Hide'\nInterface\\FrameXML\\StaticPopup.lua:3513: in function <Interface\\FrameXML\\StaticPopup.lua:3512>:\n<in C code>: in function `StaticPopupSpecial_Hide'\nInterface\\FrameXML\\LFDFrame.lua:55: in function <Interface\\FrameXML\\LFDFrame.lua:41>:\n\nLocals:|r\nself = LFDDungeonReadyPopup {\n 0 = <userdata>\n dungeonID = 258\n}\nhidingCaller = \"Interface\\FrameXML\\StaticPopup.lua:3513: in function <Interface\\FrameXML\\StaticPopup.lua:3512>\"\n\n
joshwill80 is offline Report comment to moderator  
Reply With Quote
Unread 01-21-10, 02:28 PM  
pelotkz
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Confirm Loot Roll

Excuse, but addon does not work on Russian server?
pelotkz is offline Report comment to moderator  
Reply With Quote
Unread 01-21-10, 08:51 AM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
I had a feeling I was wrong, but with an addon 5 lines long I couldn't see where else it could be coming from.

im amazed such a simple addon has generated 25 comments worth of troubleshooting.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-20-10, 01:05 PM  
Taroven
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 49
File comments: 835
Uploads: 14
Originally posted by Awbee
my guess is some other addon is doing
StaticPopupDialogs["CONFIRM_LOOT_ROLL"] = nil

then when my mod tries to do it
StaticPopupDialogs["CONFIRM_LOOT_ROLL"]
can't be found because it's already nil.
You've got that all sorts of backwards. A nil table entry (which this is) can absolutely be accessed and referenced. Not only that, but you're working with an already-existing table, at which point using
StaticPopupDialogs["CONFIRM_LOOT_ROLL"] = nil
would simply create a nil table object if ["CONFIRM_LOOT_ROLL"] didn't already exist.

You can test this yourself pretty easily. Read through the following code for some enlightenment.
Code:
local t = {}
t[1] = "foo"
print(t[1]) -- Result: "foo", note that I'm using the index reference for brevity here, a string will provide the exact same results.

t[1] = nil
print(t[1]) -- Result: nil, because the entry was set to nil.
print(t[2]) -- Result: nil, because while the table "t" exists, the subtable [2] does not. I give this example because without knowing the code behind a table's creation, it's very hard to tell this and the previous result apart - You can't expect different results from entries that do exist but are nil, and those that don't.
print(t[2][1]) -- Result: attempt to index field '?' (a nil value) - Except in this case, where the table containing what you're trying to access doesn't exist in the first place.

-- Now for the interesting part.
local foo = nil
if foo then
print("ohaithar")
else
print("No such luck")
end -- Result: "No such luck". A nil local doesn't validate.

t[1] = nil
if t[1] then
print("ohaithar")
else
print("No such luck")
end -- Result: "ohaithar". A nil table entry does, though. Strange, but you get used to it.
You're gonna have to look elsewhere for the cause of that error - The exact message would be an excellent start, since otherwise there's no telling exactly what is happening.

Edited for clarity. PM me if you have any questions or need help.
__________________
Former author of EventHorizon Continued and Other Releases.
Last edited by Taroven : 01-20-10 at 01:07 PM.
Taroven is offline Report comment to moderator  
Reply With Quote
Unread 01-20-10, 01:00 PM  
Durin
A Kobold Labourer

Forum posts: 0
File comments: 12
Uploads: 0
Thumbs up It works!

Heya

Good news everyone! It seems that this latest version definately works, at least for me.

I've seen no more nagging confirmations popping up, no errors too! And best of all I am still using XLoot!

I say good work! :P

Thanks
Durin is offline Report comment to moderator  
Reply With Quote
Unread 01-20-10, 06:46 AM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
ok. can you check if the problem persists when this addon is the only one enabled?

my guess is some other addon is doing
StaticPopupDialogs["CONFIRM_LOOT_ROLL"] = nil

then when my mod tries to do it
StaticPopupDialogs["CONFIRM_LOOT_ROLL"]
can't be found because it's already nil.

if thats the case then I can fix that with an if then statement.

that is, of course, assuming my addon is trying to do it after some other addon. if mine does it first theres nothing i can do.

but go ahead and post the error here and if you think its a certain addon let me know which one it is
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-20-10, 02:42 AM  
joshwill80
A Murloc Raider

Forum posts: 5
File comments: 144
Uploads: 0
Error

I updated to v4 today and I am getting an error related to StaticPopupDialogs. Sorry I don't have the exact error on hand atm, I will try to supply it later. It seems to happen when first entering an instance through LFD. As far as I can tell though, the error does not break the addon's functionality.
joshwill80 is offline Report comment to moderator  
Reply With Quote
Unread 01-16-10, 11:54 AM  
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 582
File comments: 240
Uploads: 35
Originally posted by Awbee
oh.. did it fix the problem though?
From looking at the code I'd guess so. Like you this problem
never happens on my or my sisters computer ... my idea of
fixing this was a little bit more brutal

Code:
StaticPopupDialogs["CONFIRM_LOOT_ROLL"] = nil
This staticpopup would never show no matter what
Rilgamon is offline Report comment to moderator  
Reply With Quote
Unread 01-16-10, 11:29 AM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
oh.. did it fix the problem though?
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-16-10, 07:23 AM  
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 582
File comments: 240
Uploads: 35
Code:
StaticPopup_Hide("CONFIRM_DISENCHANT_ROLL");
You can skip this line. There is no staticpopup with this name.
Disenchant uses CONFIRM_LOOT_ROLL, too. Called from UIParent.lua
OnEvent :

Code:
	if ( event == "CONFIRM_DISENCHANT_ROLL" ) then
		local texture, name, count, quality, bindOnPickUp = GetLootRollItemInfo(arg1);
		local dialog = StaticPopup_Show("CONFIRM_LOOT_ROLL", ITEM_QUALITY_COLORS[quality].hex..name.."|r");
		if ( dialog ) then
			dialog.text:SetFormattedText(LOOT_NO_DROP_DISENCHANT, ITEM_QUALITY_COLORS[quality].hex..name.."|r");
			StaticPopup_Resize(dialog, "CONFIRM_LOOT_ROLL");
			dialog.data = arg1;
			dialog.data2 = arg2;
		end
		return;
	end
Rilgamon is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: