Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(1 Kb)
Download
Updated: 10-16-14 10:55 PM
Pictures
File Info
Compatibility:
Warlords of Draenor Pre-Patch (6.0.2)
Siege of Orgrimmar (5.4)
Escalation (5.3)
Updated:10-16-14 10:55 PM
Created:12-15-09 03:03 PM
Downloads:6,474
Favorites:80
MD5:

Confirm Loot Roll  Popular! (More than 5000 hits)

Version: 60000
by: Awbee [More]

Automatically confirms the "Looting this item will bind it to you." and "Disenchanting ***** will destroy it." pop-ups when you roll for BOP items in groups.

TOC updated for 6.0
Archived Files (2)
File Name
Version
Size
Author
Date
50001
1kB
Awbee
08-31-12 08:44 PM
40300
959B
Awbee
12-04-11 03:38 PM


Post A Reply Comment Options
Unread 01-15-10, 04:26 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
Originally posted by Awbee
I'll try something else later today. I'll post it after I test it, if it works.
ok... it's up
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-14-10, 09:23 AM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
I'll try something else later today. I'll post it after I test it, if it works.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-12-10, 10:10 AM  
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 569
File comments: 236
Uploads: 35
With my MiscHelper I ran into the same problem.
To me it seems the hide comes before the staticpopup
is open. So its a racecondition. Your addon is programmed too well
and is faster than UIParent.lua which reacts to the same event
and creates the staticpopup.
Rilgamon is online now Report comment to moderator  
Reply With Quote
Unread 01-12-10, 08:29 AM  
Durin
A Kobold Labourer

Forum posts: 0
File comments: 12
Uploads: 0
Heya!

I started using this addon just recently, and I also find that the confirmation window isn't being closed. The loot-roll I chose is immediately accepted, but the confirmation window stays open.

If I then manually type the following command in the editbox:

/script StaticPopup_Hide("CONFIRM_LOOT_ROLL");

the confirmation window closes just like it should. However, the exact same command should already have been fired by your addon (and probably is), but somehow the window stays open. In or out of combat makes no difference.

I must also mention I am using XLoot Group to replace the default lootframes.

I will try to test this further without any other addons enabled, and also with just XLoot Group disabled to see if there's a difference.

Results coming up in a few hours I guess :P

Update 01.12.10@16:35:
It seems that XLoot is the reason that the behaviour of ConfirmLootRoll is not as expected! :P
I solely disabled XLoot, and everytime I loot BoP items it accepts the loot immediately without popping up the confirmation window.

Oh well. I will not revert to the default Blizzard loot-frames, since I like XLoot way too much Guess I'll have to stick with the windows popping up...

I'll keep using ConfirmLootRoll anyway, since that enables me to completely ignore the confirmation windows and very quickly select all my desired loot-options at bosses

Thanks for that!
Last edited by Durin : 01-12-10 at 09:44 AM.
Durin is offline Report comment to moderator  
Reply With Quote
Unread 01-11-10, 06:07 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
it only hides the popups for rolls.

should only be one popup at a time anyway.

but if there's a problem let me know.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 01-11-10, 05:58 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
Nice call. I didn't think about hiding all possible popups with that function since I have to make sure it's for the correct item.

edit: actually.. upon looking closer at the hide function, i might not need to hook either... hrmm
Last edited by Odlaw : 01-11-10 at 06:09 PM.
Odlaw is offline Report comment to moderator  
Reply With Quote
Unread 01-11-10, 05:25 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
I uploaded a new version which should fix the problem.

it's one line of simple code I was willing to add to the addon.

let me know if it fixes the problem.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 12-21-09, 04:59 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
well hooking functions to try and fix a problem I don't get sounds really fun, but I'll have to wait and see if I can find the patience to do that.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 12-19-09, 11:40 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
What happens:

You click greed/need/de on some items (bop / epic etc)
CONFIRM_LOOT_ROLL or CONFIRM_DISENCHANT_ROLL event fires
StaticPopup_Show("CONFIRM_LOOT_ROLL", SomeItemName) is called
StaticPopup_OnShow(frame) is called
You click 'Accept' and then the ConfirmLootRoll() is done.


What I did with my passloot addons for doing this, was hooked the StaticPopup_OnShow(Frame) function

Frame.which should hold the type of popup it was. Check for "CONFIRM_LOOT_ROLL" (both the de and normal confirm loot roll call the same popup.. the disenchant just changes the text) If it is, then just Frame:Hide() it.

<shrug> hope that helps.
Odlaw is offline Report comment to moderator  
Reply With Quote
Unread 12-18-09, 11:22 PM  
Manaman
An Aku'mai Servant
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 160
Uploads: 1
OK, I have removed everything I listed below, and the acceptance of the roll still occurs but leaving the dialogue behind. So to recap, I have removed all mods related to looting: Passloot's ConfirmBOP/DE modules, Automaton's BOP module. I have left Xloot because I find it too valuable to remove, and I don't see why it would impact the confirmation window anyway.

Edit: I have noticed the dialogue only remains on Greed/DE rolls, but not on Need rolls.
Last edited by Manaman : 12-18-09 at 11:24 PM.
Manaman is offline Report comment to moderator  
Reply With Quote
Unread 12-18-09, 09:29 PM  
Manaman
An Aku'mai Servant
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 160
Uploads: 1
I am also using Passloot, removing their ConfirmBOP and DE modules to see if they are impacting things.
Manaman is offline Report comment to moderator  
Reply With Quote
Unread 12-18-09, 09:23 PM  
Manaman
An Aku'mai Servant
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 160
Uploads: 1
Not sure, I think Automaton's BOP module may have been affecting things, will test without it loaded. I am also using Xloot. Not sure if it will cause problems. It didn't matter whether I was in combat or not.
Manaman is offline Report comment to moderator  
Reply With Quote
Unread 12-18-09, 11:23 AM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
well I just tested it myself. I looted in combat and clicked need and it worked fine.

make sure you're not using this mod with my other DE roll one.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 12-17-09, 10:16 PM  
Awbee
A Kobold Labourer
 
Awbee's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 110
Uploads: 8
thanks, altho I don't see how that would be an issue, since the window normally disappears during combat just fine when it's clicked manually. I don't see why it would be protected against automation, but maybe it is. only other thing I can think of would be a conflict with some other addon.
Awbee is offline Report comment to moderator  
Reply With Quote
Unread 12-17-09, 09:32 PM  
Manaman
An Aku'mai Servant
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 160
Uploads: 1
Originally posted by Awbee
weird, I haven't experienced this. do you know if it only happens in combat?
Will test out of combat versus in combat and get back to you.
Manaman is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: