Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(13 Kb)
Download
Updated: 11-14-10 08:05 AM
Pictures
File Info
Updated:11-14-10 08:05 AM
Created:12-19-09 02:40 PM
Downloads:2,367
Favorites:16
MD5:
LFDRating
Version: 1.02
by: Vladinator [More]
Ever found yourself doing a lot of LFD runs and bumping into some players you wish you hadn't? Well this won't really avoid bumping into those but it will tell you when you do by showing their player rating.
You can rate and comment at the end of each dungeon run, including those that left the group. The data will be shared between your guild so more using the addon and doing dungeons, more data you will gather about players.
If you find great players you can vote them up, perhaps add a pleasant comment. If you find people you wish had studied their class a bit more before running heroics, you may put negative rating and a comment explaining why you did that. This by all means is just an indication of what one would expect, tough if one accumulates enough negative score it may be a strong indicator they are up to no good and that you should watch out!

The addon is in beta, it works rather well with some few GUI issues that will be polished eventually. Also as a bonus feature you could use the website (not necessarily up to date with the addon, it's work in progress): http://lfdr.ziuo.net/ -it helps share data with the world and they with you!

Something like a roadmap for the future:
- Add support for all low level dungeons so it's worth using when doing LFD in Cataclysm with your low level characters.
- Implement GUI for browsing data, searching for players and such.
- Implement new statistics website page, seems they made the LFD work with all realms of the same language, not only limited to battlegroups like before.
-- Beta ----------

>1.02:
+ Minor improvements and trying to fix some issues, for one the "leavers" dialog acts a bit odd even when it seems I provide the right data and such -sometimes it leaves the button there even if there are no leavers to show, also it does not show the "no data" label properly either. I'll fix that minor GUI issue sooner or later I guess.
+ Fixed a possible exploit where people could add comments and ratings by using other peoples names and realms, the fix in this version uses the senders name and current realm as their signature and this fixes any hijacking or abuse using the addon channel. It works guild only so should not be a huge issue, unless you only have jerks in your guild. ;)

>1.01:
+ Improved boss kill tracking, should not bug out anymore (for patch 4.0.1 at least!)
+ When group is filled up you see a popup with each person and their respective rating.
+ When you end the group (last boss dies) the popup shows letting you vote and comment, leavers are in their own "Leavers" section you can toggle.
+ If you reload UI or disconnect and log back on, you see the rating popup once more. Only problem is that the order of party and leavers will not be proper, thus some that actually killed the boss may be labeled leavers -this is not a big deal but will be fixed later on.
+ If the party looses a member and someone new joins, the party popup is again shown with the new persons ratings.

> 1.00:
+ Updated for patch 4.0 and improved overall performance, will put in the information feature (when you join a group you will be alerted of the members ratings) back in the next build. Making an eat GUI for that feature so it does not just print it in the chat. :)

-- Alpha ----------

> 0.06:
+ Supports any kind of LFD dungeon within reason. I have made the bosses with multiple phases (that die and ressurect) or that despawn be tracked by statistics. Because of this I need to manually add the bosses that die in such fashion and that are to be found in the statistics section (achievements). So far I have added UK, TOC and Strat to the list where the bosses have multiple phases after death and despawn. (This is why if you die in the 0.05/0.04 on Black Knight in his 3rd phase, party wipes and you enter the dungeon you will get the party vote screen as it thinks the boss died. This is now avoided using the statistics function implemented. All the other bosses that die once and die for good are tracked by their death event in the combat log as it's pretty decent and works with 90% of all the dungeons in the game.) Note: If I forgot something, please tell me so I can add it to the special list of special bosses. /pat

> 0.05:
+ Minor fix, boss kill detection works much better now. Should not trigger the party vote screen when a random mob dies in a LFD dungeon. This flaw came to be in version 0.04 and is now hotfixed.

> 0.04:
+ Added support for both random LFD groups and specifically picked dungeons (group rating dialog should be shown properly this time around).
+ Should not show "rate user" dialog after run finishes and people leave the group as it not checks if you are in the dungeon and that it has not completed yet when someone leaves the group.
+ Known bug: only 1 "rate user" dialog comes up if 2 people leave party quickly after each other. Should not happen!

> 0.03:
+ Made handling events more efficient and precise, removed some odd bugs when someone left group before you saved the party rating the rating box for that person came up. Also that sometimes it would stop taking new events in mid of the run and so on.
+ Added an "ad" to inform group at creation that the user is using LFDRating -hinting them to perform well otherwise they will get rated. They have the right to know imo! You can turn it off by editing the .lua file manually (the 12th line).
* Working on a better website layout, more organized, more for "gamers" so it's not boring white and a little lame to navigate. Still gonna be lightweight though! We are closing into Beta soon people. My current todo list says (a) make it possible to vote on more than 1 person that leaves party at a time (b) add the option to view peoples history, comments that other people added and overall more indebt information than just the joining ratings.

> 0.02b:
+ Hotfixed a problem where too long messages were send using the addon channel and it disconnected the user. The max comment length is now 128 chars and it should no longer disconnect you. If you do get a disconnect please Private Message me the !LFDRating.lua from the savedvariables folder and tell me the name of who you commented that resulted in a DC, I'll look into it and fix it for further patches.

> 0.02:
+ Fixed party change detection, should perform much better than before and should show the appropriate dialogs when needed.
+ Hides party vote dialog if loot or alert windows are visible (or if in combat). Shows after you exit combat and loot-rolling finishes.
+ If you disconnect you can still vote on the previous party if data could be restored.
+ Improved overall performance as less logical test are performed now than the earlier version.

> 0.01:
+ Initial release.
Optional Files (0)


Archived Files (8)
File Name
Version
Size
Author
Date
1.01
12kB
Vladinator
11-13-10 08:32 AM
1.00
9kB
Vladinator
11-12-10 08:57 AM
0.06
12kB
Vladinator
01-07-10 08:42 AM
0.05
12kB
Vladinator
01-06-10 02:53 PM
0.04
11kB
Vladinator
01-05-10 08:13 AM
0.03
9kB
Vladinator
12-25-09 05:37 AM
0.02b
8kB
Vladinator
12-21-09 08:28 AM
0.01
8kB
Vladinator
12-19-09 02:40 PM


Post A Reply Comment Options
Unread 01-05-10, 01:19 PM  
algritz
A Murloc Raider
 
algritz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 44
Uploads: 3
Re: Re: Re: Invalid Archive

Originally posted by algritz
Managed to download and upload fine!

Added US-Retaliation data
Small suggestion : on the download page, in the dropdown for each battlegroup, can you put in parenthesis the # of rated players ?

select a realm :
Emberstorm(39)
Retaliation (7)
Ruin(2)


etc...
__________________
<I Pugged this life>
algritz is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 01:14 PM  
algritz
A Murloc Raider
 
algritz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 44
Uploads: 3
Re: Re: Invalid Archive

Managed to download and upload fine!

Added US-Retaliation data
__________________
<I Pugged this life>
algritz is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 10:34 AM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 765
File comments: 391
Uploads: 39
Re: Invalid Archive

Originally posted by algritz
Tried to download data from US-Emberstorm (just to consult the saved varaiable file) and winrar tells me that the zip file is invalid.
Yes, working on that issue. For now simply try again and the zip should not be corrupt/invalid. Looks like the transfer does not finish completely before the browser considers it to be... i.e. sometimes the browser thinks the download is completed while in fact the file may only be half way done downloading. Should fix it quick, meanwhile simply download again until it gives you a working copy of the file.

*Edit temporary fix*

I did a temporary fix by opening the cache folder for direct access and the PHP simply redirects the browser to the .zip file in the cache. Securing the cache once again after the issue below this paragraph gets fixed.

*Edit Issue*

PHP Code:
  header("Content-Description: File Transfer");
  
header("Content-Type: application/zip");
  
header("Content-Disposition: attachment; filename=\"{$filename}\"");
  
header("Content-Transfer-Encoding: binary");
  
header("Expires: 0");
  
header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
  
header("Pragma: public");
  
header("Content-Length: ".filesize($file));
  
#ob_clean(); // bugs so firefox says the file is not readable(?)
  
flush();
  
readfile($file); 
This is the current code for a force download, odd thing is that if I uncomment ob_clean() then Firefox returns other kind of errors, if I comment it then roughly 4 out of 10 cases the file will be corrupted/invalid and user must download it again to hope for a successful transfer.

I must look into it but in case someone got PHP skills and can figure out my issue you are welcome to help me out. :P Anyway for now simply try to download again until it works. At least it's better than getting a lua file where you think it's okay but end up with "table nil" errors.
Last edited by Vlad : 01-05-10 at 11:02 AM.
Vlad is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 10:16 AM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
Originally posted by Petrah
Forgive me if I've misunderstood.. but do you by chance have Elitist Group installed? If so, that's the one that comes up first asking you to rate 0 - 5. I tried it, and didn't much care for it. LFDRating.. FTW!
Ah yeah, crap it seems to be enabled. I was going to try both out.
__________________
I have very little time to play WoW and even less time to code addons. As such I've dropped all development of all my addons. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, Valle.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 09:30 AM  
algritz
A Murloc Raider
 
algritz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 44
Uploads: 3
Invalid Archive

Tried to download data from US-Emberstorm (just to consult the saved varaiable file) and winrar tells me that the zip file is invalid.
__________________
<I Pugged this life>
algritz is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 09:02 AM  
Petrah
A Pyroguard Emberseer
 
Petrah's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2865
File comments: 332
Uploads: 10
Originally posted by Yourstruly
What confused me further now is when I did the random heroic for Frost Emblems and first the /rate (4 people) window showed up accepting values from 0-5 (Terrible-Great) and then after that the default one in the screenshot showed up.
Forgive me if I've misunderstood.. but do you by chance have Elitist Group installed? If so, that's the one that comes up first asking you to rate 0 - 5. I tried it, and didn't much care for it. LFDRating.. FTW!
__________________
♪~ ( ) I My Sonos!
Last edited by Petrah : 01-05-10 at 09:03 AM.
Petrah is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 08:48 AM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 765
File comments: 391
Uploads: 39
Version 0.04 works with any kind of LFD group now (0.03 only worked when you pick the Random Dungeon option).

The window as seen in the screen-shot shows when the last boss has been killed.
Otherwise if someone leaves the party before the run finishes the popup dialog comes up when you can specifically rate that person.

As mentioned in 0.03 it depended on that the event that declares "the dungeon is finished" does not execute if you do not join a "Random Dungeon", that's why after you kill the last boss and everyone leaves you see only one dialog for rating the last person to leave.

That's also a bug, it should have been possible for it to show up to 4 people leaving (i.e. you form a group then everyone leaves before the instance is finished), but for now it overwrites each other so instead showing 4 dialogs it shows only 1 (the last person that left). This is a bug I'll address in the next version, for now it at least works fine with everything else except if multiple people leave before instance finishes.
Vlad is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 08:40 AM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
What confused me further now is when I did the random heroic for Frost Emblems and first the /rate (4 people) window showed up accepting values from 0-5 (Terrible-Great) and then after that the default one in the screenshot showed up.
__________________
I have very little time to play WoW and even less time to code addons. As such I've dropped all development of all my addons. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, Valle.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 08:06 AM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 765
File comments: 391
Uploads: 39
Originally posted by Yourstruly
I installed the addon and joined a already started group in PoS and as we were done everyone basically left at the same time so the window to rate them (not shown in any screenshot yet) just disappeared and switched to the next player. In the end I only got to rate 1 person.... the last one to leave.
I know the issue, it's caused by reading the "Your group has disbanded." message and assuming you have rated the party already. I fixed this in the next version by skipping this if the user is still in the dungeon. That should fix the issue.

If the group does not finish the instance (the reward alert does not come up) then there should be multiple rate windows for each leaving member instead of the screen-shot version where all 4 party members are in a dialog. Just to mention it even not declaring "exclusive" it still overwrites the last window for no apparent reason, need to do some research into this (using StaticPopup dialogs for this).

I've implemented a boss-kill check for non-random groups, since the LFG_COMPLETION_REWARD event only fires when you do a random dungeon or random heroic using the LFD tool! I tried to fix it by adding a database over all the final bosses so that when you do a specific LFD dungeon, you kill the final boss then the rating window should pop-up as it usually would.
Last edited by Vlad : 01-05-10 at 08:10 AM.
Vlad is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 08:02 AM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
I installed the addon and joined a already started group in PoS and as we were done everyone basically left at the same time so the window to rate them (not shown in any screenshot yet) just disappeared and switched to the next player. In the end I only got to rate 1 person.... the last one to leave.
__________________
I have very little time to play WoW and even less time to code addons. As such I've dropped all development of all my addons. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, Valle.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 07:46 AM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 765
File comments: 391
Uploads: 39
Originally posted by Yourstruly
Thanks for the answers, cleared some things up.

Edit: Oh, are guild members allowed to rate each other? Seems a bit unfair if they are.
They are, so far I have not added a guild-check but I may in the future to avoid favoring behavior among players that know each other. I'll see the demand in the future and implement this, it's a good idea.

The website is in beta stage. It should properly work now, it does with the EU-EN version and if there is a bug with some data I'll try to contact the uploader and request his SV (savedvariable) file so I can fix the issue.

Only one issue left is upon download the file may be corrupt and your ZIP application should tell you, if it is simply download it again and it should this time be properly working without an error when extracting the file out of it.

If you apply a bugged SV file you will get errors in-game, table issues mainly (table nil value). I'll figure out and fix it in near future, meanwhile you know the issue.
Last edited by Vlad : 01-05-10 at 08:00 AM.
Vlad is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 07:16 AM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
Thanks for the answers, cleared some things up.

Edit: Oh, are guild members allowed to rate each other? Seems a bit unfair if they are.
__________________
I have very little time to play WoW and even less time to code addons. As such I've dropped all development of all my addons. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, Valle.
Last edited by v6o : 01-05-10 at 07:21 AM.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 05:59 AM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 765
File comments: 391
Uploads: 39
Originally posted by Yourstruly
Hello just wondering how the rating and comments work as it does not state anywhere.

If I rate someone good and someone rates someone bad, and we both make comments. What happens when we upload this data, how is it processed?

What will the users be able to download from that?

How does it work if I rate someone badly and make a bad comment one day and then the next day update that to good?

Is it possible to make no note at all? (no rating and no comment) because sometimes you don't really get a feel for people and they just seem to tag along not showing anything good or bad.
Thanks for asking the right questions!

Q: If I rate someone good and someone rates someone bad, and we both make comments. What happens when we upload this data, how is it processed?
A: The server will store all the comments (entries) per user. When you download it simply merges all the battle-group realm data from the whole database into a LUA savedvariable file that the game loads. The addon will then sum the one -1 and +1 in this case and produce 0 rating (from 2 votes) i.e. the higher above 0 you are the more positive are the general population while if it's negative the more negative they are. 0 = neutral, i.e. can't really say much about him, but if people comment it can be readable trough a simple dialog browser (browse all comments of that user or the whole database) -implementing this when addon goes beta.

Q: What will the users be able to download from that?
A: You download exactly what the addon otherwise stores, per user (per entry) there is a name and realm of who ever made the entry, dungeon ID to where this happened, comment text if any, -1/0/+1 rating, date and time at the event. Only 1 entry per person (i.e. my character can only comment once on a person but I can change my opinion later on when I encounter him again, you can edit the comment and rating at that point then).

Q: How does it work if I rate someone badly and make a bad comment one day and then the next day update that to good?
A: Then when you upload it the database will update your comments rating from -1 to +1 and the person will gain 1 rating when the latest savedvariable file is downloaded.
Note: By no means is this system cheat-free, if people start to manually edit their comments and add a lot of improper votes it will try to deflect those but can't guarantee it won't be abused. Permanent IP ban on abusers (1 strike rule + cleanup afterwards) would be something I will aim for after this goes live, won't consider it in alpha and beta stages.

Q: Is it possible to make no note at all?
A: Currently rating neutral without a comment counts as "no vote". If you vote neutral and include a comment it counts as no vote but with a side-note. Hitting "Save" at the end of a run without voting will basically "skip voting", data will be stored but without comment and rating. That's why I included so you can download in regular and minimal mode, minimal mode will skip all the neutral votes ("no votes") and only include those with -1/+1 or that are 0 but with a comment so that only important data is downloaded. This will matter much more when there are a half million users, the database will be much smaller downloading the minimal version than the regular one. Even now it's roughly 60% smaller to download the minimal file than the regular one.

I hope my answers were good enough for you.
Last edited by Vlad : 01-05-10 at 06:00 AM.
Vlad is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 05:22 AM  
v6o
An Onyxian Warder
AddOn Author - Click to view AddOns

Forum posts: 399
File comments: 67
Uploads: 10
Hello just wondering how the rating and comments work as it does not state anywhere.

If I rate someone good and someone rates someone bad, and we both make comments. What happens when we upload this data, how is it processed?

What will the users be able to download from that?

How does it work if I rate someone badly and comment one day and then the next day make a good one?

Is it possible to make no note at all? (no rating and no comment) because sometimes you don't really get a feel for people and they just seem to tag along not showing anything good or bad.
__________________
I have very little time to play WoW and even less time to code addons. As such I've dropped all development of all my addons. If you want to continue any addon or make a fork then feel free to do so. This is your permission slip.

Best regards, Valle.
Last edited by v6o : 01-05-10 at 05:49 AM.
v6o is offline Report comment to moderator  
Reply With Quote
Unread 01-05-10, 05:16 AM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 765
File comments: 391
Uploads: 39
Re: Re: Re: Re: Re: Re: Re: Re: Re: Nice Add-on

Originally posted by algritz
What i meant here is my "local" file didn't contained the people I rated.

This is probably due to the "table nil" error
I assume this happened after you tried to update.

I see two reasons this may have happened:
1) You used the new site that is not yet functional (i.e. no data from it)
2) The old site works but in some few cases you get a half-file (not the full file) thus I understand the table-nil problem that occurred. To avoid this I was thinking of putting the file in a ZIP so that if something is wrong the zip program will tell you about it so you can try to download again. I'll try figure out what exactly causes this and preferably fix that directly there.
Vlad is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: