zz MiscHelper 

40300.21 doesn't load.

Yeah ill try out the latest one - have alts to run through Dragon Soul and lower ones through new 5-mans, heroic and old content - so will get a good mix of testing - just didnt want to use the newer code on mains in case it didnt do things right.

Yeah i think that is where the "SkipNeed" option is confusing because when i want to need on an items i dont want to skipneed i want to show need. But yeah we covered this area.

Blizz has changed it so that if you need BoE items they become BoP. It is only if you greed the BoE that it stays BoE

As to it falling through that it might get DEd.. i suppose it could be the options getting me a little confused but in anycase it looks like you can see what i am talking about.

I think line 3 should be

if(canNeed and quality>getPref2('showBOE') and getPref2('skipNeed')) then return end

or really have a new slider for canNeed items and have

if(canNeed and quality>getPref2('showNeed') and getPref2('skipNeed')) then return end


A BoE becomes a BoP if you did need it. If a BoE falls through to line 8 you will have items that you might have wanted to roll need on that could be DE'ed either that or i have to set the options to show all BoE's of that quality. The quality check is still relevent though.

Though i think the config options are what are still need to be adjusted; like i said they are not completely obvious.

When you rolls on stuff it is really show me only stuff i am concerned with (for me) let the addon handle the rest.

So (for me) let me see the Need/Greed/DE popup on stuff i can need on over a certain quality, auto-roll greed on BoE's over a certain quality (i dont need to see these as I would only either want to greed them not DE); all the rest gets handled by a catch all which will DE if it can else greed.
.

Ok, going through the options and code to work out what is what.

In the config: i see the new autogreed tab, but on the zz_MiscHelper tab there are the options 'AutoGReed Runed Orb/Choas Orb' and 'Greed or disenchant blue and green'.

The order of the config options in 'autogreed' tab makes it confusing as to exactly what is going to happen and this needs to be clear to know what to select.

So in a rough order/logic that it evaluates

The setting 'ignoreOrbs' makes the addon to show orb roll (no tooltip on this config item)
The setting 'Skip Need' need will show the roll for BoP items that you can need.

If BoP then
it will auto pass according to the 'Pass green/blue/epic BoE' check boxes
(this includes ones i can need on)
else
if i can need on it show roll window if better quality item than on slider and i set 'Skip Need'
if i set 'Greed BoE' then show if i set 'pass green/blue/epic BoE' or green and can DE (not sure about this as lua is not my native language)
else
.. not sure what your trying to do here ..

Anyway .. seems some options are confusing as you describing them as to what the addon is seeing them as not what the player is seeing them as. ie/ 'Skip Need' is 'Show Need'

Also things like if it is a BoP -BUT- i can need it then i may not get to need on it regardless of the 'Show/Skip Need' setting.

Hope you can see what i mean.

Some suggestions - and please take these as you will - done a fair bit of coding/program design in my time - but out of the industry now


I would have put the options in an order that code a structure to the internal logic.

So put the an option like 'Auto Greed Orbs' (in tooltip put somethign like 'Auto Greed Runed and Choas orbs') at the top.

call your need option 'Show Need Rolls' (tooltip something like 'Show rolls i can need on that are of the selected quality or better') and have a scale after that if you want for 'min quality'

call an option 'Show BoE rolls' (tooltip something like 'Show Bind-on-equip rolls that are of the selected quality or better')and have a separate min quality slider.

the logic then falls through to a catch all which would be to in reality Auto DE if possible, Auto Greed, Auto Pass or Show Loot Rolls. Given Auto Pass on Loot is an option that Blizz provides you can loose that option so it is really Auto Greed then another option Auto DE if possible.

(i dont mind coding these up if i get time but atm i am doing house renovations so not lots of time)

Yeah this is true. It works ok for me with the code that i am using from below as it pops up a need/greed/DE window for that case.

Yeah you could make the options quite extensive/complicated.

Like you said the item level - but also greed if it vendors over a certain amount (usually weapons) rather than DE it.

As an option though it would be useful to have the DE (if available) as an option rather than as part of the same configuration option.

As far as the item level things goes .. that could be a tricky thing to always get right. You would want to compared it to your current equipped gear i suppose .. what about off specs .. or if you want to collect gear for a future spec. you could turn the option off i suppose. Is it trying to do doing too much?

Just asking .. so you can bounce off ideas.