Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(2 Kb)
Download
Updated: 10-03-11 07:44 PM
Pictures
File Info
Updated:10-03-11 07:44 PM
Created:03-01-10 11:06 AM
Downloads:1,951
Favorites:18
MD5:
Criminal
Version: 40200.2-Beta
by: p3lim [More]
This addon is discontinued.
Functionality added to Molinari.

Description:
Criminal is an addon designed to make [Pick Locking] a bit easier.

While you might do it the old fashion way, by clicking the spell first, then selecting the item to pick.
Why do it the hard way?

Criminal lets you pick locks without clicking the spell first!
Simply hold the <Alt> key down and click on box you want to "crack". Voilá!

This also semi-works in the trade window aswell, only that the spell won't apply to the item automagically.
Changes in 40200.2-Beta:
  • A long overdue fix
  • Update version
Archived Files (1)
File Name
Version
Size
Author
Date
30300.1-Beta
2kB
p3lim
03-01-10 11:06 AM


Post A Reply Comment Options
Unread 03-01-10, 11:37 AM  
pomr
A Kobold Labourer
 
pomr's Avatar

Forum posts: 1
File comments: 49
Uploads: 0
Might want to subtitute the word 'Criminal' for 'Molinari' in the description. =)
pomr is offline Report comment to moderator  
Reply With Quote
Unread 03-01-10, 12:09 PM  
Xenoronin
A Deviate Faerie Dragon

Forum posts: 17
File comments: 10
Uploads: 0
loler, in before edit
Xenoronin is offline Report comment to moderator  
Reply With Quote
Unread 03-02-10, 06:15 AM  
Hiiri
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
Doesn't work.
Even with no other addons on.
Hiiri is offline Report comment to moderator  
Reply With Quote
Unread 03-02-10, 09:18 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Originally posted by Hiiri
Doesn't work.
Even with no other addons on.
What localization / game version?
p3lim is online now Report comment to moderator  
Reply With Quote
Unread 03-03-10, 04:09 AM  
Hiiri
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
enGB and current patch (3.3.2)
Hiiri is offline Report comment to moderator  
Reply With Quote
Unread 03-04-10, 04:19 PM  
ichik
A Murloc Raider
 
ichik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5
File comments: 264
Uploads: 5
ruRU same.
ichik is offline Report comment to moderator  
Reply With Quote
Unread 03-05-10, 12:36 PM  
Jzar
A Chromatic Dragonspawn
 
Jzar's Avatar
AddOn Author - Click to view AddOns

Forum posts: 157
File comments: 299
Uploads: 5
Code:
Date: 2010-03-05 11:34:11
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Criminal\Criminal.lua line 9:
   invalid option in `format'
Debug:
   [C]: ?
   [C]: format()
   Criminal\Criminal.lua:9: in main chunk
Last edited by Jzar : 03-05-10 at 12:36 PM.
Jzar is offline Report comment to moderator  
Reply With Quote
Unread 03-05-10, 02:43 PM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Ait, I'll check it out, my rogue is only 70 and on an low-populated server so its not easy to get lockboxes for testing.
p3lim is online now Report comment to moderator  
Reply With Quote
Unread 03-05-10, 06:55 PM  
Jzar
A Chromatic Dragonspawn
 
Jzar's Avatar
AddOn Author - Click to view AddOns

Forum posts: 157
File comments: 299
Uploads: 5
Originally posted by p3lim
Ait, I'll check it out, my rogue is only 70 and on an low-populated server so its not easy to get lockboxes for testing.
I got that error upon logging in. I'm not sure why I (and others, it sounds like) are getting that and you're not.

As for lockboxes, I'd just listen to your lock-picking trainer, go to where he suggests, and pick-pocket people -- they'll give you plenty of lock boxes.

Thank you for this though -- once it's working, it'll be quite nice.
Jzar is offline Report comment to moderator  
Reply With Quote
Unread 03-07-10, 04:16 AM  
Katardre
A Kobold Labourer

Forum posts: 1
File comments: 59
Uploads: 0
I'm getting the same error Jzar reported...it occurs on login...I use swatter to catch all my errors and didn't notice this error existed until I opened swatter to look for a different error...it never actually pops up on my screen...

Date: 2010-03-07 03:26:05
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Criminal\Criminal.lua line 9:
invalid option in `format'
Debug:
[C]: ?
[C]: format()
Criminal\Criminal.lua:9: in main chunk

posted a bug report with the error I get if I only have Criminal loaded and all other addons disabled...hope it helps...thanks for making this....hope you getting it working soon so I can be a happy rogue
Last edited by Katardre : 03-08-10 at 02:06 AM.
Katardre is offline Report comment to moderator  
Reply With Quote
Unread 03-08-10, 06:31 AM  
Jzar
A Chromatic Dragonspawn
 
Jzar's Avatar
AddOn Author - Click to view AddOns

Forum posts: 157
File comments: 299
Uploads: 5
Fix: Line 9, just change '%s %(.*%)' after the string.format to '%s %%(.*%%)'

Voila!
Jzar is offline Report comment to moderator  
Reply With Quote
Unread 03-08-10, 05:02 PM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Thats not a fix, its a temporary change, which also breaks the whole point of the syntax
p3lim is online now Report comment to moderator  
Reply With Quote
Unread 03-08-10, 05:48 PM  
Jzar
A Chromatic Dragonspawn
 
Jzar's Avatar
AddOn Author - Click to view AddOns

Forum posts: 157
File comments: 299
Uploads: 5
And so it does. Thank you for providing me with some good sample code for tracking down some more thorough documentation on Lua patterns than I've previously found. I've copied a few tricky functions that use patterns for my addons, but never really delved into understanding them.

My apologies if I sounded cocky and just came across as stupid. I'm not sure what motivated me to try putting extra % symbols in there, but it made the error go away, and then your mod worked fine.

Here's the replacement that after some digging, I believe does what you intend: '%s (%s)'

According to the lua-users wiki, string.format takes a formatstring as its first argument, not a Lua pattern. Thus you just have to tell it what types of data it should insert into the string, and the first two returned arguments from GetSpellInfo are both strings. You don't have to actually match the characters in the strings it returns.

If I'm still wrong, please forgive me; I'm really curious now what the correct solution to this puzzle is.
Jzar is offline Report comment to moderator  
Reply With Quote
Unread 03-08-10, 06:16 PM  
Jzar
A Chromatic Dragonspawn
 
Jzar's Avatar
AddOn Author - Click to view AddOns

Forum posts: 157
File comments: 299
Uploads: 5
Upon actually finally getting to someplace where I can find lockboxes, I find that my fix didn't fix anything. Upon further investigation, it turns out that the second returned argument from GetSpellInfo(1810) is "Journeyman" on my rogue atm. I'm guessing you're using this to try to verify that the rogue is high-enough to actually pick the lockbox. But even if the rank of Lock picking returned as "125" instead of "Journeyman", the lockbox would still say what it requires, which wouldn't equal the rogue's exact skill except very rarely, wouldn't it?

I've now changed mine formatstring to '%s' and am ignoring all but the first argument returned from GetSpellInfo and it works fine for lockboxes I'm high enough to pick. I'm not sure how you'd actually check if I'm high enough level for a box, but I hope you can get it working!
Jzar is offline Report comment to moderator  
Reply With Quote
Unread 03-09-10, 09:33 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Originally posted by Jzar
Upon actually finally getting to someplace where I can find lockboxes, I find that my fix didn't fix anything. Upon further investigation, it turns out that the second returned argument from GetSpellInfo(1810) is "Journeyman" on my rogue atm. I'm guessing you're using this to try to verify that the rogue is high-enough to actually pick the lockbox. But even if the rank of Lock picking returned as "125" instead of "Journeyman", the lockbox would still say what it requires, which wouldn't equal the rogue's exact skill except very rarely, wouldn't it?

I've now changed mine formatstring to '%s' and am ignoring all but the first argument returned from GetSpellInfo and it works fine for lockboxes I'm high enough to pick. I'm not sure how you'd actually check if I'm high enough level for a box, but I hope you can get it working!
I'm trying to get a localized string of "Lockpicking"
p3lim is online now Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: