Macaroon Fan Fix:Horizontal displacement. : Plug-Ins & Patches : World of Warcraft AddOns

(13 Kb)

Download

Updated: 06-13-10 08:55 PM

Patch for:
Ion.

Add Favorite

Install Help

Pictures

File Info

Updated:	06-13-10 08:55 PM
Created:	03-04-10 05:59 PM
Downloads:	1,304
Favorites:	7
MD5:

Macaroon Fan Fix:Horizontal displacement.

Version: 30300.21

by: Dwargh [More]

Out dated & not needed.

This was a Fan Fix for the Horizontal displacement that occured when a Macaroon(pre Cataclysm) bar with a 0-button-state switches state, if it's placed along left/right side of the screen or Snaped To left/right side of another bar.

Just some additional code and some minor changes to Mauls code in file Macaroon_Bars.lua:
local function updateBarSize(bar)

Install: replace your old Macaroon_Bars.lua file in your Macaroon folder with this one.

2010-06-14
Updated to work with Macaroon:Autohide-show on ModKey
If you don't install that patch first you shouldn't install this update.

Archived Files (1)

File Name	Version	Size	Author	Date
Macaroon Fan Fix:Horizontal displacement.	30300.2	13kB	Dwargh	03-04-10 05:59 PM

Comment Options

10-19-10, 03:41 PM
Dwargh A Theradrim Guardian Forum posts: 64 File comments: 660 Uploads: 2	Implemented into Macaroon! Last edited by Dwargh : 10-26-10 at 09:15 PM.

03-05-10, 11:48 AM

anseloth

Coding Archmage

Forum posts: 50

File comments: 267

Uploads: 3

Re: Re: Re: Re: My heart leapt...

Originally posted by Dwargh
Thing is, you see, a Macaroon bar with states wants to show the next states center where the previous state has its center.
So, if your bar state with buttons has it's center beneath it's normal(no button) state the bar will be displaced upward.

What I did with this fix was have the bar length of a no button state calculated from how many buttons the next state has in a row and match the length of that that. Meaning having the horizontal center of a bar be the same in any state.(apparently not completely though as it seems the small spaces between each button isn't included in the calculations, but close enough for now).

So a vertical displacement happens on bars that have have less rows of buttons in one state than the other. A bar with buttons in both states but not the same amount of rows might just have to be remade as 2 bars for now, where one is a workhorse bar. While the SnapTo uncheck will solve the problem with bars where the other state has no buttons, as the empty bar state will not be snapped into position but rather stay vertically centered where the state with buttons has it's vertical center.

Hope that isn't to complicated to understand.

maybe working with the settings (or the code for the settings) for snato tolerance might help, idk. granted, the "settings" are just a slider that you can use to increase or decrease the snapto tolerance.

in any case, i'll give messing around with the settings (but i probably won't be able to get to the code for now) a try right now, and i'll post again once i have the results of that test.

__________________

Last edited by anseloth : 03-05-10 at 11:51 AM.

03-05-10, 11:38 AM

Dwargh

A Theradrim Guardian

Forum posts: 64

File comments: 660

Uploads: 2

Re: Re: Re: My heart leapt...

Originally posted by SkunkWerks
It's a somewhat minor inconvenience, admittedly. But having to flip in and out of bar edit mode any time I log in or reload my UI in order to get them to appear exactly where I put them is kinda irritating.

I have not. Though I don't think it's necessarily enabled on all bars. I'd have to check.

Thing is, you see, a Macaroon bar with states wants to show the next states center where the previous state has its center.
So, if your bar state with buttons has it's center beneath it's normal(no button) state the bar will be displaced upward.

What I did with this fix was have the bar length of a no button state calculated from how many buttons the next state has in a row and match the length of that that. Meaning having the horizontal center of a bar be the same in any state.(apparently not completely though as it seems the small spaces between each button isn't included in the calculations, but close enough for now).

So a vertical displacement happens on bars that have have less rows of buttons in one state than the other. A bar with buttons in both states but not the same amount of rows might just have to be remade as 2 bars for now, where one is a workhorse bar. While the SnapTo uncheck will solve the problem with bars where the other state has no buttons, as the empty bar state will not be snapped into position but rather stay vertically centered where the state with buttons has it's vertical center.

Hope that isn't to complicated to understand.

03-05-10, 10:23 AM

SkunkWerks

A Fallenroot Satyr

Forum posts: 21

File comments: 241

Uploads: 2

Re: Re: My heart leapt...

Originally posted by Dwargh
I did try to fix the vertical as well but all my attempts only resulted in a lot of errors and no improvement. I will however look in to that some more.

It's a somewhat minor inconvenience, admittedly. But having to flip in and out of bar edit mode any time I log in or reload my UI in order to get them to appear exactly where I put them is kinda irritating.

Meanwhile though. Have you tried to uncheck "snapTo" after you've placed your bars where you want them? That usually help.

I have not. Though I don't think it's necessarily enabled on all bars. I'd have to check.

Last edited by SkunkWerks : 03-05-10 at 10:24 AM.

03-05-10, 08:59 AM

Dwargh

A Theradrim Guardian

Forum posts: 64

File comments: 660

Uploads: 2

Re: My heart leapt...

Originally posted by SkunkWerks
...for I thought the cause of my disharmonious UI displacement was finally addressed!

And then I realized you said 'horizontal'.

I'ma go cry now.

I did try to fix the vertical as well but all my attempts only resulted in a lot of errors and no improvement. I will however look in to that some more.

Meanwhile though. Have you tried to uncheck "snapTo" after you've placed your bars where you want them? That usually help.

Originally posted by seebs
THANK YOU SO MUCH!!!!!

... I promised myself I wouldn't cry.

My hunter, my other hunter, my frost mage, and my warlock? They're weeping tears of joy.

You're very welcome. It's fun when you can accomplish something that help others.

I noticed though that even this first fix has a little problem with really long horizontal bars. Specially those who is set along the sides of the screen.
It should be easy enough to do something about it though, just need to do some math calculations.

Last edited by Dwargh : 03-05-10 at 09:07 AM.

03-05-10, 01:11 AM
SkunkWerks A Fallenroot Satyr Forum posts: 21 File comments: 241 Uploads: 2	My heart leapt... ...for I thought the cause of my disharmonious UI displacement was finally addressed! And then I realized you said 'horizontal'. I'ma go cry now.

03-04-10, 06:12 PM
seebs Premium Member Forum posts: 158 File comments: 185 Uploads: 5	THANK YOU SO MUCH!!!!! ... I promised myself I wouldn't cry. My hunter, my other hunter, my frost mage, and my warlock? They're weeping tears of joy.

Report this File

Category Jump: