Download
(5 Kb)
Download
Updated: 07-23-11 06:09 PM
Pictures
File Info
Updated:07-23-11 06:09 PM
Created:10-23-10 01:08 AM
Downloads:4,556
Favorites:31
MD5:
bBuffBars
Version: 1.7
by: Blt [More]
A set of basic buff bars using SecureAuraHeaderTemplates, so it is possible to click off buffs.

This, is something I coded for my own personally use and as such, there are only some very basic configuration options in the lua file. However, most users with very basic lua skills (or who are willing to experiment) should be able to configure this how they please without any issues.

Unfortunately, as Blizzard has been dragging their feet finalizing the template there are a few bugs that are out of my hands. Both sorting, and temporary enchants are buggy. Until Blizzard fixes their typos, and adds better support this is unfortunately what you get.

This includes support for poisons on throwing weapons. Looking through blizzard's code they specifically work with the first two slots, but not the third. So if anyone can find actual proof that it's possible using the SecureTemplate, and that they can be clicked off in combat feel free to pass that along to me.

**As of v1.2 I have added a variable named "updateFrequency" to the options at the top of the lua file which defaults to 0.1. Lowering the value will make the bar empty more smoothly if you are really bothered by the default. Alternatively, you can also raise the value to lower CPU usage at the cost of the bar emptying in chunks if you (like me) don't mind that.**

**v1.6 will throw off the positioning values from previous versions . To be able to use your old values you can type "/script print(GetCVar("uiScale"))" into your chat box and then multiply your old value of barScale by the number outputted by the script. This will make it look exactly like it did before.**

Thanks to sigg for his post. I was being lazy and delaying my dig into Blizzard's code until they had fixed all the bugs, but his post did all the hard work for me in that regard so I decided to update.
Oh and Shadowed, for which I first based my buff bars on a very long time ago.
v1.7
-Added workaround to fix odd behavior with temporary weapon enchants.
-Fixed tool tip for offhand weapon.
-Slight cleanup of code.

Turns out UNIT_AURA acts very strangle when it comes to temporary weapon enchants. The event is fired under 95% of circumstances with shaman, and never for rogues.

v1.6
-Added code to turn off separation of buffs. However, looking at Blizzard's code it still looks broken, and doesn't work for me.
-Rewrote weapon enchant code. Should now support throwing weapon buff as soon as blizzard adds support for it.
-Fixed bars not hiding when alt+z is hit.
-Minor optimizations and restructuring for possible future features.

Blizzard has half fixed being able to click of weapon buffs! You can now click off your mainhand buff. Unfortunately trying to click the offhand buff removes the mainhand buff, and there still isn't any support for throwing weapon buffs.

Still haven't found the time to look into the possibility to abuse consolidated buffs to move buffs with a 0 duration.

v1.5
-Thanks to Ailae for pointing out a super embarrassing error. Performance won't suck in a party or raid now.

v1.4
-Fixed really stupid error caused by the rewrite where I wasn't passing the filter type properly so debuffs were receiving buff timers.

v1.3
-Rewrote how the auras are updated resulting in a 30-50% performance improvement, and 0 CPU usage with no buffs that require animation.

v1.2
-Fixed ghost timers that could ocassionally appear on buffs with no duration
-Fixed counter issue causing performance issue and optimized a bit. New option "updateFrequency" added. Defaulted to 0.1, lower the number for smoother animation, raise it to lower CPU time at the cost of choppy animation.

v1.1
-Added additional variables to let people anchor debuffs to buffs if they want to.
-Fixed texture path from internal location and added border texture to archive.
-Fixed really, really dumb anchoring issue.
Optional Files (0)


Archived Files (3)
File Name
Version
Size
Author
Date
1.6
5kB
Blt
11-17-10 02:59 PM
1.5
5kB
Blt
10-24-10 09:04 PM
1.4
5kB
Blt
10-24-10 04:22 PM


Post A Reply Comment Options
Unread 12-03-11, 03:30 AM  
Dhaern
A Kobold Labourer

Forum posts: 0
File comments: 61
Uploads: 0
Hi, any plans for update 4.3? We need you!
Dhaern is offline Report comment to moderator  
Reply With Quote
Unread 07-23-11, 10:03 PM  
Politig
A Chromatic Dragonspawn
AddOn Compiler - Click to view compilations

Forum posts: 164
File comments: 419
Uploads: 1
Can the debuffs be colored based on debuff type?

For example, curses have a purple bar, poisons have a green bar, etc.
Politig is offline Report comment to moderator  
Reply With Quote
Unread 07-23-11, 08:38 PM  
Blt
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 24
Uploads: 2
Originally posted by Barjack
Blt, I uploaded my edited version with various bugfixes you may be interested in today. I also sent you a private message with details of the changes since a simple diff is very daunting should you wish to backport any of the changes I made.
Thanks again. I'll go through you changes over the next little while and see what ideas can be backported. By the looks of things there will be something helpful in there.



As for EBB being able to click off buffs. I'm nearly positive EBB only lets you cancel buffs off out of combat, and doesn't use any secure code. The problem would be trivial if that were case with this addon.
Blt is offline Report comment to moderator  
Reply With Quote
Unread 07-23-11, 08:01 PM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
Blt, I uploaded my edited version with various bugfixes you may be interested in today. I also sent you a private message with details of the changes since a simple diff is very daunting should you wish to backport any of the changes I made.
Barjack is offline Report comment to moderator  
Reply With Quote
Unread 07-23-11, 06:35 PM  
thebigmunch
A Deviate Faerie Dragon

Forum posts: 15
File comments: 11
Uploads: 1
ElkBuffBars seems to support clicking off enchants on thrown weapons. Don't think it's what you're looking for, but maybe it'll help.

However, KBF, which is more like this addon in implementation suffers the same issues stemming from Blizzard code.

If I thought I would have the time, I'd try to find a solution as well. But gonna be pretty busy for awhile.

Good luck.

PS Quite a bit of Blizzard's code is ridiculous. : O
Last edited by thebigmunch : 07-23-11 at 06:41 PM.
thebigmunch is offline Report comment to moderator  
Reply With Quote
Unread 07-23-11, 11:55 AM  
Blt
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 24
Uploads: 2
Yeah sorry about that, I didn't do enough testing (basically any), and forgot doing that would cause taint errors during combat. The solution is much easier now that I have spent some time looking at it.

Delete those two lines, and instead open up bAuraButtonTemplate.xml and edit the high/width values in there to match the ones in bBuffBars.lua. I'll release a version with a note about this, as well as a few other small fixes later today. I plan on getting around to the weapon enchants too, but I don't want to make promises.

Edit: Ok, I downloaded the latest code from blizzard to look figure out why my current 'future proofed' implementation doesn't work for throwing weapons. There is specific, clear as day, handling for mainhand and offhand, but it completely ignores the third slot. So my question to everyone is: Does anyone actually know of ANY buff mod that has them working that IS NOT just reskinning the default buff frames and actually uses the secure template so you can click them off?
I really don't believe it's possible at this time. Which is ridiculous.

Edit2: I fixed issue with the timers not appearing right away. However, the issue with weapon buffs not appearing right away is much more strange. Almost a shaman vs rogue issue, but not quite.
When you put a temporary enchant on as a shaman it triggers the event UNIT_AURA 95% of the time. There doesn't seem to be any pattern to why it sometimes doesn't, just that it only seem to happen more with frostbrand/rockbiter, and nearly never the others.
However, with a rogue it doesn't ever.

It would be easily fixed if I were to just put an OnUpdate to check to see if temp enchants were updated, but i'd rather not have to do that. Going to investigate to see if I can find a more efficient way of doing it than that.
Last edited by Blt : 07-23-11 at 02:06 PM.
Blt is offline Report comment to moderator  
Reply With Quote
Unread 07-10-11, 04:55 PM  
Lunasea01
A Kobold Labourer

Forum posts: 0
File comments: 10
Uploads: 0
Thanks for that update. Those two lines fixed it perfectly and now the bars display properly when I adjust the size.


As for the temporary enchant there is two issues, but I've grown used to it so it's not a tremendous deal.

One is I mentioned, if I put poisons on my weapons, the bars move down and make just a blank space. However after a few seconds, or if another buff is applied (doesn't have to be a temp) then they just appear.

The other issue mentioned is still happening where you can't click off the temp enchants for your Offhand, only main.

Another quirky issue too, was if I apply poisons to my offhand before my main hand, it sill display the same buff for both temporary enchants. I clicked off the mainhand, reapplied it, and still said the offhand's buff (offhand was deadly poison, main was instant). Hovering over the buff shows the tooltip for the weapon and the weapon has instant on it, but the buff says deadly, and even showed the icon for the offhand. A /reload cleared the issue up, but I don't know if that might be tied to the same issues causing them to not display properly when first applied. This particular issue can be replicated easily, but like I said, only appears when I apply my offhand before my main hand. (Which isn't too often, and not a bug I really care much about, but if it could be tied to other issues then it might be worth noting).

Either way, with it's current state now displaying properly, i could live with it like this forever, so thank you!


EDIT: Another note, it doesn't display at all the poison applied to my throwing weapon. Don't know if this is something that could ever be added (if it's easy to even add?)


EDIT 2.0: Ok, so those lines of code didn't fix it 100%. This is strange. The first 4 buffs display fine, the next 4 the icon is still in the old position, the next 4 after that display fine.
Last edited by Lunasea01 : 07-10-11 at 08:54 PM.
Lunasea01 is offline Report comment to moderator  
Reply With Quote
Unread 07-09-11, 01:13 PM  
Blt
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 24
Uploads: 2
I've been busy lately so I haven't had time to look into the temporary enchant stuff.
If it's not obvious from the screenshot I play a shaman, and I didn't really notice anything wrong with it over the past while. Not until I checked the comments when I decided I should probably update the few addons I use that aren't my own. I guess I don't normally click off imbues though...

Anyways, someone had sent a message about a possible patch to fix something about the temporary enchants (Though before 4.2), but hasn't gotten back to me with it yet. If it doesn't happen soon I'll update my dev environment and start picking through code again I guess.


As for the icons not moving when you resize the bar... unless I am somehow misremembering how I have it coded it shouldn't do that. I'll look into reproducing and getting a fix. I'll probably edit this post later on.

Edit: Ok, slightly silly error there, but the fix does more than just helping with the icon position so it's good you caught that.

Go down to the top of the createBar function at line 219 and add:
Code:
   button:SetWidth(barWidth)
   button:SetHeight(barHeight)
I think I'll wait to fix other things before releasing an official update though.
Last edited by Blt : 07-09-11 at 01:35 PM.
Blt is offline Report comment to moderator  
Reply With Quote
Unread 07-01-11, 08:25 PM  
Lunasea01
A Kobold Labourer

Forum posts: 0
File comments: 10
Uploads: 0
TEnch Buffs

Hey,

I love the addon, perfect for everything I need it for and amazingly lightweight. Up until 4.2 I haven't had any issues but after 4.2 the issue I've been having is with TEnch buffs (more specifically, poisons on weapons and shammy weapon enhancements).

When I buff my items, the buff bar moves down as tho the bars appeared, but the space is blank. If I do a /reload, or if a debuff appears, then they instantly appear.

Do you know what could be causing this or what can be done to fix it?

Thank you!


PS. Also just noticed another bug. If I increase the width of my bars from 200 to 250, I notice that the icon for the buffs/debuffs stays in the same location behind the bars. I'm terrible at LUA, and where is the value I need to modify to fix that?
Last edited by Lunasea01 : 07-04-11 at 11:49 AM.
Lunasea01 is offline Report comment to moderator  
Reply With Quote
Unread 06-24-11, 06:30 PM  
Blt
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 24
Uploads: 2
Hey, a large portion of the reason I wasn't posting is because I haven't noticed anything broken with my UI and haven't been in the mood to add any features to anything.

One way or another I will try to get what I missed worked on in the next little while.


As for the whole debuff thing. Unless you mean separating out specific buffs or debuffs, the addons does that.
If you do mean that, then I am sorry that isn't going to make it into this addon. Considering that's something that you can almost do in one line of code if you are really ugly about it, I tend to just write an addon for that on a case by case basis for myself. No sense adding a bunch of cruft to this one.
Blt is offline Report comment to moderator  
Reply With Quote
Unread 05-16-11, 03:37 PM  
Mayron
A Chromatic Dragonspawn
 
Mayron's Avatar
AddOn Author - Click to view AddOns

Forum posts: 162
File comments: 883
Uploads: 5
How do you make the opacity of the buff bars 100%? for some reason The bars are very transparent even with the alpha on 1. Please help!
Mayron is offline Report comment to moderator  
Reply With Quote
Unread 03-07-11, 07:28 PM  
thebigmunch
A Deviate Faerie Dragon

Forum posts: 15
File comments: 11
Uploads: 1
If you're talking about debuffs on the player, then these cover that. If you're talking about timer bars like Classtimer et al, which rightly tend to cover more than target debuffs, there are a number of minimal addons that do this already including Filger and rFilter3.
thebigmunch is offline Report comment to moderator  
Reply With Quote
Unread 03-07-11, 01:07 AM  
Siannus
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 72
Uploads: 2
Love it, love it, love it! Now then, when are you going to make a DEbuffbars? Get that and Ill be done with my UI and can get rid of a couple bloated addons.
Siannus is offline Report comment to moderator  
Reply With Quote
Unread 02-26-11, 03:55 PM  
thebigmunch
A Deviate Faerie Dragon

Forum posts: 15
File comments: 11
Uploads: 1
Anchor and other settings are at the top of the lua file for editing. If you're not comfortable doing so, you're out of luck with this addon. As for someone updating a buff bar addon, the author hasn't had any activity on his account since December 15th, so I wouldn't say it's really being updated.
thebigmunch is offline Report comment to moderator  
Reply With Quote
Unread 02-18-11, 03:30 AM  
Aranda
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 2
Uploads: 1
method to move the buff bars?

I'm thrilled that someone is updating a buff bar with buff-names that can actually be right-clicked. However, on my screen it's running right into my actionbars and such.

Is there any way to move the anchor? Any chance for an update that allows moving the anchor?
Aranda is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: