World of Warcraft AddOns » Optional » Plug-Ins & Patches » Faceroller
  • Addon Info.
  • Change Log
  • Other Files (3)
  • Comments (27)
    • Download
    (102 Kb)
    Download
    Updated: 02-13-11 01:06 PM
    Patch for:
    Faceroller.
    Pictures
    File Info
    Updated:02-13-11 01:06 PM
    Created:10-29-10 11:25 AM
    Downloads:16,059
    Favorites:50
    MD5:
    Faceroller  Popular! (More than 5000 hits)
    Version: 1.2.1
    by: decipherable [More]
    This is a patch for the current version of Faceroller making it patch 4.0.1 compliant. You need to have Faceroller before you may apply the patch.

    Notes:
    1.2.1 - Added updated module for Hunters shot priority. Needs testing.
    Updated a few spells IDs.
    Added suggested changes by Ardente.
    Archived Files (3)
    File Name
    Version
    Size
    Author
    Date
     Faceroller
    1.2
    99kB
    decipherable
    02-13-11 11:38 AM
     Faceroller
    1.1
    99kB
    decipherable
    01-15-11 10:38 PM
     Faceroller
    1.0.1
    99kB
    decipherable
    11-03-10 01:26 PM


    Post A Reply Comment Options
    Page 2 of 2 < 1 2
    Old 01-12-11, 03:45 AM  
    incognitoo
    A Kobold Labourer

    Forum posts: 0
    File comments: 11
    Uploads: 0
    Re: me also
    Originally posted by ironlung111
    I also can't get any modules to work. I installed faceroller downloaded the patch copied the contents of the patch into faceroller folder replacing old files. If i did anything wrong let me know and what i need to do to update correctly.
    Its clearly not working, hence the neglectance of the author
    incognitoo is offline Report comment to moderator  
    Reply With Quote
    Old 01-10-11, 10:05 AM  
    ironlung111
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    me also
    I also can't get any modules to work. I installed faceroller downloaded the patch copied the contents of the patch into faceroller folder replacing old files. If i did anything wrong let me know and what i need to do to update correctly.
    ironlung111 is offline Report comment to moderator  
    Reply With Quote
    Old 01-06-11, 03:42 AM  
    incognitoo
    A Kobold Labourer

    Forum posts: 0
    File comments: 11
    Uploads: 0
    Re: Re: Modules
    Originally posted by decipherable
    Are these updated modules for 4.0.x?
    same for me, and yes they are.. im using the fury warrior module and keep on getting the msg that theres no module for that
    incognitoo is offline Report comment to moderator  
    Reply With Quote
    Old 12-07-10, 01:33 PM  
    decipherable
    A Kobold Labourer
    AddOn Author - Click to view AddOns

    Forum posts: 0
    File comments: 13
    Uploads: 2
    Re: Modules
    Originally posted by 4word
    None of my modules load in game, even the default ones. Is there anything i need to change in order to get them to load?
    Are these updated modules for 4.0.x?
    decipherable is offline Report comment to moderator  
    Reply With Quote
    Old 12-03-10, 04:00 PM  
    4word
    A Kobold Labourer

    Forum posts: 0
    File comments: 1
    Uploads: 0
    Modules
    None of my modules load in game, even the default ones. Is there anything i need to change in order to get them to load?
    4word is offline Report comment to moderator  
    Reply With Quote
    Old 11-28-10, 11:42 AM  
    decipherable
    A Kobold Labourer
    AddOn Author - Click to view AddOns

    Forum posts: 0
    File comments: 13
    Uploads: 2
    I think I actually added the Hunter part on my local and forgot to push an update. Thanks.

    I'll push these updates up today.


    Originally posted by ardente
    More fixes
    Code:
    Index: D:/work/wow/Faceroller/trunk/Faceroller.lua
===================================================================
--- D:/work/wow/Faceroller/trunk/Faceroller.lua	(revision 17)
+++ D:/work/wow/Faceroller/trunk/Faceroller.lua	(working copy)
@@ -145,7 +145,8 @@
     if playerClass == "WARRIOR"
             or playerClass == "DEATHKNIGHT"
             or playerClass == "DRUID"
-            or playerClass == "ROGUE" then
+            or playerClass == "ROGUE"
+            or playerClass == "HUNTER" then
         powerUpdate = 1
     end
 end
@@ -511,10 +512,6 @@
     last_update = 0
 
     if FacerollerDB.powercheck == 1 and last_spell ~= 0 then
-        if last_spell == 0 then
-            return
-        end
-
         local x = IsUsableSpell(gsi_mt[last_spell])
 
         if x ~= last_usablecheck then
@@ -528,10 +525,6 @@
     end
 
     if FacerollerDB.rangecheck == 1 and last_spell ~= 0 then
-        if last_spell == 0 then
-            return
-        end
-
         local x = IsSpellInRange(gsi_mt[last_spell], "target")
 
         if x ~= last_rangecheck then
@@ -802,9 +795,11 @@
 -- false otherwise.
 --
 function Faceroller:HasGlyph(spellid)
-    for i = 1, 6 do
-        local _, _, g = GetGlyphSocketInfo(i)
-        if g == spellid then
+    local talentGroup = GetActiveTalentGroup()
+
+    for i = 1, NUM_GLYPH_SLOTS do
+        local enabled, _, _, g = GetGlyphSocketInfo(i, talentGroup)
+        if enabled and (g == spellid) then
             return true
         end
     end
@@ -1705,8 +1700,7 @@
     }
 
     for _, lspell in pairs(referenceSpells) do
-        local x = self:HasSpell(lspell)
-        if x ~= nil then
+        if self:HasSpell(lspell) then
             gcdSpell = lspell
             break
         end
    decipherable is offline Report comment to moderator  
    Reply With Quote
    Old 11-26-10, 05:10 AM  
    ardente
    A Kobold Labourer

    Forum posts: 0
    File comments: 13
    Uploads: 0
    More fixes
    Code:
    Index: D:/work/wow/Faceroller/trunk/Faceroller.lua
===================================================================
--- D:/work/wow/Faceroller/trunk/Faceroller.lua	(revision 17)
+++ D:/work/wow/Faceroller/trunk/Faceroller.lua	(working copy)
@@ -145,7 +145,8 @@
     if playerClass == "WARRIOR"
             or playerClass == "DEATHKNIGHT"
             or playerClass == "DRUID"
-            or playerClass == "ROGUE" then
+            or playerClass == "ROGUE"
+            or playerClass == "HUNTER" then
         powerUpdate = 1
     end
 end
@@ -511,10 +512,6 @@
     last_update = 0
 
     if FacerollerDB.powercheck == 1 and last_spell ~= 0 then
-        if last_spell == 0 then
-            return
-        end
-
         local x = IsUsableSpell(gsi_mt[last_spell])
 
         if x ~= last_usablecheck then
@@ -528,10 +525,6 @@
     end
 
     if FacerollerDB.rangecheck == 1 and last_spell ~= 0 then
-        if last_spell == 0 then
-            return
-        end
-
         local x = IsSpellInRange(gsi_mt[last_spell], "target")
 
         if x ~= last_rangecheck then
@@ -802,9 +795,11 @@
 -- false otherwise.
 --
 function Faceroller:HasGlyph(spellid)
-    for i = 1, 6 do
-        local _, _, g = GetGlyphSocketInfo(i)
-        if g == spellid then
+    local talentGroup = GetActiveTalentGroup()
+
+    for i = 1, NUM_GLYPH_SLOTS do
+        local enabled, _, _, g = GetGlyphSocketInfo(i, talentGroup)
+        if enabled and (g == spellid) then
             return true
         end
     end
@@ -1705,8 +1700,7 @@
     }
 
     for _, lspell in pairs(referenceSpells) do
-        local x = self:HasSpell(lspell)
-        if x ~= nil then
+        if self:HasSpell(lspell) then
             gcdSpell = lspell
             break
         end
    Last edited by ardente : 11-26-10 at 05:10 AM.
    ardente is offline Report comment to moderator  
    Reply With Quote
    Old 11-03-10, 01:27 PM  
    decipherable
    A Kobold Labourer
    AddOn Author - Click to view AddOns

    Forum posts: 0
    File comments: 13
    Uploads: 2
    Re: Re: Re: Patch or Complete Mod?
    Originally posted by Pigiron
    Good to know. I only brought it up because I tried applying the "patch" over the old version and got alot of errors when I ran it.

    Loving the addon, by the way. Thank you for updating it.
    Thanks for bringing this to my attention. I went ahead and put the proper version of the patch up with only the patched files.
    decipherable is offline Report comment to moderator  
    Reply With Quote
    Old 11-03-10, 12:26 AM  
    Pigiron
    A Kobold Labourer
     
    Pigiron's Avatar

    Forum posts: 0
    File comments: 18
    Uploads: 0
    Re: Re: Patch or Complete Mod?
    Good to know. I only brought it up because I tried applying the "patch" over the old version and got alot of errors when I ran it.

    Loving the addon, by the way. Thank you for updating it.
    Pigiron is offline Report comment to moderator  
    Reply With Quote
    Old 11-02-10, 11:01 PM  
    decipherable
    A Kobold Labourer
    AddOn Author - Click to view AddOns

    Forum posts: 0
    File comments: 13
    Uploads: 2
    Re: Patch or Complete Mod?
    Originally posted by Pigiron
    This is being called a patch. There seem to be the same number and types of files in this folder as there are in the original addon. Isn't this rather an updated addon in and of itself?
    That was solely by accident and I just never corrected it by uploading a new file with only the faceroller.lua and the gui.lua files updated.
    decipherable is offline Report comment to moderator  
    Reply With Quote
    Old 11-02-10, 09:27 PM  
    Pigiron
    A Kobold Labourer
     
    Pigiron's Avatar

    Forum posts: 0
    File comments: 18
    Uploads: 0
    Patch or Complete Mod?
    This is being called a patch. There seem to be the same number and types of files in this folder as there are in the original addon. Isn't this rather an updated addon in and of itself?
    Pigiron is offline Report comment to moderator  
    Reply With Quote
    Old 10-29-10, 08:06 PM  
    Xylan Trueheart
    Premium Member
    Premium Member

    Forum posts: 58
    File comments: 158
    Uploads: 0
    A first step
    This is a first step in the right direction in getting part of this addon working again.

    However as I mentioned in the original Faceroller page more more has to be done in the individual modules themselves as spells and talents have changed, in my case my Destruction Warlock.

    I post the error as I logged in my Warlock if anyone is able or wants to correct the Destro warlock module.

    1x Faceroller-1.0\Faceroller.lua:981: table index is nil
    ...DestructionWarlock\Faceroller_DestructionWarlock.lua:40: in function `init_func':
    Faceroller-1.0\Faceroller.lua:1341: in function `UseModule'
    Faceroller-1.0\Faceroller.lua:1244: in function `UseModuleForSpec'
    Faceroller-1.0\Faceroller.lua:1720: in function `?'
    Faceroller-1.0\Faceroller.lua:43: in function <Faceroller\Faceroller.lua:42>

    Locals:
    spells = <table> {
    603 = 0
    17962 = 0
    50796 = 0
    }
    CONFLAG = 17962
    CHAOS = 50796
    DOOM = 603
    Faceroller = <unnamed> {
    0 = <userdata>
    CornerIndicatorSetColor = <function> @ Faceroller\Faceroller.lua:853:
    HasGlyph = <function> @ Faceroller\Faceroller.lua:804:
    SPELL_UPDATE_COOLDOWN = <function> @ Faceroller\Faceroller.lua:1591:
    setMod = <function> @ Faceroller\Faceroller.lua:272:
    RegisterBuff = <function> @ Faceroller\Faceroller.lua:910:
    SetSpells = <function> @ Faceroller\Faceroller.lua:1162:
    modules = <table> {}
    GetSetItemSlotItems = <function> @ Faceroller\Faceroller.lua:841:
    DisplayFrame = Faceroller_df_Button {}
    SKILL_LINES_CHANGED = <function> @ Faceroller\Faceroller.lua:1688:
    RegisterDebuff = <function> @ Faceroller\Faceroller.lua:959:
    PARTY_MEMBERS_CHANGED = <function> @ Faceroller\Faceroller.lua:1576:
    UNIT_SPELLCAST_SENT = <function> @ Faceroller\Faceroller.lua:1610:
    ModuleOption = <function> @ Faceroller\Faceroller.lua:302:
    SPELL_UPDATE_USABLE = <function> @ Faceroller\Faceroller.lua:1600:
    setScale = <function> @ Faceroller\Faceroller.lua:282:
    LockUnlock = <function> @ Faceroller\Faceroller.lua:257:
    UNIT_SPELLCAST_SUCCEEDED = <function> @ Faceroller\Faceroller.lua:1622:
    RegisterGUI = <function> @ Faceroller\Faceroller.lua:163:
    spec = 2
    updateBuffs = <function> @ Faceroller\Faceroller.lua:178:
    setSkin = <function> @ Faceroller\Faceroller.lua:237:
    in_combat = false
    PLAYER_ENTERING_WORLD = <function> @ Faceroller\Faceroller.lua:1561:
    version = <table> {}
    CallNextSkillFunc = <function> @ Faceroller\Faceroller.lua:556:
    setAnim = <function> @ Faceroller\Faceroller.lua:441:
    UseModuleForSpec = <function> @ Faceroller\Faceroller.lua:1232:
    UNIT_AURA = <function> @ Faceroller\Faceroller.lua:1545:
    DebugOn = <function> @ Faceroller\Faceroller.lua:246:
    setSilent = <function> @ Faceroller\Faceroller.lua:463:
    ShowGUI = <function> @ Faceroller\Faceroller.lua:168:
    ADDON_LOADED = <function> @ Faceroller\Faceroller.lua:1408:
    EasyChooseSpell = <function> @ Faceroller\Faceroller.lua:991:
    RangeCheck = <function> @ Faceroller\Faceroller.lua:415:
    UseModule = <function> @ Faceroller\Faceroller.lua:1253:
    createFrames = <function> @ Faceroller\Faceroller.lua:619:
    PrintVersion = <function> @ Faceroller\Faceroller.lua:232:
    setAlpha = <function> @ Faceroller\Faceroller.lua:320:
    PowerCheck = <function> @ Faceroller\Faceroller.lua:428:
    PLAYER_REGEN_DISABLED = <function> @ Faceroller\Faceroller.lua:1490:
    ResetOptions = <function> @ Faceroller\Faceroller.lua:331:
    PLAYER_REGEN_ENABLED = <function> @ Faceroller\Faceroller.lua:1485:
    Debug = <function> @ Faceroller\Faceroller.lua:205:
    PLAYER_TARGET_CHANGED = <function> @ Faceroller\Faceroller.lua:1495:
    EasyRegister = <function> @ Faceroller\Faceroller.lua:1219:
    ListModules = <function> @ Faceroller\Faceroller.lua:294:
    UnregisterModule = <function> @ Faceroller\Faceroller.lua:1206:
    PrintHelp = <function> @ Faceroller\Faceroller.lua:212:
    power = 0
    RegisterModule = <function> @ Faceroller\Faceroller.lua:1187:
    EasySetup = <function>
    ---
    Xylan Trueheart is online now Report comment to moderator  
    Reply With Quote
    Post A Reply
    Page 2 of 2 < 1 2


    Report this file Report this File

    Category Jump: