Download
(1 Kb)
Download
Updated: 12-08-10 12:17 PM
Pictures
File Info
Updated:12-08-10 12:17 PM
Created:12-07-10 09:57 PM
Downloads:1,039
Favorites:16
MD5:
NoGuildReputationWarning (Obsolete)
Version: 1.1
by: Nephaliana [More]
As there is a weekly cap for earning guild reputation and Blizzard makes sure you are aware of it every time you turn in a quest, this addon was written to reduce the number of warnings you receive.

The first time you receive the message (for each game session), the message is displayed as normal. However, any future times the message would show up, the message is automatically hidden so you don't see the warning.

(So yes, technically "NoGuildReputationWarning" is incorrect, as it really is "SingleGuildReputationWarning", but meh...)

UPDATE: Supposedly a hotfix Blizzard did in the last couple days has made this addon unnecessary. "After hitting the weekly guild reputation cap, players will no longer receive the message that they're at the cap every time a quest is turned in."
Change Log
==========
1.1
- Updated string matching to use Blizzard's variable rather than a set string (should make this locale independent)

1.0
- Initial Release
==========
Post A Reply Comment Options
Old 12-10-10, 05:56 AM  
Nephaliana
A Kobold Labourer
 
Nephaliana's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 23
Uploads: 11
Originally posted by Nathanyel
Yes it does, but does the addon reset the warningShown variable weekly?

(I could have tried saving when the warning was last shown, calculating if it was the current week or a previous one, and storing a flag in the saved variables, allowing the warning to only display the first time it happens each week and not the first time each session, but if you want to talk about bloat....)
It isn't worth the effort to make it store across sessions to reset once a week - not for a small addon like this.
Nephaliana is offline Report comment to moderator  
Reply With Quote
Old 12-10-10, 05:48 AM  
Nathanyel
Premium Member
 
Nathanyel's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 152
Uploads: 10
Originally posted by Nephaliana
Bloated... it's 575 bytes in memory, which is probably smaller than 99.9% of the addons on WoWInterface.
Of course, but it could be reduced to way less :P

And doesn't reset weekly? I know it doesn't reset daily (just tested by doing one quest after the daily reset), so going by the text of the warning, I say it does reset weekly.
Yes it does, but does the addon reset the warningShown variable weekly?
*edit* Ah wait, I just realized it doesn't save between sessions anyway So it always shows the first time during a session, that's ok I'd say.
Last edited by Nathanyel : 12-10-10 at 05:51 AM.
Nathanyel is offline Report comment to moderator  
Reply With Quote
Old 12-10-10, 05:28 AM  
Nephaliana
A Kobold Labourer
 
Nephaliana's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 23
Uploads: 11
Originally posted by Nathanyel
However, I find your code kinda bloated, why show the message the first time when this doesn't reset weekly?
Bloated... it's 575 bytes in memory, which is probably smaller than 99.9% of the addons on WoWInterface. And doesn't reset weekly? I know it doesn't reset daily (just tested by doing one quest after the daily reset), so going by the text of the warning, I say it does reset weekly.

Anyway, I left it showing the message the first time so you know the limit is reached. Imagine someone is questing along (earning guild rep) and in the middle of their session they cap out. If the message was always hidden, they wouldn't necessarily notice the cap was reached. I know I don't often pay attention to reputation gains so I may not realize I have stopped getting guild rep. With the warning shown once, you know the limit is reached, and can do what you want with that information. (I could have tried saving when the warning was last shown, calculating if it was the current week or a previous one, and storing a flag in the saved variables, allowing the warning to only display the first time it happens each week and not the first time each session, but if you want to talk about bloat....)

Did I have to leave it showing the first time? No. Was it a good idea? Maybe, maybe not. Is once per session better than every quest? Definitely.

If you (or anyone else) wants to not see the warning ever and save a few bytes of memory (185 of them dropping total to 390 bytes), delete or comment out line 15 of NoGuildRepWarning.lua and replace the last function (lines 33 through 51) with the following:

Code:
function NoGuildRepWarning_ChatEvent(self, event, msg, ...)
	return (string.find(msg, GUILD_REP_WEEKLY_CAPPED)), false, ...
end
Last edited by Nephaliana : 12-10-10 at 05:33 AM.
Nephaliana is offline Report comment to moderator  
Reply With Quote
Old 12-10-10, 03:28 AM  
Nathanyel
Premium Member
 
Nathanyel's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 152
Uploads: 10
I just started to extract the fix I had in one of my private addons to its own when I stumbled upon this, damn you beat me to it (by two days *whistle*)

However, I find your code kinda bloated, why show the message the first time when this doesn't reset weekly?
Last edited by Nathanyel : 12-10-10 at 03:30 AM.
Nathanyel is offline Report comment to moderator  
Reply With Quote
Old 12-08-10, 04:49 PM  
F1NCH
A Kobold Labourer
 
F1NCH's Avatar

Forum posts: 0
File comments: 44
Uploads: 0
THX for update, works fine
F1NCH is offline Report comment to moderator  
Reply With Quote
Old 12-08-10, 12:30 PM  
Nephaliana
A Kobold Labourer
 
Nephaliana's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 23
Uploads: 11
Locale independence

Originally posted by F1NCH
For German Version you have to change this
I finally found the variable Blizzard used to store the string (it wasn't declared where I thought it would be in GlobalStrings.lua). I updated the addon to version 1.1 and replaced the set string with Blizzard's variable, which should (I hope) make this locale independent.

If for some reason this 1.1 version still doesn't work for other locales without modification, the same fix F1NCH posted will continue to work (for the German client, but similar edits would work for other locales).
Nephaliana is offline Report comment to moderator  
Reply With Quote
Old 12-08-10, 11:18 AM  
F1NCH
A Kobold Labourer
 
F1NCH's Avatar

Forum posts: 0
File comments: 44
Uploads: 0
Great Addon

For German Version you have to change this / Für die Deutsche Version muss man das hier
Code:
local start = string.find(msg, "You have gained the maximum amount of guild reputation allowed this week.")
	--print("NGRW: "..msg)
	--print("NGRW: You have gained the maximum amount of guild reputation allowed this week.")
by that / mit dem hier ersetzen
Code:
local start = string.find(msg, "Ihr habt den maximal erreichbaren Gildenruf in dieser Woche erlangt.")
	--print("NGRW: "..msg)
	--print("NGRW: Ihr habt den maximal erreichbaren Gildenruf in dieser Woche erlangt.")
F1NCH is offline Report comment to moderator  
Reply With Quote
Old 12-07-10, 11:52 PM  
Sojik
A Wyrmkin Dreamwalker
 
Sojik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 53
File comments: 168
Uploads: 11
After the third time getting this warning I knew there would be an addon and I knew I would download and install said addon to put an end to said warning. My chat frame wraps the warning to a second line so it's twice as annoying. Thank you.
Last edited by Sojik : 12-07-10 at 11:53 PM.
Sojik is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: