Download
(11 Kb)
Download
Updated: 12-03-11 03:44 PM
Pictures
File Info
Updated:12-03-11 03:44 PM
Created:07-23-11 07:59 PM
Downloads:1,853
Favorites:6
MD5:
bBuffBars Barjack
Version: 0.25experimental
by: Barjack [More]
ATTENTION

This addon contains no in-game configuration and is instead configured by editing values in the Lua files. If you are not comfortable doing this and require in-game configuration, this addon may not be for you. There are no current plans to add any in-game configuration.


Description

This addon is a fork (with permission) of bBuffBars by blt. It contains (currently) a few bug fixes for edge cases, as well as some visual changes, such as different colours for different types/durations of buffs/debuffs, custom highlighting and custom stack counts. All credit for the original code and addon goes to blt, this version simply contains my own personal edits for my own UI.
0.25experimental

- Fixes and work-arounds for ranged weapon temporary enchantments
- Ranged enchant timers no longer cause errors, but do not update immediately (until another buff or enchant updates). This is due a bug in Blizzard's code.

0.24experimental

- Ugly, memory-wasting workaround for Blizzard's bug that occurs when using weapon enchants in 4.3. If you don't play character that use weapon enchants, or can simply deal with turning weapon enchants off, please use 0.23.

0.23

- TOC updated to 4.3
- Extremely minor fix for icon borders
Optional Files (0)


Archived Files (3)
File Name
Version
Size
Author
Date
0.24experimenta
11kB
Barjack
12-03-11 02:13 PM
0.23
10kB
Barjack
12-03-11 12:07 PM
0.2
10kB
Barjack
07-23-11 07:59 PM


Post A Reply Comment Options
Old 04-29-12, 09:34 PM  
rach3l
A Kobold Labourer

Forum posts: 1
File comments: 11
Uploads: 0
I just want to thank you for tweaking what was a great mod into a PERFECT mod. I think bbuffbars is, bar none (heh), the best bar mod since Cata came out. It's been a very well-kept secret, but I couldn't live without it. Your tweaks make it even BETTER, though. Many, many thanks to both you and the original author!
rach3l is offline Report comment to moderator  
Reply With Quote
Old 01-11-12, 01:58 PM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
Originally Posted by Fae
You named that the main reason for SecureAuraHeaderTemplates is to be able to click-off auras in combat. Which is awesome for buffs, but void for debuffs as we can't remove those anyway. So is there any other reason to actually use SecureAuraHeaderTemplates for debuffs?
Yeah, in fact since there are no cancelable debuffs (to my knowledge) there is no actual advantage from a functionality standpoint to using SecureAuraHeaderTemplate for debuffs. However, from a development standpoint, once you write an addon that uses SecureAuraHeaderTemplate to support buffs, supporting debuffs is very easy since it uses the exact same infrastructure. All of the events, hooks, frame code, etc. is the same.

To ditch the SecureAuraHeaderTemplate debuff header and create those frames with manual scanning etc. would certainly be possible, and would allow the addition of blacklists or whitelists or whatever. The problem is that very little (complete guess: maybe 10 to 20%) of the code currently in bBuffBars would be reusable for this purpose, compared to the current situation of debuffs reusing 90%+ of the buff code. So essentially it would just be coding a classic-style uncancelable buff/debuff addon with all its own event code, frame code, etc. and tacking it on to the end of the current addon with very little interaction.

Functionality-wise, it's a clearly winning idea since the shackles on SecureAuraHeaderTemplate don't win us anything when it comes to debuffs. However from a practical standpoint, it's much more difficult and basically boils down to starting from scratch since so little of the current code can be used in the non-secure alternative. So while it's certainly possible, it's probably outside the scope of what I personally want to do with this addon given that I don't have a burning need for this kind of thing myself.
Barjack is offline Report comment to moderator  
Reply With Quote
Old 01-11-12, 12:34 PM  
Fae
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Thanks a lot for fast reply with so much in-deep info.

It's sad that we can't do much with SecureAuraHeaderTemplates. But the question is - do we even need to use it for debuffs?

You named that the main reason for SecureAuraHeaderTemplates is to be able to click-off auras in combat. Which is awesome for buffs, but void for debuffs as we can't remove those anyway. So is there any other reason to actually use SecureAuraHeaderTemplates for debuffs?

Would not it be possible to just do debuffs "the other way" like other addons and add features like filtering? Or is there any issue that makes it undesirable?

I admit that I don't know much about this stuff, but I can imagine that with the "other method" you may need to for example scan auras manually. Which kinda goes against the lightweight philosophy of bBuffBars, doesn't it?
Fae is offline Report comment to moderator  
Reply With Quote
Old 01-11-12, 06:18 AM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
Originally Posted by Fae
There is one thing I wanted to ask - do you know if it's possible to add filtering (based on buff name/aura ID) while still using SecureAuraHeaderTemplates and it's benefits? I know that SecureAuraHeaderTemplates are a bit restrictive and thats why it's not used by many other addons - that on the other hand allow advanced features such as filtering. This is the only reason why I am still using Elkano's BuffBars for tracking my debuffs. Because unlike buffs, I need to filter those in PvP. But I am not really happy with EBB CPU and memory usage, would enjoy bBuffBars simplicity even for debuffs.
Thanks. Anyway, basically what you're saying is correct. There isn't really any way to do filtering when using SecureAuraHeaderTemplate--we're completely limited to whatever filtering is provided by Blizzard for use with SecureAuraHeaderTemplate and no more. That amounts essentially to changing the sort ordering alone (based only on a few preset criteria), and potentially filtering out buffs that Blizzard considers to be "consolidated" (as in the default UI), which in itself is not changable (nor currently tested/supported in this fork of bBuffBars).

So essentially the situation is that using SecureAuraHeaderTemplate, we have no control of which buffs get buttons on our screen--they all do, always. All that can be done is change their appearance in some way. Currently for instance, to work around the weapon enchant bug, I'm setting some buffs to be almost invisible (0.05 alpha, but 0 is possible too). However, there is no way to actually remove the underlying button, which will remain clickable, or to move it to the end of the list or whatever. All frame positioning is done by Blizzard's code.

So if highlighting and dimming etc. works for your filtering needs, it's doable. If not, it isn't. Unfortunately, that's the lot we've been dealt when using SecureAuraHeaderTemplate, and as you correctly observed, it's resulted in a lot of buff/debuff trackers either having to forego buff canceling entirely, using out-of-combat canceling only, or using some sort of hybrid system with preset lists that create aura cancelling frames at a fixed point.

In any case, as an addon (or addon fork) that submits itself as much as possible, for better or worse, to the SecureAuraHeaderTemplate system, none of those hacks really make a good fit. So to cut a long story short--we're stuck with what we have, and what we have is changing how the bars look--and little if anything else.

I think your current solution, though awkward, is probably the best you're going to be able to get with both completely in-combat-cancelable buffs, and filterable debuffs. This addon specializes in the former, and there are other addons that specialize in the latter. Blizzard doesn't really provide an easy way for a single type of addon to do both since each requires a completely different system to work.
Last edited by Barjack : 01-11-12 at 06:30 AM.
Barjack is offline Report comment to moderator  
Reply With Quote
Old 01-11-12, 02:58 AM  
Fae
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Cheers for maintaining the addon, it saved me a lot of trouble with updating original bBuffBars when it broke after 4.3 release. Everything seems to be working properly now.

I also love your improvements, colored bars are nice.

There is one thing I wanted to ask - do you know if it's possible to add filtering (based on buff name/aura ID) while still using SecureAuraHeaderTemplates and it's benefits? I know that SecureAuraHeaderTemplates are a bit restrictive and thats why it's not used by many other addons - that on the other hand allow advanced features such as filtering. This is the only reason why I am still using Elkano's BuffBars for tracking my debuffs. Because unlike buffs, I need to filter those in PvP. But I am not really happy with EBB CPU and memory usage, would enjoy bBuffBars simplicity even for debuffs.

Naturally, I am not asking for an in-game interface for filtering configuration. Adding spell IDs to an array in Lua code would work just fine.
Fae is offline Report comment to moderator  
Reply With Quote
Old 12-03-11, 03:47 PM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
One more fix in the "experimental" branch related to weapon enchant bugs. Ranged weapon enchantments no longer cause errors in 0.25experimental.

However, again due to bugs in Blizzard's code, ranged weapon enchants being applied or expiring will not cause the buff list to update immediately. Such enchantments will only appear or disappear the next time another buff updates.
Last edited by Barjack : 12-03-11 at 03:47 PM.
Barjack is offline Report comment to moderator  
Reply With Quote
Old 12-03-11, 02:20 PM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
I have uploaded a new version called 0.24experimental. It attempts to implement an ugly work-around for the bug Blizzard created in 4.3 when weapon enchants are shown.

If you don't use weapon buffs or are willing to turn them off, please consider using 0.23 instead as it will use less memory.

As for how it works, if it detects a buff appearing on you twice, or an "invalid" buff, it sets the alpha for the invalid/duplicate buff line to 0.05 (almost invisible). The bar is still there, can still be clicked, etc., as there's nothing I can do about that. But this may reduce the visual clutter caused by the bug.

Note that this fix depends on the order buffs appear in and so forth and may not work depending on your sorting options (though I think it should be okay). As a result, more memory is used since a new table has to be created to check for duplicates each time buffs are updated. Problems may also occur when weapon buffs are manually canceled or expire, though they should not be too severe.
Last edited by Barjack : 12-03-11 at 02:20 PM.
Barjack is offline Report comment to moderator  
Reply With Quote
Old 12-03-11, 01:30 PM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
Okay, after testing on a different character I now see the bug. It's related to weapon enchantments (which is why I didn't notice this problem on my warlock, but just testing now on my rogue, I do).

Now the problem is this seems to actually be a Blizzard bug. Instead of fixing the countless issues and bugs already in their SecureAuraHeader code, they have instead added new ones with patch 4.3.

I found these threads related to the problem:

http://eu.battle.net/wow/en/forum/topic/2868633701#1
http://us.battle.net/wow/en/forum/topic/3580989647
http://us.battle.net/wow/en/forum/topic/3424690010
http://www.tukui.org/forums/topic.php?id=17050

Right now I'm not sure there is any work around, except to disable weapon enchantments from showing on the bar (i.e. set includeWeapons to nil). I will look into the issue some more but for now, I don't know if there is anything I can do since the problem is in Blizzard's protected code that addons can't touch.
Last edited by Barjack : 12-03-11 at 01:33 PM.
Barjack is offline Report comment to moderator  
Reply With Quote
Old 12-03-11, 12:08 PM  
Barjack
A Black Drake
AddOn Author - Click to view AddOns

Forum posts: 80
File comments: 52
Uploads: 6
I just posted an update for 4.3 (may still be pending, check the changelog to see). However, it only contains one very, very small icon border fix (not related to the patch). Other than that, it is only a TOC update. So updating may not be necessary for people who are happy to edit their own TOCs or enable outdated addons.

Of course, if you actually find any bugs since 4.3, let me know. I haven't run into any.
Last edited by Barjack : 12-03-11 at 12:15 PM.
Barjack is offline Report comment to moderator  
Reply With Quote
Old 12-03-11, 02:29 AM  
Dhaern
A Kobold Labourer

Forum posts: 0
File comments: 61
Uploads: 0
Hi, any plans for update 4.3? I need you!
Dhaern is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: