Download
(22 Kb)
Download
Updated: 11-30-11 02:06 AM
Pictures
File Info
Updated:11-30-11 02:06 AM
Created:07-26-11 07:14 AM
Downloads:1,612
Favorites:9
MD5:
Categories:Character Advancement, Outdated Mods
TabardCheck [DISCONTINUED]
Version: 0.2b
by: Nathanyel [More]
4.3 fixed the Molten Front bug, so this addon is not really needed anymore (until a new zone reintroduces the bug)

Old description for posterity:

The Molten Front daily zone, or rather the portal into it, has a nasty bug: whenever you use this portal to enter or leave, you lose the buffs from championing tabards, rendering the tabard inactive until you re-equip that tabard (or equip another one)
This can be annoying if you are still working on Guild reputation by doing the dailies in the Molten Front, or plan to run a dungeon wearing a faction's tabard after the dailies.

This addon monitors these buffs, and attempts to un- and re-equip the respective tabard should you lose their buff.

Known problems:
I say "attempt" above because there can of course be interfering factors: inventory is full, you enter combat immediately after leaving the Molten Front (ganking) etc.
The addon will communicate failures to re-equip after unequipping, you unfortunately have to re-equip the tabard manually in that case. If it was just unable to unequip, it will try again at the next opportunity.
This addon cannot guarantee you will always re-gain the championing buff, but it will help where it can.
0.2b: .toc bump for 4.3, include current versions of libs used (just in case one uses absolutely no other Ace addons)

0.2a: prevent unnecessary Ace warning

0.2: fixed a bug causing errors, improved recognition&handling of unequip failures (a.k.a. try again 5 seconds later) and having no tabard buff due to being a ghost.
Archived Files (1)
File Name
Version
Size
Author
Date
0.2a
22kB
Nathanyel
09-15-11 04:45 AM


Post A Reply Comment Options
Unread 08-04-11, 01:56 PM  
zaphon
A Defias Bandit

Forum posts: 2
File comments: 35
Uploads: 0
I just installed this as I'm so sick of having to unequip and equip my tabard when I go through the portal. It seems to work, however I did get an error when using it.

Code:
2x TabardCheck\TabardCheck-0.1.lua:50: 37AceTimer-3.0-5: ScheduleTimer(callback, delay, arg): "callback" - function or method name expected.
<in C code>
Ace3-r1035\AceTimer-3.0\AceTimer-3.0-5.lua:214: in function <Ace3\AceTimer-3.0\AceTimer-3.0.lua:211>
(tail call): ?
TabardCheck\TabardCheck-0.1.lua:50: in function <TabardCheck\TabardCheck.lua:47>
(tail call): ?
<in C code>
<string>:"safecall Dispatcher[1]":9: in function <string>:"safecall Dispatcher[1]":5
(tail call): ?
Ace3-r1035\AceTimer-3.0\AceTimer-3.0-5.lua:166: in function <Ace3\AceTimer-3.0\AceTimer-3.0.lua:138>

Locals:
nil
NOTE: I fixed this, you we're calling the function tabardcheck prior to it's definition. So I defined tabardcheck prior to the reequip function, and changed the tabardcheck function to be defined as tabardcheck=function(self) (here's the diff)

Code:
*** TabardCheck/TabardCheck.lua	2011-07-24 18:32:10.000000000 -0700
--- /WoW-Apps/World of Warcraft/Interface/AddOns/TabardCheck/TabardCheck.lua	2011-08-04 12:58:20.000000000 -0700
***************
*** 44,49 ****
--- 44,50 ----
  end
  
  local reequip
+ local tabardcheck
  reequip=function(tid)
   if GetInventoryItemID("player",19) then
    tt=0
***************
*** 60,66 ****
   TabardCheck:ScheduleTimer(reequip,1,tid)
  end
  
! local function tabardcheck(self)
   if((abs(startup-GetTime())<20) or UnitIsDead("player") or UnitIsGhost("player")) then return end
   --PEW might fire before the client is ready to handle this stuff properly, dead we can't un- and reequip, and as a ghost you don't have a tabard buff
   local tid=GetInventoryItemID("player",19)
--- 61,67 ----
   TabardCheck:ScheduleTimer(reequip,1,tid)
  end
  
! tabardcheck=function(self)
   if((abs(startup-GetTime())<20) or UnitIsDead("player") or UnitIsGhost("player")) then return end
   --PEW might fire before the client is ready to handle this stuff properly, dead we can't un- and reequip, and as a ghost you don't have a tabard buff
   local tid=GetInventoryItemID("player",19)
Last edited by zaphon : 08-04-11 at 03:42 PM.
zaphon is offline Report comment to moderator  
Reply With Quote
Unread 08-29-11, 10:46 AM  
Nathanyel
Premium Member
 
Nathanyel's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 152
Uploads: 10
Ah, thanks for noticing that. I did see that error pop up, but only occasionally, I blamed random Ace problems :P
I wanted to rewrite the addon a bit anyway, to (hopefully) prevent occasional unnecessary re-equips after a corpse run.
Nathanyel is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: