Just started doing a bit of PVP and noticed an error. It seems an event has been removed so the PVP window no longer opens.

In core.lua at line 176 if you change
to

It will work properly again.


Thanks again for a great addon.

Morning Sorcerermerlin

Everything is still working fantastically for me. Just have a question regarding savedvariables this time around. Does the savedvariables file only hold settings that have changed from default?

For example, in the config.lua file, "MarkTank = true," is the Default. I go in game and uncheck that option in the settings. If I then look at the savedvariables file I see the line "["MarkTank"] = false,". No other lines besides toon name, server, and profile name are listed. So the other settings that are possible do not get listed until they are changed from the Default as it's seen in the config.lua file?

Just clarifying how it all works in my head/out loud

Yea this is what I see now with the latest SMQueue as you reported when I finally have some solid play time in. The right click option is anchored to the lower left corner.

http://i.imgur.com/wiXZJ.jpg

I just installed a new copy of DockingStation, SMQueue, Ace3 and also Broker_Micromenu for testing. I left all settings on default except for enabling SMQueue, moving the bar to the very bottom and also locking the bar. The mouseover tooltip is working perfectly fine just like you experienced. I joined a queue and everything worked fine there. I decided to leave the queue so I right clicked on the LDB text for SMQueue. The right click menu actually appeared above the bar as it should, but, it appeared to the far left as if it was anchored to the bottom left of the screen.

The tooltip is there with a default install, just not directly over the LDB plugin for some reason.

That is why it totally baffles me. The mouseover tooltip works fine. Everything displays properly on screen and above the bar as it should.

It is only when I attempt to access the queue with the right click that becomes unavailable. The tooltip portion shows above and I guess the enter dungeon portion shows below the tooltip which ends up below the screen.

I haven't really had a chance to test out the new layout yet. From what I see, it all looks great. Still not encountering any issues.

Out of curiosity, what were you thinking of adding for Pet Battles?



@keLston:

I just checked using Bazooka at least and the tooltip does properly change to be above the bar when Bazooka's bars are on the bottom of the screen. It may be a setting within DockingStation that is causing an issue or could also be a difference in how the displays show information.

I haven't tested the newest version yet so I may be a few versions behind but I was glad to see a replacement for eQueue so I tried this a few days back (this was I think Monday, before MoP's release).

When I tried it, I ran into an issue that I couldn't seem to find a way around. As I noticed in your screenshots, your LDB display bar is on the top of your screen but for my UI I decided I was more comfortable having it on the bottom (I use DockingStation if that matters) of my screen. With it on the bottom, whenever I try to right click to bring up the queue options like trying to use it to teleport to the dungeon when the queue pops but i'm dead and had to rez so needed a teleport after rezzing, I couldn't bring up the menu because for some reason it pops the menu below my visible screen.

None of the other LDB plugins I have running with DockingStation in the years i've run with it has even run into this problem so i'm stumped as to how to try and fix it.

I've had a chance to play with your addon again and it's looking great. I like how the new custom tooltip looks. Nice and simple and easy on the eyes. And again, no errors for me yet.

From my testing, if you have the Auto Select Queue checked, but Show Only Active unchecked, you are still limited to only being able to see the active queues. That's with multiple active queues and with only a single active queue. I can still cycle through the active ones if I'm in more than one queue as intended though. Otherwise, it does work as intended by auto changing to show the first active queue timer.

It appears that Auto Select Queue and Show Only Active options will both do the same thing on my end. It may be best to combine the two options into a single one.

A small recommendation on the options page as well would be to change the text for the Builtin Tooltips option. On first glance, seeing it checked by default I got the impression that I would see the Addons Builtin tooltips, not Blizzards. So the text confused me a bit until I toggled it a couple times. Changing the text to read "Show Blizzard Tooltip" may be a clearer way to let the user know what it does.

As usual though, I like the changes. They are little features that add big "feel" to your addon.


I've seen something similar in one of the other queue addons that showed it like this "THDDD". The letters would change color depending on who was missing. Red letters would represent missing roles, green would indicate a filled role. So at a glance if you saw Green DDD and TH was red, you'd know that you had all 3 dps'ers but were still missing a tank and a healer. Something along those lines would be clean and easy to read as well without taking up too much space.


*I apologize for yet another wall o text, lol.

I would much rather see which roles are missing than how long I've waited in the LDB feed.
sort of like this: "T/H/DX" where X is the number of missing DPS. if for example the Tank and one DPS is missing it would be T/D1.

I think it would be a great idea to implement both of those ideas. That would make it even easier to see the current queue time/s. Obviously no rush is needed. Free time is precious, get your changes when you can, the addon works great without them