Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(1 Kb)
Download
Updated: 10-14-14 05:58 AM
Compatibility:
Warlords of Draenor Pre-Patch (6.0.2)
Updated:10-14-14 05:58 AM
Created:08-27-12 04:04 PM
Downloads:5,198
Favorites:48
MD5:

infMopTalentMacros  Popular! (More than 5000 hits)

Version: 2.0
by: infin1te [More]

A very simple addon that helps you make working macros for the new tier based talents in 5.0.4 (MoP)
At least until they make #showtooltip able to handle the new system.


Technically you could do this kind of macro:

Code:
/cast ability1
/cast ability2
/cast ability3
But then you are stuck with the issue that you wont have the correct icon/tooltip.


You could solve that problem by doing something like this
Code:
/cast ability1
/cast ability2
/run SetMacroSpell("MacroName",GetSpellInfo("ability1") or "ability2")
However the problem with that is that you have to click the macro once for it to update the icon/tooltip correctly.


This addon solves those issues completely and lets you make proper macros.

You simply make an empty macro with any icon but with the name "tier_#", where # is the number of the talent tier you want the macro for. (1-6, top to bottom), it is not case sensitive.
It does not matter if it is in the general or player specific macro section, though of course if you want it available cross-character then I would recommend putting in the general section.
Make sure you get the name right though, it won't work otherwise.

And that is it, the addon will do the rest.

What it does is that it edits your macro to the appropriate ability every time you swap a talent for that tier.

Note that you will most likely need to swap a talent for that tier or swap you spec for the macro to initialize, though this only has to be done the very first time.
Also make sure you do not have more than one macro per tier as it can cause issues.

Cpu usage is essentially zero if anyone was wondering, as it only operates when you swap a talent.


iNFEH @ Twisting Nether EU or methodwow.com

2.0
  • Update TOC for 6.0

1.7
  • Reverted back to the non-lib version, but kept some in combat error protection since blizzard still hasn't fixed the problem with PLAYER_TALENT_UPDATE firing 'randomly' for some ppl, seems to be especially warlock related, I've never been able to replicate it myself but it's definitely there.
    http://wow.curseforge.com/addons/tellmewhen/tickets/949
  • As I'm not using this addon myself since 5.2~ don't expect anything major to be changed.
    I have also enabled so anyone that has some good changes can upload them here as optional files.

1.6
  • Update TOC for 5.4
  • Added some additional code for handling in-combat scenarios based upon comments.

1.5
  • Update TOC for 5.3

1.4
  • Update TOC for 5.2

1.3
  • Update TOC for 5.1

1.2
  • Cleaned the code a bit. y u heff to be so good nebula169!

1.1
  • Fixed a minor issue that occurred when swapping characters.
Optional Files (0)


Archived Files (8)
File Name
Version
Size
Author
Date
1.7
1kB
infin1te
06-08-14 09:11 AM
1.6
15kB
infin1te
09-10-13 04:52 AM
1.5
905B
infin1te
05-22-13 03:16 PM
1.4
916B
infin1te
03-05-13 04:09 PM
1.3
916B
infin1te
11-28-12 08:10 AM
1.2
916B
infin1te
09-07-12 06:43 AM
1.1
991B
infin1te
08-30-12 05:18 AM
1.0
1001B
infin1te
08-27-12 04:04 PM


Post A Reply Comment Options
Unread 08-27-12, 06:59 PM  
the-wind-waker
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
finally!

I've been waiting for this since beta started... great job!
one thing though, would it be possible to use it for macros in general?

for something like:
/cast [stance:1] tier_1; [stance:3] barkskin

that would be amazing! =)
Last edited by the-wind-waker : 08-27-12 at 07:38 PM.
the-wind-waker is offline Report comment to moderator  
Reply With Quote
Unread 08-28-12, 05:15 AM  
infin1te
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 16
Uploads: 6
Re: finally!

Cheers!

About being able to run the macro within another macro.

Well... sort of.

Since unfortunately the /RunMacro 'name' is protected we have to make a kind of crude wordaround.
Using your example;

Start by putting the tier_1 macro somewhere on your bars, it does not really matter where as you wont directly be running that macro, then move your mouse over it and '/print GetMouseFocus():GetName()'
This should give a name of the action bar and button number, for example 'MultiBarRightButton1' or 'BT4Button99' if you are using say bartender4.

Then make a second macro looking something like this:
Code:
/click [stance:1] MultiBarRightButton1
/cast [stance:3] barkskin
The first line will 'run' the tier_1 macro if you are in stance 1, else cast barkskin if you are in stance 3
So it will work the way you wanted it to.

Hope my walkthrough is not to poorly written and makes sense
Last edited by infin1te : 08-28-12 at 05:23 AM.
infin1te is offline Report comment to moderator  
Reply With Quote
Unread 09-02-12, 10:33 PM  
10leej
A Firelord
 
10leej's Avatar
AddOn Author - Click to view AddOns

Forum posts: 486
File comments: 355
Uploads: 20
So a macro would pretty much be just this?

Code:
/cast tier_1
correct?

EDIT: sorry bout the idiocy reread what you said got it working now the name is literally supposed to be tier_#

Also, mind if I include this within BobUI credit will be given and I more than likely won't modify the code
Last edited by 10leej : 09-02-12 at 10:58 PM.
10leej is offline Report comment to moderator  
Reply With Quote
Unread 09-03-12, 04:38 AM  
infin1te
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 16
Uploads: 6
Originally Posted by 10leej
Also, mind if I include this within BobUI credit will be given and I more than likely won't modify the code
Sure, go for it
infin1te is offline Report comment to moderator  
Reply With Quote
Unread 09-03-12, 11:15 PM  
10leej
A Firelord
 
10leej's Avatar
AddOn Author - Click to view AddOns

Forum posts: 486
File comments: 355
Uploads: 20
Originally Posted by infin1te
Originally Posted by 10leej
Also, mind if I include this within BobUI credit will be given and I more than likely won't modify the code
Sure, go for it
Awesome, thanks. I'm finding this really useful, lmao.
10leej is offline Report comment to moderator  
Reply With Quote
Unread 10-17-12, 02:42 PM  
Lockslap
Premium Member
 
Lockslap's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 38
Uploads: 8
Simple, effective, and brilliantly implemented. Well done!
Lockslap is offline Report comment to moderator  
Reply With Quote
Unread 11-07-12, 07:05 PM  
twinight
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
This is fantastic!

Kind of a long shot, but would there be any way to flag these and make them a mouseover macro?

I can't LUA my way out of a wet paper bag but if there were say an option to make tier_2m to make it mouseover or something that'd be fantastic. I swap between the T2 monk talents a lot for healing and mouseover cast basically all my spells.

Either way, thanks for this!
twinight is offline Report comment to moderator  
Reply With Quote
Unread 11-19-12, 10:45 PM  
reale411
A Kobold Labourer

Forum posts: 0
File comments: 25
Uploads: 0
Originally Posted by twinight
This is fantastic!

Kind of a long shot, but would there be any way to flag these and make them a mouseover macro?

I can't LUA my way out of a wet paper bag but if there were say an option to make tier_2m to make it mouseover or something that'd be fantastic. I swap between the T2 monk talents a lot for healing and mouseover cast basically all my spells.

Either way, thanks for this!
I overwrote line 9 with:

Code:
EditMacro("TIER_"..tier, nil, "INV_Misc_QuestionMark", "#showtooltip\n/cast [@mouseover,help][help][] "..name)
...for my mouseovers
reale411 is offline Report comment to moderator  
Reply With Quote
Unread 12-15-12, 07:01 PM  
xmrone
A Defias Bandit

Forum posts: 2
File comments: 4
Uploads: 0
Great addon, been looking for something like this for a while.

Could anyone tell me an easy way to edit the lua so the macro text inserted can be customized for each individual tier? For example, if I wanted to include /use 14 for tier_6. Thanks.
xmrone is offline Report comment to moderator  
Reply With Quote
Unread 03-10-13, 11:26 AM  
losername
A Kobold Labourer

Forum posts: 0
File comments: 13
Uploads: 0
Awesome addon, thanks for throwing this together.

However, I've been getting an error lately. Not sure if it started after the hotfix or after 5.2.

This is the BugGrabber info:

Code:
"[ADDON_ACTION_BLOCKED] AddOn \"infMopTalentMacroes\" tried to call the protected function \"EditMacro()\".",
["stack"] = "!BugGrabber-r191-release\\BugGrabber.lua:587: in function <!BugGrabber\\BugGrabber.lua:587>
<in C code>\ninfMopTalentMacroes\\infMopTalentMacroes-1.3.lua:9: in function <infMopTalentMacroes\\infMopTalentMacroes.lua:5>",
I'll get a crazy amount of these in a short time span. Record is 276 in a minute after logging in a char using 3 tier macros.
Last edited by losername : 03-10-13 at 11:27 AM.
losername is offline Report comment to moderator  
Reply With Quote
Unread 05-18-13, 04:40 AM  
circatm2001
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Problem:
http://www.twitch.tv/circatm2001/b/405014416

Solution:
infMopTalentMacros.zip (1 KB)


Before:
Code:
----------------------------------------------
-- infMopTalentMacroes
----------------------------------------------

local function OnEvent(self, event, ...)
	for i=1, MAX_NUM_TALENTS do
		local name, _, tier, _, selected = GetTalentInfo(i)
		if selected then
			EditMacro("TIER_"..tier, nil, "INV_Misc_QuestionMark", "#showtooltip\n/cast "..name)
		end
	end
end

local infMopTalentMacroes = CreateFrame("Frame")
infMopTalentMacroes:RegisterEvent("PLAYER_LOGIN")
infMopTalentMacroes:RegisterEvent("PLAYER_TALENT_UPDATE")
infMopTalentMacroes:SetScript("OnEvent", OnEvent)
After:
Code:
----------------------------------------------
-- infMopTalentMacroes
----------------------------------------------

local function OnEvent(self, event, ...)
-- Check to see whether the player is in combat before attempting to call protected function EditMacro()
    if InCombatLockdown() then
        return
    end
    for i=1, MAX_NUM_TALENTS do
		local name, _, tier, _, selected = GetTalentInfo(i)
		if selected then
			EditMacro("TIER_"..tier, nil, "INV_Misc_QuestionMark", "#showtooltip\n/cast "..name)
		end
	end
end

local infMopTalentMacroes = CreateFrame("Frame")
infMopTalentMacroes:RegisterEvent("PLAYER_LOGIN")
infMopTalentMacroes:RegisterEvent("PLAYER_TALENT_UPDATE")
infMopTalentMacroes:SetScript("OnEvent", OnEvent)
Last edited by circatm2001 : 05-18-13 at 06:38 PM.
circatm2001 is offline Report comment to moderator  
Reply With Quote
Unread 05-23-13, 04:05 AM  
infin1te
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 16
Uploads: 6
I did actually consider adding a check for if-in-combat originally, however as you can't actually learn nor unlearn talents in combat I never bothered.
Which on the other hand makes me quite curious as to how you managed to produce that error.
I've been using this addon since I made it and I've never encountered an in-combat error.

Anyway if it's causing people problems I can fix it, and cheers for the suggestion circatm2001
Last edited by infin1te : 05-23-13 at 04:07 AM.
infin1te is offline Report comment to moderator  
Reply With Quote
Unread 07-02-13, 09:54 AM  
Kathel
A Kobold Labourer

Forum posts: 1
File comments: 2
Uploads: 0
150x [ADDON_ACTION_BLOCKED] AddOn "infMopTalentMacros" tried to call the protected function "EditMacro()".
!BugGrabber-r193-release\BugGrabber.lua:587: in function <!BugGrabber\BugGrabber.lua:587>
<in C code>
infMopTalentMacros\infMopTalentMacros-1.5.lua:9: in function <infMopTalentMacros\infMopTalentMacros.lua:5>

Locals:
nil
Kathel is offline Report comment to moderator  
Reply With Quote
Unread 07-20-13, 08:20 PM  
circatm2001
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by infin1te
I did actually consider adding a check for if-in-combat originally, however as you can't actually learn nor unlearn talents in combat I never bothered.
Which on the other hand makes me quite curious as to how you managed to produce that error.
I've been using this addon since I made it and I've never encountered an in-combat error.

Anyway if it's causing people problems I can fix it, and cheers for the suggestion circatm2001
Np . I don't know what's causing the talent update event to fire during combat, but it's triggering hundreds of times in short periods of time. Multiple people were experiencing this issue, it must be something on blizzard's end. Have you not noticed this error infin1te? I haven't had a single problem since I modified the code and added the combat check.
Last edited by circatm2001 : 07-20-13 at 10:49 PM.
circatm2001 is offline Report comment to moderator  
Reply With Quote
Unread 08-28-13, 04:18 AM  
Machinelf
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Machinelf is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: