Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(2 Kb)
Download
Updated: 10-14-12 07:59 AM
Pictures
File Info
Updated:10-14-12 07:59 AM
Created:09-08-12 01:39 PM
Downloads:1,910
Favorites:42
MD5:

Collie

Version: 50001.4-Release
by: p3lim [More]

This addon is discontinued.

Description:
When Blizzard implemented the account-wide mounts and companions they introduced a new window for both types.
However, as they implemented a search and filter function for the companions, they didn't for the mounts.
This addon makes up for that, and makes a search and filter for the mounts.


Features:
- Search mounts by name
- Filter the mounts by ground, flying, combined or swimming

Changes in 50001.4-Release
  • Properly filter flag 23 and spew errors for everything else
  • Some tweaks to update and checks
Changes in 50001.3-Release
  • Take into account for mounts that has weird flags that is not accounted for
Changes in 50001.2-Release
  • Some fixes to low-level characters
Changes in 50001.1-Release
  • Update the list when we learn a new mount
  • Add a filter system and move the search button to match pets
  • Rework to use LoadWith
  • Majik!
Archived Files (4)
File Name
Version
Size
Author
Date
50001.3-Release
2kB
p3lim
09-29-12 05:45 PM
50001.2-Release
2kB
p3lim
09-20-12 12:33 PM
50001.1-Release
2kB
p3lim
09-08-12 01:39 PM
0B
p3lim
09-08-12 01:39 PM


Post A Reply Comment Options
Unread 11-28-12, 02:58 AM  
Tonyleila
A Scalebane Royal Guard
 
Tonyleila's Avatar
AddOn Author - Click to view AddOns

Forum posts: 414
File comments: 1465
Uploads: 33
Addon is broken with 5.1 - blizzard has now its own search bar but I realy miss the filters of this addon
__________________
Author of: LeilaUI and Aurora: Missing Textures
__________________
Tonyleila is offline Report comment to moderator  
Reply With Quote
Unread 11-06-12, 05:21 PM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1313
File comments: 1184
Uploads: 25
Originally Posted by kittykatmax
Originally Posted by p3lim
Originally Posted by kittykatmax
There's no filtering mentioned, however, which is a great feature.
That's true, we'll have to see how it is when it comes.
Also, assuming you continue this addon once Blizz incorporates it's own search pane, a filter for passenger mounts would be awesome.
I will add that.
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 10-25-12, 09:05 AM  
penguinsane
A Kobold Labourer

Forum posts: 0
File comments: 156
Uploads: 0
I get the following error when I log in from Collie...

26x Collie\Collie-Alpha.lua:69: attempt to index local "name" (a nil value)
Collie\Collie-Alpha.lua:69: in function "MountJournal_UpdateMountList"
Blizzard_PetJournal\Blizzard_PetJournal-1.0.lua:1659: in function <Blizzard_PetJournal\Blizzard_PetJournal.lua:1657>
<in C code>

Locals:
self = MountJournal {
0 = <userdata>
LeftInset = <unnamed> {}
RightInset = <unnamed> {}
ListScrollFrame = MountJournalListScrollFrame {}
MountCount = <unnamed> {}
MountButton = MountJournalMountButton {}
MountDisplay = <unnamed> {}
}
event = "COMPANION_UPDATE"
penguinsane is offline Report comment to moderator  
Reply With Quote
Unread 10-15-12, 11:05 AM  
kittykatmax
A Deviate Faerie Dragon
 
kittykatmax's Avatar

Forum posts: 16
File comments: 230
Uploads: 0
Originally Posted by p3lim
Originally Posted by kittykatmax
There's no filtering mentioned, however, which is a great feature.
That's true, we'll have to see how it is when it comes.
Also, assuming you continue this addon once Blizz incorporates it's own search pane, a filter for passenger mounts would be awesome.
kittykatmax is offline Report comment to moderator  
Reply With Quote
Unread 10-14-12, 02:57 PM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1313
File comments: 1184
Uploads: 25
Originally Posted by kittykatmax
There's no filtering mentioned, however, which is a great feature.
That's true, we'll have to see how it is when it comes.
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 10-14-12, 11:58 AM  
kittykatmax
A Deviate Faerie Dragon
 
kittykatmax's Avatar

Forum posts: 16
File comments: 230
Uploads: 0
There's no filtering mentioned, however, which is a great feature.
kittykatmax is offline Report comment to moderator  
Reply With Quote
Unread 10-11-12, 01:48 PM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1313
File comments: 1184
Uploads: 25
A search bar has been added to the mount section of the Mount and Pet Journal
Pretty much makes this addon obsolete when 5.1 arrives.
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 10-09-12, 05:06 PM  
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1391
File comments: 3372
Uploads: 89
Your Github version is working fine. I was just pointing out that the event check you previously had wasn't that bad actually. Nevermind.
__________________
| Simple is beautiful.
| Roth UI | Roth UI FAQ | GoogleCode | Zork | TDMOG

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
Last edited by zork : 10-09-12 at 05:41 PM.
zork is offline Report comment to moderator  
Reply With Quote
Unread 10-09-12, 01:35 PM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1313
File comments: 1184
Uploads: 25
I say again, this addon is LoD, it doesn't matter if it's a fresh login or a reload, since it doesn't activate until the player opens up the PetJournal.

If you have other results, that means you embedded this addon or modified it in other ways.
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 10-09-12, 10:46 AM  
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1391
File comments: 3372
Uploads: 89
Actually not the case. Adding my workaround fixed the loading issue on the first login of a character. Not sure why but adding it calls the BuildMount() function when GetCompanion() etc return desired results.

Your Github version is fine aswell. You removed the event check. Now it runs on each event applied to the MountJournal.

The thing is on the first login of a char "COMPANION_UPDATE" event fires like 4 times. On a /reload it does not fire once.

Your direct BuildMount() function does nothing on first login of a char (it fails). What makes it work is the hook without the event check.
But on a /reload that is different. Then the BuildMount() returns correct data and since there is no COMPANION_UPDATE event the function will not be executed by the event hook.

I had the same phenomenon with oUF modules.

You can easily check it by adding a print(event) debug to the BuildMount() function.

COMPANION_UPDATE fires quite a lot. If it is not needed the version where you checked for the event was actually superior since all we need is to check for mounts once on loadup and once a new mount gets added.
__________________
| Simple is beautiful.
| Roth UI | Roth UI FAQ | GoogleCode | Zork | TDMOG

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
Last edited by zork : 10-09-12 at 11:15 AM.
zork is offline Report comment to moderator  
Reply With Quote
Unread 10-09-12, 10:42 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1313
File comments: 1184
Uploads: 25
This addon is LoD and loads with Blizzard_PetJournal, so PLAYER_LOGIN won't do anything.
I've asked you all to test out the version currently on github, but I have yet to get any response if it works or not.
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 10-09-12, 08:29 AM  
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1391
File comments: 3372
Uploads: 89
Not sure if you want to do that. Maybe it is enough to delay the initial "BuildMounts()" call until PLAYER_LOGIN.

Going to replace
Lua Code:
  1. BuildMounts()

with
Lua Code:
  1. local loader = CreateFrame("Frame")
  2. loader:RegisterEvent("PLAYER_LOGIN")
  3. loader:SetScript("OnEvent", function(self,event) BuildMounts() end)

*edit*
Yepp...fixed my issue. So going to stick with it.
__________________
| Simple is beautiful.
| Roth UI | Roth UI FAQ | GoogleCode | Zork | TDMOG

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
Last edited by zork : 10-09-12 at 10:44 AM.
zork is offline Report comment to moderator  
Reply With Quote
Unread 10-08-12, 10:48 PM  
siweia
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 19
File comments: 44
Uploads: 4
Originally Posted by kittykatmax
I'm having the same issue....zero mounts showing until I /reload ui
You can currently delete the line below, before the official version releases.
Code:
if(event and event ~= "COMPANION_LEARNED") then return end
siweia is offline Report comment to moderator  
Reply With Quote
Unread 10-06-12, 10:41 PM  
kittykatmax
A Deviate Faerie Dragon
 
kittykatmax's Avatar

Forum posts: 16
File comments: 230
Uploads: 0
I'm having the same issue....zero mounts showing until I /reload ui
kittykatmax is offline Report comment to moderator  
Reply With Quote
Unread 10-05-12, 03:00 AM  
guin
A Kobold Labourer
 
guin's Avatar

Forum posts: 0
File comments: 19
Uploads: 0
When i first log-in with my character (any character) no mount are shown.
After /reload everything look fine.
So for all those that can't see their mounts the work around is to type /reload command on your chat.
But it's really annoying to do it every time you log-in.

A suggestion for this add-on if i may.
Add category such as Dragon, Horse, Night Sabre, Mammoth, Mechanic, etc.
__________________
For GLORY and HONOR,
CRASH THE HORDE TO BLOOD AND DUST.
guin is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: