PetCaught

first off - addon works great as intended to function. problem i have is when i open the journal to search something as soon as i type the first letter, and for each subsequent letter i get this error:

PetCaught\PetCaught-1.0.lua:15: Usage: GetPetStats(ID)
<in C code>
PetCaught\PetCaught-1.0.lua:15: in function "OnEvent"
PetCaught\PetCaught-1.0.lua:6: in function <PetCaught\PetCaught.lua:6>
<in C code>
Blizzard_PetJournal\Blizzard_PetJournal-1.0.lua:837: in function <Blizzard_PetJournal\Blizzard_PetJournal.lua:830>
<in C code>

Locals:
self = <unnamed> {
LastTooltipText = ""
KnownPets = <table> {}
0 = <userdata>
AddTooltipLine = <func> @..\PetCaught.lua:29
Print = <func> @..\PetCaught.lua:39
OnEvent = <func> @..\PetCaught.lua:8
}
self = <unnamed> {
LastTooltipText = ""
KnownPets = <table> {}
0 = <userdata>
AddTooltipLine = <func> @..\PetCaught.lua:29
Print = <func> @..\PetCaught.lua:39
OnEvent = <func> @..\PetCaught.lua:8
}
numPets = 7
numOwned = 215
(for index) = 8
(for limit) = 215
(for step) = 1
i = 8
petID = nil
speciesID = nil
isOwned = nil
customName = nil
level = nil
favorite = nil
isRevoked = nil
name = nil
icon = nil
petType = nil
creatureID = nil
sourceText = nil
description = nil
isWildPet = nil

greatly appreciated - tyvm

VERY useful addon. Thanks for taking the time.

I did notice that when you get multiple creatures in the same tooltip its looks a little strange. i.e.

Frog
Toad
Caught
Uncaught

Other than that I dig it. Seems like it should be standard in the Blizz UI.

It seems that the addon is making the menu icons (charsheet, spellbook, questlog, etc..) that appear in the little box on the right side during a Pet Battle disappear.

If you use a menu hotkey (like L to open the questlog, or shift+P for the pet journal) the icons come back. So yeah.

Edit: actually opening/closing the map is what makes the icons show up again.

Edit2: saw another issue; Found a skunk wandering in Duskwood, it said "not caught" - but I do have one caught from the same zone. I used the "click to open in Journal" link to make sure it was the same Pet ID

Liking it so far, can't wait for more features. I would like to see rarity color and caught/not caught show somewhere on the info cards/tooltips that show up during pet battles, as there is no way to tell if you have the 2nd pet in a wild-battle, or its rarity (there is another pet addon that does this currently)

Ah, I went through and found out what was causing it; I had just updated Dominos (a bar mod) and it seems to be the culprit, the previous version wasn't doing it.


I did find a genuine issue with your addon though, that was causing the detection to "fail" on the tooltips. if you use the filters in the pet journal (say to show only favorites) then any pet that is "hidden" in the journal will display as "not caught" in the world, even if you have caught it. I turned it on and off several times to confirm

Should have named it "CaughtOrNot.com" (parody of Hotornot.com).

I got some errors, when i'm searching pet's.

Really nice mod, but I think its blocking my achievements. Not from getting them, but seeing them.

For example, in the last 30 minutes or so, I have got 2 battle pet achievements, getting a pet to 10 and getting my first rare. both of them never showed, if I checked my achievements it said I never got them, reloading my ui didn't change it, and I had to relog for them to show.

the only other mods I use is Recount and WarcraftpetsExpress.

Any idea if this is your mod doing it, a glitch, or what? anyone else having this issue? no error report displays.

Other than that, I really like this mod. super helpful because I'm stuck in a "Gotta catch'em all" mindset right now. Love this mod, I actually just now registered to WoW Interface because I'm hoping you can fix this, if its your mod doing it.

thanks

Hi

I love your addon since I like to collect pets. I have a few suggestions though...

Mainly its to change the minimap color of the pets. It is always green and I have to stop, mouseover and check if I have it or not.
My suggestion is to change the icon color depending on for example:

Rarity: Green, Blue, Purple
Caught: Grey
Hard: Red

(hard: say when the pet level is above 5 or 10 levels above my highest pet so i have no chance of catching it anyway)

I realize that changing this icon may or may not be hard to do so I humbly suggest it.

Thanks again for a nice addon!

Unfortunately, this isn't possible, since addons can't even see minimap tracking blips, let alone find out what each blip is tracking. Mousing over the icon is your only option.

Oh, please please don't discontinue this addon! Yes, they added the caught pets number to the tooltip, but PetCaught is awesome for the minimap mouseover telling you what quality you have in your journal. The default WoW tooltip doesn't do that, only gives a number -- and even then, you have to land and find the critter in the first place in order to target it, or stop and search for the pet in your journal to see what you own.

PetCaught has been an invaluable thing to have while hunting new pets and upgrading ones I already own. It would be sad to see it go just because WoW adds a default that is sort of (but not really) the same.

Love this addon. Just wanted to report:

37x PetCaught\PetCaught-1.1.lua:23: attempt to compare number with nil
PetCaught\PetCaught-1.1.lua:23: in function "OnEvent"
PetCaught\PetCaught-1.1.lua:6: in function <PetCaught\PetCaught.lua:6>
<in C code>
<in C code>
<in C code>
Blizzard_PetJournal\Blizzard_PetJournal-1.0.lua:846: in function <Blizzard_PetJournal\Blizzard_PetJournal.lua:839>




Thanks.