Quantcast
Download
(17 Kb)
Download
Updated: 07-26-16 05:08 AM
Updated:07-26-16 05:08 AM
Created:04-22-13 06:29 PM
Downloads:3,862
Favorites:74
MD5:

GoFish  Updated less than 3 days ago!

Version: 7.0.3.0
by: Phanx [More]

GoFish lets you double-right-click to fish, and enhances sound effects while fishing.

Fishing mode is automatically enabled when you mouse over a fishing pool, while you have a fishing pole equipped, or can be toggled using a keybind or slash command. Fishing mode is disabled if you enter combat or unequip a fishing pole, or after 10 seconds of no fishing activity if it was enabled via mouseover.

While in fishing mode, double-right-clicking anywhere on the game world casts Fishing, auto-loot is enabled, auto-interact is disabled, the sound effect volume is raised, and other volumes are lowered. When exiting fishing mode, your normal settings are restored.

GoFish does not support lures or other skill-enhancing items, as these are not neccessary or especially useful in Mists of Pandaria.

To toggle fishing mode manually, type "/gofish" or bind a key. To change options, type "/gofish options" or browse to the GoFish panel in the standard Interface Options window.
Feedback
Post a comment. If you are reporting a bug, please include detailed instructions I can follow to reproduce the bug myself, whether or not it still happens when all other addons are disabled, and the exact text of the first related error message (if any) from Bugger.
Language Support
Compatible with all locales. Translated into English, Deutsch, Español, Français, Italiano, Português, Русский, 한국어, 简体中文, and 繁體中文. Languages in italic are missing some translations.

To add or update translations for any language, enter them on CurseForge and then post a comment or send me a PM on either site to let me know you made changes. If you do not comment or PM me, your translations will not be included in the addon until I happen to notice them on my own, which may take months or even years since CurseForge doesn't notify me, so please don't forget that part!
Credits
GoFish was inspired by Ammo's FishermansFriend. The click-casting code borrows heavily from Torhal's Archy. Fish school name translations were copied from Kagaro's GatherMate2.

Version 7.0.3.0 (2016 Jul 26)
  • Updated for WoW 7.0
  • Add Korean translations by next96

Version 6.2.2.15 (2015 Sep 17)
  • Fixed a localization error

Version 6.2.2.14 (2015 Sep 15)
  • Fishing mode will not longer be auto-activated while in a pet battle

Version 6.2.2.13 (2015 Sep 10)
  • Updated for WoW 6.2
  • Added Felmouth Frenzy School
  • Fishing mode will no longer be auto-activated while in shapeshift forms
  • When auto-enabling global sound for fishing mode, only Sound Effects will be enabled

Version 6.1.0.12 (2015 Feb 26)
  • Updated for WoW 6.1
  • Fixed a bug allowing minimap tracking tooltips to activate fishing mode

Version 6.0.3.11 (2015 Feb 18)
  • Updated fish pool translations for all languages

Version 6.0.3.10 (2014 Nov 30)
  • Added Draenor fish pools (some translations missing)

Version 6.0.2.46 (2014 Oct 20)
  • Fixed disabling auto-loot after fishing if it was off beforehand (why!?)

Version 6.0.2.45 (2014 Oct 16)
  • Updated for WoW 6.0
  • Fixed reversed on/off messages in some languages

Version 5.4.8.31 (2014 Jun 2)
  • Fishing mode will no longer activate on mouseover while channeling Far Sight, Eye of Kilrogg, or similar effects
  • Fixed an error for users whose game clients fail at retrieving and/or caching item info

Version 5.4.1.27 (2013 Nov 30)
  • Fixed a possible error at startup if the mouse happened to be over a fish pool
  • Updated German translations from ckaotik on CurseForge
  • Updated for WoW 5.4

Version 5.3.0.22 (2013 Jul 17)
  • Fixed deDE/zhTW localization conflict

Version 5.3.0.21 (2013 Jul 9)
  • Updated for WoW 5.3
  • Fixed disabling option to enhance sounds
  • Added remaining "fish of the day" special pools
  • Added zhTW translations from BNSSNB

Version 5.2.0.14 (2013 May 4)
  • Added options for auto-activation and fishing sound levels
  • Added Mixed Ocean School and Brew Frenzied Emperor Salmon
  • Fishing mode will now be re-enabled automatically if your fishing pole is still equipped when you leave combat

Version 5.2.0.10-beta (2013 Apr 28)
  • Fixed auto-loot toggling
  • Added Crane Yolk Pool (seen during an Anglers daily quest)
  • Added fish pool translations for all languages (some are incomplete)
  • Reduced maximum double-click detection time from 0.4 seconds to 0.25 seconds

Version 5.2.0.6-beta (2013 Apr 22)
  • First public release
Archived Files (15)
File Name
Version
Size
Author
Date
6.2.2.15
16kB
Phanx
09-17-15 08:15 AM
6.2.2.14
16kB
Phanx
09-15-15 06:04 AM
6.2.2.13
16kB
Phanx
09-10-15 02:15 AM
6.1.0.12
19kB
Phanx
02-27-15 04:20 AM
6.0.3.10
28kB
Phanx
12-01-14 03:55 AM
6.0.3.10
30kB
Phanx
10-20-14 02:27 AM
6.0.2.45
30kB
Phanx
10-16-14 07:00 AM
5.4.8.31
30kB
Phanx
06-01-14 10:05 PM
5.4.1.27
30kB
Phanx
11-30-13 12:05 PM
5.3.0.22
29kB
Phanx
07-17-13 03:06 AM
5.3.0.21
29kB
Phanx
07-08-13 07:41 PM
5.2.0.18
29kB
Phanx
05-18-13 04:51 PM
5.2.0.14
29kB
Phanx
05-04-13 05:16 PM
5.2.0.10-beta
23kB
Phanx
04-25-13 10:08 PM
5.2.0.6-beta
9kB
Phanx
04-22-13 06:29 PM


Post A Reply Comment Options
Unread 09-18-15, 08:12 AM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
If it happens fairly regularly, you can enable some debug messages to try to see if the problem is actually in the addon logic or not. If it's a rare problem, debugging will just spam you a lot, but you could still try.

Open Addon.lua in Notepad and find this line:
Code:
GoFish:SetScript("PostClick", function(self, button, down)
After it, remove the two dashes from in front of each "print" statement, eg:
Code:
--print("Fished")
But stop replacing when you get to this line:
Code:
function GoFish:EnableFishingMode()
Now save the file, reload your UI if you were already in-game, and start fishing.

If it turns out your mouse button is flaky (eg. if the sensor is wearing out, pressing the button with insufficient force may just barely complete the switch and end up sending multiple click events as it makes and loses contact) you may be able to work around it by raising the minimum time between clicks:
Code:
if clickDiff > 0.05 and clickDiff < 0.25 then
Change 0.05 to something higher. However, this may cause your intentional double-clicks to be ignored if they're too fast. You can play around with it.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 09-17-15, 05:40 AM  
Barleduq
A Warpwood Thunder Caller
 
Barleduq's Avatar

Forum posts: 95
File comments: 449
Uploads: 0
English

Yes, English, USA servers.

One reason I haven't reported the lack of loot was because of exactly that. I have double-click turned *off* on fishing buddy, tho, because it never worked. I wouldn't care except that I don't get the fish, and it made various fish questing a royal pain in the butt.
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 09:21 PM  
def9
A Cobalt Mageweaver
 
def9's Avatar
AddOn Author - Click to view AddOns

Forum posts: 219
File comments: 114
Uploads: 2
English here.
__________________
Epiria, level 100 Ret/Holy Paladin
Simkin level 100 Combat Rogue
Feldeemus, level 100 Arcane Mage
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 08:10 PM  
rocnroll
A Cobalt Mageweaver
 
rocnroll's Avatar

Forum posts: 238
File comments: 59
Uploads: 0
Re: Re: On first login after updating

Originally Posted by Phanx
What language are you guys playing in?

Originally Posted by Barleduq
I do have Fishing Buddy installed, which claims to enable double-click fishing ... sometimes when I click on the bobber to loot the fish, it immediately casts the line again and does NOT give me the fish.
Without any other information, I'd be inclined to assume this is happening because you have two addons trying to manage double-clicking to fish, or because your mouse has a sticky button, though you'd probably notice that in other apps as well.
I also get this message even with all addons disabled except yours and stAddon manager.

Code:
Message: Interface\AddOns\GoFish\Addon.lua:15: attempt to index field 'Quick fishing {OFF}' (a nil value)
Time: 09/16/15 22:07:08
Count: 1
Stack: Interface\AddOns\GoFish\Addon.lua:15: in main chunk

Locals: ADDON = "GoFish"
ns = <table> {
 F = <table> {
 }
 L = <table> {
 }
}
FISHING = "Fishing"
FISHING_POLE = "Fishing Poles"
F = <table> {
 蕁麻魚群 = true
 Ein Schwarm Hochlandguppys = true
 大型鼠尾魚群 = true
 Grosso Banco di Dipnoi di Giada Luminosi = true
 Banco di Pesci di Vetro = true
 微光珍宝斑马鱼 = true
 Musselback Sculpin School = true
 Grande Cardume de Polvos do Recife Migrados = true
 Cardume de Pançudos do Mar Profundo = true
 Banco di Gamberi Mantide Aggrovigliati = true
 Débris de la Voile sanglante = true
 Banco di Pescifango = true
 Banco de peces alveolares de jade = true
 Banco di Vildenti Frenetici = true
 Poza brillante = true
 Débris flottants = true
 Large Swarm of Migrated Reef Octopus = true
 Banc de poissons-spores = true
 Sporefish School = true
 포자물고기 떼 = true
 용지느러미 천사돔 떼 = true
 Piscinia extraño = true
 Banco di Pescisalvia = true
 Banc de tassergals = true
 刺皮鱼群 = true
 Banco de pulpos de arrecife emigrados = true
 Banco de sabiolas = true
 Cardume de Bagres-cegos Albinos = true
 Schiffswracktrümmer = true
 미꾸라지 떼 = true
 Grande réserve de boue de gouramis tigres = true
 Pozza di Tuorlo di Gru = true
 Banco di Pesci Scorpione Toccati dallo Sha = true
 Косяк борейского медузника = true
 Ein Schwarm Sporenfische = true
 Cardume de Acarás-bandeira Pinadragos = true
 Floating Wreckage = true
 Destroços Encharcados = true
 유리지느러미 송사리 떼 = true
 闪光翠绿肺鱼 = true
 Banc de lutjans de nagefeu = true
 虎皮丝足鱼群 = true
 Banc de saumons glaciaires = true
 Cardume de Piranha Selvagem = true
 Косяк ледоспинки = true
 Cardume de Boca-grandes Abissais Oleosos = true
 Косяк испуганноого веслоноса = true
 Стайка каменного угря = true
 Cardume de Boca-grandes Abissais = true
 高地孔雀魚群 = true
 Redbelly Mandarin School = true
 Ein Schwarm Blauflossen = true
 Banco de mandarines panzarroja = true
 Fat Sleeper School = true
 Grosso Banco Affollato di Panciarossa Orientali = true
 Большой косяк сверкающего бриллиантового данио = true
 Verhedderter Schwarm riesiger Mantisgarnelen = true
 Banco de esturiones ciegos de lago = true
 Cardume da Lagoa = true
 Cardume de Platis = true
 Oily Abyssal Gulper School = true
 Giant Mantis Shrimp Swarm = true
 Fire Ammonite School = true
 Cardume de Peixes-espátula de Krasarang = true
 Bassin du lagon = true
 Restos de los Velasangre = true
 크라사랑 주걱철갑상어 떼 = true
 Mandarines panzarroja atiborrados = true
 Grosso Banco di Pesci Scorpione Toccati dallo Sha = true
 Banco di Pesci Oceanici = true
 Ein Schwarm Riffkraken = true
 비취 폐어 떼 = true
 Косяк глубоководного шалфокуня = true
 Pozza di Fuoco = true
 황금 화살고기 떼 = true
 Стайка саженного угря = true
 Cardume de Escorpiões do Mar Oleosos = true
 Cardume Misto Salobre = true
 Banco de pargos de fuego = true
 Стая запутавшихся раков-богомолов = true
 Banc de sagerelles abyssales = true
 Glimmering Jewel Danio Pool = true
 Enjambre de poliodóntidos aterrados = true
 Cardume de Gouramis-tigre = true
 帝王鲑鱼群 = true
 Pozza di Piranha Selvaggi = true
 Banco de salmones glaciales = true
 Banco di Pesci Spatola nel Panico = true
 Flaque de sang = true
 Peixe-espinho Tocado pelo Sha = true
 Schiffswrackteile = true
 一大群迁徙的八爪鱼 = true
 Détritus de la pompe à vapeur = true
 Ein Schwarm Rotbauchmandarine = true
 Косяк луфаря = true
 Banco di Storioni di Lago Ciechi = true
 Cardume de Azorragues Aguanegra = true
 Grande Poça de Piramboias de Jade Brilhantes = true
 Banco di Eleotridi Grassi = true
 Banco de pulpos de arrecife = true
 Ein Schwarm dicker Schläfer = true
 Пруд свирепых пираний = true
 Banc de demoiselles aileron-de-dragon = true
 Agua pura = true
 Banc mixte en eaux saumâtres = true
 Banc de crevettes-mantes
__________________
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 05:05 PM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
Re: On first login after updating

What language are you guys playing in?

Originally Posted by Barleduq
I do have Fishing Buddy installed, which claims to enable double-click fishing ... sometimes when I click on the bobber to loot the fish, it immediately casts the line again and does NOT give me the fish.
Without any other information, I'd be inclined to assume this is happening because you have two addons trying to manage double-clicking to fish, or because your mouse has a sticky button, though you'd probably notice that in other apps as well.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 11:09 AM  
def9
A Cobalt Mageweaver
 
def9's Avatar
AddOn Author - Click to view AddOns

Forum posts: 219
File comments: 114
Uploads: 2
I also get the error after updating to version: 6.2.2.14 using no other mods other than swatter and gofish and a clean wtf folder.

Lua Code:
  1. Error occured in: Global
  2. Count: 1
  3. Message: ..\AddOns\GoFish\Addon.lua line 15:
  4.    attempt to index field 'Quick fishing {OFF}' (a nil value)
  5. Debug:
  6.    GoFish\Addon.lua:15: in main chunk
__________________
Epiria, level 100 Ret/Holy Paladin
Simkin level 100 Combat Rogue
Feldeemus, level 100 Arcane Mage
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 03:41 AM  
Barleduq
A Warpwood Thunder Caller
 
Barleduq's Avatar

Forum posts: 95
File comments: 449
Uploads: 0
On first login after updating

My apologies, I don't use Bugger, I use Swatter, as that comes with the Auctioneer suite. Also, the last time I turned all my addons off, I had to re-create all my settings. If you're still willing to take this report...

I updated GoFish. Started game via CLI (linux system). Game stopped, told me to patch. Launched Battle.net app via doubleclick on desktop shortcut. After patch download/install finished, exited battle.net app and launched from CLI. The very first toon I logged in, this message popped up on Swatter:

Code:
Date: 2015-09-16 05:04:21
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\GoFish\Addon.lua line 15:
   attempt to index field 'Quick fishing {OFF}' (a nil value)
Debug:
   GoFish\Addon.lua:15: in main chunk
Locals:
ADDON = "GoFish"
ns = <table> {
 F = <table> {
 }
 L = <table> {
 }
}
FISHING = "Fishing"
FISHING_POLE = nil
F = <table> {
 蕁麻魚群 = true
 Ein Schwarm Hochlandguppys = true
 大型鼠尾魚群 = true
 Grosso Banco di Dipnoi di Giada Luminosi = true
 Banco di Pesci di Vetro = true
 微光珍宝斑马鱼 = true
 Musselback Sculpin School = true
 Grande Cardume de Polvos do Recife Migrados = true
 Cardume de Pançudos do Mar Profundo = true
 Banco di Gamberi Mantide Aggrovigliati = true
 Débris de la Voile sanglante = true
 Banco di Pescifango = true
 Banco de peces alveolares de jade = true
 Banco di Vildenti Frenetici = true
 Poza brillante = true
 Débris flottants = true
 Large Swarm of Migrated Reef Octopus = true
 Banc de poissons-spores = true
 Sporefish School = true
 포자물고기 떼 = true
 용지느러미 천사돔 떼 = true
 Piscinia extraño = true
 Banco di Pescisalvia = true
 Banc de tassergals = true
 刺皮鱼群 = true
 Banco de pulpos de arrecife emigrados = true
 Banco de sabiolas = true
 Cardume de Bagres-cegos Albinos = true
 Schiffswracktrümmer = true
 미꾸라지 떼 = true
 Grande réserve de boue de gouramis tigres = true
 Pozza di Tuorlo di Gru = true
 Banco di Pesci Scorpione Toccati dallo Sha = true
 Косяк борейского медузника = true
 Ein Schwarm Sporenfische = true
 Cardume de Acarás-bandeira Pinadragos = true
 Floating Wreckage = true
 Destroços Encharcados = true
 유리지느러미 송사리 떼 = true
 闪光翠绿肺鱼 = true
 Banc de lutjans de nagefeu = true
 虎皮丝足鱼群 = true
 Banc de saumons glaciaires = true
 Cardume de Piranha Selvagem = true
 Косяк ледоспинки = true
 Cardume de Boca-grandes Abissais Oleosos = true
 Косяк испуганноого веслоноса = true
 Стайка каменного угря = true
 Cardume de Boca-grandes Abissais = true
 高地孔雀魚群 = true
 Redbelly Mandarin School = true
 Ein Schwarm Blauflossen = true
 Banco de mandarines panzarroja = true
 Fat Sleeper School = true
 Grosso Banco Affollato di Panciarossa Orientali = true
 Большой косяк сверкающего бриллиантового данио = true
 Verhedderter Schwarm riesiger Mantisgarnelen = true
 Banco de esturiones ciegos de lago = true
 Cardume da Lagoa = true
 Cardume de Platis = true
 Oily Abyssal Gulper School = true
 Giant Mantis Shrimp Swarm = true
 Fire Ammonite School = true
 Cardume de Peixes-espátula de Krasarang = true
 Bassin du lagon = true
 Restos de los Velasangre = true
 크라사랑 주걱철갑상어 떼 = true
 Mandarines panzarroja atiborrados = true
 Grosso Banco di Pesci Scorpione Toccati dallo Sha = true
 Banco di Pesci Oceanici = true
 Ein Schwarm Riffkraken = true
 비취 폐어 떼 = true
 Косяк глубоководного шалфокуня = true
 Pozza di Fuoco = true
 황금 화살고기 떼 = true
 Стайка саженного угря = true
 Cardume de Escorpiões do Mar Oleosos = true
 Cardume Misto Salobre = true
 Banco de pargos de fuego = true
 Стая запутавшихся раков-богомолов = true
 Banc de sagerelles abyssales = true
 Glimmering Jewel Danio Pool = true
 Enjambre de poliodóntidos aterrados = true
 Cardume de Gouramis-tigre = true
 帝王鲑鱼群 = true
 Pozza di Piranha Selvaggi = true
 Banco de salmones glaciales = true
 Banco di Pesci Spatola nel Panico = true
 Flaque de sang = true
 Peixe-espinho Tocado pelo Sha = true
 Schiffswrackteile = true
 一大群迁徙的八爪鱼 = true
 Détritus de la pompe à vapeur = true
 Ein Schwarm Rotbauchmandarine = true
 Косяк луфаря = true
 Banco di Storioni di Lago Ciechi = true
 Cardume de Azorragues Aguanegra = true
 Grande Poça de Piramboias de Jade Brilhantes = true
 Banco di Eleotridi Grassi = true
 Banco de pulpos de arrecife = true
 Ein Schwarm dicker Schläfer = true
 Пруд свирепых пираний = true
 Banc de demoiselles aileron-de-dragon = true
 Agua pura = true
 Banc mixte en eaux saumâtres = true
 Banc de crevettes-mantes géantes = 
AddOns:
     [ Elided for brevity. Let me know if you want the list. ]
  BlizRuntimeLib_enUS v6.2.2.60200 <none>
  (ck=cfc)
I do have Fishing Buddy installed, which claims to enable double-click fishing but this has never worked for me. Which is why I've installed GoFish.

ALSO:
I've not mentioned it before because I can't reliably reproduce it, but sometimes when I click on the bobber to loot the fish, it immediately casts the line again and does NOT give me the fish. The loot window flashes, there's something in it, but it never goes into my bags. Due to this, I've disabled GoFish on some of my alts.

ALSO:

When I was checking to make sure that I had it enabled on this toon, the options page under the Menu > Interface looked odd - I took a screenshot, you can see it here on imgur.
Report comment to moderator  
Reply With Quote
Unread 10-20-14, 02:32 AM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
Version 6.0.2.46
  • Fixed disabling auto-loot after fishing if it was off beforehand (why!?)

I couldn't actually reproduce the problem, but it was storing and setting the value as a boolean (true/false) instead of a flag (1/0) so I fixed that just in case. If you're still seeing auto-loot turning off after fishing, and you're sure it was on before fishing, please try disabling all your other addons and reproducing the problem. You can quickly check the state of the auto-loot setting at any time using this command:

/dump GetCVar("autoLootDefault")

It'll write "1" in your chat frame if it's on, or "0" if it's off. Run it before activating fishing mode, while fishing mode is active, and after deactivating fishing mode. It should say the same thing before and after depending on your setting, and "1" during fishing.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 10-19-14, 09:12 PM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
Oh is that what's doing that... interesting. I'll have to see why the game isn't accurately indicating whether auto-loot is enabled. It should check the state when you start fishing, and only turn it off afterwards if it was off to begin with.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 10-18-14, 11:33 AM  
uncomplimentary
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
auto loot

auto loot is being toggled off on deactivation, it appears
Report comment to moderator  
Reply With Quote
Unread 10-16-14, 07:02 AM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
Version 6.0.2.45
  • Updated for WoW 6.0
  • Fixed reversed on/off messages in some languages
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 06-01-14, 10:05 PM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
Version 5.4.8.31
  • Fishing mode will no longer activate on mouseover while channeling Far Sight, Eye of Kilrogg, or similar effects
  • Fixed an error for users whose game clients fail at retrieving and/or caching item info
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 03-07-14, 05:10 PM  
Ethan Centaurai
A Flamescale Wyrmkin
 
Ethan Centaurai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 139
File comments: 153
Uploads: 15
Originally Posted by Phanx
Why are you deleting your cache so much?
To be honest, I'm not the one doing the deleting.

I think it's either a file permissions issue or the Battle.net App clears it after I log out of WoW (or both, or one thing causes the other, I don't know). I'm pretty sure the cache gets deleted or modified as SilverDragon pops up "NPC found in cache" alerts even though I don't delete it.
__________________

Twitter | Blog
Report comment to moderator  
Reply With Quote
Unread 03-05-14, 05:11 PM  
Phanx
No Life!
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5274
File comments: 2216
Uploads: 46
Well, I can factor out the IsEquippedItemType call to a function that first attempts to update the value of the FISHING_POLE constant if it's not set... that will prevent the error from occurring, but the "activate on equip" feature will still fail when your client fails to retreive the item data in a timely fashion.

Why are you deleting your cache so much?
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Report comment to moderator  
Reply With Quote
Unread 03-03-14, 04:54 PM  
Ethan Centaurai
A Flamescale Wyrmkin
 
Ethan Centaurai's Avatar
AddOn Author - Click to view AddOns

Forum posts: 139
File comments: 153
Uploads: 15
Using /dump GetItemInfo(6256) returns everything you'd want to know about the Fishing Pole. It hasn't yet returned "empty result" during my playtime sessions.

One thing I have noticed is that the error occurs on line 342 (currently at 30x this session) as well as 374 (111x), and that errors sometimes occur when looting or mousing-over things.

My Cache is deleted regularly and I have a feeling that might be what is causing it.

I play a 64-bit client on EU realms using Mac OS X 10.9.2.
__________________

Twitter | Blog
Last edited by Ethan Centaurai : 03-03-14 at 04:58 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: