Download
(29 Kb)
Download
Updated: 10-11-10 03:56 PM
Pictures
File Info
Updated:10-11-10 03:56 PM
Created:unknown
Downloads:864,490
Favorites:2,861
MD5:
EquipCompare  Popular! (More than 5000 hits)
Version: 2.18
by: Legorol [More]
Patch 4.0.1: The latest version is patch 4.0.1 compatible. There are no functionality changes, EquipCompare still works, so I just updated the version number.

If you like this AddOn, please consider making a small, optional donation of any amount that is convenient for you to show your support. You can use PayPal for this:

Click here to lend your support!

Summary

When you shop for items at a vendor or the Auction House and you hover over an item, you get a comparison tooltip showing the "currently equipped" item too. This AddOn adds such a feature everywhere in the game where you can hover over items, such as in your bags, in the loot window or on the reward page of a quest. You also receive comparison tooltips when clicking an item link in the chat box.

For detailed description of features, see the included Description.txt file. Simple install/uninstall/usage instructions are given below. Post a comment if you like, or discuss the AddOn in this thread: http://www.wowinterface.com/forums/s...ead.php?t=2597

The AddOn is compatible with and the texts are localized for US English, EU English, German, French, Korean, Simplified Chinese and Traditional Chinese clients.

Troubleshooting

Check the Known Issues list first! If EC only appears to be working at the AH and vendors, but nowhere else, then you donīt actually have EC correctly installed and working! The default Blizzard UI has EC-like features in those two places already, thatīs what you are seeing. In this case, make sure that EC is enabled correctly on the character selection screen.

Advanced tip: For some really advanced uses, turn on the Alt-key mode and install CharactersViewer. Choose an alternate character in CV, go to the Auction House then hover over an item. First you get comparison with your equipped item, but then hold Alt to get comparison with your alternate character. Shop with ease both for yourself and your other characters with this great feature!

Install

Unzip the downloaded zip file into your "World of Warcraft\Interface\AddOns" folder. This is a standalone, pure AddOn.

Uninstall

Delete the "World of Warcraft\Interface\AddOns\EquipCompare" folder.

Usage

The AddOn is enabled by default. Type "/equipcompare help" for further usage information, or see the documentation in the included Description.txt file.

Developer API

See the included Description.txt for a short summary. See the comments in front of each of the functions in EquipCompare's code for full documentation.

Known Issues
  • Main/Off Hand item both gets displayed in situations when a lot of players feel they shouldn't be (This works as intended at the moment).
  • If you view an Off Hand item when you have a 2H item equipped, you don't get comparison with the equipped 2H item. (This works as intended at the moment).
  • If both comparison tooltips are getting displayed and they are very wide (e.g. German client), it is possible that they don't both fit on the screen. In this case, part of one might get cut off.

Special thank you goes to

Flisher for the very fruitful collaboration on making CharactersViewer and EquipCompare work together.

Thanks goes to
  • WoWInterface and Curse Gaming for hosting the AddOn.
  • The entire Cosmos team for their help and support (including, but not limited to AlexYoshi, Thott, Sarf, AnduinLothar, StarDust, Sasmira).
  • Norganna for making Auctioneer work together with EquipCompare
  • Woofiest for the bug reports and great AddOn pack.
  • All the original localizers (beWRage, Maischter, zerra, eerieN, Firebroo, arith)

Legalese (a.k.a. the Small Print)

The author holds all copyright to this AddOn. You are free to download, copy, distribute and re-host this AddOn in its original, unmodified form, for non-profit purposes. You are free to include this AddOn in any compilation, package, distribution etc. in its original form so long as credit is given to the author. If you distribute or re-host this AddOn, either in a compilation or by itself, you must include a link to the AddOn's official page as the author is responsible for maintaining only the official page of the AddOn. You are allowed, for your own personal use only, to make modifications to this AddOn and to privately distribute such modified form to people known to you (such as friends and guild members). However, you must not publically host or distribute a modified version of this AddOn, without express permission of the author. The author reserves the right to deny any of the above to any person or sites for any reasons.

Optional Dependencies: Khaos, Satellite, CharactersViewer, LootLink

Khaos: If Khaos is installed, EquipCompare options can be set via the Khaos configuration options. In this case, the settings are rememebered on a per-configuration basis.

Satellite: If Satellite is installed, slash commands are registered via Satellite.

Lootlink: If LootLink is installed, you will receive the comparison tooltips when hovering over items in the LootLink database.

CharactersViewer: If CharactersViewer (version 55 or higher) is installed, EquipCompare shows comparison tooltips with the items of the character you have selected in CV, instead of with the currently equipped items, provided this feature is enabled in EquipCompare. Use this great feature to easily compare your equipment or inventory with your alts. Alternatively, do things like receive relevant shopping tooltips at the Auction House, when you are shopping for your alt.

Cosmos (deprecated but supported): If Cosmos is installed, EquipCompare options can be toggled on and off via the Cosmos configuration menu. In this case, the settings are remembered on a per-character basis.

Sky (deprecated but supported): If Sky is installed, slash commands are registered via Sky.
Changes in 2.18:
* Patch 4.0 TOC update

Changes in 2.17:
* Patch 3.3 TOC update

Changes in 2.16:
* Patch 3.1

Changes in 2.15:
* Temporary workaround for the frequent "attempt to compare number with nil" bug that seem to appear for a lot of people.

Changes in 2.14:
* Weapon comparison behaviour changed. This fixes the missing main/offhand tooltip bug as well.
* Tooltip placement logic significantly improved. If there is one side to fit all the comparison tooltips, the code will find it now. In rare cases tooltips may still be partially off the screen, if the tooltips can't fit on any side.

Changes in 2.13:
* Patch 3.0

For older change notes see the included Change Notes.txt file.
Archived Files (2)
File Name
Version
Size
Author
Date
2.17
29kB
Legorol
12-10-09 07:12 PM
2.16
29kB
Legorol
04-13-09 08:03 PM


Post A Reply Comment Options
Old 11-23-08, 11:16 PM  
arcadin
A Kobold Labourer

Forum posts: 1
File comments: 7
Uploads: 0
Same problem when mousing over and have a few other screens open (20+ times), rev 2.14, OK with 2.13

Originally posted by Lusky
Erreur : attempt to compare number with nil
AddOn: EquipCompare
Fichier : EquipCompare.lua
Ligne : 2551
Nombre : 2
Interface\AddOns\EquipCompare\EquipCompare.lua:2551: in function `EquipCompare_ShowCompare'
Interface\AddOns\EquipCompare\EquipCompare.lua:2245: in function `EquipCompare_CheckCompare'
Interface\AddOns\EquipCompare\EquipCompare.lua:1529: in function `EquipCompare_OnUpdate'
[string "*:OnUpdate"]:1: in function <[string "*:OnUpdate"]:1>


I got this error when putting mouse on equipement in chat box.
Then money text appears, adds and stay on info tooltips.
It adds a money in the tooltip and the game seems to go slow and freeze when selling objects.

Informant from Auctioneer is activated.

Seems to be fixed by modifying the line 2551 in :
"if ( right and GetScreenWidth() and right > GetScreenWidth() ) then"
!Swatter log is

["message"] = "Interface\\AddOns\\EquipCompare\\EquipCompare.lua:1276: attempt to compare number with nil",
["count"] = 1,
["addons"] = " Swatter, v5.1.3830 (SnaggleTooth)\n WowheadLooter, v30015\n Ace2, v\n AdvancedTradeSkillWindow, v\n AlphaMap, v3.50.30000\n AlphaMapBattlegrounds, v\n AlphaMapExteriors, v\n AlphaMapInstances, v\n AlphaMapWorldBosses, v\n AlphaMobMap, v1.00.30000\n AlphaQuestHelper, v1.01.30000\n Altoholic, v3.0.003\n AtlasLoot, v5.02.01\n AtlasQuest, v4.2.1\n AucAdvanced, v5.1.3830 (SnaggleTooth)\n AucFilterBasic, v5.1.3830 (SnaggleTooth)\n AucFilterOutlier, v5.1.3830.2531\n AucMatchUndercut, v5.1.3830.2531\n AucScanData, v5.1.3830 (SnaggleTooth)\n AucStatClassic, v5.1.3830 (SnaggleTooth)\n AucStatHistogram, v5.1.3830 (SnaggleTooth)\n AucStatiLevel, v5.1.3830 (SnaggleTooth)\n AucStatPurchased, v5.1.3830 (SnaggleTooth)\n AucStatSales, v5.1.3830.2842\n AucStatSimple, v5.1.3830 (SnaggleTooth)\n AucStatStdDev, v5.1.3830 (SnaggleTooth)\n AucStatWOWEcon, v5.1.3830.2530\n AucUtilAHWindowControl, v5.1.3830.3311\n AucUtilAppraiser, v5.1.3830.2530\n AucUtilAskPrice, v5.1.3830.3175\n AucUtilAutoMagic, v5.1.3830.3142\n AucUtilCompactUI, v5.1.3830.2530\n AucUtilEasyBuyout, v5.1.3830.3583\n AucUtilItemSuggest, v5.1.3830.3108\n AucUtilPriceLevel, v5.1.3830.2545\n AucUtilScanButton, v5.1.3830.2530\n AucUtilScanFinish, v5.1.3830.2530\n AucUtilScanProgress, v5.1.3830.2530\n AucUtilSearchUI, v5.1.3830.3655\n AucUtilVendMarkup, v5.1.3830.2530\n AutoBar, vv3.00.02.07 beta\n Babylonian, v5.1.DEV.130\n BankItems, v30002\n Bartender4, v4.2.1\n BeanCounter, v5.1.3830 (SnaggleTooth)\n BigWigs, v2.0\n BonusScanner, v4.2\n CharacterProfiler, v3.0.1\n Chatmanager, v\n Chatter, v1.0\n Configator, v5.1.DEV.130\n CTRaidTracker, vv1.5.7(3.0.2) (MLdkp.net)\n cyCircled, v0.5\n DebugLib, v5.1.DEV.130\n Decursive, v2.3.0\n DoubleWide, v\n DrDamage, v1.6.0b\n ElkBuffBars, v2.1\n EnhancedFlightMap, v2.0.8\n EnhTooltip, v5.1.3715 (SnaggleTooth)\n EquipCompare, v2.14\n EveryQuest, v$Revision: 43 $\n Exp2, v\n Factionizer, v30002.2\n FishingAce, v0.4.2i\n Fortress, v1.1 \n Gatherer, v3.1.8\n GemHelper, v1.7.1\n GFWLevelator, v3.0\n HealBot, v3.0.3.4\n IceHUD, v1.3.16 (Revision: 301)\n Informant, v5.1.3830 (SnaggleTooth)\n ItemRack, v\n ItemRackOptions, v\n LightHeaded, v264\n LittleWigs, v3.0.0\n LoggerHead, v3\n LootHog, v\n MapNotes, v5.12.30000\n MapNotesBrowser, vv1.00.30000\n MapNotesIconLib, v1.04.30000\n MapNotesIconLibFancy, v\n MapNotesIconLibLegacy, v\n MapNotesIconLibNeptunia, v\n MapNotesIconLibNumbers, v\n MBB, v\n MobInfo2, v3.71\n MobMap, v304\n MoveAnything, v3.0.2-7\n Nameplates, v$Revision: 974 $\n NECB, v20118\n Omen, v3.0.3\n OmniCC, v2.2.4\n QuestHelper, v0.70\n RatingBuster, v\n RecipeBook, v\n Recount, v\n Rep2, v\n RicoMiniMap, v\n sct, v6.2\n sctd, v3.1\n SimpleRaidTargetIcons, v1.06\n SlideBar, v5.1.3830 (SnaggleTooth)\n StealYourCarbon, v3.0.2.15\n Stubby, v5.1.3830 (SnaggleTooth)\n TankPoints, v\n TipTac, v08.11.10\n TipTacTalents, v08.11.05\n Titan, v4.1.2.30000 (Revision 69)\n TitanAmmo, v4.1.2.30000\n TitanBag, v4.1.2.30000\n TitanClock, v4.1.2.30000\n TitanCoords, v4.1.2.30000\n TitanGoldTracker, v4.1.2.30000\n TitanHealBot, v3.0.2.0\n TitanItemBonuses, v4.1.2.30000\n TitanLootType, v4.1.2.30000\n TitanNameToggle, v3.0 r2\n TitanPerformance, v4.1.2.30000\n TitanRegen, v4.1.2.30000\n TitanRepair, v4.1.2.30000\n TitanRider, v3.0 r2\n TitanVolume, v4.1.2.30000\n TitanXP, v4.1.2.30000\n TomTom, v176\n XPerl, v3.0.1f\n XPerlArcaneBar, v\n XPerlParty, v\n XPerlPartyPet, v\n XPerlPlayer, v\n XPerlPlayerBuffs, v\n XPerlPlayerPet, v\n XPerlRaidAdmin, v\n XPerlRaidFrames, v\n XPerlRaidHelper, v\n XPerlRaidMonitor, v\n XPerlRaidPets, v\n XPerlTarget, v\n XPerlTargetTarget, v\n (ck=e17)\n",
["timestamp"] = "2008-11-24 00:37:13",
["context"] = "Global",
["stack"] = "(tail call): ?\n[C]: ?\nInterface\\AddOns\\EquipCompare\\EquipCompare.lua:1276: in function `EquipCompare_ShowCompare'\nInterface\\AddOns\\EquipCompare\\EquipCompare.lua:1123: in function `EquipCompare_CheckCompare'\nInterface\\AddOns\\EquipCompare\\EquipCompare.lua:765: in function `EquipCompare_OnUpdate'\n[string \"*:OnUpdate\"]:1: in function <[string \"*:OnUpdate\"]:1>\n",
}, -- [39]
arcadin is offline Report comment to moderator  
Reply With Quote
Old 11-22-08, 10:15 AM  
Lusky
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Erreur : attempt to compare number with nil
AddOn: EquipCompare
Fichier : EquipCompare.lua
Ligne : 2551
Nombre : 2
Interface\AddOns\EquipCompare\EquipCompare.lua:2551: in function `EquipCompare_ShowCompare'
Interface\AddOns\EquipCompare\EquipCompare.lua:2245: in function `EquipCompare_CheckCompare'
Interface\AddOns\EquipCompare\EquipCompare.lua:1529: in function `EquipCompare_OnUpdate'
[string "*:OnUpdate"]:1: in function <[string "*:OnUpdate"]:1>


I got this error when putting mouse on equipement in chat box.
Then money text appears, adds and stay on info tooltips.
It adds a money in the tooltip and the game seems to go slow and freeze when selling objects.

Informant from Auctioneer is activated.

Seems to be fixed by modifying the line 2551 in :
"if ( right and GetScreenWidth() and right > GetScreenWidth() ) then"
Lusky is offline Report comment to moderator  
Reply With Quote
Old 11-22-08, 07:47 AM  
zoktar
A Cliff Giant
AddOn Compiler - Click to view compilations

Forum posts: 72
File comments: 268
Uploads: 1
yeah, been goin around posting bout this feature on a bunch of addons, wasnt quite sure where this would best be implemented. prob some sort of bank/bag addon, like sanity2 or so.

Originally posted by Legorol
I understand what you are asking for and it would be a great feature to add, it's one of the most requested. Unfortunately it's a lot more difficult to do than it sounds at first and therefore I don't plan to work on it. Here are some of the stumbling blocks:

When you are not at your bank, WoW does not provide information about what items you have in your bank, so EquipCompare can't see those items either.

Now you will say that there are addons that allow you to see the contents of your bank. However, the way these work is that they memorise the bank contents when you are at the bank, and later on display that memorised content. Writing such a memorisation method is quite complicated and belongs to a bank addon, and is outside the scope of what I'd write for EquipCompare.

In principle, it would be possible to use the memorised contents from one of the bank addons, but then either EquipCompare would be dependent on the particular addon, or would have to be written to work with most of the popular ones out there. Neither solution is desirable to me.

Finally there is the issue of how to select the items from the bank that you need to compare against. For this, you need to understand a bit about how the comparisons are performed at the moment.

When you hover on an item, EquipCompare has two methods available to it. It can look at the item and compare it against particular slots on your character sheet, based on the type of the item. (For example, if you hover on a chestpiece, it compares it against whatever is in the chest slot on your character sheet). The other method is to ask WoW to generate the comparison, whatever the result might be, based on just the knowledge of the item you are hovering on. Note that neither of these methods rely on having to look through all the items you currently have equipped.

Therefore what would be neccessary in order to be able to compare against items in the bank is to systematically look through all the items in there, and select the ones that would be sensible comparison targets. This is a layer of complexity which EquipCompare doesn't have at the moment and I don't plan to code it.

If I can think of a totally different approach to comparisons against items in the bank, I might do it, but it's unlikely.
zoktar is offline Report comment to moderator  
Reply With Quote
Old 11-21-08, 02:20 PM  
Maischter
A Defias Bandit

Forum posts: 2
File comments: 94
Uploads: 0
EquipCompare-2.14\EquipCompare.lua:1276: attempt to compare number with nil
EquipCompare-2.14\EquipCompare.lua:1123: in function `EquipCompare_CheckCompare'
EquipCompare-2.14\EquipCompare.lua:765: in function `EquipCompare_OnUpdate'
<string>:"*:OnUpdate":1: in function <[string "*:OnUpdate"]:1>
Maischter is offline Report comment to moderator  
Reply With Quote
Old 11-20-08, 05:54 AM  
Legorol
A Cliff Giant
AddOn Author - Click to view AddOns

Forum posts: 79
File comments: 23
Uploads: 5
Originally posted by zoktar
Hi great addon, i have a feature request, while hovering over an item add with modifier, to also compare item with same type of items in bank. what im looking for is a easy way to determine gear that i find or roll on. for druids and palas for example have to keep track of 3-4+ sets of gear. this way hovering over say a head slot item that is gonna be rolled for and holding say shift, i would be able to see currently equiped, in bags and in bank just adding more tooltips. that way i could determine weather i need the item or not, and quickly (example=pug rolling can go very fast) would be most awsome. cheers.
I understand what you are asking for and it would be a great feature to add, it's one of the most requested. Unfortunately it's a lot more difficult to do than it sounds at first and therefore I don't plan to work on it. Here are some of the stumbling blocks:

When you are not at your bank, WoW does not provide information about what items you have in your bank, so EquipCompare can't see those items either.

Now you will say that there are addons that allow you to see the contents of your bank. However, the way these work is that they memorise the bank contents when you are at the bank, and later on display that memorised content. Writing such a memorisation method is quite complicated and belongs to a bank addon, and is outside the scope of what I'd write for EquipCompare.

In principle, it would be possible to use the memorised contents from one of the bank addons, but then either EquipCompare would be dependent on the particular addon, or would have to be written to work with most of the popular ones out there. Neither solution is desirable to me.

Finally there is the issue of how to select the items from the bank that you need to compare against. For this, you need to understand a bit about how the comparisons are performed at the moment.

When you hover on an item, EquipCompare has two methods available to it. It can look at the item and compare it against particular slots on your character sheet, based on the type of the item. (For example, if you hover on a chestpiece, it compares it against whatever is in the chest slot on your character sheet). The other method is to ask WoW to generate the comparison, whatever the result might be, based on just the knowledge of the item you are hovering on. Note that neither of these methods rely on having to look through all the items you currently have equipped.

Therefore what would be neccessary in order to be able to compare against items in the bank is to systematically look through all the items in there, and select the ones that would be sensible comparison targets. This is a layer of complexity which EquipCompare doesn't have at the moment and I don't plan to code it.

If I can think of a totally different approach to comparisons against items in the bank, I might do it, but it's unlikely.
Legorol is offline Report comment to moderator  
Reply With Quote
Old 11-20-08, 05:38 AM  
Legorol
A Cliff Giant
AddOn Author - Click to view AddOns

Forum posts: 79
File comments: 23
Uploads: 5
Re: Feature missing

Originally posted by Alakaste
EQcompare would compare items equipped to items you had on your action bar. This is a very useful feature. i.e. if you're mining, you want to have your mining gloves on. Easily mouse over the button on your action bar to equip them or re-equip your regular gloves and it shows which you have equipped. Your version only shows the tooltip for the item on the bar and doesn't compare it.
The reason why EquipCompare doesn't show comparisons when you mouse over a button on your action bar is becuase it's possible that you have dragged your currently equipped item onto the action bar (for example a trinket). If EquipCompare showed comparisons, it would be comparing items to themselves in many cases.

The default UI already shows (with a green border) if an item you have on the actionbar is also currently equipped or not, you don't need a comparison tooltip to appear for you to be able to tell this.

Hence there is no need to show a genuine comparison tooltip for an item on the action bar, and EquipCompare has code to deliberately suppress those.
Last edited by Legorol : 11-20-08 at 05:40 AM.
Legorol is offline Report comment to moderator  
Reply With Quote
Old 11-19-08, 06:43 AM  
Legorol
A Cliff Giant
AddOn Author - Click to view AddOns

Forum posts: 79
File comments: 23
Uploads: 5
Sorry for the slow replies, I had been busy.

Mainhand/offhand bug: as noted by several comments, this is indeed a bug, and I'm aware of it. It will be fixed in due course. Thrashfinger's quick fix should work in the meantime.

Tooltip placements: I've known for a long time that the placement logic is not ideal and planning to rewrite it at some point. It's quite hard to come up with an algorithm that works for all situations. (If you take a look at how Blizzard's own UI code does it, they even end up having to move the main tooltip in some corner cases). I wasn't planning on touching the placement code until I have a proper fix.

Tharshfinger's fix for the tooltip placement code may work for some people, but there is one problem with it. ComparisonTooltip2 isn't always populated, so always anchoring ComparisonTooltip1 to it in a rightAlign situation will cause problems.

I want to thank Thrashfinger for the submitted patches and for helping out folks when I wasn't looking

For those of you requesting additional features, unfortunately I won't be working on these for now. (@Alakaste: EquipCompare deliberately doesn't show comparisons when you hover on an action bar. This is intended functionality)
Last edited by Legorol : 11-19-08 at 06:46 AM.
Legorol is offline Report comment to moderator  
Reply With Quote
Old 11-18-08, 04:20 PM  
Oxides
A Kobold Labourer

Forum posts: 0
File comments: 79
Uploads: 0
I'm getting

.\AddOns\EquipCompare\EquipCompare.lua line 1317:
ComparisonTooltip2:SetPoint(): ComparisonTooltip1 is dependent on this

with 2.13 and the Thrashfinger changes. Not saying his changes cause it, i haven't tried this mod without his changes.

After i get this error tooltips become universally corrupt. It seems like its adding a bunch of lines with coin data or something.
Last edited by Oxides : 11-19-08 at 12:19 PM.
Oxides is offline Report comment to moderator  
Reply With Quote
Old 11-15-08, 01:35 AM  
zoktar
A Cliff Giant
AddOn Compiler - Click to view compilations

Forum posts: 72
File comments: 268
Uploads: 1
Hi great addon, i have a feature request, while hovering over an item add with modifier, to also compare item with same type of items in bank. what im looking for is a easy way to determine gear that i find or roll on. for druids and palas for example have to keep track of 3-4+ sets of gear. this way hovering over say a head slot item that is gonna be rolled for and holding say shift, i would be able to see currently equiped, in bags and in bank just adding more tooltips. that way i could determine weather i need the item or not, and quickly (example=pug rolling can go very fast) would be most awsome. cheers.
Last edited by zoktar : 11-15-08 at 02:11 AM.
zoktar is offline Report comment to moderator  
Reply With Quote
Old 11-08-08, 10:12 AM  
Thrashfinger
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 14
Uploads: 1
Tooltip rendered (partially/completely) off screen fix for EquipCompare v2.13

Works with WoW v3.0.3:

The following code modifications should resolve most (if not all) issues with
wide comparative tooltip frames being displayed (partially or completely) off
screen. This change repositions dual comparative tooltip frames when there are
two slots that an item can be equipped in (ie, rings, trinkets, weapons). The
comparative tooltip frames will appear above/below one another instead of to
their left/right, but will still be rendered left/right of the main tootlip.

(1) line is moved
(2) lines are modified
(1) line is added

I recommend you copy/paste the "To" code below (without line numbers) over the
existing code in the EquipCompare.lua file.

Open the EquipCompare.lua file.

Change lines 1259-1267:

From:
----
Code:
1259:	-- Now place it in its rightful place
1260:	ComparisonTooltip2:ClearAllPoints();
1261:	if ( leftAlign ) then
1262:		ComparisonTooltip1:ClearAllPoints();
1263:		ComparisonTooltip2:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
1264:		ComparisonTooltip1:SetPoint("TOPRIGHT", "ComparisonTooltip2", "TOPLEFT", 0, 0);
1265:	else
1266:		ComparisonTooltip2:SetPoint("TOPLEFT", "ComparisonTooltip1", "TOPRIGHT", 0, 0);
1267:	end
To:
----
Code:
		-- Now place it in its rightful place
		ComparisonTooltip1:ClearAllPoints();
		ComparisonTooltip2:ClearAllPoints();
		if ( leftAlign ) then
			ComparisonTooltip2:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
			ComparisonTooltip1:SetPoint("TOPRIGHT", "ComparisonTooltip2", "BOTTOMRIGHT", 0, 0);
		else
			ComparisonTooltip2:SetPoint("TOPLEFT", tooltip:GetName(), "TOPRIGHT", 0, -10);
			ComparisonTooltip1:SetPoint("TOPLEFT", "ComparisonTooltip2", "BOTTOMLEFT", 0, 0);
		end
I am sure there are much more complicated, or maybe even some cleaner ways,
to accomplish similar changes to the relative frame layout that would yield
similar results. This just happens to be one of the quick and dirty methods.

NOTE:
One side effect I observed was that this change does not appear to
"work and play well" with the ALT button functionality.
Last edited by Thrashfinger : 11-08-08 at 10:36 AM.
Thrashfinger is offline Report comment to moderator  
Reply With Quote
Old 11-08-08, 04:07 AM  
Thrashfinger
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 14
Uploads: 1
Off-hand "as intended" behavior (not bug) fix for EquipCompare v2.13

Works with WoW v3.0.3:

The following code modification will resolve the "as intended" behavior which
currently (when items are equipped in both weapon slots) shows only the
equipped "off-hand" item for comparison if you hover over a "main hand" or
"two-hand" item.

Open the EquipCompare.lua file.

Change line 1237:
if ( itype == INVTYPE_WEAPON ) then

To:
if ( itype == INVTYPE_WEAPON ) or ( itype == INVTYPE_WEAPONMAINHAND ) then

This behavior (not bug) fix works, but with one noted side effect. After this
change is applied, "main hand" only items will be compared to equipped items
in both weapon slots, including "off-hand" only items and "one hand" items
equipped in the "off-hand" slot. However, "off-hand" only items will only be
compared to (if equipped) an "off-hand" slotted item. Although this may not be
perfect or ideal, I believe this quick and dirty fix (showing both items in
both weapon slots) is more user-friendly than the "as intended" behavior which
currently looks and feels more like a "bug" (based on user feedback here).

NOTE:
I do not know if this adversely affects other addons that have hooks for
EquipCompare. I use a small selection of addons and have not noticed any
conflicts.
Last edited by Thrashfinger : 11-08-08 at 04:36 AM.
Thrashfinger is offline Report comment to moderator  
Reply With Quote
Old 11-07-08, 08:57 AM  
vpr
A Theradrim Guardian

Forum posts: 65
File comments: 273
Uploads: 0
Anyway to make sure that the tooltip doesn't appear off the screen? It's really annoying when this happens
vpr is offline Report comment to moderator  
Reply With Quote
Old 11-06-08, 08:38 AM  
Alakaste
A Defias Bandit

Forum posts: 2
File comments: 1
Uploads: 0
Feature missing

EQcompare would compare items equipped to items you had on your action bar. This is a very useful feature. i.e. if you're mining, you want to have your mining gloves on. Easily mouse over the button on your action bar to equip them or re-equip your regular gloves and it shows which you have equipped. Your version only shows the tooltip for the item on the bar and doesn't compare it.
Alakaste is offline Report comment to moderator  
Reply With Quote
Old 11-02-08, 08:16 PM  
seebs
Premium Member
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 155
File comments: 185
Uploads: 5
Main hand/off hand

This is stranger than I thought.

If I hover over a weapon, EC shows my shield -- but the stat changes summarized below are actually for my weapon, not my shield. So it shows the right comparison, but the wrong base item tooltip.
seebs is offline Report comment to moderator  
Reply With Quote
Old 10-28-08, 06:10 PM  
lewal
A Kobold Labourer

Forum posts: 0
File comments: 158
Uploads: 0
is the author working on a fix for this off hand bug
lewal is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.