Download
(180 Kb)
Download
Updated: 05-06-11 01:21 AM
Addon for:
FuBar 3.6.5.
Pictures
File Info
Updated:05-06-11 01:21 AM
Created:unknown
Downloads:81,060
Favorites:491
MD5:
FuBar - SkillsPlusFu  Popular! (More than 5000 hits)
Version: 4.1.3
by: Jayhawk [More]
Please note I activated my Portal to keep track of bugs and features request more easily. Thanks.

FuBar - SkillsPlusFu v4.1.3
Release Date: 2011.05.03

This add-on combines the functionality of avngr's FuBar_ProfessionsFu, Kemayo's FuBar_KungFu, and smuggles FubarTradeCooldownFu. This add-on is uploaded with their approval. I decided to merge the the first two because they seemed to have a rather large overlap, although both had bits that were unique and very useful (or just plain good looking). I have tried to keep the best of both. Next I wanted to get rid of another add-on on my bar and added the Trade Cooldown functionality. It took me a while to get the salt shaker support correct, as I'm still figuring out the event flow.

On popular demand, I added the option to show the skills for your other toons.

SkillsPlusFu is currently localised only for English, but should be easy to expand to cover other languages. However, by using BabbleLib it should at least properly for those languages supported by that library.

Use
The FuBar menu will display either Skills or the name of a skill that can be used to make things (so, say, Mining doesn't show, but Smelting does). Behind the skill (name and/or icon depending on your preferences) the number of cooldown items is displayed. This display show (total item - items ready) This will not be shown when you have no cooldown items for any of the toons you play.

By selecting the (right-click) menu you see all skills that you can use to make things with for your current toon. Selecting one of these skills will open the relevant skill window and put it's name/icon up in the FuBar. Clicking this later will open the associated skill window again. The last used skill is saved between sessions.

Options
Show skill label - Toggles the display of the skill name (or the text skills) on the FuBar. Use this when you want to show only the icon and the cooldown info.
Show boolean skills - Toggles skills that do not progress, this includes proficiencies.
Show other player skills - Allows you to select which other toons and skills are shown.
Show cross faction skills - Toggles whether the skills mentioned above include those of other faction toons.

Show player names - Toggles display of the player names in the cooldown info
Show cooldown notification - Toggles displaying the cooldown info on the FuBar
Clear current cooldown data - Clears the current cooldown database.
Hide cooldown data for - Allows you to hide a specific cooldown

Complete changelog

Acknowledgements
This add-on is based on avngr's FuBar_ProfessionsFu, Kemayo's FuBar_KungFu, and smuggles FubarTradeCooldownFu. Thanks guys!

I'd like to add a special thank you to avngr who put me on this path by pointing out to me how easy it was to expand FuBar_PetInfo to my wishes.

Furthermore I'd like to thank all of you who helped me by logging bugs and offering suggestions. Thanks!
4.1.2 - fixed COMBAT_LOG_EVENT_UNFILTERED by adding hideCaster parameter
4.1.1 - updated TOC
4.1.0 - added option to show toon levels (Comicus), fixed issue with Fire Prism (Retlaw)
4.0.2 - removed debuggers
4.0.1 - fixed issue with disappeared own skills and cooldowns
4.0.0 - updated to Cataclysm
removed boolean and weapon skills and languages
added cooldowns for Cataclysm spells (Alchemy, Jewelcrafting, Tailoring)
3.3.1 - removed cooldowns for Titansteel Bar, Moonshroud, Spellweave and Ebonweave (Patch 3.3.3).
added cooldown for Glacial Bag (Patch 3.3.3).
3.3.0 - updated TOC
3.2.0 - added cooldown for new Alchemy transmutes (3.2)
updated TOC
3.0.6 - added cooldowns for Mooshroud, Ebonweave, Spellweave and Icy Prism (serious2)
3.0.5 - removed level 70 cloth cooldowns (patch 3.0.8)
3.0.4 - fixed a possible reason for cooldowns resetting
3.0.3 - added cooldown for Smelt Titansteel (Calesta)
added cooldown for Transmute: Titanium
added cooldown for Northrend Alchemy Research
3.0.2 - added safety catch for viewing other people's trade skills (Myster)
- removed link to TradeSkillInfo as it was broken (Zidomo)
- more rework to try and fix bug with cooldown issues for Alchemy and Enchanting
3.0.1 - bugfix embed.xml, Salt Shaker cooldown
3.0.0 - updated for WotLK, streamlined code, added Inscriptions
2.4.7b - cleaned up code (still possible Alchemy problems)
2.4.7 - bugfix for alchemy cooldoown issue, added transmutes for WotLK (untested)
2.4.6 - removed cooldown for Mooncloth (Patch 2.4.3)
2.4.5 - updated cooldowns (Patch 2.4.2), cleaned up code, fixed problem with Alchemy cooldown failing
2.4.4f - hopefully fixed memory issue.
2.4.4 - updated TOC, redone cooldowns for v. and p. spheres (by Ackis), redone salt shaker, elune's lantarn and snowmaster 9000 (thanks Seerah), removed Alchemy Hack (Ackis)
2.4.3 - updated TOC, zhTW localisation updated (helium), koKR localisation added (7destiny/ochocobo)
2.4.2 - redone cooldowns for v. and p. spheres (by Ackis), updated T.O.C. Fixed Blood Elf issue. Hacked alchemy issue.
2.4.1 - attempted to add cooldowns for void and prismatic spheres
2.4.0b - fixed BabbleRace again
2.4.0 - updated TOC
- added herbalism, mining and skinning to the Other toons skills
- Traditional Chinese (zhTW) localisation added by helium
2.3.1 - fixed bug with showing other toons
- fixed bug in Babble-Race for "Blood Elf"
2.3.0 - added interface to hide specific cooldowns and skills (or a specific toon) as suggested by Highend
2.2.8 - expanded cooldowns for new cloth (hopefully)
- added Blood elf to faction check
2.2.7 - added Jewelcrafting
2.2.6 - fixed some more library issues
- changed datamodel for better functionality
- fixed Purge option
- added fishing skill back to the list of saved skills for other toons
- added a partial French translation for the Cooldown functionality (ID1755), courtesy of sturmy
2.2.5 - actually removed dewdrop:Close()
2.2.4 - added German translation to TOC again (ID2631)
2.2.3 - finally fixed library issues
- set LoadOnDemand to 0 (false) so it will run without FuBar
2.2.2 - added German translation, courtesy of Xanatandor
- added CloseWhenClickd to dewdrops back in (ID2400)
2.2.1 - fixed sloppy coding and removed unnecessary libraries
2.2.0 - updated to WoW 2.0
- updated libraries
- using SkillsPlus to Disenchant, Fish or Pick Locks is no longer possible
Archived Files (1)
File Name
Version
Size
Author
Date
4.1.0
179kB
Jayhawk
01-02-11 08:00 AM


Post A Reply Comment Options
Unread 12-23-08, 10:55 AM  
Jaim Sandar
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 358
Uploads: 1
Originally posted by Jayhawk
Jaim. From what I can see the errors are in Skillet, but the DewDrop library it uses is the one in SkillsPlus, thus giving errors there later. Ace loads only library of each type and I thin in this case that's the one in the SkillsPlus folder.
Actually, it looks like the Dewdrop-2.0 library loaded is from ...\FuBar\libs\Dewdrop-2.0, for what it is worth, and I don't think Skillet uses Dewdrop-2.0.

In any case, the SkillsPlusFu function "func" seems to be tripping up on something in the Dewdrop-2.0 library in the FuBar\libs folder.

I thought I understood that Ace loads the newest instance of a library. The date on the Dewdrop lib in SkillsPlusFu is the newer, dated 12/17/2008, compared to the one in FuBar, dated 11/29/2008. I'm so confused. I wonder what would happen if I deleted the Dewdrop folder in FuBar\libs.

Thank you.
Jaim Sandar is offline Report comment to moderator  
Reply With Quote
Unread 12-22-08, 11:50 PM  
Jayhawk
Premium Member
 
Jayhawk's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 151
Uploads: 6
faye, my cooldowns seem to be behaving at the moment (including the Inscription and Alchemy ones). You may try and zap the Cooldown info? Maybe even check to see if you have a double cooldown save section in the SavedVariables file? The latter happened to me at some time, and I haven't been able to reproduce it.

Jaim. From what I can see the errors are in Skillet, but the DewDrop library it uses is the one in SkillsPlus, thus giving errors there later. Ace loads only library of each type and I thin in this case that's the one in the SkillsPlus folder.
Oh, and thanks for the kind words
Jayhawk is offline Report comment to moderator  
Reply With Quote
Unread 12-22-08, 03:03 PM  
Jaim Sandar
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 358
Uploads: 1
Skillet display problem

I have posted the following errors on the Skillet comments, also. I have no way of knowing which of the two AddOns, Skillet or SkillsPlusFu, is at fault for causing the conflict.

I am still getting errors like the following examples whenever opening a tradeskill window, and the window's contents are not displayed completely or correctly. When I close the window giving the error and open it again, everything looks fine and no error (for that session).

Enchanting:
Code:
[2008/12/14 15:01:52-1600-x1]: Skillet-1.13-153\UI\Sorting.lua:188: invalid order function for sorting
Tailor, Blizzard trade window opened instead of Skillet:
Code:
[2008/12/14 15:03:26-1600-x1]: SkilletStitch-1.1-159 (Skillet):358: Usage: GetItemDataByIndex('profession', index)
<in C code>: in function `CastSpellByName'
FuBar_SkillsPlusFu-3.0.3\SkillsPlusFu.lua:603: in function `func'
Dewdrop-2.0-90320 (FuBar):732: in function <...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:671>
Cooking, Blizz window opens:
Code:
[2008/12/14 15:05:10-1600-x1]: SkilletStitch-1.1-159 (Skillet):358: Usage: GetItemDataByIndex('profession', index)
<in C code>: in function `CastSpellByName'
FuBar_SkillsPlusFu-3.0.3\SkillsPlusFu.lua:495: in function `func'
Dewdrop-2.0-90320 (FuBar):732: in function <...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:671>
First Aid:
Code:
[2008/12/14 15:06:17-1600-x1]: SkilletStitch-1.1-159 (Skillet):358: Usage: GetItemDataByIndex('profession', index)
<in C code>: in function `CastSpellByName'
FuBar_SkillsPlusFu-3.0.3\SkillsPlusFu.lua:531: in function `func'
Dewdrop-2.0-90320 (FuBar):732: in function <...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:671>
This is a fairly minor inconvenience, but an inconvenience just the same.

Thank you so very much for spending your time and efforts to make such a useful tool, and I hope the problem is not to hard to find.
Jaim Sandar is offline Report comment to moderator  
Reply With Quote
Unread 12-20-08, 12:48 AM  
faye
A Kobold Labourer
 
faye's Avatar

Forum posts: 0
File comments: 2
Uploads: 0
I just updated to v3.0.4.
I saw Cacheelma having a similar problem than me.
My Inscription cooldown did the same thing a few hours ago when I updated it, then after a while it seemed to have decided to let me have it my way and finally showed it when I logged onto a different character and does eversince. But it doesn't seem to work with Alchemy cooldowns, both Transmute and Research timers keep resetting (barely spending any time on th.
Btw, don't know if this helps, but my Inscriber is also a Miner, so besides the Inscription Research timers, I also have a Titansteel cooldown. This one always shows right, no matter how often I log out / change character etc.
Hope it helps and you find a way to fix it soon.
faye is offline Report comment to moderator  
Reply With Quote
Unread 12-12-08, 02:18 AM  
Jayhawk
Premium Member
 
Jayhawk's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 151
Uploads: 6
Re: Cooldown reset

Originally posted by Cacheelma
Ever since 3.0.x, Inscription's cooldown seems to reset itself randomly after switching toons/log off.
I know what you mean, and I'm experiencing the same problem. The problem seems indeed random, and what I find most strange is that it seems to reset itself between switching characters (or exiting the game). The cooldowns show correct as you leave the toon involved, but with the new one the cooldown is reset. It's as if the saved variables doesn't get saved properly.

I've asked several people for help, but... no one seems to have a clue. I really hope I can find a solution soon.
Jay
Jayhawk is offline Report comment to moderator  
Reply With Quote
Unread 12-10-08, 08:37 PM  
Cacheelma
A Kobold Labourer

Forum posts: 0
File comments: 22
Uploads: 0
Cooldown reset

Ever since 3.0.x, Inscription's cooldown seems to reset itself randomly after switching toons/log off.

I mean, I do a research on one of my toon, then I look at the cooldown timer on Skillsplusfu to make sure that it's reported properly. But when I log off and log in again to any of my characters (even the one I did the research on previously), Skillsplusfu would give me the message that the inscription research is ready (it's not).

Sometimes I have to log into the character with inscription and reopen the inscription window to make skillsplusfu see the cooldown, then log off and log in again and, if it still tells me the thing is ready, do it over and over until it remembers the cooldown correctly. Sometimes it remembers the cooldown correctly right away.

So what causes this randomness? I can also confirm that it happens with Jewelcrafting and Tailoring cooldowns as well. I'd suspect that it has something with my saved variable files if it happens everytime. But this is so random.

Thanks in advance.
Cacheelma is offline Report comment to moderator  
Reply With Quote
Unread 12-05-08, 06:45 AM  
Jayhawk
Premium Member
 
Jayhawk's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 151
Uploads: 6
Twidget, that should be fixed with version 3.0.2.
Jayhawk is offline Report comment to moderator  
Reply With Quote
Unread 11-23-08, 10:23 AM  
Twidget
An Aku'mai Servant
 
Twidget's Avatar

Forum posts: 33
File comments: 404
Uploads: 0
Hi,
I got the following error when I right clicked the mod on FuBar:

Date: 2008-11-23 11:20:41
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\FuBar_SkillsPlusFu\SkillsPlusFu.lua line 635:
attempt to call method 'IsActive' (a nil value)
Debug:
[C]: IsActive()
FuBar_SkillsPlusFu\SkillsPlusFu.lua:635: OnMenuRequest()
...FuBar_uClock\Lib\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:1134:
...FuBar_uClock\Lib\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:1124
...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:1894:
...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:1843
...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2779:
...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2738
...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:2995: Open()
...FuBar_uClock\Lib\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:1179: OpenMenu()
...killsPlusFu\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:987:
...killsPlusFu\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:985
FuBar\FuBar.lua:1213:
FuBar\FuBar.lua:1207
...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2556:
...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2554
AddOns:

This may have already have been reported... sorry if so.

Thanks,
Twidget
Twidget is offline Report comment to moderator  
Reply With Quote
Unread 11-21-08, 03:12 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Re: Re: TradeSkillInfo

Originally posted by Jayhawk
So it's not a SkillsPlus issue, it's something that has changed in TradeskillInfo. As I wasn't aware it was there, I had no idea what or even how to update it. I'm removing it from the next version, as it seems to be broken.
Ah yes. TradeskillInfo is actually back in very active development here .

Been updating it regularly here. Highly doubt its that circa-2007 change alone causing the problem as I have had no issues between the two up until WotLK. More likely further modifications done lately adding to it. Or something .

Anyway, thanks very much for the reply and look forward to the update(s).
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 11-20-08, 11:22 AM  
khanthal
A Kobold Labourer

Forum posts: 0
File comments: 5
Uploads: 0
Northrend Alchemy Research cooldown (7 day, independant from the transmute cooldown) does not seem to be supported? Or am I doing something wrong/not doing something I should?

I only just got the mod and everything else seems right so....it could be me
khanthal is offline Report comment to moderator  
Reply With Quote
Unread 11-19-08, 07:45 PM  
Myster
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 175
Uploads: 11
Fix for saving invalid Cooldowns for linked tradeskills

Replace with this function at line 417:

function SkillsPlusFu:TRADE_SKILL_CLOSE()
local cooldown = nil
if (IsTradeSkillLinked()) then
_, self.currentPlayer = IsTradeSkillLinked()
if not (self.currentPlayer == UnitName("player")) then return end
else
local numSkills = GetNumTradeSkills()
for i=1, numSkills do
local itemName = GetTradeSkillInfo(i)
-- check name with name in spellMatrix, cooldown item is member of spellMatrix[itemName]
if spellMatrix[itemName] ~= nil then
cooldown = GetTradeSkillCooldown(i)
-- self:Print('Found: '..itemName..' '..spellMatrix[itemName])
if cooldown == nil then cooldown = 0 end -- safety catch; should cooldown be removed (or wrong spell ID used
-- self:Print('Found: '..itemName..format(cooldown))
self:WriteCooldownInfo(spellMatrix[itemName],cooldown)
end
end
end
self:Update()
end
Myster is offline Report comment to moderator  
Reply With Quote
Unread 11-19-08, 07:00 AM  
Jayhawk
Premium Member
 
Jayhawk's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 151
Uploads: 6
Re: TradeSkillInfo

Zidomo, that error is really weird. It's triggered off a variable that is never set inside my code. It seems to be referring to another addon: TradeskillInfo by wmrojer. Digging into the changelog I see:

r70 | mcc | 2007-10-22 18:14:23 +0000 (Mon, 22 Oct 2007) | 2 lines
Changed paths:
M /tmp/trunk/FuBar_SkillsPlusFu/SkillsPlusFu.lua

FuBar_SkillsPlusFu:
- add TradeSkillInfo Menu support..I don't know what I done is legal or not,If not pls remove it.

So it's not a SkillsPlus issue, it's something that has changed in TradeskillInfo. As I wasn't aware it was there, I had no idea what or even how to update it. I'm removing it from the next version, as it seems to be broken.
Jayhawk is offline Report comment to moderator  
Reply With Quote
Unread 11-19-08, 02:57 AM  
Jayhawk
Premium Member
 
Jayhawk's Avatar
AddOn Author - Click to view AddOns

Forum posts: 105
File comments: 151
Uploads: 6
I've been having issues with wrong cooldowns showing up for Alchemy/Enchanting. I'm trying to figure out what is wrong, but... =/ I'm beginning to think it may have something to do with the toonSaveKey not being properly reset when switching toons.

Zidomo, thanks for the information. I think the portal is still up and I can see I got a warning for two new bugs.
Last edited by Jayhawk : 11-19-08 at 03:08 AM.
Jayhawk is offline Report comment to moderator  
Reply With Quote
Unread 11-18-08, 04:24 PM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 34
File comments: 30
Uploads: 1
Originally posted by Shabazza
In the savedvariables.lua there is this section:

["skillsSave"] = {
[""] = {
["Cooking"] = {
["Modifier"] = 0,
["MaxRank"] = 375,
["Rank"] = 375,
},
That happens to me as well, but it does actually save the skills for the current character and for others. It seems to happen more often if I reloadui or if I log out almost immediately after logging in (wrong char, forgot to install the addon I just DLd, etc). If I delete that section from the saved variables file and restart, I have no issues (unless I reloadui/relog too quickly again).
Firedancer is offline Report comment to moderator  
Reply With Quote
Unread 11-18-08, 07:47 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Well, deleted saved variables and relogged. The mouse-over tooltip with the cooldown & other info now works & shows things properly. But the right-click options tooltip still doesn't work properly.

The previously mentioned errors are consistently thrown up upon right-clicking the SkillsPlusFu icon/text & the professions in the menu.

Again, this is the only FuBar plugin I run (and I run/test a lot) that has such an issue.

GL fixing it.

EDIT: I submitted a bug report yesterday and tried again today at your portal; they are not showing up in the list. Is the list no longer active?
Last edited by Zidomo : 11-18-08 at 08:21 AM.
Zidomo is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: