Download
(263 Kb)
Download
Updated: 10-13-12 07:11 AM
Pictures
File Info
Compatibility:
Mists of Pandaria (5.0.4)
Updated:10-13-12 07:11 AM
Created:unknown
Downloads:19,497
Favorites:206
MD5:
Categories:Raid Mods, Bags, Bank, Inventory, Miscellaneous
PassLoot  Popular! (More than 5000 hits)
Version: r139
by: Odlaw [More]
What this mod does

This mod will allow you to automatically roll greed, need, pass, or if the setting is disabled, let you manually roll on loot based on customized loot rules.

By adding customized rules, you can do things like roll greed on all Bind on Equip items, except in Karazhan. You could also let it ignore all Bind on Pickup items, to let you manually roll on them.

Features
Automatic loot settings for each category:
  • Need - This will roll need on the loot in this rule.
  • DE - If an enchanter is present this will roll disenchant.
  • Greed - This will roll greed on the loot in this rule.
  • Pass - This will automatically pass on the loot in this rule.
  • If no loot method is selected, you will have to manually roll on the items.
  • You may select multiple methods.

Loot rules can filter loot based on the following:
  • Bind on status
  • Can I Roll filter - Checks if you can roll differently
  • Class / Spec
  • Equip slot
  • Group/Raid
  • Guild Group - When the group has a percentage of guild mates.
  • Inventory - Do you already own an item
  • Item Level (or formula based on current equipped level)
  • Item Name (partial or exact)
  • Item Price
  • Item Type and SubType
  • Learned Item (recipes/mounts)
  • Loot Won Counter/Comparison - How often you have won an item with the rule
  • Player Name
  • Quality
  • Required Level (or formula based on current level)
  • Uniqueness
  • Usable Items (things that you can equip/use)
  • Zone
  • Zone Type
  • Confirm BoP filter to accept BoP item popups
  • Confirm DE filter to accept DE item popups (use care with this one)

Logic
  • Rules are checked for a match in the order they appear.
  • You may have more than one of the same type of filter.
  • Each filter type must have at least one match.
  • Items may not match any exception.
  • If ( matched rule ) then ( roll ) else ( skip rule )
  • Rolling is attempted in the following order: Need > DE > Greed > Pass. (Depending on what is selected)

Logic Example 1
  • Quality -> Rare
  • Quality -> Epic
  • Binds on -> None
  • Binds on -> Equip
  • Binds on -> Use
This will match IF (Rare OR Epic) AND (None OR Equip OR Use)

Logic Example 2
  • Item Type -> Armor
  • Item Type -> Weapon
  • Item Type -> Plate Armor (exception)
  • Item Type -> 2hd Maces (exception))
This will match IF (Armor OR Weapons) AND NOT (Plate OR 2hd Mace)

Logic Example 3
  • Quality -> Rare
  • Quality -> Epic
  • Binds on -> Pickup
  • Usable -> Unsuable
  • Zone Name -> Halls of Reflection (exception)
  • Zone Name -> Pit of Saron (exception)
This will match IF (Rare OR Epic) AND (BoP) AND (Unusable) AND NOT (HoR OR PoS)

Roll Logic Examples
  • -Need +DE +Greed -Pass = DE > Greed
  • +Need -DE +Greed -Pass = Need > Greed
  • +Need -DE -Greed +Pass = Need > Pass
  • -Need +DE -Greed -Pass = DE > Manual roll

Basic Usage
  • To open the configuration menu, type /passloot
  • Use Add button to create a new rule (Rules are processed in the order they are listed)
  • To remove a rule, select the rule and click the remove button
  • To move a rule up and down in the list, select the rule and click the up/down buttons
  • Once a rule has been selected, you can edit the description or change it's filters.
  • To add a filter to the selected rule, select the filter you wish to add and click add.
  • To remove a filter, select the filter in the Active Filters window and click remove. (You can also shift-right click the filter)
  • To edit an active filter, select the filter in the Active Filters window and change it's properties. (You may have multiple filters of the same type to match)
  • To test an item to see how PassLoot would roll, type /passloot test <shift-click an item>

Example 1
If you want to roll greed on all BoE items, except when on a raid in Karazhan, you can do the following:
  • Rule 1:
    • Zone -> Karazhan (Exception)
    • Binds on -> Equip

Example 2
The only way to have it roll Need if condition X is met, and Greed if condition Y is met is to have 2 separate rules.
You wish to manually roll on all epic items, roll greed on all rare non-bop items items, and roll Disenchant on anything else (and greed if no disenchant option is available)
  • Rule 1: (nothing checked)
    • Quality -> Epic
  • Rule 2: (Greed)
    • Binds on -> Pickup (exception)
    • Quality -> Rare
  • Rule3: (Greed + Disenchant)
    • (no filters added)

Notes
  • Default settings
    • Mod: On (If this setting is off, it won't do automatic pass/greed/need on anything)
    • Quiet: disabled (If this setting is enabled, you won't see what it rolls on)
    • All loot categories are disabled by default to let you manually roll on them.
  • When rolling greed or need on BoP items, WoW will still ask you if you are sure you want to roll since it will bind on pickup. If you want to auto click yes on the BoP confirmations, add a Confirm BoP filter to the rule.
  • The Loot Won Counters are only incremented when you win loot. It will remember what rule was matched and will increment that counter accordingly.

Translation
  • Translation is done through the localization system at www.wowace.com/projects/pass-loot/localization/
- r139 -
ClassSpec - Add Guardian spec
ConfirmDE - Add preferredIndex in popup

- r138 -
Update Equipable - Monk, and a few other class updates.

- r137 -
Fixed some variables that were not defined local.
Changed some StaticPopupDialogs to use a preferred index.
Added Monk to ClassSpec.
Fixed typo in TypeSubType.

- r136 -
Updated for 5.0

- r135 -
Updated libraries and localization

- r134 -
Add LDB to open menu and show last 10 looted items

- r133 -
Locale update - frFR - thanks Blia

- r131 -
Add option to copy/export rules (right click on rule)
Add ptBR and esMX locale files.

- r131 -
toc update

- r130 -
toc update

- r129 -
toc update

- r128 -
More localization updates. Thanks BMSSMB (zhTW) and Shadow11 (deDE)

- r127 -
repackage for updated localization

- r126 -
toc update

- r125 -
Fix Guild Group module.

- r124 -
Type / SubType: Add Trade Goods-Tackle Box, Trade Goods-Item Enchantment, Recipe-Inscription, Gem-Hydraulic, Gem-Cogwheel
Type / SubType: Remove Trade Goods-Armor Enchantment, Trade Goods-Weapon Enchantment

- r123 -
Added Armor - Relic in Type / SubType

- r122 -
Equipable filter: added 2hd axes to dk and paladins

- r121 -
Hopefully fix Equipable module.

- r120 -
Fixed updating which rules get skipped if you remove unknown filters manually.

- r119 -
Added option to display unknown filter variables.
Unknown filter variables show up as gray in the active filters list.
Unknown filter variables can be removed by either the 'Clean Rules' in the options, or 'Remove' on each one in the active filter list. (Unknown filter variables will cause passloot to skip the rule if skip rules is enabled)
Skip rules option now default to off
Changed some text descriptions to be a bit more clear.

- r118 -
Added defaults for SkipRules and SkipRulesWarning
Fix for Can I Roll module
Added option for RegEx matches for Item Name filter (option in modules menu)
Locale updates (zhTW - alpha2009)

- r117 -
Fixed error when it can't figure out what is being rolled on if it is told something is being rolled on.
Modules changes: Will not save empty tables if they were not added to a rule.
Options for skipping rules if a rule has a setting from a module that is disabled or obsolete.
Option to clean disabled / obsolete module settings from rules in profile.
Bug Fix: removes variables from default template when a module is disabled.
deDE - Thanks CuDiLLA
zhTW - Thanks alpha2009

- r116 -
toc update

- r115 -
Add equipable filter - Will match on class based armor and weapons.
zhTW update - thanks alpha2009

- r114 -
Added GuildGroup module - Matches when the group has a percentage of guild mates.

- r113 -
Bug fix for ItemLevel module.

- r112 -
ItemLevel can now use formulas and allows the keyword 'current' for your currently equipped item level.

- r111 -
toc fix

- r110 -
Add options to change the loot rolling text.
Added requested "Can I Roll" filter. (If you can roll need, you might want to look at it before rolling)
Updated toc: ## X-Compatibile-With: 40000

- r109 -
Fix error if some addon removes CONFIRM_LOOT_ROLL from StaticPopups.
Fix display bug with edit box not hiding if you don't press enter/escape in a few dropdowns
Don't load a few modules if a couple libraries are not available.

- r108 -
Repackaged with LibSink-2.0 r70 (custom channels)

- r107 -
Update ZoneType for dynamic instances.

- r106 -
filter regex characters in ItemName match.

- r105 -
Multiple Loot rolling methods can be selected. Order is tried Need > DE > Greed > Pass > Manual Roll (depending on what is selected)
Move modules ui to ace config options menu
Rework Confirm BoP / DE .. no more hooking.
Add Player Name filter.
Add Class/Spec filter.
esES update (yllelder)
zhCN update (pauleldwan)

- r99 -
Added inventory filter to check for items that you already have (checks bank/bags/equipped). It checks for the base items.

- r98 -
Update Bind, Unique filters to scan more lines (heroic items or colorblind mode adds extra lines)
Add an option to let multiple confirm loot popups show. (Blizzard only allows one confirm popup at a time)

- r97 -
Add /passloot test <itemlink> to see how passloot would roll on an item.

- r96 -
localization fix

- r95 -
Change RequiredLevel to allow for logic based rules.

- r94 -
Change dropdown menus with edit boxes to hide better.

- r93 -
Sigh.. add the Usable filter to the toc file.

- r92 -
New filter: Usable - checks for items that are usable (Using tooltip scanning for the red color.. so if anyone knows a better way, let me know)
Sort the filter list.

- r91 -
deDE update (Thanks Slicerdice)

- r90 -
Added ability for filters to become exceptions to a rule. Not all filters can become an exception.
Fix edit boxes in the DropDown menu boxes of some filters to hide properly.
LearnedItem filter: Scan more lines for the 'Already known' text.
Confirm BoP/DE: Allow user to manually roll on an item and will confirm the message.
deDE localization updates (thanks T-Base)

- r89 -
prevent hooking the static popup functions more than once.
fix Confirm BoP and Confirm DE item matching in the popup windows (regex special cases)

- r88 -
Added a confirmation box when you attempt to add the Confirm DE filter. (Endure the confirmation box here so you don't have to endure them later.)
Added a Learned Item filter. Good for Recipes, Mounts, Pets, etc.

- r87 -
Add ConfirmBoP to toc (sigh)
Fix status message if you have DE as an option and ignore as fallback.
Added a Confirm DE filter module. Be careful with this one.

- r86 -
Add the ConfirmBoP module since I said I would.
ruRU update (thanks StingerSoft)

- r85 -
toc update
Adjust the UI a little (make name font smaller to fit better and other small changes)
Added the Confirm BoP module. (We can trade items so I don't see the need for this to be separate addon anymore)
Add DE options for each rule. Rules with DE marked will try to roll for disenchant first, greed/need/pass second.

- r84 -
Shrunk the UI a tiny bit so it could fit in the Blizzard Interface Panels. UI is now displayed there.
ZoneType dropdown expanded a little.

- r83 -
Workaround libsink deforming item links.

- r82 -
Moving from UI from xml to lua coded.

- r81 -
Refresh Active/Available filter lists after disabling a module.

- r80 -
Fixed the tooltip frame that was supposed to be passed to modules.
Removed the settings and profiles tabs, and moving them to Ace config menu.
Renamed some localization keys.
ItemPrice: 3.2 does not need LibItemPrice any longer I believe.
ZoneType: 3.2 changes for 10/25 man normal/heroic modes.
Renamed Zone.lua to ZoneName.lua
Removed PassLoot.xml and Modules.xml
Updated .toc for 3.2

- r79 -
Translation repackage - Russian update (Thanks StingerSoft and lacostes)

- r78 -
toc update (Adding X-WoWI-ID for Minion updater support)

- r77 -
Changed ItemPrice to use a money input frame, and display money with some icons.

- r76 -
Repackaged with updated libraries.

- r75 -
correct toc version

- r74 -
Support for Raid Normal/Heroic in ZoneType filter.
toc update

- r71 -
Added RollMethod to PassLoot_OnRoll message.

- r70 -
Moved the PassLoot_OnRoll event to before the actual rolling occurs, and added the RollID to it's arguments.

- r69 -
Removed embeds.xml, updated .toc

- r68 -
WotLK compatibility.
Binds: Added Bind on Account
TypeSubType: Added Sigils, Inscription Bag, Glyphs, Armor and Weapon Enchantments,
OptionFrameBoxTemplate replacement.
Description change
Added a Settings tab, moved Quiet/Enable mod checkboxes there
Added option to change output to different chat frames using LibSink
Added ItemLevel and RequiredLevel filters
Changed ShowTooltip()
Added ItemPrice filter. Must have a item price library/mod that gives GetSellValue(), or have ItemPrice-1.1 library.
Removed a few remaining arg1 and this's
Small code change to look more uniform.
Added some more data validation checks.

- r79132 -
Redesigned the UI a bit
You may now have multiple filters of the same type (Must have at least 1 match from each filter type)

- r77429 -
PassLoot is now modular. Each filter is it's own module, allowing people to create their own modules.
Changed the layout a little bit.

- r76645 -
Added Group/Raid selection to check if you are in a group or raid.
Added Zone Type to check what type of zone you were in (outside, normal group, heroic group, or raid instance)
Added a Loot Won Comparison and Loot Won Counter. The counter for each rule is incremented only when you win loot based on that rule.

- r65855 -
Updated toc for 2.4

- r64541 -
Updated toc
Changed a few formatting strings
zhTW and zhCN translations from a few people
libbabble-inventory-3.0 seems to have been updated to support more languages as well

- r63489 -
Added a locales.xml
Fixed externals issue.

- r63478 -
Updated .toc to allow embeded files to be loaded separately
Changed versioning to reflect the svn #s instead.

- 3.0.0 -
Changed EquipSlot to a 2-tier dropdown menu style. Dividing up the slots into armor/weapon/misc slots
Merged ItemType and ItemSubType dropdowns into a single dropdown. Also using the 2-tier style.
Removed the command line functions of menu, quiet, enable. (it goes directly to the config window)
Rewrote a few functions (localization, db, event handling) using Ace.

- 2.8.1 -
Fixed error message. (Unique setting wasn't being set on upgrade)

- 2.8.0 -
Added tooltip scanning back in to check for binding and uniqueness
Binding now has the following options: Any, None, Equip, Pickup, Use, Quest
Added a unique check with the following options: Any, Unique, Not (unique)

- 2.7.0 -
Added a button to create a copy of the current profile.
Fixed highlighting text bug.
Added small bits of german localization (item types, subtypes, and equip locations) Untested.

- 2.6.0 -
Updated for 2.3.0
Added the new categories for items in Consumable and Trade Goods, and Containers.

- 2.5.1 -
Updated toc

- 2.5 -
Displays what rule was matched when it rolls on an item.
Combined the ranged weapons for equip slots (guns were showing up under wands).
Combined the chest location to include robes.
Updated a few tooltip descriptions

- 2.4 -
Changed item names to be case-insensitive.
Added a checkbox to turn on/off the mod from the menu.
Added profiles. You can now create your own, or use the default. The default profile can not be deleted. (although individual rules can)
Added a tab menu to switch between rules and profiles.
Changed the way Equip slot works. It is now an equip type.
Removed Armor and Weapon types.
Added Type, and SubTypes. You can now select armor, weapon, recipes, gems, etc from the Type dropdown. SubType will be individual types.

Note: the Miscellaneous Type covers pretty much everything that isn't covered by the other types. (Just the way Blizzard defines items)
It should convert armor / weapon / equip slots to the new format, but double check to make sure it was converted correctly.

- 2.3 -
Fixed quality of loot checking.
Changed zone check to be case-insensitive.

- 2.2 -
It wasn't checking rules sequentially, now it should.
Should no longer keep checking rules if it finds a rule that matches and that rule lets you manually roll on it.

- 2.1 -
Added Equipment slot match.
Added Weapon type match.
Added Armor type match.
Removed poor and common quality (you can't set loot threshold that low anyway)
Added color to the quality match.
Changed how Quality and Bind variables are saved.
Wrote a function to upgrade older rules. (hopefully it will keep all your BOE/BOP/Quality settings for each rule)

- v2.0 -
Rewrite to allow dynamic loot rules.
Archived Files (44)
File Name
Version
Size
Author
Date
r138
263kB
Odlaw
09-28-12 08:51 PM
r137
262kB
Odlaw
09-03-12 05:41 PM
r136
262kB
Odlaw
08-28-12 10:35 AM
r135
261kB
Odlaw
06-06-12 12:13 PM
r133
258kB
Odlaw
02-20-12 08:13 AM
r132
257kB
Odlaw
01-03-12 11:24 AM
r131
250kB
Odlaw
12-01-11 04:35 PM
r130
249kB
Odlaw
07-24-11 06:59 PM
r128
249kB
Odlaw
05-13-11 09:33 AM
r125
248kB
Odlaw
03-13-11 09:56 AM
r124
248kB
Odlaw
02-22-11 12:22 PM
r121
247kB
Odlaw
11-10-10 12:04 AM
r120
247kB
Odlaw
11-07-10 10:40 AM
r118
245kB
Odlaw
11-05-10 01:25 PM
r117
245kB
Odlaw
10-30-10 01:56 PM
r116
241kB
Odlaw
10-12-10 12:24 PM
r115
241kB
Odlaw
10-07-10 09:14 AM
r114
236kB
Odlaw
09-29-10 10:09 AM
r111
234kB
Odlaw
09-09-10 09:42 PM
r110
234kB
Odlaw
09-05-10 10:25 AM
r109
231kB
Odlaw
07-18-10 09:18 AM
r108
230kB
Odlaw
07-03-10 08:39 AM
r106
232kB
Odlaw
02-06-10 01:36 PM
r105
232kB
Odlaw
01-24-10 11:53 AM
r99
221kB
Odlaw
01-05-10 11:06 AM
r98
218kB
Odlaw
12-31-09 06:30 PM
r96
216kB
Odlaw
12-29-09 11:13 PM
r95
216kB
Odlaw
12-29-09 12:09 PM
r94
216kB
Odlaw
12-24-09 10:26 AM
r91
213kB
Odlaw
12-20-09 11:31 AM
r88
208kB
Odlaw
12-14-09 01:40 AM
r87
205kB
Odlaw
12-10-09 04:51 PM
r86
203kB
Odlaw
12-10-09 10:26 AM
r84
193kB
Odlaw
09-14-09 04:34 PM
r83
194kB
Odlaw
09-11-09 08:31 PM
r82
193kB
Odlaw
08-06-09 08:50 PM
r79
117kB
Odlaw
06-26-09 09:25 AM
r78
116kB
Odlaw
06-02-09 11:51 AM
r77
116kB
Odlaw
05-27-09 10:13 AM
r76
115kB
Odlaw
05-22-09 10:10 AM
r75
115kB
Odlaw
04-17-09 09:08 AM
r74
115kB
Odlaw
04-14-09 09:23 AM
r71
100kB
Odlaw
01-25-09 11:55 AM
r68
99kB
Odlaw
10-13-08 03:42 PM


Post A Reply Comment Options
Unread 12-31-09, 10:30 AM  
Kerecha
A Deviate Faerie Dragon
 
Kerecha's Avatar

Forum posts: 10
File comments: 200
Uploads: 0
Done some more tests now and any items with "heroic" are competely ignored if the BoP filter is active, if i change BoP into "any" or remove the bind filter the filter matches up properly.

This testing has been done with only passloot and atlasloot (to get links to test with) active.

Quick idea on possible cause.

Bind information ins normally listen on the second line of the tooltip.

Itemname
Bindinfo

"rest of stuff"

But when "heroic" is added the bind info moves to the 3rd line

Itemname
"heroic"
Bindinfo

"rest of stuff"


Might this be whats causing it (ie passloot scanns line 2 for "binds on" and when not found there passes the item as not binding at all without checking any other lines)?
Last edited by Kerecha : 12-31-09 at 11:06 AM.
Kerecha is offline Report comment to moderator  
Reply With Quote
Unread 12-31-09, 10:24 AM  
Kerecha
A Deviate Faerie Dragon
 
Kerecha's Avatar

Forum posts: 10
File comments: 200
Uploads: 0
doubblepost
Last edited by Kerecha : 12-31-09 at 11:06 AM.
Kerecha is offline Report comment to moderator  
Reply With Quote
Unread 12-31-09, 10:05 AM  
AnrDaemon
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 115
File comments: 2363
Uploads: 6
Originally posted by xtoq
Ok I think I've noticed a bug in the /passloot test slash command. I have a rule set up like this:

BoP
Confirm D/E
Epic quality
!PoS
!HoR
!FoS

It works as you would think it would in PoS, FoS, and HoR, by ignoring things. However, if I use a link from an item in PoS/FoS/HoR, the "rule" comes back that it will roll d/e on the item, even though that is not the case when the instance happens. Any idea why this would be? I've tried it without the "!" before the instances, at that point, the rule rolls d/e on those items, but when you do /passloot test, the items say they will be ignored.
Too complicated filter.
Simple add a rule to DE i200 BoP "epics". Much easier.
AnrDaemon is offline Report comment to moderator  
Reply With Quote
Unread 12-31-09, 02:17 AM  
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view AddOns

Forum posts: 32
File comments: 641
Uploads: 3
Ok I think I've noticed a bug in the /passloot test slash command. I have a rule set up like this:

BoP
Confirm D/E
Epic quality
!PoS
!HoR
!FoS

It works as you would think it would in PoS, FoS, and HoR, by ignoring things. However, if I use a link from an item in PoS/FoS/HoR, the "rule" comes back that it will roll d/e on the item, even though that is not the case when the instance happens. Any idea why this would be? I've tried it without the "!" before the instances, at that point, the rule rolls d/e on those items, but when you do /passloot test, the items say they will be ignored.
__________________
There is absolutely no evidence to support the theory that life is serious.
xtoq is offline Report comment to moderator  
Reply With Quote
Unread 12-30-09, 09:59 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
tooltip addons shouldn't affect it.. i use a tooltip frame that shouldn't be affected by such mods.

I'll keep investigating.
Last edited by Odlaw : 12-30-09 at 10:09 PM.
Odlaw is offline Report comment to moderator  
Reply With Quote
Unread 12-30-09, 08:50 PM  
Kerecha
A Deviate Faerie Dragon
 
Kerecha's Avatar

Forum posts: 10
File comments: 200
Uploads: 0
Originally posted by Odlaw
Hrm.. I am having a hard time replicating this bug. Was there any errors? What items in particular? I've tried numerous heroic items without error.

The Usable filter works as follows: sets a tooltip, and tries to scan the tooltip.
It processes each line of the tooltip (left and right side) until it finds a newline character (\n) on the left side. Patterns look like this:
LeftText1: "Pattern: Lunarc Eclipse Robes"
LeftText2: "Races: Human, Dwarf, Night Elf, Gnome, Draenei"
LeftText3: "Requires Leatherworking (450)"
LeftText4: "Use: Teaches you how to make a Lunar Eclipse Robes."
LeftText5: "\nLunar Eclipse Robes"
<rest of it is the item it makes + mats>

While it is scanning each line (up until the \n character at the start of the text), it checks the color of the text. If it matches the red color for 'Already Known', and invalid requirements (such as the leatherworking requirement), or things like Plate armor for a caster, it should return that it is not usable.

Now I can forsee a few problems:
1 - The item itself is not cached, and it is trying to scan the tooltip before it has been loaded. I tried replicating this by checking items that are not in my cache, and what I end up getting is an error in some other module (from trying to concatenate a nil string) and it never even reached the usable module. The error caused it not to even roll.

Since you say it IS rolling, but using a different rule, I am thinking this is not the case. WoW seems to cache the item, and load the tooltip properly from what I can tell before rolling. (Unique filter also does tooltip scanning as does the Binds On filter since no function can tell if it's bind on account etc.)

2 - for some reason, the item you have is adding a new line somewhere in the tooltip that isn't normal.

3 - The color for 'unusable' items that i check for is different in your client.

I have tried turning the 'colorblind' features in wow options to on, but that doesn't seem to affect the usable filter. (although i think i found a bug for the unique filter for those that use colorblind option)

Does the heroic tag have the same color as unusable items for you?



edit: reason i scan until i find a newline character, is because patterns can be usable, while the item they make might not be. This was the only way I could figure out to only scan part of the tooltip. I've not found an item that contains a newline character yet, so this seemed like the best solution.
No error messages.

Maybe i was being unclear about how items with "heroic" tag are being treated.

I use the new test command and link random stuff that my guildies has equioed, any items without the "heroic" part is properly being passed on with referense to my "unusable" filter, but any item cointaining the "Heroic" tag just triggers a "no filters matched" and thus ignored and left for manual rolling.

The "heroic" text is green.

Only thing i have adding anything to tooltip is ratingbuster.


I will do some more testing tomorrow to see if i can can narrow it down a bit by testing varoius filters and try to bug it out, but now its time for some sleep


Originally posted by AnrDaemon
O.O You are not running ToGC with ML enabled?
Ofc not, we always have grp loot on in all our raids. Who are u to trust if u can't trust your guildies? Even if we got a ninja in on trail or something, loot from one boss is a fairly cheap price to pay to weed them out.

Thats part of the reason i want to get my unusable filter working right, to autopass everything i know i don't want, leaving only the stuff that might be of interest. (makes me wish i could add filters with specific stats to ignore, like str/agi/ap/def and simmilar to weed out rings/necks/backs not of interest)
Last edited by Kerecha : 12-30-09 at 09:11 PM.
Kerecha is offline Report comment to moderator  
Reply With Quote
Unread 12-30-09, 07:40 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
Hrm.. I am having a hard time replicating this bug. Was there any errors? What items in particular? I've tried numerous heroic items without error.

The Usable filter works as follows: sets a tooltip, and tries to scan the tooltip.
It processes each line of the tooltip (left and right side) until it finds a newline character (\n) on the left side. Patterns look like this:
LeftText1: "Pattern: Lunarc Eclipse Robes"
LeftText2: "Races: Human, Dwarf, Night Elf, Gnome, Draenei"
LeftText3: "Requires Leatherworking (450)"
LeftText4: "Use: Teaches you how to make a Lunar Eclipse Robes."
LeftText5: "\nLunar Eclipse Robes"
<rest of it is the item it makes + mats>

While it is scanning each line (up until the \n character at the start of the text), it checks the color of the text. If it matches the red color for 'Already Known', and invalid requirements (such as the leatherworking requirement), or things like Plate armor for a caster, it should return that it is not usable.

Now I can forsee a few problems:
1 - The item itself is not cached, and it is trying to scan the tooltip before it has been loaded. I tried replicating this by checking items that are not in my cache, and what I end up getting is an error in some other module (from trying to concatenate a nil string) and it never even reached the usable module. The error caused it not to even roll.

Since you say it IS rolling, but using a different rule, I am thinking this is not the case. WoW seems to cache the item, and load the tooltip properly from what I can tell before rolling. (Unique filter also does tooltip scanning as does the Binds On filter since no function can tell if it's bind on account etc.)

2 - for some reason, the item you have is adding a new line somewhere in the tooltip that isn't normal.

3 - The color for 'unusable' items that i check for is different in your client.

I have tried turning the 'colorblind' features in wow options to on, but that doesn't seem to affect the usable filter. (although i think i found a bug for the unique filter for those that use colorblind option)

Does the heroic tag have the same color as unusable items for you?



edit: reason i scan until i find a newline character, is because patterns can be usable, while the item they make might not be. This was the only way I could figure out to only scan part of the tooltip. I've not found an item that contains a newline character yet, so this seemed like the best solution.
Last edited by Odlaw : 12-30-09 at 07:59 PM.
Odlaw is offline Report comment to moderator  
Reply With Quote
Unread 12-30-09, 05:56 PM  
AnrDaemon
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 115
File comments: 2363
Uploads: 6
Originally posted by Kerecha
Latest Alpha buggers out on items flagged with "heroic" tag and won't match them to "unusable" fikter.
O.O You are not running ToGC with ML enabled?
AnrDaemon is offline Report comment to moderator  
Reply With Quote
Unread 12-30-09, 03:05 PM  
Kerecha
A Deviate Faerie Dragon
 
Kerecha's Avatar

Forum posts: 10
File comments: 200
Uploads: 0
Latest Alpha buggers out on items flagged with "heroic" tag and won't match them to "unusable" fikter.

(im playing on a preist and set to pass all unusable BoP in raids, but items in ToGC are being passed along to wiev/roll as usable)

My guess is that its the "heroic" tag that messes it up since it works fine everywhere else.



added: About the armorclass i use this on my pally for passing non plate, non ring/neck/trinket/back/librams

1:
Weapon
Unusable
BoP
Epic
Raid
"pass"


2:
!misc
!plate
!libram
BoP
Epic
Raid
"pass"

1st one to sort out wepons and the second for the rest.
Last edited by Kerecha : 12-30-09 at 03:33 PM.
Kerecha is offline Report comment to moderator  
Reply With Quote
Unread 12-30-09, 10:56 AM  
Raederle
A Deviate Faerie Dragon

Forum posts: 18
File comments: 101
Uploads: 0
For the most part the existing logic choices are fine, especially now that that ! variable exists.

I would still love to see a "my armor type" variable, with the fixed meaning of cloth for mages/priests/warlocks, leather for druids/rogues etc etc. That would force me to choose for the armor type I wear, and let me default to greed/pass on the rest, at which point I can make the rules generic for all my chars.

Just checking that we're referring to required level on the items? Ilevel wont help much once you hit the 60's really. And I'll have to make sure the "look at bop" rule is above that since many bop items dont have levels, but that's my worry , not yours.

Raederle
Raederle is offline Report comment to moderator  
Reply With Quote
Unread 12-29-09, 04:14 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
Re: Re: Re: Re: Variables

Ok, I updated the required level filter. Instead of substituting -1 for your current level, i have altered it to allow you to type in a mathematical equation. (Actually, it translates it into lua script) You are allowed the variable 'level'

so you can type in level - 5 to match items with your current level - 5
or level / 2 or whatever you want.

I've thought about expanding upon this idea to allow you to write your own custom filters that can have their own logic that isn't limited to the logic i have in place.

You could then write stuff like xor's (Rare and not BoP) or (BoP and not Rare)
Odlaw is offline Report comment to moderator  
Reply With Quote
Unread 12-26-09, 05:36 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
Re: Re: Re: Variables

Ok.. I see what you want now. I could turn the edit box into a text field that saves the entire text, and evaluates it every time loot gets rolled on..
Only downside is if you type in text that gets evaluated into an error, it will return false.
Odlaw is offline Report comment to moderator  
Reply With Quote
Unread 12-25-09, 01:54 PM  
AnrDaemon
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 115
File comments: 2363
Uploads: 6
Re: Re: Variables

Originally posted by Odlaw
Having a setting for MyArmoryType / MyWeaponType would be extremely time consuming and difficult to code in. I did add a 'usable' filter. The way it works is it checks for red colored text in the tooltip to determine if you can 'use' it. Similar to how the auction house works if you check for usable items. If you wear mail, cloth and leather will show up as 'usable' as well.

For Required Level, I added the option for -1 being your current level. So type in -1 for required level, and it will match on your current level.
Could you please make it so 0 = current level? Then we can use +/- to add to that.
AnrDaemon is offline Report comment to moderator  
Reply With Quote
Unread 12-25-09, 11:28 AM  
Raederle
A Deviate Faerie Dragon

Forum posts: 18
File comments: 101
Uploads: 0
That alone does help a lot, as it fixes a moving target. Would it be possible to make -1 = 5 or 10 less than my level, though a minimum of 1? That's very little extra code. When levelling a toon up, looking at greens, something that's a required level of 2-3 less than yours can often be an upgrade if it's been a while. 5 levels less, or 7 makes that much less likely. I often have chars who go back to finish up quests and want to pass on all the low stuff, but one level lower than me could very well be an upgrade.

Thanks also for the speedy reply.

Happy Winterfest!
Raederle is offline Report comment to moderator  
Reply With Quote
Unread 12-24-09, 04:26 PM  
Odlaw
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 67
Uploads: 7
Re: Variables

Having a setting for MyArmoryType / MyWeaponType would be extremely time consuming and difficult to code in. I did add a 'usable' filter. The way it works is it checks for red colored text in the tooltip to determine if you can 'use' it. Similar to how the auction house works if you check for usable items. If you wear mail, cloth and leather will show up as 'usable' as well.

For Required Level, I added the option for -1 being your current level. So type in -1 for required level, and it will match on your current level.
Odlaw is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.