Download
(82 Kb)
Download
Updated: 05-19-09 03:56 PM
Pictures
File Info
Updated:05-19-09 03:56 PM
Created:unknown
Downloads:243,494
Favorites:974
MD5:
SellFish  Popular! (More than 5000 hits)
Version: 2.1.10
by: Tuller [More]
SellFish has become integrated into the game as of World of Warcraft v3.2.0, and I'm now discontinuing the addon. Thank you for the support!

SellFish is a lightweight addon for displaying sell value data for items, originally based on ColaLight. The addon includes sell values for the vast majority of items by default, and will automatically update prices whenever you visit a vendor.

Commands: (All start with /sf or /sellfish)
  • /sf ? - displays help messages
  • /sf reset - resets the item database
  • /sf style - cycles between graphical and text displays for sell value
2.1.10
* Updated localization

2.1.9
* Updated ItemPrice

2.1.8
* Updated ItemPrice(if it was updated0
* Bumped TOC for 3.1

2.1.7
* Updated ItemPrice

2.1.6
* Updated ItemPrice

2.1.5b
* Corrected zip

2.1.5
* Updated ItemPrice

2.1.4
* Updated ItemPrice
* Fixed a bug preventing sellfish's new sell value cache from being cleared when updating item price



2.1.4
* Updated ItemPrice
* Fixed a bug preventing sellfish's new sell value cache from being cleared when updating item price

2.1.3 (11/24)
* Updated ItemPrice

2.1.3 (08-11-18)
* Updated ItemPrice

2.1.3
* Updated ItemPrice
* Fixed a bug with hooking mail items

2.1.2
* Updated ItemPrice
* Added Guildbank support

2.1.1
* Updated ItemPrice
* Made compatible with WoW 3.0

2.0.8
* Updated ItemPrice
* Fixed a bug with querying cached item (hopefully really this time)

2.0.7
* Updated ItemPrice
* Fixed a bug with cached item queries

2.0.6
* Updated for 2.4
Optional Files (0)


Archived Files (9)
File Name
Version
Size
Author
Date
2.1.9
89kB
Tuller
04-26-09 04:28 PM
2.1.8
85kB
Tuller
04-12-09 06:41 PM
2.1.7
77kB
Tuller
03-14-09 11:48 AM
2.1.6
85kB
Tuller
01-01-09 09:01 PM
2.1.5b
77kB
Tuller
12-19-08 10:54 PM
2.1.5
75kB
Tuller
12-19-08 06:05 PM
2.1.4
77kB
Tuller
12-06-08 08:37 AM
2.1.3 (11/24)
76kB
Tuller
11-24-08 05:21 PM
2.1.3 (08-11-18
74kB
Tuller
11-18-08 04:54 PM


Post A Reply Comment Options
Unread 11-11-07, 06:45 PM  
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 9560
File comments: 584
Uploads: 25
Re: Stack size shown?

Originally posted by speak
If not, can you recommend a mod that does it, and also plays nicely with SellFish?

Thanks!
I use Mendeleev. Informant from the Auctioneer Suite does, as does KCI (I think) and a few others I believe.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

[SIGPIC][/SIGPIC]
Seerah is offline Report comment to moderator  
Reply With Quote
Unread 11-11-07, 02:00 PM  
Tuller
A Black Drake
 
Tuller's Avatar
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 1615
Uploads: 36
2.0.3

I've put 2.0.3 up. The TOC is updated for 2.3, but it should work on normal realms.

Hi, does this mod include functionality to show the stack size of the item?
No, and I have no clue what addon might do so
Tuller is offline Report comment to moderator  
Reply With Quote
Unread 10-29-07, 02:07 PM  
speak
A Wyrmkin Dreamwalker
 
speak's Avatar

Forum posts: 57
File comments: 186
Uploads: 0
Stack size shown?

Hi, does this mod include functionality to show the stack size of the item?

If not, can you recommend a mod that does it, and also plays nicely with SellFish?

Thanks!
speak is offline Report comment to moderator  
Reply With Quote
Unread 10-25-07, 02:55 PM  
Tuller
A Black Drake
 
Tuller's Avatar
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 1615
Uploads: 36
Re: External access to SellFish

Originally posted by Fin
Heya,

Any chance you could remove the "local SellFish = {}" line at the start of db.lua? You deserve much credit for keeping everything localised, but it would be nice to be able to access SellFish externally - specifically in my case, so that I can fix GarbageFu without having to reimplement a SellFish function. Currently, the call to SellFish:GetPrice() is failing.

cheers,

- Fin
You can use GetSellValue(item) to get at the price of anything. As an added bonus, it'll use data from any other addon that implements that function, too
Tuller is offline Report comment to moderator  
Reply With Quote
Unread 10-20-07, 11:31 PM  
Fin
An Aku'mai Servant
 
Fin's Avatar
AddOn Author - Click to view AddOns

Forum posts: 34
File comments: 74
Uploads: 4
External access to SellFish

Heya,

Any chance you could remove the "local SellFish = {}" line at the start of db.lua? You deserve much credit for keeping everything localised, but it would be nice to be able to access SellFish externally - specifically in my case, so that I can fix GarbageFu without having to reimplement a SellFish function. Currently, the call to SellFish:GetPrice() is failing.

cheers,

- Fin
Fin is offline Report comment to moderator  
Reply With Quote
Unread 09-30-07, 03:07 PM  
existe
A Deviate Faerie Dragon
 
existe's Avatar

Forum posts: 17
File comments: 29
Uploads: 0
Originally posted by Tuller
Thanks. This is fixed (at least it should be) in 2.0.2
So far so good, thanks for the quick turn around!
existe is offline Report comment to moderator  
Reply With Quote
Unread 09-30-07, 02:41 PM  
Tuller
A Black Drake
 
Tuller's Avatar
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 1615
Uploads: 36
Originally posted by existe
Get this error on latest version:

\SellFish\db.lua:156: attempt to perform arthmetic on local 'cost' (a nol value)

happens when I talk to Vendors or mouse over items that dont sell.
Thanks. This is fixed (at least it should be) in 2.0.2
Tuller is offline Report comment to moderator  
Reply With Quote
Unread 09-30-07, 07:21 AM  
existe
A Deviate Faerie Dragon
 
existe's Avatar

Forum posts: 17
File comments: 29
Uploads: 0
Get this error on latest version:

\SellFish\db.lua:156: attempt to perform arthmetic on local 'cost' (a nol value)

happens when I talk to Vendors or mouse over items that dont sell.
existe is offline Report comment to moderator  
Reply With Quote
Unread 09-29-07, 12:35 PM  
Tuller
A Black Drake
 
Tuller's Avatar
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 1615
Uploads: 36
2.0.0 Changes

2.0.0 changes:
* SellFish now uses ItemPrice-1.1 (Bam) as the backend
* A bunch of tooltip fixes, thanks to Polarina (Valuation)
Tuller is offline Report comment to moderator  
Reply With Quote
Unread 07-05-07, 07:01 PM  
Bam
A Deviate Faerie Dragon
 
Bam's Avatar
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 5
Uploads: 1
Originally posted by Tuller
Neither does sellfish Unsellable are not stored to save storage space. I think itempricetooltip does store them, so it may have the functionality you're looking for.
No, my addon doesn't have it either. And it seems none of the big information web-sites differentiate between items not having a price and the price not being known. So it's probably difficult to get this information in a reliable way.
Bam is offline Report comment to moderator  
Reply With Quote
Unread 07-04-07, 05:22 PM  
Tuller
A Black Drake
 
Tuller's Avatar
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 1615
Uploads: 36
Originally posted by Lombra
Hi,
could you make it display "No sell price" when that is the case? Currently I don't know if there simply isn't any price stored or if it's unsellable.
Neither does sellfish Unsellable are not stored to save storage space. I think itempricetooltip does store them, so it may have the functionality you're looking for.
Last edited by Tuller : 07-04-07 at 05:29 PM.
Tuller is offline Report comment to moderator  
Reply With Quote
Unread 07-02-07, 10:51 AM  
Lombra
A Chromatic Dragonspawn
 
Lombra's Avatar
AddOn Author - Click to view AddOns

Forum posts: 193
File comments: 270
Uploads: 25
Hi,
could you make it display "No sell price" when that is the case? Currently I don't know if there simply isn't any price stored or if it's unsellable.

Thanks

Edit: Noticed now that my dr00d Insignia of the Alliance insists on having a 2 copper sell price even though I have visited a vendor and updated it. Same goes for Stormpike Insignia Rank 2.
__________________
Grab your sword and fight the Horde!
Last edited by Lombra : 07-02-07 at 07:49 PM.
Lombra is online now Report comment to moderator  
Reply With Quote
Unread 06-20-07, 06:49 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Originally posted by Tuller
If you're using fubar to do CPU profiling, you're not going to get an accurate result, since fubar and itemprice "share" code. The best way to do so is to run both a non ace profiling addon and just sellfish or itemprice at the same time.
I wasn't comparing the two as per CPU usage. I was mentioning it in comparison to...every other mod I run . Yes, shared code may have an effect if doing a strict comparison. As I said in the next paragraph (referring to ItemPrice): Though with its (Ace2) dependencies, its hard to tell via those performance gathering mods whether for sure it does a better job or not..

Regularly run several dozen mods here (and do testing on many more). SellFish 1.5 was consistently in second to fourth place among all mods here in both "CPU total" & "CPU rate" all the time it was tested, behind Group Calendar and/or ES_GuildCheck (among others). The raw numeric totals of those two stats were consistently on another plane of CPU usage above nearly all other non-Ace mods I run.

Look forward to testing out the 1.6 workaround.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 06-17-07, 10:55 AM  
Tuller
A Black Drake
 
Tuller's Avatar
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 1615
Uploads: 36
SellFish is nice & compact...with its memory usage. But testing with both FuBar_PerformanceFu & FuBar_Usage (with Blizzard's CPU profiling activated through the mods) shows that SellFish sucks up an incredible amount of CPU time. Hope this not-so-compact problem is rectified soon.
If you're using fubar to do CPU profiling, you're not going to get an accurate result, since fubar and itemprice "share" code. The best way to do so is to run both a non ace profiling addon and just sellfish or itemprice at the same time.

Even then, I don't expect the results to be accurate for SellFish since using metatables seems to freak out the profiler a bit. I noticed it when testing out the old/new search methods in Ludwig.

That being said, I would suspect that ItemPrice has a faster initial lookup than SellFish. From what I've read about the changes that have been made, the DB now uses a very regular format. This allows ItemPrice to use an index to find data, while SellFish uses string.match (slow).

SellFish, however, stores the result in a cache whenever it looks something up (this is what causes the CPU profiler to freak out), which I would suppose makes every lookup after the first for a price to be on par with ItemPrice's method. Now, since tooltips for bag slots are generally updated every frame, I would hope that this would make the two methods on par as over time as far as access time goes.

Database updating: ItemPrice's maintainer also crawls wowhead for data, and ItemPrice's main method of updating is via SVN. It will always have data that's more up to date than SellFish.

Edit:
Turns out there's a pretty large penalty in SellFish when there's a cache miss. I've added a workaround in 1.6.
Last edited by Tuller : 06-20-07 at 10:11 AM.
Tuller is offline Report comment to moderator  
Reply With Quote
Unread 06-17-07, 04:04 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
SellFish is nice & compact...with its memory usage. But testing with both FuBar_PerformanceFu & FuBar_Usage (with Blizzard's CPU profiling activated through the mods) shows that SellFish sucks up an incredible amount of CPU time. Hope this not-so-compact problem is rectified soon.

ItemPrice/Tooltip initially appears to do a better job in this regard. Though with its dependencies, its hard to tell via those performance gathering mods whether for sure it does a better job or not.

Originally posted by Harwel
Since 2.1, the vendor price of quite a few green gems has decreased, and Sellfish (nor ItemPriceTooltip for that matter) reflect this accurately. Specifically, all Blood Garnet and Green Peridot cuts now vendor for 25s instead of 1g. Sounds minor, but I like to haunt the AH for deals on green quality gems, cut them, and vendor them for spare cash.
Cuts & raw uncommon quality gems both vendor for 25s now.

ItemPrice-1.0 (the library for ItemPriceTooltip, included in the ItemPriceTooltip ZIP below) has its sell value database updated very frequently by the author. The last database update (from the files.wowace.com posting of the mod) was done on June 13. SellFish's database--defaults.lua--was last updated on May 5.

As the database is compressed, can't see offhand if the vendor prices have been modified to account for the new gem prices. Best to open a vendor window with one in your pack. Because like many item price addons (including SellFish), new prices for items will be automatically recorded in saved variables when you visit a vendor & used by ItemPriceTooltip in the future if they differ from the mod's database price.

Originally posted by Izadore
So what exactly do I need to do with ItemPrice then? First time I've heard of it. Will I need to have it installed for this to work now? Tried to look for a desc over at wowace.com, but they don't have it listed (like so many other mods).
ItemPriceTooltip, listed at wowace.com.

Direct download was posted above. That mod and SellFish are completely unrelated (except for the fact they both do the same thing).
Last edited by Zidomo : 06-17-07 at 04:19 AM.
Zidomo is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: