Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(3 Kb)
Download
Updated: 08-05-09 11:00 AM
Pictures
File Info
Updated:08-05-09 11:00 AM
Created:unknown
Downloads:12,296
Favorites:142
MD5:
Damn Quest Icons  Popular! (More than 5000 hits)
Version: r20090805
by: Shadowed [More]
Ever hate when you're questing and you have 20 quests in your quest log, and you need to click through 2-3 different panels to find out which one is the one you've completed? This mod solves that by graying out the "?" icon and the "*" bullet point on quest turn in panels when the quest isn't completed yet.

Author: Shadowed <shadowed.wow@gmail.com>
Date: Wed Aug 5 09:57:55 2009 -0700
Updated getglobal -> _G
TOC Bump

Date: Sat Jun 13 18:09:11 2009 -0700
* CLRF

Date: Sat Apr 25 07:30:48 2009 +0000
* TOC bump, previous update was 20300 should probably indicate it still works given it's almost been two years

Date: Sun Sep 7 18:18:43 2008 +0000
* Improved color code stripping, which I stole from Industrial, who stole it from me!

Date: Wed Nov 28 09:46:00 2007 +0000
* Switched methods of doing text checks to just strip out everything we don't like, if the check fails because a mod does something special you're out of luck

Date: Wed Nov 14 09:34:14 2007 +0000
* Fixed a bug caused by WoW 2.3 due to quest text now having color codes wrapped around them, moved to GetToThePoint's method of checking quest names by storing the original as it's added instead of going off of the GetText() results. Should be a bit more accurate hopefully

Date: Sat Nov 10 22:11:49 2007 +0000
* Updated all TOC information to 20300, added revision info to the version field, also the author field is now consistent instead of using 5 different character names

Date: Mon Nov 5 01:38:33 2007 +0000
* Fixed quests with ( and ) breaking the checks

Date: Sat Oct 27 18:11:33 2007 +0000
* Fixed quests with dashes breaking checks if only one part of it has brackets in it (For example, Electro-Shock Goodness)

Date: Tue Oct 9 23:12:52 2007 +0000
* Added check so quests that have no objectives are automatically considered completed, some quests like the "return to blah" aren't considered complete, but they are in reality

Date: Mon Oct 8 22:18:04 2007 +0000
* Fixed up the logic so we specifically use the correct one needed depending on the mod (if any) being used to modify quest information

Date: Sun Oct 7 03:29:08 2007 +0000
* Trying an improvement to the complete detection so it works better

Date: Wed Oct 3 03:42:58 2007 +0000
* Apparently, isActive means isAvailable

Date: Tue Oct 2 22:51:46 2007 +0000
* I'm 99% sure I actually got it working this time
* Hopefully fixed rows not being reset to no gray scale if they aren't a turn in quest that we've accepted
* Changed to the SetDesaturation that Blizzard provies in UIParent.lua incase the players graphics card doesn't support it normally

Date: Mon Oct 1 04:51:54 2007 +0000
* Hopefully fixed a case where icons would show up as gray regardless of being completed or not

Date: Sun Sep 30 17:16:35 2007 +0000
* Added another string match check this should cover for both different methods of modifying quest functions and text

Date: Sat Sep 29 23:39:16 2007 +0000
* Improved to also gray out the quest bullet point for the current quest/available quest/ect panel

Date: Tue Sep 25 20:57:47 2007 +0000
* Toc updated to 20200

Date: Thu May 31 18:30:06 2007 +0000
I have no idea what I changed, but whatever

Date: Wed May 23 19:00:35 2007 +0000
First Commit
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Author
Date
r1277
3kB
Shadowed
04-25-09 01:36 AM
r399
3kB
Shadowed
11-28-07 03:49 AM


Post A Reply Comment Options
Unread 10-05-07, 10:59 AM  
Shadowed
...
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 387
File comments: 2512
Uploads: 99
Thats because I switched to using Blizzards SetDesaturated function, if for some reason your graphics card doesn't support it it'll use vertex color.
Shadowed is offline Report comment to moderator  
Reply With Quote
Unread 10-05-07, 02:49 PM  
Lombra
A Cobalt Mageweaver
 
Lombra's Avatar
AddOn Author - Click to view AddOns

Forum posts: 240
File comments: 270
Uploads: 25
Originally posted by Shadowd
Thats because I switched to using Blizzards SetDesaturated function, if for some reason your graphics card doesn't support it it'll use vertex color.
Well that is odd. I know it's not anything you can do anything about (?) but I have a GeForce 8600 GTS with fairly updated drivers, you'd think it'd support most stuff. ;l Oh well..
__________________
Grab your sword and fight the Horde!
Lombra is offline Report comment to moderator  
Reply With Quote
Unread 10-06-07, 06:25 PM  
Frigidman
A Kobold Labourer

Forum posts: 1
File comments: 46
Uploads: 0
I like the idea of this mod... show incomplete quests in NPC dialog as a gray (?) instead of the same gold color as when its complete (ready to turn in).

However... it seems all the question-marks in dialog have been replaced with round bullet graphics instead? Not like its a bad thing, because gray bullets represent unfinished quests, while gold bullets represent completed ones. It just doesn't match the floating symbol above their heads.

its still better than every quest in their dialog having a gold question-mark and having to recall the title of the right one you want to complete and not click on all to find out lol. Thanks for the mod to make it more intuitive.
Frigidman is offline Report comment to moderator  
Reply With Quote
Unread 10-08-07, 11:53 AM  
Frigidman
A Kobold Labourer

Forum posts: 1
File comments: 46
Uploads: 0
Originally posted by Frigidman
However... it seems all the question-marks in dialog have been replaced with round bullet graphics instead? Not like its a bad thing, because gray bullets represent unfinished quests, while gold bullets represent completed ones. It just doesn't match the floating symbol above their heads.
Well... I think its dependant on the NPC you are talking too, as I just now saw one with questionmarks in the dialog instead of bullets... then afterwards saw someone else with bullets instead of questionmarks. Sooooo... chalk that one up to Blizzard for not staying uniform there on that. No fault of the mod!
Frigidman is offline Report comment to moderator  
Reply With Quote
Unread 10-08-07, 12:30 PM  
Shadowed
...
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 387
File comments: 2512
Uploads: 99
Originally posted by Frigidman
Well... I think its dependant on the NPC you are talking too, as I just now saw one with questionmarks in the dialog instead of bullets... then afterwards saw someone else with bullets instead of questionmarks. Sooooo... chalk that one up to Blizzard for not staying uniform there on that. No fault of the mod!
Correct, it's Blizzard that uses a different texture for question mark of bullet points.
Shadowed is offline Report comment to moderator  
Reply With Quote
Unread 10-08-07, 08:09 PM  
Lombra
A Cobalt Mageweaver
 
Lombra's Avatar
AddOn Author - Click to view AddOns

Forum posts: 240
File comments: 270
Uploads: 25
I don't know what you did, but with the latest release I'm getting properly grayed out icons!
__________________
Grab your sword and fight the Horde!
Lombra is offline Report comment to moderator  
Reply With Quote
Unread 10-08-07, 09:47 PM  
Shadowed
...
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 387
File comments: 2512
Uploads: 99
Originally posted by Lombra
I don't know what you did, but with the latest release I'm getting properly grayed out icons!
Good to hear!

Originally, it was just basically "brute forcing" the check and trying a couple of possible methods which is why sometimes things would get missed. The last change made it use the correct logic depending on what the mod was doing (Modifying the function call, modifying the button text, or nothing at all).
Last edited by Shadowed : 10-08-07 at 09:48 PM.
Shadowed is offline Report comment to moderator  
Reply With Quote
Unread 10-09-07, 12:19 AM  
tralkar
An Onyxian Warder
 
tralkar's Avatar

Forum posts: 352
File comments: 217
Uploads: 0
what about changing the bullet to a "?" its working but hard to see the differant color gold and gray
tralkar is offline Report comment to moderator  
Reply With Quote
Unread 10-09-07, 08:24 AM  
Lombra
A Cobalt Mageweaver
 
Lombra's Avatar
AddOn Author - Click to view AddOns

Forum posts: 240
File comments: 270
Uploads: 25
Gah, okay now I'm seriously confused. First quest NPC I arrived at today showed the dark yellow question mark again. So I reloaded the UI and then it was gray.

Any idea what this could be the cause of?

Edit: Hmm, and that was for a completed quest I realised.

Edit2: It was a quest where I just had to talk to someone. No objectives, but it didn't say (Complete) in the quest log.
__________________
Grab your sword and fight the Horde!
Last edited by Lombra : 10-09-07 at 08:48 AM.
Lombra is offline Report comment to moderator  
Reply With Quote
Unread 10-09-07, 09:23 AM  
Shadowed
...
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 387
File comments: 2512
Uploads: 99
Lombra: Try this, open Interface/Addons/DamnQuestIcons/DamnQuestIcons.lua

At line #27 replace

SetDesaturation(texture, nil)

with

texture:SetDesaturation(nil)

line #34

SetDesaturation(texture, true)

with

texture:SetDesaturation(true)

line #49

SetDesaturation(getglobal(button:GetName() .. "GossipIcon"), nil)

with

getglobal(button:GetName() .. "GossipIcon"):SetDesaturation(nil)

line #67

SetDesaturation((button:GetRegions()), nil)

with

(button:GetRegions()):SetDesaturation(nil)
Shadowed is offline Report comment to moderator  
Reply With Quote
Unread 10-09-07, 04:32 PM  
Lombra
A Cobalt Mageweaver
 
Lombra's Avatar
AddOn Author - Click to view AddOns

Forum posts: 240
File comments: 270
Uploads: 25
That gave me
Code:
Error:  attempt to call method 'SetDesaturation' (a nil value)
AddOn: DamnQuestIcons
File: DamnQuestIcons.lua
Line: 34
Count: 2
__________________
Grab your sword and fight the Horde!
Lombra is offline Report comment to moderator  
Reply With Quote
Unread 10-09-07, 05:00 PM  
Shadowed
...
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 387
File comments: 2512
Uploads: 99
Oops, replace it with SetDesaturated not SetDesaturation, so texture:SetDesaturated and so on.
Last edited by Shadowed : 10-09-07 at 05:00 PM.
Shadowed is offline Report comment to moderator  
Reply With Quote
Unread 10-10-07, 12:47 PM  
Lombra
A Cobalt Mageweaver
 
Lombra's Avatar
AddOn Author - Click to view AddOns

Forum posts: 240
File comments: 270
Uploads: 25
Now it doesn't work at all. Just getting the normal yellow colour. Doh!
__________________
Grab your sword and fight the Horde!
Lombra is offline Report comment to moderator  
Reply With Quote
Unread 10-10-07, 01:10 PM  
Shadowed
...
WoWInterface Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 387
File comments: 2512
Uploads: 99
Originally posted by Lombra
Now it doesn't work at all. Just getting the normal yellow colour. Doh!
Yea you're out of luck, just redownload and replace the LUA file to make it work again. You're stuck with the icons like that thought, can't do much short of someone actually making a grey bullet point/quest icon.
Shadowed is offline Report comment to moderator  
Reply With Quote
Unread 10-11-07, 07:54 AM  
Maziel
A Deviate Faerie Dragon
 
Maziel's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 154
Uploads: 9
Didnt realise you updated again (dunno if you got it working on EQL or not)

I guess I was working on your old code, the things I did:

Code:
-- EXPANDED QUEST LOG FILTER
function Damn_FormatQuestTitle(title)
local final = "";

if(title == nil) then
return 0;
end
title = string.lower(title);
for w in string.gmatch(title, "%a") do
final = final .. w;
end
return final;
end
This above code removes the numbers and brackets and spaces leaving only the letters for better matching of names as some logs don't put the [60] etc in them but the button text does.

Credit goes to Hackop who did HK Quest Initiators. I thought to myself, if Hackop can search for EQL quest titles and then add stuff in to any quest log, including EQL, then he must be doing something that DamnQuestIcons isn't... so I check out his code, and the above filter thing is pretty much from HK Quest Initiators mod.

~~~~

Code:
-- EXPANDED QUESTLOG CHECK
for i=1, GetNumQuestLogEntries() do
local questName, level, questTag, isHeader, isCollapsed, isComplete = GetQuestLogTitle(i);

if( not isHeader ) then
-- Damn you people modifying quest name *glares at Cide*

if( Damn_FormatQuestTitle(string.lower(questName)) == Damn_FormatQuestTitle(string.lower(buttonText)) 
or string.match(Damn_FormatQuestTitle(string.lower(questName)), Damn_FormatQuestTitle(string.lower(buttonText))) 
or string.match(Damn_FormatQuestTitle(string.lower(buttonText)), Damn_FormatQuestTitle(string.lower(questName)))) then

if( isComplete or GetNumQuestLeaderBoards(i) == 0 ) then
SetDesaturation(texture, nil)
return
end
break
end

end
end
As you can see above I make both lower case and send it over to that other function for space removal etc for better matching with EQL.

But the GetNumQuestLogEntries() thing I had to use the one from EQL to get it to work. I dunno if it is meant to be different or not *shrug* but what I've done there seems to get it to work on EQL.

Hope this is helpful to you for your next update Shadowd =)
Last edited by Maziel : 10-11-07 at 08:00 AM.
Maziel is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.