Download
(89 Kb)
Download
Updated: 03-26-08 06:33 PM
Pictures
File Info
Updated:03-26-08 06:33 PM
Created:unknown
Downloads:2,881
Favorites:21
MD5:
PetInstance
Version: 13
by: kergoth [More]
PetInstance - ChangeLog and Git Repository
A little addon to change pet ability autocast states and aggression (passive, defensive, aggressive) on entering an instance/battleground and revert back to their previous states on leaving the instance.

The addon has seperate settings for battlegrounds from instances, and has a "persist" behavior which one can toggle. When "persist" is enabled, it will re-apply the settings every time you hit the macro in question, otherwise it does it just once upon zoning into the instance. WIth it disabled, one could change the pet's behavior after zoning and it will stay that way, so you can override the addon. With it enabled, you can do a /autocaston Growl in your (if BM) Intimidation macro, and it'll stay that way until you send the pet to the next mob, which is helpful for quick offtanking, to grab a loose mob.

Defaults:
Growl off in instances and battlegrounds both.
Other autocast for pet spells are left as is.
Aggressive in battlegrounds.
Passive in instances.

Usage:
Configurable either via the Interface Options menu or /peti or /petinstance.
Add '/click PetInstanceButton' to a macro you use regularly (I use my pet attack macro).
13:
- Use AceDialog-3.0 to inject our options into the blizzard interface options.
- Make the slash command open the options via the interfaceoptionsframe.
- Update toc interface version for 2.4.
12:
- Fix some bugs related to doing a reloadui or relog.
11:
- Update embedded libraries.
10:
- Treat arena like battlegrounds.
9:
- Don't add the pet abilities section to the options dialog until we've
seen a pet.
- Simplify the db handling.
8:
- Added seperate aggression and autocast options for battlegrounds vs
regular instances, as I got sick of it setting my pet to passive in bg.
7:
- Fix copy/paste bug resulting in the autocast options only toggling
between true/false, not true/false/nil.
6:
- Fix a bug in the set() method for the Temporary option (would error if
you clicked temporary while in an instance).
5:
- Add 'Aggression' option, to change pet aggression in instances.
- Change the 'Temporary' option on the fly, so you don't have to zone out
of the instance and back in after changing the option to see the change.
4:
- Fix bug with pet ability scanning when you first login (I'd thought I
fixed this previously, but I guess not. In previous versions, you'd
have to /console reloadui, or dismiss the pet, to get it to pick up the
abilities).
3:
- Add 'Temporary' option, which re-applies your autocast settings every
time, rather than only the first time, when in an instance.
- Fixed bug with pet ability autocast state checking, it was incorrectly
picking up all the abilities as autocasting, so enabled them all when
leaving the instance.
2:
- Add some missing embedded libraries so it works without standalone Ace3.
1:
- Initial Release.
Optional Files (0)


Post A Reply Comment Options
Old 01-08-08, 01:35 AM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Hmm, I just tried this addon (great concept btw) and I can't seem to get the config screen open what so ever. The addon is loaded according to preformancefu/myaddons and I've tried loading it by its self to no avail.
KayossZero is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 02:04 AM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Originally posted by KayossZero
Hmm, I just tried this addon (great concept btw) and I can't seem to get the config screen open what so ever. The addon is loaded according to preformancefu/myaddons and I've tried loading it by its self to no avail.
That's odd.. hmm. Make sure 'show lua errors' is enabled in your interface options, load it by itself, and hit /peti, and let me know if you got any errors. Thanks for the report (users always hit bugs I don't... boggles the mind
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 02:09 AM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Originally posted by kergoth
That's odd.. hmm. Make sure 'show lua errors' is enabled in your interface options, load it by itself, and hit /peti, and let me know if you got any errors. Thanks for the report (users always hit bugs I don't... boggles the mind
Nevermind, I'm an idiot. Posting a new version (forgot one of the embedded libraries :P)
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 02:11 AM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Originally posted by kergoth
That's odd.. hmm. Make sure 'show lua errors' is enabled in your interface options, load it by itself, and hit /peti, and let me know if you got any errors. Thanks for the report (users always hit bugs I don't... boggles the mind
Typing the command for the menu yeilds nothing but a standard "Type /help for commands" etc. however upon first load I get this with Bugsack:

[2008/01/08 04:09:18-566-x1]: PetInstance\PetInstance.lua:5: Cannot find a library instance of "AceConfigRegistry-3.0".
Ace2\AceLibrary\AceLibrary.lua:49: in function `LibStub'
PetInstance\PetInstance.lua:5: in main chunk

---
KayossZero is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 02:15 AM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Aye, I figured it was something like that, can't wait to try it!

EDIT: Alright its working now however I have one suggestion.

I'm noticing that the /click PetInstanceButton only works the first time you zone in and hit it, so if you change settings after already hitting it you have to zone out and then back in and hit the macro again for the settings to take effect, or so it appears. Perhaps allow us to have the mod only change it once (in situations where you get a bad pull and need a quick OT disposable pet etc.) and to change it constantly in case of accidental growl enable.

EDIT2: Bug report? All of my PVP cats skills get enabled after zoning out of an instance even if I have none of them on auto cast when I first zone in.
Last edited by KayossZero : 01-08-08 at 02:42 AM.
KayossZero is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 09:41 AM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Originally posted by KayossZero
Aye, I figured it was something like that, can't wait to try it!

EDIT: Alright its working now however I have one suggestion.

I'm noticing that the /click PetInstanceButton only works the first time you zone in and hit it, so if you change settings after already hitting it you have to zone out and then back in and hit the macro again for the settings to take effect, or so it appears. Perhaps allow us to have the mod only change it once (in situations where you get a bad pull and need a quick OT disposable pet etc.) and to change it constantly in case of accidental growl enable.


Okay, I'd done that intentionally figuring it'd let the user override the settings after the zoning if, say, they intended to farm that instance and wanted growl on all the time for that run. I didn't consider that it might be temporary. I'll add an option for that, it's a good idea.

I was also musing over other possibilities, like having a seperate set of settings for pve instances vs pvp battlegrounds vs arena and such, but I have no idea whether such a thing would actually be of any use in the real world.

EDIT2: Bug report? All of my PVP cats skills get enabled after zoning out of an instance even if I have none of them on auto cast when I first zone in.
Argh, looking into it..
EDIT: Okay, I think I may have found the issue. I must not have spotted it since my later tests I must've had all the abilities autocasting before zoning in. I'll test it as soon as the realms come back up.
Last edited by kergoth : 01-08-08 at 10:15 AM.
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 03:26 PM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Giving v4 a go now, thanks for all the quick updates!

EDIT: Seems to be working as intended and with the new option seems feature sound for now.
Last edited by KayossZero : 01-08-08 at 03:45 PM.
KayossZero is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 07:54 PM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Hmm, I should start using /click [group] PetInstanceButton instead of unconditionally clicking it, so it doesn't mess with abilities when solo instance farming.. either that, or I'll add an option to the addon for it.
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 08:29 PM  
OklahomaOgre
A Kobold Labourer
 
OklahomaOgre's Avatar

Forum posts: 0
File comments: 2
Uploads: 0
Option Request

Please add an option for Thunderstomp. Breaking Crowd Control is embarassing and deadly, especially when it breaks your own trap...



Also, how about some FuBar support?
Last edited by OklahomaOgre : 01-08-08 at 08:32 PM.
OklahomaOgre is offline Report comment to moderator  
Reply With Quote
Old 01-08-08, 10:33 PM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Re: Option Request

Originally posted by OklahomaOgre
Please add an option for Thunderstomp. Breaking Crowd Control is embarassing and deadly, especially when it breaks your own trap...


It scans what pet abilities can be autocasted, so Thunderstomp should show up fine, if you pull up the config with that pet out. Have you tested it and seen a problem? If so, I'll go tame a pet with thunderstomp and test.

Also, how about some FuBar support?
Fubar to open the configuration panel? I suppose I could write a seperate little addon to add a button to the panel to do so.
Last edited by kergoth : 01-08-08 at 10:35 PM.
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-09-08, 05:38 PM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Getting this error, and also testing v5 it didn't seem to be working.

[2008/01/09 19:35:41-576-x1]: PetInstance\PetInstance.lua:50: attempt to index global 'btn' (a nil value)
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceConfigDialog-3.0\AceConfigDialog-3.0.lua:633: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:502>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[3]":9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?:
AceGUI-3.0\AceGUI-3.0.lua:175: in function `Fire'
...ce\libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:51: in function <...ce\libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:47>:

---
KayossZero is offline Report comment to moderator  
Reply With Quote
Old 01-10-08, 11:57 AM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Originally posted by KayossZero
Getting this error, and also testing v5 it didn't seem to be working.

[2008/01/09 19:35:41-576-x1]: PetInstance\PetInstance.lua:50: attempt to index global 'btn' (a nil value)
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceConfigDialog-3.0\AceConfigDialog-3.0.lua:633: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:502>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[3]":9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?:
AceGUI-3.0\AceGUI-3.0.lua:175: in function `Fire'
...ce\libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:51: in function <...ce\libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:47>:

---
EDIT Would you mind testing out v6 when it's approved?
Last edited by kergoth : 01-10-08 at 12:23 PM.
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-10-08, 03:27 PM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Originally posted by kergoth
EDIT Would you mind testing out v6 when it's approved?
Will do when I get some free time tonight before or after raiding.

EDIT: Doesn't seem to be working at all inside BT, config menu works but settings having no effect.
Last edited by KayossZero : 01-10-08 at 05:35 PM.
KayossZero is offline Report comment to moderator  
Reply With Quote
Old 01-11-08, 09:02 AM  
kergoth
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 136
Uploads: 8
Originally posted by KayossZero
Will do when I get some free time tonight before or after raiding.

EDIT: Doesn't seem to be working at all inside BT, config menu works but settings having no effect.
I'm not able to reproduce this.. I did find a bug where the autocast config checkboxes were only switching between off and on, no toggle to tell it to not mess with that ability at all.. but it seems to be functioning here, at least in testing on my bank (17 lock) in the instance in Orgrimmar. I'll mess with my hunter in another few instances to be certain, and release a new version to fix the config checkboxes.
kergoth is offline Report comment to moderator  
Reply With Quote
Old 01-11-08, 04:06 PM  
KayossZero
A Kobold Labourer

Forum posts: 0
File comments: 33
Uploads: 0
Trying Version 7 right now, I'll let you know how it is in a few minutes.

EDIT: Seems to be working 100% so far from testing inside Stockade.
Last edited by KayossZero : 01-11-08 at 05:10 PM.
KayossZero is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: