Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(3 Kb)
Download
Updated: 05-12-08 04:52 AM
Addon for:
oUF.
Pictures
File Info
Updated:05-12-08 04:52 AM
Created:unknown
Downloads:3,413
Favorites:17
MD5:
oUF Indicators
Version: 1.1.1
by: chalae [More]
Grid like Indicators for oUF

usage at own risk, may eat your babies

I rewrote the addon completly, basicaly riped of oUF_DebuffHighlight for its PostAuraHook. Thanks for the hints Ammo. It looks way better now.

Yes this are only usefull Indicators for Holy Raiding Priests, youll have to go into the code and change it, if you are a different class.

Also this only works for the english game client since it uses the name of the debuffs to identify them. I dont know if ill bother to change that in a later version with spell IDs and stuff.
1.1.1 bug fix
1.1 rewrote it, i think it wont eat your babies now.
Post A Reply Comment Options
Unread 05-07-08, 01:43 AM  
Ammo
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 17
File comments: 137
Uploads: 26
OnUpdate

Wow...

You know there are better ways to detect debuffs. There is are events firing for them (UNIT_AURA) and you can respond to that instead of creating a gazillion onUpdates.

Also spells have IDs nowadays that can be used, removing the need for localization.

This addon will indeed eat my babies.

Hints on fixing:
1. Look at oUF_DebuffHighlight and implement a PostUpdateAura hook similar, removing the need for overwriting any active OnUpdates on the unitframes. Your method is destructive.
2. Use spellIDs you can find them on wowhead. Just look up the debuff you want to detect and you can build your names table using GetSpellInfo()
3. Don't loop the 40 buffs and debuffs for every single spell you want to find. Loop once and check all spells.
4. read up on local vars and global vars, you have a few globals leaking in your addon (line 38, 53, and similar)
5. You use a string value "true" and "false", you can use: local boss = true
instead of using a string.

-Ammo
Last edited by Ammo : 05-07-08 at 01:47 AM.
Ammo is offline Report comment to moderator  
Reply With Quote
Unread 05-07-08, 03:03 AM  
Rabbit
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 5
File comments: 45
Uploads: 21
God dammit.

Ammo beat me to it by one hour! :P
Seriously, your code is really, really bad, and you need to fix it. If you want more help, please join #wowace on freenode.
Rabbit is offline Report comment to moderator  
Reply With Quote
Unread 05-07-08, 03:08 AM  
chalae
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 1
Hey i never said it was good >.<

its all copy and pasted together from other places more or less. i got asked how im getting indicators on oUF, so i just posted it somewhere for people to get it.

im fixing some stuff ammo mentioned but it works fine for me, i dont advise anyone who wants a perfectly finished addon to use this.
chalae is offline Report comment to moderator  
Reply With Quote
Unread 05-07-08, 04:12 AM  
mrruben5
Guest

Join Date: Not Yet
Forum posts: 0
File comments: 0
Uploads: 0
Ammo and Rabbit have developed or co-developed some major addons, code from oRA2 and BigWigs are from both hands, not to mention the number of addons both have developed individually.

Really, take their advice and use it
Report comment to moderator  
Edit/Delete Message Reply With Quote
Unread 05-07-08, 11:48 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Id say it would be easier and better (or something) to let a layout/ouf support LibDogTag-3.0 and implement text strings (like dots and so colored after buffs, ive seen this in some interfaces on diffrent sites, looks cool )
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 05-09-08, 07:38 AM  
chalae
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 1
Originally posted by p3lim
Id say it would be easier and better (or something) to let a layout/ouf support LibDogTag-3.0 and implement text strings (like dots and so colored after buffs, ive seen this in some interfaces on diffrent sites, looks cool )
Mhm i remember seeing it on some screens aswel, but a pretty big part of this is the imitation of the center icon on grid with the actual texture of the debuff. Wouldn't want to miss out on that.
chalae is offline Report comment to moderator  
Reply With Quote
Unread 05-09-08, 11:59 AM  
Slakah
A Molten Giant
 
Slakah's Avatar
AddOn Author - Click to view AddOns

Forum posts: 863
File comments: 146
Uploads: 26
Originally posted by p3lim
Id say it would be easier and better (or something) to let a layout/ouf support LibDogTag-3.0 and implement text strings (like dots and so colored after buffs, ive seen this in some interfaces on diffrent sites, looks cool )
DogTag is a bit big and imo would defeat the whole point of oUF.
Slakah is offline Report comment to moderator  
Reply With Quote
Unread 05-10-08, 08:18 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Originally posted by chalae
Mhm i remember seeing it on some screens aswel, but a pretty big part of this is the imitation of the center icon on grid with the actual texture of the debuff. Wouldn't want to miss out on that.
oUF_Indicators shows buffs, not debuffs... What you are thinking of is already possible with oUF_DebuffHighlight
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 05-10-08, 08:35 AM  
chalae
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 1
Originally posted by p3lim
oUF_Indicators shows buffs, not debuffs... What you are thinking of is already possible with oUF_DebuffHighlight
im the author of it i know what it does : (

it shows debuffs as a center icon on the frame, particular debuffs, wich i named in an array.

i basicaly just put things in it i missed from using grid for years.
Last edited by chalae : 05-10-08 at 08:37 AM.
chalae is offline Report comment to moderator  
Reply With Quote
Unread 05-10-08, 08:47 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Originally posted by chalae
im the author of it i know what it does : (

it shows debuffs as a center icon on the frame, particular debuffs, wich i named in an array.

i basicaly just put things in it i missed from using grid for years.
Aw yeah i missed that debuff part, i though it was oUF_DebuffHighlight

Btw, what layout do you use?
Last edited by p3lim : 05-10-08 at 08:51 AM.
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 05-10-08, 09:11 AM  
chalae
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 1
Originally posted by p3lim
Btw, what layout do you use?
base is yours, love the colour btw : p but i changed alot, may upload it some time but its not ready for that
Last edited by chalae : 05-10-08 at 09:25 AM.
chalae is offline Report comment to moderator  
Reply With Quote
Unread 05-10-08, 09:40 AM  
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1292
File comments: 1181
Uploads: 25
Originally posted by chalae
base is yours, love the colour btw : p but i changed alot, may upload it some time but its not ready for that
I like your raid frames, thats all

Gonna redo my raid frames next week or so to make them look more like grid
(maybe even release a 2nd layout? )
p3lim is offline Report comment to moderator  
Reply With Quote
Unread 05-12-08, 03:53 AM  
ulrich
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
I get this error when loading ui with oUF_Indicators:

Interace\AddOns\oUF_Indicators\oUF_Indicators.lua:96: attempt to index a global 'origPostUpdateAura' (a nil value)

I have oUF_P3lim and oUF_DebuffHighlight as only 2 other addons. (And oUF ofc).

Any solutions to this?

I am using the newest version of all 4 addons.
Last edited by ulrich : 05-12-08 at 03:59 AM.
ulrich is offline Report comment to moderator  
Reply With Quote
Unread 05-12-08, 04:53 AM  
chalae
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 1
Originally posted by ulrich
Interace\AddOns\oUF_Indicators\oUF_Indicators.lua:96: attempt to index a global 'origPostUpdateAura' (a nil value)
Think i fixed it in 1.1.1
chalae is offline Report comment to moderator  
Reply With Quote
Unread 05-12-08, 04:56 AM  
ulrich
A Kobold Labourer

Forum posts: 0
File comments: 9
Uploads: 0
Originally posted by chalae
Think i fixed it in 1.1.1
Sounds great!
ulrich is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: