Download
(5 Kb)
Download
Updated: 12-26-08 08:07 AM
Patch for:
Buffet.
Pictures
File Info
Updated:12-26-08 08:07 AM
Created:unknown
Downloads:2,019
Favorites:5
MD5:
Buffet - PATCH separating Healthstones/Mana Gems
Version: 3.0.3.25-Beta
by: kerrang [More]
**Updated to Buffet 3.0.3.25-Beta**

As per my comments against the full mod - this is my patched version of Buffet (buffet.lua and config.lua ONLY - you need the full mod to use this).

I've added a 3rd macro "AutoST" (for STones) which will show Mana Gems over Healthstones (holding SHIFT will force Healthstones to show).

I've also modified all macros so that holding ALT will switch to 'Conjure' mode (Highest-Rank Food/Water/ManaGems for Mages - Healthstones for Warlocks)

IMPORTANT NOTE: If you use this patch PLEASE don't yell at Tekkub if it doesn't work - yell at ME instead - ok?

Have fun with it
Post A Reply Comment Options
Unread 12-26-08, 09:03 AM  
Kardinalsin
A Fallenroot Satyr
 
Kardinalsin's Avatar

Forum posts: 23
File comments: 42
Uploads: 0
nice idea !
Kardinalsin is offline Report comment to moderator  
Reply With Quote
Unread 11-21-08, 03:36 PM  
kerrang
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 109
File comments: 96
Uploads: 6
Originally posted by Samasnier
Using a mana gem is quicker than drinking. Especially if I swap in my Serpent-Coil Braid.

With a one hour cooldown, I can't imagine why anyone would want their hearthstone on their action bars.

Thank you for creating this modification to Buffet, BTW.
It sure is faster but I'd rather have the gem handy for 'moments of crisis' myself

I'll have a look and see if removing the [COMBAT] condition is practical for you when I get a few mins - you could just remove any mention of [COMBAT] in buffet.lua if you wanted to test it tho.

I'm guessing Tekkub chose the Hearthstone because it's the one item EVERY player will have - I did, at one point, remove it and make the macro 'blank' - but in an effort to keep my version in line with the Tekkubs it went back in
Last edited by kerrang : 11-21-08 at 04:21 PM.
kerrang is offline Report comment to moderator  
Reply With Quote
Unread 11-21-08, 01:35 PM  
Samasnier
A Deviate Faerie Dragon
 
Samasnier's Avatar

Forum posts: 13
File comments: 47
Uploads: 0
Using a mana gem is quicker than drinking. Especially if I swap in my Serpent-Coil Braid.

With a one hour cooldown, I can't imagine why anyone would want their hearthstone on their action bars.

Thank you for creating this modification to Buffet, BTW.
Samasnier is offline Report comment to moderator  
Reply With Quote
Unread 11-21-08, 10:22 AM  
kerrang
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 109
File comments: 96
Uploads: 6
Originally posted by Samasnier
It would be nice to be able to use a stone out of combat, but all that's displayed on my AutoST button (out of combat) is my hearthstone.
That's a hangover of the way the standard Buffet works but I cannot for the life of me work our why you'd use a stone/pot out-of-combat - it's bonkers...
kerrang is offline Report comment to moderator  
Reply With Quote
Unread 11-21-08, 05:20 AM  
Samasnier
A Deviate Faerie Dragon
 
Samasnier's Avatar

Forum posts: 13
File comments: 47
Uploads: 0
It would be nice to be able to use a stone out of combat, but all that's displayed on my AutoST button (out of combat) is my hearthstone.
Samasnier is offline Report comment to moderator  
Reply With Quote
Unread 07-20-08, 02:01 AM  
Tekkub
Featured Artist
 
Tekkub's Avatar
Featured Addon Author

Forum posts: 953
File comments: 321
Uploads: 85
Okey, yea, "patches" is a bad name for them to give the section. You provide a replacement here, not a patch. It's not really a plugin either...

What I meant was, submit a diff file (aka a patchfile) to me so that I can apply it to my version.
Tekkub is offline Report comment to moderator  
Reply With Quote
Unread 07-19-08, 05:08 PM  
kerrang
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 109
File comments: 96
Uploads: 6
Tekkub - I did submit a patch - it's listed under 'Plug-Ins and Patches' - and I can easily reset the zip to only contain the 1 file I changed if that makes things any better... (I've now done this)

I can change the patch description o "Buffet - patched to separate Heathstones/ManaGems into 3rd macro" if that helps too... (Also done).

I may be new to publically released addons but I've coded addons since I got WoW and I've written freeware/shareware for over 20 years - so I understand the need to support code

I'm not trying to wind anyone up - I only posted it here because several people asked for something like it - and I've posted this nowhere but WOWI so it's not like you'll get 1000s of ravening 'Curse Nubs' screaming for your blood
Last edited by kerrang : 07-19-08 at 05:13 PM.
kerrang is offline Report comment to moderator  
Reply With Quote
Unread 07-18-08, 11:27 PM  
Tekkub
Featured Artist
 
Tekkub's Avatar
Featured Addon Author

Forum posts: 953
File comments: 321
Uploads: 85
There is logic behind my "change the name" condition. I WANT my code to be open, I want people to take it and modify it... but I don't want THEIR versions coming back to me.

The problem with "tag a 'reborn' onto the end of the name" versions is that, more often that not, they are a one time "fire it and forget it" submission. Asking people to come up with a new name does three things... keep people from associating the new addon with my version (and thus asking me to fix things in it)... forces the new author to take up a little more responsibility for maintaining their addon... and avoids conflicts (especially in savedvars) if a user switches between them.

That being said, if you aren't interested in actually maintaining an addon in the long run, you should submit patches. I don't think I've turned away a patch yet, only feature requests (hey, I don't have all the time in the world here, and I do have specific features I intend for an addon before I ever start writing it.) I'm certainly more open to suggestions when I don't have to do the legwork implementing them.

In short... rename, submit patches, whatever ya wish. Just please don't use the original addon name with a word or two tacked on the end. That's the only thing I ask in my license... would you rather I use GPL or some crap that requires you maintain the same license and give credit and not do this or that or 20 other things? I think it's a small thing to ask in return for leaving my code open to anyone and everyone to use under no other conditions, don't you?
Tekkub is offline Report comment to moderator  
Reply With Quote
Unread 07-16-08, 07:24 PM  
kerrang
A Flamescale Wyrmkin
AddOn Author - Click to view AddOns

Forum posts: 109
File comments: 96
Uploads: 6
I think it would be silly to release this as a uniquely-named mod as it's only a slightly modified/fixed version of Buffet.

The '2 macro' approach simply didn't work for Mages or Warlocks as it locked-out mana/health potions if they had a managem/healthstone on cooldown.

Remember that gems have 3 charges and many warlocks use multiple healthstones so this will happen a LOT - and many people stack gems/stones and pots quite frequently.

The conjure ability I added just because someone suggested it in the original mod comments

What I SHOULD have done is simply zip-up the buffet.lua as a 'patch' for people who want the different approach perhaps?

Apologies to the original author but I do think the stone/gem change was essential to making Buffet work properly for mages, warlocks and anyone warlocks give healthstones to...
kerrang is offline Report comment to moderator  
Reply With Quote
Unread 07-15-08, 07:30 PM  
Purity
A Deviate Faerie Dragon

Forum posts: 16
File comments: 177
Uploads: 0
Handy changes. Thank you! I can put this to use on my mage. (and dump that other macro.)

I second the name change though. Just so people don't get confused and ask the wrong person for support or something. Most people would do a search for Buffet and that leaves a 50/50 shot at getting the correct author.

Maybe something like "BarFood" or "Tapas Anyone".
__________________
Purity is offline Report comment to moderator  
Reply With Quote
Unread 07-15-08, 04:40 PM  
Tekkub
Featured Artist
 
Tekkub's Avatar
Featured Addon Author

Forum posts: 953
File comments: 321
Uploads: 85
As I've said many times before, I'm fine with people modifying my stuff and releasing it, under the condition that they find a new name for their addon, not just tagging extra words on to the end of the name :P
Tekkub is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: