Download
(10 Kb)
Download
Updated: 06-08-09 12:18 AM
Pictures
File Info
Updated:06-08-09 12:18 AM
Created:unknown
Downloads:33,522
Favorites:342
MD5:
ImprovedMerchant  Popular! (More than 5000 hits)
Version: 3.6x5
by: Macniel [More]
Warning
if you depend on item scaling and spacing between items do not upgrade and use version 3.6a instead, this update is not necessary if the previous version (3.6a) is working fine on your computer.

Installation

You install this AddOn like any other, just unpack the downloaded zip into your /Interface/AddOns folder.

Summary
Hello and welcome back to another helpful AddOn which will improves your daily shopping-adventures with merchants.

Okay what did this AddOn do to your merchantframe ? It replaces the paged item display with a scrollable and more informative list which can also be filtered by available item types. It use the same purchase protection like the default merchantframe when buying an item which requires honor-,arena-points or specific items.

Features
  • Filter: you can filter items from a vendor out. You can setup a filter to show only trainable, usable, purchasable items or just items from a specific type (or subtype)
  • Searchcraft: you can search item descriptions for certain a or multiple (seperated by an colon ;) keywords and filter those out which does not include your keywords
  • Scrollable List: you can now scroll through the merchant shop instead of the paged view
  • Autorepair: as a request you can now check a button on a merchant frame to enable autorepair.
Credits
Thanks again to Dridzt who have uploaded a fixed version here http://www.wowinterface.com/downloads/info12206.html while I was not available. Thanks and kudos to you!

Thanks to Seebs for GetOpt which handels slashcommands / parameterized Inputs

Need some localization help!
If you use a french, spanish, russian, korean, chinese client please provide me with a correct localization for "Recipe"

Thanks.
bugfixes in v3.6x5 :
a bug that prevents items from being clicked has drycoded out.
see changes.txt for more details

bugfixes in v3.6x4 :
A bug that prevents the item list to populate properbly after selecting the filter "nothing" in the dropdown menu has been eliminated.
A cosmetic "feature" has been added that preselect visually the "nothing" filter item in the dropdown menu when this filter is active.
see changes.txt for more details

changes in v3.6x3 :
Reenabled the Trainable filter function
Added file changes.txt for more code specific changes

bugfixes in v3.6x2 :
Localization enGB / enUS are now corrected (mass find/replace is evil!)

changes in v3.6x (xml) :
Rewrote lua Frame definitions into XML Definitions
Heavily improved Memory consumption and CPU Time consumption

bugfixes in v3.6c :
Fixed a call that caused an error message when selling something (this only applies to 3.6b)

changes in v3.6b :
Removed Options (consider v3.6a if you need item scaling and spacing)
Improved performance
- removed 2 functions as they were not necessary to determine if an item is usable
- change the way the functions and variables were accessed (they are now no longer members of an UIObject)

bugfixes in v3.6a :
Reassigned constants properbly so the filter affordable, usable and trainable works again

changes in v3.6 :
Added Autorepair option
Adjust itemcost a bit to appear more stream lined

changes in v3.5d :
Added Count and StockCount fontstrings into XML

changes in v3.5b :
Switched to XML based item definition and stress tested this for the OSP Bug, and it has not occure.

bugfixes in v3.5 :
I do not know what I had done but the OSP Bug does not appear to me anymore

bugfixes in v3.4j :
Fixed a minor bug (try to index local texture a nil value)

bugfixes in v3.4i :
An hidden visibility error has been found (by Dridzt) and eliminated

bugfixes in v3.4h :
Reverted a fix in g and replaced it with another fix - now this shall work

bugfixes in v3.4g :
On-Screen-Printing (sounds cool to me) bug should no longer occure
Fixed a function that hide everything if the filter is set to "NOTHING" (it should not display nothing but filter out nothing!)
Skipped minor version f for unkown reason


bugfixes in v3.4e :
Changed the encoding format of localization.lua to utf-8 so this can be accessed probably (again)

bugfixes in v3.4d :
An error that says there is no filter types available should no longer occure
Added a bunch of comments

bugfixes in v3.4c :
Combinated filter are now working again!

bugfixes in v3.4b :
Removed a ClearAllPoints() that caused to disalign some elements

bugfixes in v3.4a :
Changed a variable name so the count of an stacked item (for example water) will show up again

changes in v3.4 :
Implemented support for Recipe-Book (and similiar AddOns)
Changed lots of code, so it should work now performantly
Fixed filter and search craft when they are used together (they will not longer disable each other)

known bugs:
there is not yet a localization frFR, enES, koKR, zhCN, zhTW and ruRU clients so the Trainable Filter wont work for these Clients (please provide me with a proper translation for the itemtype "recipe")

changes in v2.1 :
Bugfix with stock based Items (they will now properly decreased); new Trainable Filter

changes in v2.0 :
itemcost + money will not longer result in a graphical glitch

changes in v1.9 :
switched to ItemButtonTemplate to enable AddOns to skin the item texture

changes in v1.8 :
improved Searchengine which allows more than one keyword to search for, bugfix which prevented to show every required itemtype to purchase an item (like a pvp mount)

changes in v1.7 :
new affordable filter, filter are hidden on default

changes in v1.6 :
many bugfixes

changes in v1.5 :
click handler are removed, the default click handler are used instead, localization completed by yaroot (thank you very much)

changes in v1.3 :
list is now redesigned for improved experience, major fix in left/rightclick handling, buybackitem will now show probably in the buy frame

changes in v1.1 :
Some designtweaks were applied

changes in v1.06:
Compare Tooltips was added, Dressup function was added

changes in v1.04:
Currency display was changed, Localization should now work probably

bugfix in v1.01:
SplitStack should now work probably
Optional Files (0)


Archived Files (26)
File Name
Version
Size
Author
Date
3.6x4
10kB
Macniel
06-07-09 03:02 PM
3.6x3
9kB
Macniel
05-25-09 11:05 AM
3.6x2
9kB
Macniel
05-25-09 06:34 AM
3.6x
9kB
Macniel
05-24-09 12:32 PM
3.6c
8kB
Macniel
05-24-09 03:02 AM
3.6b
8kB
Macniel
05-23-09 06:58 PM
3.6
13kB
Macniel
05-23-09 12:04 PM
3.6
13kB
Macniel
05-23-09 03:36 AM
3.5d
13kB
Macniel
05-22-09 07:52 AM
3.5b
13kB
Macniel
05-22-09 06:38 AM
3.5a
13kB
Macniel
05-21-09 10:30 AM
3.5
13kB
Macniel
05-21-09 04:50 AM
3.4j
13kB
Macniel
05-20-09 04:17 AM
3.4i
13kB
Macniel
05-18-09 04:46 AM
3.4h
13kB
Macniel
05-17-09 10:46 PM
3.4g
13kB
Macniel
05-17-09 02:18 PM
3.4e
13kB
Macniel
05-17-09 10:01 AM
3.4d
13kB
Macniel
05-17-09 06:20 AM
3.4c
12kB
Macniel
05-16-09 03:17 PM
3.4b
12kB
Macniel
05-16-09 08:53 AM
3.4a
12kB
Macniel
05-15-09 06:03 PM
3.4
12kB
Macniel
05-15-09 05:45 PM
3.1
11kB
Macniel
04-17-09 10:50 AM
2.1a
6kB
Macniel
03-27-09 01:45 PM
2.1
6kB
Macniel
03-25-09 04:29 PM
2.02
6kB
Macniel
10-25-08 06:21 AM


Post A Reply Comment Options
Unread 10-20-11, 03:09 PM  
spiralofhope
A Deviate Faerie Dragon
 
spiralofhope's Avatar

Forum posts: 11
File comments: 207
Uploads: 0
GnomishVendorShrinker may be a good replacement.
__________________
spiralofhope.com
spiralofhope is offline Report comment to moderator  
Reply With Quote
Unread 12-05-10, 02:06 AM  
Harshmage
Different
 
Harshmage's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 9
File comments: 25
Uploads: 1
Repairs or a replacement?

I hate to say it, but it's been over a year since anything has been done with ImprovedMerch. While it had a great system to it, I suggest using xMerchant as a replacement.
__________________
-Bryan-
http://www.harshmage.com/
[SIGPIC][/SIGPIC]
Harshmage is offline Report comment to moderator  
Reply With Quote
Unread 11-01-10, 11:25 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 190
File comments: 206
Uploads: 5
Originally posted by EvoTech
Hope this helps:

[string "ImprovedMerchantAutoRepairCheckBox:OnLoad"] line 1:
attempt to index global 'this' (a nil value)
[string "ImprovedMerchantToggleFilter:OnLoad"] line 1:
attempt to index global 'this' (a nil value)
It's more complicated than that. There are numerous globals that need to be fixed and some vars are unpassed that should be. I got it working but the author really needs to either support the mod or ask someone else to take over.
VincentSDSH is offline Report comment to moderator  
Reply With Quote
Unread 10-14-10, 01:11 AM  
EvoTech
A Kobold Labourer

Forum posts: 1
File comments: 24
Uploads: 0
Hope this helps:

[string "ImprovedMerchantAutoRepairCheckBox:OnLoad"] line 1:
attempt to index global 'this' (a nil value)
[string "ImprovedMerchantToggleFilter:OnLoad"] line 1:
attempt to index global 'this' (a nil value)
EvoTech is offline Report comment to moderator  
Reply With Quote
Unread 05-01-10, 04:50 AM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
AddOn Author - Click to view AddOns

Forum posts: 26
File comments: 113
Uploads: 10
what is broken?

I wonder what exactly is broken, everything works fine on my trywow account?
Macniel is offline Report comment to moderator  
Reply With Quote
Unread 03-30-10, 05:16 AM  
Taigen
A Defias Bandit
 
Taigen's Avatar

Forum posts: 3
File comments: 83
Uploads: 0
Yah they are... but looks like last work done on it was over a year ago =/

Maybe if enough ppl show interest the project will be picked up.
Last edited by Taigen : 03-30-10 at 05:16 AM.
Taigen is offline Report comment to moderator  
Reply With Quote
Unread 12-19-09, 07:58 AM  
jedasa
A Kobold Labourer

Forum posts: 1
File comments: 16
Uploads: 0
Update

So has this addon been abandoned cause it is by far one of the best addons out there it does what blizz should have done with there merchant frames from the begining.

EDIT: Found someone working on this addon

http://forums.wowace.com/showthread.php?t=15886&page=6
Last edited by jedasa : 03-03-10 at 12:13 AM.
jedasa is offline Report comment to moderator  
Reply With Quote
Unread 08-09-09, 11:50 AM  
Miralen
A Rage Talon Dragon Guard
 
Miralen's Avatar

Forum posts: 330
File comments: 83
Uploads: 0
Was wondering since this is supposed to and does improve the merchant window if you would possibly add an auto sell grey item button as it would be nice to have that built into an addon that already makes the merchant window better, it would just improve it even more imo. Also would be handy I feel if we could permanently toggle on filters and what not, for instance I don't wear anything below plate on my tank and also I don't wear anything above cloth on my priest healer it would be nice to set it to permanently remember filters on a character basis so that I wouldn't have to keep setting them per vendor visit. Apologies if either of these are already built in just haven't seen anything that tells me so in game. Thanks for a great addon!
__________________
-There's always something to envy. A smile, a friendship, something you don't have and want to appropriate. There will always be rich and poor. Rich in gifts, poor in gifts. Rich in love, poor in love.-
Miralen is offline Report comment to moderator  
Reply With Quote
Unread 07-20-09, 10:19 AM  
Synchretomus
A Kobold Labourer

Forum posts: 0
File comments: 16
Uploads: 0
Need some localization help!
If you use a french, spanish, russian, korean, chinese client please provide me with a correct localization for "Recipe"

"Recipe" is "Recette" in french, mostly for cooking, jewelcrafting or alchemy.

By the way, please note that allakzam or wowhead can provide useful info on localization ex :

http://fr.wowhead.com/?item=20013 -> Recette : Potion de vive action (FR) Note that froggies have a particular typography for ":" ^^
http://www.wowhead.com/?item=20013 -> Recipe: Living Action Potion (EN)
http://de.wowhead.com/?item=20013 -> Rezept: Trank der lebhaften Aktion (DE)
http://es.wowhead.com/?item=20013 -> Receta: poción de acción viva (SP)
http://ru.wowhead.com/?item=20013 -> Рецепт: зелье неудержимости (RU)

Maybe working on the basis of spell/item ID is a better solution to get text. But i don't know if its possible with your code strategy. If it's for parsing tooltips, then it's useless.
Synchretomus is offline Report comment to moderator  
Reply With Quote
Unread 06-19-09, 04:11 AM  
antisocialink
A Kobold Labourer

Forum posts: 0
File comments: 38
Uploads: 0
I haven't experienced my issue since the last update.

Sorry I never got you a screen of it. I had disabled the mod till I saw there was an update. Kept forgetting to enable it and get you a screen.
antisocialink is offline Report comment to moderator  
Reply With Quote
Unread 06-07-09, 04:22 PM  
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1190
File comments: 783
Uploads: 82
Originally posted by Macniel
thank you dridzt I have finally encountered this bug as well and could pinpoint it. the problem was that UIDropDown_GetSelectedValue(...) will use the .text attribute when the .value attribute is nil. So I had give the nothing item a non-nil value.

As the other bug I could not yet find this bug.

@ antisocialink, I couldnt encounter this bug as well sorry.
Good news

The only possible place for the other bug that I could think off was in the PopulateList function where the item button is created or passed to the ImprovedMerchant_Update() function.

I replaced that line in my local copy with
Code:
local button;
if _G["itemInfo"..iterator] then
	button = _G["itemInfo"..iterator]
	button:SetFrameLevel(ImprovedMerchantScrollChild:GetFrameLevel() + 1)
else
	button = CreateFrame("Button", "itemInfo"..iterator, ImprovedMerchantScrollChild, "ImprovedMerchantItemInfoTemplate")
end
The idea behind it is that the created button is parented to ImprovedMerchantScrollChild so it will always have the proper framelevel to be above it/clickable.
There was nothing to guarantee this happens when you pass the existing itembutton.
After the change above I haven't observed that problem but it is hard to say 100% that this was the cause or solution as it never used to happen consistently.

I can only say that I haven't observed it for a few days now since I made that change while it happened before.

Edit: There's a leftover debug statement as first line of ImprovedMerchant_PopulateList() function.
Last edited by Dridzt : 06-08-09 at 12:02 AM.
Dridzt is online now Report comment to moderator  
Reply With Quote
Unread 06-07-09, 02:43 PM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
AddOn Author - Click to view AddOns

Forum posts: 26
File comments: 113
Uploads: 10
thank you dridzt I have finally encountered this bug as well and could pinpoint it. the problem was that UIDropDown_GetSelectedValue(...) will use the .text attribute when the .value attribute is nil. So I had give the nothing item a non-nil value.

As the other bug I could not yet find this bug.

@ antisocialink, I couldnt encounter this bug as well sorry.
Macniel is offline Report comment to moderator  
Reply With Quote
Unread 06-06-09, 07:55 AM  
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1190
File comments: 783
Uploads: 82
v3.6x3
I'm having a repeat of an old issue solved with 3.1 previously.

No lua errors but:
1. Occasionally the merchant frame appears empty until I re-set a filter.
(was "nothing" to begin with I just need to re-select it from the dropdown).
When it bugs out like that it also clears the items with every purchase and I need to re-set the filter again to make them appear.
2. Items after the 7th row become unclickable + do not show their tooltip on mouseover.
(seems like a frame strata problem).

Both issues can usually be temporarily resolved with reloadui.

Edit: Last occurrence of this behavior was at Braeg Stoutbeard
but it happens at other merchants as well.
Last edited by Dridzt : 06-06-09 at 07:57 AM.
Dridzt is online now Report comment to moderator  
Reply With Quote
Unread 05-28-09, 03:34 PM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
AddOn Author - Click to view AddOns

Forum posts: 26
File comments: 113
Uploads: 10
Originally posted by antisocialink
This has been acting a bit wonky for me of late.

Some merchants won't have prices for first few items.
And more importantly, when out of the merchant window the currency still continues to show on the game field. This particularly seems to happen when accessing merchants that use alternate currency (i.e. Stone Keeper Shards and all the different badges) but does occasionally leave gold/ silver/ copper on the screen as well.

Logging will reset it and the merchant seems to work fine after but eventually the issue seems to come back up.
could you please provide a Screenshot or a more detailed information : when it happens, what item is affected, who is the merchant.

but as I am now in hospital this fix could take it time...
Macniel is offline Report comment to moderator  
Reply With Quote
Unread 05-28-09, 08:35 AM  
antisocialink
A Kobold Labourer

Forum posts: 0
File comments: 38
Uploads: 0
This has been acting a bit wonky for me of late.

Some merchants won't have prices for first few items.
And more importantly, when out of the merchant window the currency still continues to show on the game field. This particularly seems to happen when accessing merchants that use alternate currency (i.e. Stone Keeper Shards and all the different badges) but does occasionally leave gold/ silver/ copper on the screen as well.

Logging will reset it and the merchant seems to work fine after but eventually the issue seems to come back up.
antisocialink is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: