Addon Information
Download Latest Version.
To add favorites please register for a free account. If you already have one you need to login. How do I install this? (FAQ)
Macniel's Portal Bug Reports Feature Requests
Author:
Version:
3.6x5
Date:
06-08-2009 02:18 AM
Size:
9.68 Kb
Downloads:
28,168
Favorites:
434
MD5:
Pictures
Click to enlarge
OSP Bug is gone!
Click to enlarge
new interface with checkbutton to check autorepair on and off
Click to enlarge
full action buying!!!
ImprovedMerchant   Popular! (More than 5000 hits)
Warning
if you depend on item scaling and spacing between items do not upgrade and use version 3.6a instead, this update is not necessary if the previous version (3.6a) is working fine on your computer.

Installation

You install this AddOn like any other, just unpack the downloaded zip into your /Interface/AddOns folder.

Summary
Hello and welcome back to another helpful AddOn which will improves your daily shopping-adventures with merchants.

Okay what did this AddOn do to your merchantframe ? It replaces the paged item display with a scrollable and more informative list which can also be filtered by available item types. It use the same purchase protection like the default merchantframe when buying an item which requires honor-,arena-points or specific items.

Features
  • Filter: you can filter items from a vendor out. You can setup a filter to show only trainable, usable, purchasable items or just items from a specific type (or subtype)
  • Searchcraft: you can search item descriptions for certain a or multiple (seperated by an colon ;) keywords and filter those out which does not include your keywords
  • Scrollable List: you can now scroll through the merchant shop instead of the paged view
  • Autorepair: as a request you can now check a button on a merchant frame to enable autorepair.
Credits
Thanks again to Dridzt who have uploaded a fixed version here http://www.wowinterface.com/downloads/info12206.html while I was not available. Thanks and kudos to you!

Thanks to Seebs for GetOpt which handels slashcommands / parameterized Inputs

Need some localization help!
If you use a french, spanish, russian, korean, chinese client please provide me with a correct localization for "Recipe"

Thanks.
  Change Log - ImprovedMerchant
bugfixes in v3.6x5 :
a bug that prevents items from being clicked has drycoded out.
see changes.txt for more details

bugfixes in v3.6x4 :
A bug that prevents the item list to populate properbly after selecting the filter "nothing" in the dropdown menu has been eliminated.
A cosmetic "feature" has been added that preselect visually the "nothing" filter item in the dropdown menu when this filter is active.
see changes.txt for more details

changes in v3.6x3 :
Reenabled the Trainable filter function
Added file changes.txt for more code specific changes

bugfixes in v3.6x2 :
Localization enGB / enUS are now corrected (mass find/replace is evil!)

changes in v3.6x (xml) :
Rewrote lua Frame definitions into XML Definitions
Heavily improved Memory consumption and CPU Time consumption

bugfixes in v3.6c :
Fixed a call that caused an error message when selling something (this only applies to 3.6b)

changes in v3.6b :
Removed Options (consider v3.6a if you need item scaling and spacing)
Improved performance
- removed 2 functions as they were not necessary to determine if an item is usable
- change the way the functions and variables were accessed (they are now no longer members of an UIObject)

bugfixes in v3.6a :
Reassigned constants properbly so the filter affordable, usable and trainable works again

changes in v3.6 :
Added Autorepair option
Adjust itemcost a bit to appear more stream lined

changes in v3.5d :
Added Count and StockCount fontstrings into XML

changes in v3.5b :
Switched to XML based item definition and stress tested this for the OSP Bug, and it has not occure.

bugfixes in v3.5 :
I do not know what I had done but the OSP Bug does not appear to me anymore

bugfixes in v3.4j :
Fixed a minor bug (try to index local texture a nil value)

bugfixes in v3.4i :
An hidden visibility error has been found (by Dridzt) and eliminated

bugfixes in v3.4h :
Reverted a fix in g and replaced it with another fix - now this shall work

bugfixes in v3.4g :
On-Screen-Printing (sounds cool to me) bug should no longer occure
Fixed a function that hide everything if the filter is set to "NOTHING" (it should not display nothing but filter out nothing!)
Skipped minor version f for unkown reason


bugfixes in v3.4e :
Changed the encoding format of localization.lua to utf-8 so this can be accessed probably (again)

bugfixes in v3.4d :
An error that says there is no filter types available should no longer occure
Added a bunch of comments

bugfixes in v3.4c :
Combinated filter are now working again!

bugfixes in v3.4b :
Removed a ClearAllPoints() that caused to disalign some elements

bugfixes in v3.4a :
Changed a variable name so the count of an stacked item (for example water) will show up again

changes in v3.4 :
Implemented support for Recipe-Book (and similiar AddOns)
Changed lots of code, so it should work now performantly
Fixed filter and search craft when they are used together (they will not longer disable each other)

known bugs:
there is not yet a localization frFR, enES, koKR, zhCN, zhTW and ruRU clients so the Trainable Filter wont work for these Clients (please provide me with a proper translation for the itemtype "recipe")

changes in v2.1 :
Bugfix with stock based Items (they will now properly decreased); new Trainable Filter

changes in v2.0 :
itemcost + money will not longer result in a graphical glitch

changes in v1.9 :
switched to ItemButtonTemplate to enable AddOns to skin the item texture

changes in v1.8 :
improved Searchengine which allows more than one keyword to search for, bugfix which prevented to show every required itemtype to purchase an item (like a pvp mount)

changes in v1.7 :
new affordable filter, filter are hidden on default

changes in v1.6 :
many bugfixes

changes in v1.5 :
click handler are removed, the default click handler are used instead, localization completed by yaroot (thank you very much)

changes in v1.3 :
list is now redesigned for improved experience, major fix in left/rightclick handling, buybackitem will now show probably in the buy frame

changes in v1.1 :
Some designtweaks were applied

changes in v1.06:
Compare Tooltips was added, Dressup function was added

changes in v1.04:
Currency display was changed, Localization should now work probably

bugfix in v1.01:
SplitStack should now work probably
  Optional Files - ImprovedMerchant
Sorry, there are currently no optional files available.
  Archived Versions - ImprovedMerchant
File Name
Version
Size
Author
Date
3.6x4
10kB
Macniel
06-07-2009 05:02 PM
3.6x3
9kB
Macniel
05-25-2009 01:05 PM
3.6x2
9kB
Macniel
05-25-2009 08:34 AM
3.6x
9kB
Macniel
05-24-2009 02:32 PM
3.6c
8kB
Macniel
05-24-2009 05:02 AM
3.6b
8kB
Macniel
05-23-2009 08:58 PM
3.6
13kB
Macniel
05-23-2009 02:04 PM
3.6
13kB
Macniel
05-23-2009 05:36 AM
3.5d
13kB
Macniel
05-22-2009 09:52 AM
3.5b
13kB
Macniel
05-22-2009 08:38 AM
3.5a
13kB
Macniel
05-21-2009 12:30 PM
3.5
13kB
Macniel
05-21-2009 06:50 AM
3.4j
13kB
Macniel
05-20-2009 06:17 AM
3.4i
13kB
Macniel
05-18-2009 06:46 AM
3.4h
13kB
Macniel
05-18-2009 12:46 AM
3.4g
13kB
Macniel
05-17-2009 04:18 PM
3.4e
13kB
Macniel
05-17-2009 12:01 PM
3.4d
13kB
Macniel
05-17-2009 08:20 AM
3.4c
12kB
Macniel
05-16-2009 05:17 PM
3.4b
12kB
Macniel
05-16-2009 10:53 AM
3.4a
12kB
Macniel
05-15-2009 08:03 PM
3.4
12kB
Macniel
05-15-2009 07:45 PM
3.1
11kB
Macniel
04-17-2009 12:50 PM
2.1a
6kB
Macniel
03-27-2009 03:45 PM
2.1
6kB
Macniel
03-25-2009 06:29 PM
2.02
6kB
Macniel
10-25-2008 08:21 AM
  Comments - ImprovedMerchant
Post A Reply Comment Options
Old 05-20-2009, 10:50 AM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
Interface Author - Click to view interfaces

Forum posts: 26
File comments: 125
Uploads: 10
Re: Argent Toru

Quote:
Originally posted by DaemonSambe
This remains bugged for Argent Tournament faction vendors. When i scroll thru the list, the item prices, notably the Champion Seals, continue to scroll up the window, and remain there, when i leave the merchant.
I can in no ways reconstruct those errors. Please for the next time write down every merchant interaction during a session where this error occure.
Macniel is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-19-2009, 09:34 PM  
DaemonSambe
A Kobold Labourer

Forum posts: 0
File comments: 96
Uploads: 0
Argent Toru

This remains bugged for Argent Tournament faction vendors. When i scroll thru the list, the item prices, notably the Champion Seals, continue to scroll up the window, and remain there, when i leave the merchant.

Last edited by DaemonSambe : 05-19-2009 at 09:34 PM.
DaemonSambe is online now Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-18-2009, 06:47 AM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
Interface Author - Click to view interfaces

Forum posts: 26
File comments: 125
Uploads: 10
Quote:
Originally posted by Dridzt
Just in case my edit in comment was unnoticed.
I had an error related to a chat output line (debug code for the tooltip scanning routine).
I commented out that line and it's good.

I am also getting this error when using the searchbox
(with no filter selected in the dropdown: "nothing")

Code:
ImprovedMerchant-3.4c\ImprovedMerchant.lua:126: attempt to index global 'LOCALE' (a nil value)
Code:
ImprovedMerchant-3.4c\ImprovedMerchant.lua:184: in function `PopulateList'
ImprovedMerchant-3.4c\ImprovedMerchant.lua:435: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:431>
Bugfix for this one is replacing ImprovedMerchant.lua: 126 with
Code:
if text and string.find(text, ImprovedMerchant_GetLocaleString("RATINGBUSTER")) then
hmm, this visibilty related issue has been fixed, thank you very much Dridzt! (also the debug line has been deleted)
Macniel is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-18-2009, 06:08 AM  
Dridzt
A Frostmaul Preserver
Interface Author - Click to view interfaces

Forum posts: 279
File comments: 409
Uploads: 37
Just in case my edit in comment was unnoticed.
I had an error related to a chat output line (debug code for the tooltip scanning routine).
I commented out that line and it's good.

I am also getting this error when using the searchbox
(with no filter selected in the dropdown: "nothing")

Code:
ImprovedMerchant-3.4c\ImprovedMerchant.lua:126: attempt to index global 'LOCALE' (a nil value)
ImprovedMerchant-3.4c\ImprovedMerchant.lua:184: in function `PopulateList'
ImprovedMerchant-3.4c\ImprovedMerchant.lua:435: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:431>
Bugfix for this one is replacing ImprovedMerchant.lua: 126 with
Code:
if text and string.find(text, ImprovedMerchant_GetLocaleString("RATINGBUSTER")) then

Last edited by Dridzt : 05-18-2009 at 06:10 AM.
Dridzt is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-18-2009, 05:32 AM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
Interface Author - Click to view interfaces

Forum posts: 26
File comments: 125
Uploads: 10
Re: 3.4h

Quote:
Originally posted by Dridzt
3.4h looks good.

I couldn't reproduce any of the bugs in previous 3.4 versions.

Only aesthetic detail I noticed is that when there's not enough items in the merchantframe to scroll they're all greyed-out.

It's only visual I can still buy them normally.
that is a problem of my actual implementation to reflect the vertex color of the itembuttons; this is my only idea how to use AddOns like Recipe Book in this AddOn.
Macniel is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-18-2009, 05:25 AM  
Dridzt
A Frostmaul Preserver
Interface Author - Click to view interfaces

Forum posts: 279
File comments: 409
Uploads: 37
3.4h

3.4h looks good.

I couldn't reproduce any of the bugs in previous 3.4 versions.

Only aesthetic detail I noticed is that when there's not enough items in the merchantframe to scroll they're all greyed-out.

It's only visual I can still buy them normally.

Edit:
I spoke too soon.
Still getting errors with some filters.
Code:
ImprovedMerchant-3.4c\ImprovedMerchant.lua:78: in function `SearchForRedLines'
ImprovedMerchant-3.4c\ImprovedMerchant.lua:210: in function `PopulateList'
ImprovedMerchant-3.4c\filterDropDown.lua:36: in function `func'
Interface\FrameXML\UIDropDownMenu.lua:563: in function `UIDropDownMenuButton_OnClick':
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>
That's trying to set filter "usable".

Edit in edit:
That seems like a debug line left in for chat output, not functional to the addon.

Last edited by Dridzt : 05-18-2009 at 05:36 AM.
Dridzt is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 09:35 PM  
Hevanus
A Deviate Faerie Dragon
 
Hevanus's Avatar

Forum posts: 15
File comments: 209
Uploads: 0
Re: Re: Latest version...

Seeing this in 3.4g:
Code:
[2009/05/17 18:19:53-5740-x1]: ImprovedMerchant-3.4c\itemClass.lua:261: attempt to compare number with nil
ImprovedMerchant-3.4c\ImprovedMerchant.lua:275: in function `PopulateList'
ImprovedMerchant-3.4c\ImprovedMerchant.lua:314: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:291>

  ---
Hevanus is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 08:10 PM  
joshwill80
A Murloc Raider

Forum posts: 5
File comments: 122
Uploads: 0
Re: Latest version...

Quote:
Originally posted by VincentSDSH
Interface\AddOns\ImprovedMerchant\itemClass.lua:261: attempt to compare number with nil
Count: 2

Call Stack:
[C]: ?
Interface\AddOns\ImprovedMerchant\itemClass.lua:261: in function `CreateMerchantItem'
...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:275: in function `PopulateList'
...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:314: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:291>
I'm also seeing multiple errors with 3.4g, all involving line 261 in itemClass.lua. ImprovedMerchant 3.4g is totally broke for me, and nothing appears in the merchant window at all. Reverting to 3.4b for now.
joshwill80 is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 07:02 PM  
VincentSDSH
A Flamescale Wyrmkin
 
VincentSDSH's Avatar
Interface Author - Click to view interfaces

Forum posts: 122
File comments: 161
Uploads: 5
Latest version...

Interface\AddOns\ImprovedMerchant\itemClass.lua:261: attempt to compare number with nil
Count: 2

Call Stack:
[C]: ?
Interface\AddOns\ImprovedMerchant\itemClass.lua:261: in function `CreateMerchantItem'
...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:275: in function `PopulateList'
...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:314: in function <...terface\AddOns\ImprovedMerchant\ImprovedMerchant.lua:291>
VincentSDSH is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 05:44 PM  
AlicanC
A Kobold Labourer

Forum posts: 0
File comments: 19
Uploads: 0
Wow that was fast. I'll try it asap
AlicanC is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 04:14 PM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
Interface Author - Click to view interfaces

Forum posts: 26
File comments: 125
Uploads: 10
Quote:
Originally posted by Fonjask
I had exactly the same problem with 3.4d, bought something at the Argent Quartermaster and the champion's seals were printed ON TOP of my recount, even got a screenshot:
Okay I have located the bug, I had thought that 0 (zero, not nil/null) is equal to false (in a if ... then control flow) but it is not equal. So this bug should be eliminated.
Macniel is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 02:14 PM  
Fonjask
A Fallenroot Satyr
 
Fonjask's Avatar
Interface Author - Click to view interfaces

Forum posts: 22
File comments: 255
Uploads: 4
Quote:
Originally posted by AlicanC
Today I had a problem while visiting PvP stuff vendors at The Underbelly. First I saw that prices of some items were missing. (Not for the stuff I wanted to buy...) After I looked at the items I closed the windows and started to walk and saw that some prices are floating over my UI. There were numbers and icons of the prices. It was like those price tags were printed directly on the UI instead of the frame.

I was using 3.4c and I couldn't find a way to reproduce it...
I had exactly the same problem with 3.4d, bought something at the Argent Quartermaster and the champion's seals were printed ON TOP of my recount, even got a screenshot:




EDIT: I updated ImpMer from 3.1 to 3.4d, and didn't have this error in 3.1.
Seeing as AlicanC had this problem in 3.4c it's probably a bug added in 3.4(a,b, or c).
Keep us up to date !
__________________
Himeros
80 Draenei Holy Paladin
EU-Bronze Dragonflight-A

Last edited by Fonjask : 05-17-2009 at 02:16 PM.
Fonjask is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 02:10 PM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
Interface Author - Click to view interfaces

Forum posts: 26
File comments: 125
Uploads: 10
Quote:
Originally posted by AlicanC
Today I had a problem while visiting PvP stuff vendors at The Underbelly. First I saw that prices of some items were missing. (Not for the stuff I wanted to buy...) After I looked at the items I closed the windows and started to walk and saw that some prices are floating over my UI. There were numbers and icons of the prices. It was like those price tags were printed directly on the UI instead of the frame.

I was using 3.4c and I couldn't find a way to reproduce it...
a very very strange bug, I hope I will stumble upon it and can get it fixed then.
Macniel is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 01:29 PM  
AlicanC
A Kobold Labourer

Forum posts: 0
File comments: 19
Uploads: 0
Today I had a problem while visiting PvP stuff vendors at The Underbelly. First I saw that prices of some items were missing. (Not for the stuff I wanted to buy...) After I looked at the items I closed the windows and started to walk and saw that some prices are floating over my UI. There were numbers and icons of the prices. It was like those price tags were printed directly on the UI instead of the frame.

I was using 3.4c and I couldn't find a way to reproduce it...
AlicanC is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Old 05-17-2009, 12:02 PM  
Macniel
A Fallenroot Satyr
 
Macniel's Avatar
Interface Author - Click to view interfaces

Forum posts: 26
File comments: 125
Uploads: 10
Quote:
Originally posted by Sparanoid
I'm going to translate it but i think the encoding of that language file is wrong, i cannot open it currectly with my text editor
Oh I had forgotten to set the encoding to utf-8 (is fixed in v3.4e), and thank you for your support
Macniel is offline Report comment to moderator   Edit/Delete Message Reply With Quote
Post A Reply



Category Jump:




The Network:
EQInterface | EQ2Interface | LoTROInterface | MMOInterface | War.MMOUI | WoWInterface | VGInterface | Allakhazam | Thottbot | Wowhead | Zam


©2009 MMOUI / ZAM Network
vBulletin - Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.