World of Warcraft AddOns » Stand-Alone Addons » Buff, Debuff, Spell » DoTimer Fix for 5.1
  • Addon Info.
  • Comments (26)
    • Download
    (821Kb)
    Download
    Updated: 11-27-12 11:54 PM
    Updated:11-27-12 11:54 PM
    Created:08-29-12 12:06 AM
    Downloads:9,299
    Favorites:29
    MD5:

    DoTimer Fix for 5.1  Popular! (More than 5000 hits)

    Version: 2
    by: Neuro [More]

    This is a quick fix to DoTimer to clean up the bugs in 5.04. I coded this for a guildmate, and he asked me to publish it.

    Once the author of DoTimer updates his addon, I'll pull this one down. I can't guarantee it works 100%, but it does work.

    5.1: Uploaded a new version, it works for me, but that's not saying much. If people could try it out and see if it's working, and report back any bugs, I'd appreciate it.

    Post A Reply Comment Options
    Page 1 of 2 1 2 >
    Unread 08-29-12, 09:41 PM  
    flew
    A Kobold Labourer

    Forum posts: 0
    File comments: 1
    Uploads: 0
    Thank you so much for publishing this.
    Report comment to moderator  
    Reply With Quote
    Unread 08-30-12, 03:15 AM  
    Teoneh
    A Kobold Labourer

    Forum posts: 0
    File comments: 1
    Uploads: 0
    Additional update/fix
    Not sure if you or your friend has run in to this error (and not exactly sure how this has been running) but there is a problem in the events.lua file under /Notifications. The COMBAT_EVENT_LOG_UNFILTERED function has been missing several new parameters since v4.2 but it seems to only now toss out lua errors. Line 277 in the events.lua file is as follows:

    Code:
    function Notifications:COMBAT_LOG_EVENT_UNFILTERED(timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)
    This is missing 3 new parameters (per http://www.wowwiki.com/API_COMBAT_LOG_EVENT) and should be as follows:

    Code:
    function Notifications:COMBAT_LOG_EVENT_UNFILTERED(timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, sourceFlags2, destGUID, destName, destFlags, destFlags2, ...)
    If you're not using the Notifications module, then you probably wouldn't run in to this error. Just wanted to post this here in case others do run in to this problem and if you would like to incorporate it in to your fix.
    Report comment to moderator  
    Reply With Quote
    Unread 08-30-12, 11:27 AM  
    Neuro
    A Theradrim Guardian
     
    Neuro's Avatar
    AddOn Author - Click to view AddOns

    Forum posts: 60
    File comments: 65
    Uploads: 2
    Teoneh: Thanks, I'll incorporate that into the fix. Those changes apparently went in with 4.1 and 4.2, so it's been in there awhile.

    I don't actually run this addon myself, so it's hard for me to test it. If you run into errors, let me know please.
    Report comment to moderator  
    Reply With Quote
    Unread 11-25-12, 02:29 PM  
    Fizzgig
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    Consolidate Buffs Problem
    Been having this problem since MoP but its taken me a while to figure out that this is the mod thats causing it.

    I have the consolidate buffs option turned off, but everytime I log in, the icon is there in the corner on top of my current buffs. I have to go into the options screen and turn it on then off again to make it disappear.

    Would be most grateful for a fix because its driving me crazy!
    Report comment to moderator  
    Reply With Quote
    Unread 11-27-12, 02:29 PM  
    C A I N
    A Murloc Raider
     
    C A I N's Avatar

    Forum posts: 6
    File comments: 15
    Uploads: 0
    with 5.1 this mod is now causing all my toons to hang at a full loading bar, it wont let me into the game as long as this addon is enabled.
    Report comment to moderator  
    Reply With Quote
    Unread 11-27-12, 06:26 PM  
    Neuro
    A Theradrim Guardian
     
    Neuro's Avatar
    AddOn Author - Click to view AddOns

    Forum posts: 60
    File comments: 65
    Uploads: 2
    Originally Posted by C A I N
    with 5.1 this mod is now causing all my toons to hang at a full loading bar, it wont let me into the game as long as this addon is enabled.
    Yeah, I'll try and take a look at this tonight.
    Report comment to moderator  
    Reply With Quote
    Unread 11-27-12, 08:26 PM  
    Jykor
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    *edit* Just saw a previous reply.

    thank you. love this addon!
    Last edited by Jykor : 11-27-12 at 08:27 PM.
    Report comment to moderator  
    Reply With Quote
    Unread 11-27-12, 09:44 PM  
    C A I N
    A Murloc Raider
     
    C A I N's Avatar

    Forum posts: 6
    File comments: 15
    Uploads: 0
    yay! if you can fix this I am sure many of us would be eternally grateful, sucks playing without this mod.
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 07:23 AM  
    Fizzgig
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    Still getting the consolidate buffs problem.
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 09:52 AM  
    Nillin
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    If it's any help, deleting the addon and associated saved variables and reinstalling does allow you to log in once with it active - but subsequent logins will get stuck. Possibly something changed with the format/types of variables?

    It does appear to get as far as popping up the 'This addon is in simple mode' box if you just delete the settings.
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 12:37 PM  
    Neuro
    A Theradrim Guardian
     
    Neuro's Avatar
    AddOn Author - Click to view AddOns

    Forum posts: 60
    File comments: 65
    Uploads: 2
    Originally Posted by Nillin
    If it's any help, deleting the addon and associated saved variables and reinstalling does allow you to log in once with it active - but subsequent logins will get stuck. Possibly something changed with the format/types of variables?

    It does appear to get as far as popping up the 'This addon is in simple mode' box if you just delete the settings.
    Are you using this version of the addon, because I've had zero issues with logging in.
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 01:19 PM  
    Neuro
    A Theradrim Guardian
     
    Neuro's Avatar
    AddOn Author - Click to view AddOns

    Forum posts: 60
    File comments: 65
    Uploads: 2
    Originally Posted by Fizzgig
    Still getting the consolidate buffs problem.
    Fizz, this issue goes beyond what I was looking to do for this addon, it's something the addon author should address, but here's a quick and dirty fix which I believe will help:

    Go into your Interface/Addons/DoTimer/PlayerAuras folder and open up the core.lua file with Wordpad. Hit Ctrl-H which should bring up the "Replace" window. In the 'Find what:' section, type in "ConsolidatedBuffs", and in the "Replace with:" section, type in "-- Consolidated Buffs". Then hit Replace All.

    This will comment out the section of the code that is problematic. I honestly don't know if it has any side effects, but it should stop the behavior you are having problems with.
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 03:33 PM  
    SamadhiUF
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    Originally Posted by Neuro
    Originally Posted by Nillin
    If it's any help, deleting the addon and associated saved variables and reinstalling does allow you to log in once with it active - but subsequent logins will get stuck. Possibly something changed with the format/types of variables?

    It does appear to get as far as popping up the 'This addon is in simple mode' box if you just delete the settings.
    Are you using this version of the addon, because I've had zero issues with logging in.
    Same problem here. I can confirm the behavior Nillin is reporting as far as deleting settings letting you get into simple mode, but it hanging if you re-enable things.

    Thanks a ton for picking this up, though!
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 04:37 PM  
    Fizzgig
    A Kobold Labourer

    Forum posts: 0
    File comments: 3
    Uploads: 0
    Originally Posted by Neuro
    Originally Posted by Fizzgig
    Still getting the consolidate buffs problem.
    Fizz, this issue goes beyond what I was looking to do for this addon, it's something the addon author should address, but here's a quick and dirty fix which I believe will help:

    Go into your Interface/Addons/DoTimer/PlayerAuras folder and open up the core.lua file with Wordpad. Hit Ctrl-H which should bring up the "Replace" window. In the 'Find what:' section, type in "ConsolidatedBuffs", and in the "Replace with:" section, type in "-- Consolidated Buffs". Then hit Replace All.

    This will comment out the section of the code that is problematic. I honestly don't know if it has any side effects, but it should stop the behavior you are having problems with.
    That fixed it, much appreciated!
    Report comment to moderator  
    Reply With Quote
    Unread 11-28-12, 05:18 PM  
    Neuro
    A Theradrim Guardian
     
    Neuro's Avatar
    AddOn Author - Click to view AddOns

    Forum posts: 60
    File comments: 65
    Uploads: 2
    Originally Posted by SamadhiUF
    Originally Posted by Neuro
    Originally Posted by Nillin
    If it's any help, deleting the addon and associated saved variables and reinstalling does allow you to log in once with it active - but subsequent logins will get stuck. Possibly something changed with the format/types of variables?

    It does appear to get as far as popping up the 'This addon is in simple mode' box if you just delete the settings.
    Are you using this version of the addon, because I've had zero issues with logging in.
    Same problem here. I can confirm the behavior Nillin is reporting as far as deleting settings letting you get into simple mode, but it hanging if you re-enable things.

    Thanks a ton for picking this up, though!
    When you say you delete the settings, what does that entail? Are you restoring them to default settings, or are you deleting the actual SavedVariables file?

    If you would, can you create a lvl 1 character (not a panda!) and see how DoTimer interacts with a fresh character?
    Report comment to moderator  
    Reply With Quote
    Post A Reply
    Page 1 of 2 1 2 >


    Report this file Report this File

    Category Jump: