Download
(110Kb)
Download
Updated: 01-12-08 03:55 PM
Patch for:
Saeris's LootLink.
Pictures
File Info
Updated:01-12-08 03:55 PM
Created:unknown
Downloads:15,636
Favorites:60
MD5:

Saeris's LootLink 8.2.9 Fixed  Popular! (More than 5000 hits)

Version: 8.2.9 Fixed 5
by: Siz [More]

This is a modified version of Saeris's LootLink 8.2.9, which is currently the last released version. I'm uploading this since no official update has been posted for so long. I want to emphasize that this amazing addon is all Saeris' work, I just found a band-aid for it. This is not a forked version. I will delete this once an official version takes its place. *Update* Saeris has recently posted a successor to his LootLink addon called LinksList, I suggest you check it out.

Here are changes that I remember making from Saeris' last released 8.2.9a version:
- Enforces a 2 second interval between !item query responses to prevent you from being disconnected if someone spams you with requests.
- Tooltip showing 20 most recent items only shows as many lines as there were items instead of always showing 20 lines even if they were blank.
- Added support for Gem type and corresponding subtypes which were added in wow 2.1. This fixes errors that appear any time you see a gem link.
- Fixed the error when trying to use the premade database.
- Extracts scaled suffix from the uniqueID to save memory.

You should Reparse your database occasionally so that your database can be updated with the new Subtypes added in 2.3.

Changes:
Second Version:
-Improved Fake Tooltip appearance. Simply displays all lines from the fulltext cache. Also shows empty socket icons and colors socket bonus lines gray.
-Fixes color of extra tooltip information added by lootlink to either be all white or all teal instead of always having teal values.
-Added hint for moving minimap button to tooltip.
-Other stuff?
Third Version: [TOC: 20300]
-Added support for new item subtypes in 2.3 (enUS and deDE only)
-Implemented the GetSellValue API and uses the API to get sell values from other addons.
Fourth Version:
-Now parses items in the inbox
-Add support for Leatherworking Bags (enUS and deDE only)
-Support changed subtypes (enUS and deDE only)
-Fix hooks for tooltip functions
-Support SetGuildBankItem
Fifth Version:
-Fix GameTooltipMoneyFrame errors. Thanks to Xinhuan for the guidance.


Useful Scripts:
- Remove items from your database which do not meet the minimum stored rarity setting:

Code:
/script for baseID, itemTable in pairs(LootLink.Database) do if (itemTable[2] < LootLink.Config.MinStoredRarity) then LootLink:ItemTables_RemoveBaseItem(baseID,false) end end

Post A Reply Comment Options
Unread 06-07-07, 01:41 AM  
Buio
A Kobold Labourer

Forum posts: 0
File comments: 150
Uploads: 0
Thanks for implementing the fixes and uploading it.
Report comment to moderator  
Reply With Quote
Unread 06-07-07, 02:57 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Yes, nice work. Now that Saeris has confirmed he's alive--with updates of a couple of his other addons since the patch, seen through his author portal--the possibility exists he might update his version of LootLink. No word given on the LootLink addon page, though. Telo updated his original LootLink for WoW 2.1 & someone has updated LootLink Enhanced on worldofwar.net; here's hoping Saeris gets back in the saddle for his version .

Encountered an error popping up with this LootLink_829_Fixed revision. Unzipped over top of the existing 8.2.9a I had installed previously (that had the manual LUA revisions I made per the comment posts).

The previous error I reported in the original section yesterday has not reoccurred (yet). A new one:

"LootLink-829\\LootLink_Results.lua:172: attempt to concatenate field '?' (a nil value)\nLootLink-829\\LootLink_Results.lua:738: in function `Results_ShowSuffixesForEntryID'\nLootLink-829\\LootLink_Results.lua:684: in function `Results_ItemButton_OnClick'\n<string>:\"*:OnClick\":1: in function <[string \"*:OnClick\"]:1>".

Did a "Name" search for "Hallowed". A number of items were returned in the results window. One odd result, though: "Hallowed Trousers" had a "(1) +" next to it, as though there was more than one variety of it (there is not). Click on the "+" to expand it and that's when the error occurred. Has never happened before. Avoid clicking the "+" and just click the name "Hallowed Trousers" and the link appeared without errors. The last database reparsing here was done a week ago, as noted on the other comments page.
Last edited by Zidomo : 06-07-07 at 02:59 AM.
Report comment to moderator  
Reply With Quote
Unread 06-07-07, 08:12 AM  
Siz
A Wyrmkin Dreamwalker
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 228
Uploads: 5
Zidomo.. I'm not denying the possibility of a problem with LootLink, but I think there's something wrong with your database that reparse isn't catching.

I've seen odd problems with items having "(0)" suffixes, but I've never seen items which should not have suffixes listed with "(1)". I'll be on the lookout for anything that might cause this.

For now, I would recommend removing the problematic item by Alt+Clicking it, or if that produces an error and fails to delete the item, log out of game and delete the item from your savedvariables file manually. Then add the item back to the database using the "/ll addbyrequestlink 27875" command for Hallowed Trousers.
Report comment to moderator  
Reply With Quote
Unread 06-07-07, 04:57 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Originally posted by Siz
Zidomo.. I'm not denying the possibility of a problem with LootLink, but I think there's something wrong with your database that reparse isn't catching.

I've seen odd problems with items having "(0)" suffixes, but I've never seen items which should not have suffixes listed with "(1)". I'll be on the lookout for anything that might cause this.

For now, I would recommend removing the problematic item by Alt+Clicking it, or if that produces an error and fails to delete the item, log out of game and delete the item from your savedvariables file manually. Then add the item back to the database using the "/ll addbyrequestlink 27875" command for Hallowed Trousers.
This is becoming more trouble than its worth. I may go back to Telo's original (further extending my already long logon time ) if the errors keep occurring and Saeris's version doesn't become fully 2.1 compatible.

Never had such a problem prior to the patch. No, there are no problems with the hard drive partition WoW is on. After all the LUA changes were posted on the original page, I performed them--over a week ago (yes, I know how to properly make/save changes to script files). Then unzipped the pre-2.1 saved variables LUA and logged on with it in 2.1. Logged on, reloaded UI as LootLink requests, then did a proper reparsing.

Then a couple days later, did another reparsing. Then over a week later, installed this new revision and the error occurs.

Yep, I am familiar with the item deleting & adding-by-ID processes. Thanks for the tip regardless & for your efforts with this mod.
Last edited by Zidomo : 06-07-07 at 05:02 PM.
Report comment to moderator  
Reply With Quote
Unread 06-08-07, 08:03 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Update:

The previously noted errors (as follows) have been reoccurring with this version on a number of different characters. Identical errors as I posted about in the original thread that occurred on one character after making manual changes, then reparsing properly:

"LootLink-828\\LootLink_Tooltips.lua:58: attempt to index local 'config' (a nil value)\nBankItems\\BankItems.lua:1704: in function <Interface\\AddOns\\BankItems\\BankItems.lua:1701>\n<in C code>: ?\n<in C code>: ?\n<in C code>: ?\n<in C code>: in function `Original_GameTooltip_SetHyperlink'\nLootLink-828\\LootLink_Parsing.lua:383: in function <Interface\\AddOns\\LootLink\\LootLink_Parsing.lua:382>\nSellFish\\tooltips.lua:56: in function `SetHyperlink'\nTipHooker-1.0-37421 (TipHookerLib):305: in function <...\\AddOns\\TipHookerLib\\TipHooker-1.0\\TipHooker-1.0.lua:300>\n\n"

"LootLink-828\\LootLink_Parsing.lua:37: attempt to index field 'Config' (a nil value)\nLootLink-828\\LootLink_Parsing.lua:117: in function `Parsing_ParseFromHyperlink'\nLootLink-828\\LootLink_Parsing.lua:386: in function <Interface\\AddOns\\LootLink\\LootLink_Parsing.lua:382>\nSellFish\\tooltips.lua:56: in function `SetHyperlink'\nTipHooker-1.0-37421 (TipHookerLib):305: in function <...\\AddOns\\TipHookerLib\\TipHooker-1.0\\TipHooker-1.0.lua:300>\n\n"
Report comment to moderator  
Reply With Quote
Unread 06-08-07, 11:52 AM  
Siz
A Wyrmkin Dreamwalker
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 228
Uploads: 5
Originally posted by Zidomo
Update:

The previously noted errors (as follows) have been reoccurring with this version on a number of different characters. Identical errors as I posted about in the original thread that occurred on one character after making manual changes, then reparsing properly:
Could you PM me a link to your current database?

LootLink's data is stored per-account, so it would make sense to me that you see errors on all of your characters it there really is a problem.
Last edited by Siz : 06-08-07 at 06:46 PM.
Report comment to moderator  
Reply With Quote
Unread 06-09-07, 02:31 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Originally posted by Siz
Could you PM me a link to your current database?

LootLink's data is stored per-account, so it would make sense to me that you see errors on all of your characters it there really is a problem.
I'd prefer to remain anonymous . But will take the time to upload it somewhere (after name editing) if it will really help.

Single account. Not all characters bring up those two errors at logon consistently, only some (i.e. every one under level 20 so far).

EDIT: And yes, it really is a problem. Errors only started occurring after WoW 2.1, logging on with a pre-2.1 saved variables database with a LUA-modified LootLink (as per the posts on the other page). Did not log on with an unaltered LootLink 8.2.9. The errors continue on with the modified version here, including after a couple of proper parsings.
Last edited by Zidomo : 06-09-07 at 11:58 AM.
Report comment to moderator  
Reply With Quote
Unread 06-13-07, 09:40 PM  
Hevanus
A Deviate Faerie Dragon
 
Hevanus's Avatar

Forum posts: 15
File comments: 199
Uploads: 0
Still getting the memory error when merging:

[08:38:13PM] LootLink: Error: The plugin named "LootLink_PremadeDatabase" failed to load, for the following reason:

Not enough memory: 11600 KB extra memory needed, -44918 available. Boost your available script memory via the edit box at the top right corner of the addon selection screen, then try again.

Please ensure that the plugin's folder exists in LootLink's directory.
Report comment to moderator  
Reply With Quote
Unread 06-13-07, 10:55 PM  
Siz
A Wyrmkin Dreamwalker
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 228
Uploads: 5
Disable all addons other than LootLink and LootLink Premade Database then log in and add the data. After that, you can re-enable any other addons and you can delete the premade database adder addon.

Originally posted by Hevanus
Still getting the memory error when merging:

[08:38:13PM] LootLink: Error: The plugin named "LootLink_PremadeDatabase" failed to load, for the following reason:

Not enough memory: 11600 KB extra memory needed, -44918 available. Boost your available script memory via the edit box at the top right corner of the addon selection screen, then try again.

Please ensure that the plugin's folder exists in LootLink's directory.
Last edited by Siz : 06-13-07 at 10:57 PM.
Report comment to moderator  
Reply With Quote
Unread 06-14-07, 12:51 AM  
Hevanus
A Deviate Faerie Dragon
 
Hevanus's Avatar

Forum posts: 15
File comments: 199
Uploads: 0
Is that really necessary now that there are no memory limits for the scripting engine? I seem to remember that someone hacked the check to get around it and that worked.
Last edited by Hevanus : 06-14-07 at 12:51 AM.
Report comment to moderator  
Reply With Quote
Unread 06-14-07, 12:53 AM  
Siz
A Wyrmkin Dreamwalker
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 228
Uploads: 5
This fixed version already includes that hack. I may post an update with the offending code removed.

You could edit the files and increase the memory size even more.
Report comment to moderator  
Reply With Quote
Unread 06-14-07, 01:05 AM  
Hevanus
A Deviate Faerie Dragon
 
Hevanus's Avatar

Forum posts: 15
File comments: 199
Uploads: 0
Holy crap that was a fast reply.

I think I may have installed your fixed version wrong - I'll double check.

Edit: Nope, your fix has line 389 commented out and forces maxMemory to an arbitrary value of 49152, which isn't enough. Anyways, I commented out lines 392-401 because that seems like a more proper fix (I don't see the point in checking for an arbitrary and nonexistent memory limit) and it works fine.

One issue I am now seeing as a side-effect of importing your premade database is that every time I attempt a reparse of the data (/ll fullreparse) it reports 9809 items altered. This is highly unusual, as I have always seen the number diminish to zero after a few reparses (why it takes more than one in the first place is beyond me).
Last edited by Hevanus : 06-14-07 at 01:12 AM.
Report comment to moderator  
Reply With Quote
Unread 06-14-07, 08:14 AM  
Siz
A Wyrmkin Dreamwalker
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 228
Uploads: 5
Whoops, I thought I had increased maxMemory to 150000.

After importing the premade database, you may have items that don't even exist on your server. Reparsing the database can only fix those items which you have seen either in chat links, on another character, at the vendor, or on the auction house. Before importing, I'd imagine that your database was fairly small and only contained very common items. Now, you have stuff like Black Qiraji Resonating Crystal which is very rare and not likely to be seen.
Last edited by Siz : 06-14-07 at 08:27 AM.
Report comment to moderator  
Reply With Quote
Unread 06-15-07, 07:53 AM  
Hevanus
A Deviate Faerie Dragon
 
Hevanus's Avatar

Forum posts: 15
File comments: 199
Uploads: 0
Originally posted by Siz
Whoops, I thought I had increased maxMemory to 150000.

After importing the premade database, you may have items that don't even exist on your server. Reparsing the database can only fix those items which you have seen either in chat links, on another character, at the vendor, or on the auction house. Before importing, I'd imagine that your database was fairly small and only contained very common items. Now, you have stuff like Black Qiraji Resonating Crystal which is very rare and not likely to be seen.
Yes, I'm aware of that but that's not what is happening here because items like those can't be parsed and won't be counted as items that were modified by the parse. What I'm seeing is the same number of items being altered every time I do a parse, which is disconcerting because once they're changed they shouldn't have to be again (well, not all of them anyways) if I do another parse 2 seconds later.
Last edited by Hevanus : 06-15-07 at 07:55 AM.
Report comment to moderator  
Reply With Quote
Unread 06-15-07, 08:33 PM  
Hevanus
A Deviate Faerie Dragon
 
Hevanus's Avatar

Forum posts: 15
File comments: 199
Uploads: 0
Update:

I commented out line 492 of LootLink_Parsing.lua ("instanceID = bit.band(instanceID, 65535) --Siz") and it cleared up the problem.

I think what might be happening is that line 492 may be generating false positives on line 496 ("if (suffixData[instanceID] ~= instanceData) then"), causing the numChanges counter to increment when it shouldn't.
Last edited by Hevanus : 06-15-07 at 08:34 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: