(153Kb)

Compatible with Retail, Classic & TBC

Updated: 09-13-23 08:08 PM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	Hot Fix (10.1.7) Classic (1.14.4) WotLK Patch (3.4.2)
Updated:	09-13-23 08:08 PM
Created:	unknown
Downloads:	55,990
Favorites:	486
MD5:

BankStack

Version: v2023.2

by: Kemayo [More]

BankStack is the leading cause of things moving in your bags and bank.

It:

sorts your inventory, bank, or guild bank
fills incomplete stacks in your bank with items from your inventory
compresses your bags by filling incomplete stacks within them
puts a chicken in every pot, and pot in every chicken

Code:

/sort -- rearrange your bags
/sort bank -- rearrange your bank
/stack -- fills stacks in your bank from your bags
/stack bank bags -- fills stacks in your bags from your bank
/stack {group1} {group2} -- fills stacks in group2 from group1
/compress -- merges stacks in your bags
/compress bank -- merges stacks in your bank
/compress {group} -- merges stacks in group
/fill -- fill empty slots in your bank from your bags
/fill {group1} {group2} -- fill empty slots in group2 from group1

/bankstack -- show configuration

In the /bankstack configuration you'll find sections for "ignore" and "groups". Here's a bit of elaboration on the syntax for those parts.

You need, regrettably, to hear about bag ids first. Each bag has a number which addons use to interact with it.

Your bags are: 0, 1, 2, 3, 4
Your bank is: -1, 5, 6, 7, 8, 9, 10, 11
The reagent bank is -3. It's sort of special, but you can think of it as part of the bank.

To ignore slot 1 of bag 0, the first slot in your backpack, go to the "ignore" panel and put "0 1" into the textfield and click "okay".

Groups are similar. Let's say that you're a herbalist, and only want to do some things to your herb bags.

You could put this into the "groups" textbox: herbs 3,4
Or this: bankherbs 10,11

You now have two custom groups -- herbs and bankherbs. Presumably you keep massive herb bags in slots 3 and 4, and are making lots of money from this because you have the two most expensive bank slots as well (10 and 11).

Having created these groups you could:

Code:

/stack herbs bankherbs

Which would fill up stacks in your bank herb bags from stacks in your personal herb bags.

Predefined groups are: bank, bags, guild, all, and a few more. Click the "list" button in the groups config to see these.

Planned Features:

Suggest something?

BankStack
v2023.2 (2023-09-14)
Full Changelog Previous Releases

Adjust an easily confused comparison to make luacheck happy
TOC for 10.1.7

Optional Files (0)

Archived Files (7)

File Name	Version	Size	Author	Date
BankStack	v2023.1	153kB	Kemayo	02-11-23 01:37 PM
BankStack	v2022.4	153kB	Kemayo	12-05-22 08:43 PM
BankStack	v2022.3	153kB	Kemayo	11-21-22 05:44 PM
BankStack	v2022.2	153kB	Kemayo	11-15-22 12:19 AM
BankStack	v2022.1	153kB	Kemayo	11-12-22 12:12 PM
BankStack	v2022.0	150kB	Kemayo	02-22-22 01:39 PM
BankStack	v2021.0	151kB	Kemayo	05-29-21 10:36 AM

Comment Options

Page 5 of 10

« First

Last »

07-12-09, 11:43 AM
Annyonne An Aku'mai Servant Forum posts: 30 File comments: 63 Uploads: 0	more sorting options? Right now, the command "/sort bank" sorts all of my equipment by slot. Could you add "/sort bank level" to sort the equipment by either item level or character level? Thanks for an awesome addon!

07-13-09, 05:42 PM
hi2chriz A Murloc Raider Forum posts: 4 File comments: 5 Uploads: 1	Error Report Great addon thus far, however it never seem to want to move more then 16 items from one group to another. I use this addon for moving are large amount of glyphs, and sometime i want to move 40 stack from bags to guild1 and it will only move 16 stacks, if i try again it says there is perfection but the guild tab still has plenty of room. same thing happens the other way around or in my personal bank. any thoughts?

07-19-09, 12:32 AM
hi2chriz A Murloc Raider Forum posts: 4 File comments: 5 Uploads: 1	no longer maintained? well i figured out another detail it only moves the glyphs on the first bag not the the glyphs in any of the bags which are all "Pack of Endless Pockets" Last edited by hi2chriz : 07-19-09 at 12:35 AM.

07-21-09, 04:40 AM
essmene A Murloc Raider Forum posts: 5 File comments: 30 Uploads: 0	progress bar Would it be possible to setup a progress bar for the pending moves for the guild bank ? (maybe with an estimated time). Sometimes i don't know if it's stuck or still working and how long it will need to compete sorting 8 guild bank tabs.

08-01-09, 01:05 PM
darkyce A Kobold Labourer Forum posts: 0 File comments: 3 Uploads: 0	I can't get the group filling and sorting to work, so I assume that I di something wrong =/ Here's what I did: I created a group called Backpack, with the text "backpack 0", then I added another group with "glyphbags 1,2,3,4". The I tried "/fill backpack glyphbags", and sometimes it moves one or two items, but rarely, and never all the items. I'm using this for my glyph char, and he's using 4 max size glyph bags, but he also sells a few random drops from my other chars every now and then, and that's why I need to clear some Backpack space. Oh, and thanks for this insanely awesome addon! I'm now a clickaholic on the sorting button

09-02-09, 07:33 AM

Dajova

A Wyrmkin Dreamwalker

Forum posts: 58

File comments: 787

Uploads: 5

Since the last maintence, i've been getting this error and not being able to stack the bank via the LDB launcher:

[2009/09/02 15:32:15-521-x1]: BankStack-v14\stack.lua:39: attempt to perform arithmetic on field '?' (a nil value)
BankStack-v14\stack.lua:93: in function `Stack'
BankStack-v14\sort.lua:32: in function `SortBags'
BankStack-v14\ldb.lua:7: in function `?'
BankStack-v14\ldb.lua:68: in function `OnClick'
Fortress-1.12 \Core.lua:248: in function <Interface\AddOns\Fortress\Core.lua:233>

---

__________________
Livestream | Twitter | YouTube

09-19-09, 01:09 AM
Kupotek An Aku'mai Servant Forum posts: 38 File comments: 1201 Uploads: 2	Would it be possible, that when I use the mod to stack my inventory, if it finds 10 crystallized fire, water, whatever, it stacks them in eternals? __________________ Panther UI \| My Home on the Web

09-24-09, 10:52 PM
xythian A Kobold Labourer Forum posts: 1 File comments: 20 Uploads: 0	I too am having problems with BankStack working with inscription bags. If I try to fill my inscription bags from the bank, it will only fill the backpack slot and then stops. The inscription bags are untouched. Note: I am only trying to move glyphs into these bags. It's not an item-bag conflict. I've poked around the Bank Stack lua but I can't figure out where it stores information about specialty bags. Does this problem exist with other special bags or just inscription bags? Also, I can't move anything out of glyph bags either. Last edited by xythian : 09-24-09 at 10:55 PM.

09-25-09, 04:56 PM
xythian A Kobold Labourer Forum posts: 1 File comments: 20 Uploads: 0	I think I've fixed the issue (at least for me) with Bank Stack ignoring profession bags. You want to edit the "IsSpecialtyBag" function in core.lua to look like the following. Code: function core.IsSpecialtyBag(bagid) if safe[bagid] or is_guild_bank_bag(bagid) then return false end local invslot = ContainerIDToInventoryID(bagid) if not invslot then return false end local bag = GetInventoryItemLink("player", invslot) if not bag then return false end -- local item_type, item_subtype = select(6, GetItemInfo(bag)) -- if item_type == L.CONTAINER and item_subtype == L.BAG then -- return false -- end -- return item_subtype end The lined which are commented out with the -- markers are meant to identify non-normal bags. However, Bank Stack appears to only be able to handle ammo and shard bags but not profession bags. I commented out the code and am able to use my glyph bags just fine when moving large amounts of glyphs between bank and bags and vice versa. Good luck!

10-01-09, 05:22 AM
Bornabe A Flamescale Wyrmkin Forum posts: 133 File comments: 264 Uploads: 6	Hi there, is there a way to only sort the current Guild Bank Tab you're on? I had all my items from the last Officer-Only tab throwing items into the Open-Access tab we have. I had to manually move it all back when done, lol.

10-01-09, 05:03 PM
brontes A Murloc Raider Forum posts: 4 File comments: 49 Uploads: 0	Oh how I wish I knew more lua. If it was perl I'd have having a field day. Suggestion for reworking the sort algorithm: Stack up partial stacks. Save inventory state in a table/associative array/even just a plain array. (eg: slot0 = item1, slot1 = item2, etc.), structure Foo. Do whatever sorting you're doing now, but instead of actually moving the items, save the end-state of the sort in a similar-to-above data structure, Bar. Step through each item slot, lookup Bar value, step through Foo until there is a == match, [edit: check to make sure that Foo[slot] != Bar[slot] to insure you're not moving an "already sorted" item, ] then make the physical move, clear Foo entry for that slot. This would be a dirty fix to the issue of making 80+ moves when hand sorting could do it in three. edit: To below comment: /sort guild1 (for tab 1), /sort guild5, etc. Last edited by brontes : 10-01-09 at 05:08 PM.

10-01-09, 09:49 PM

Kemayo

A Cyclonian

Forum posts: 41

File comments: 129

Uploads: 11

It's worth mentioning that this is (close) to what it's doing. Every move that's made results in at least one stack being filled with the correct item -- there's no in-place bubble-sort, or anything like that.

The main problem with the algorithm is that it doesn't handle the fairly common case of having to move an empty space to the end. So, if you've used up one soul shard, it will make 20 moves of one soul shard at a time, to fill up that space, and then the space left by the other shard, and so forth.

Unless I'm misunderstanding your suggestion, I don't think it'd help with that case.

EDIT: If you're interested in what's going on, take a look at sort.lua. Lines 194-247 are the moving logic. default_sorter on line 107 does the work of determining the correct order. There's a pseudo-decent amount of comments on why things are being done, and there's not *too* much weird lua-specific metatable meddling happening.

Originally posted by brontes
Oh how I wish I knew more lua. If it was perl I'd have having a field day.

Suggestion for reworking the sort algorithm:
Stack up partial stacks.

Save inventory state in a table/associative array/even just a plain array. (eg: slot0 = item1, slot1 = item2, etc.), structure Foo.

Do whatever sorting you're doing now, but instead of actually moving the items, save the end-state of the sort in a similar-to-above data structure, Bar.

Step through each item slot, lookup Bar value, step through Foo until there is a == match, [edit: check to make sure that Foo[slot] != Bar[slot] to insure you're not moving an "already sorted" item, ] then make the physical move, clear Foo entry for that slot.

This would be a dirty fix to the issue of making 80+ moves when hand sorting could do it in three.

edit: To below comment:

/sort guild1 (for tab 1), /sort guild5, etc.

Last edited by Kemayo : 10-01-09 at 09:55 PM.

10-01-09, 11:39 PM

brontes

A Murloc Raider

Forum posts: 4

File comments: 49

Uploads: 0

Originally posted by Kemayo
Every move that's made results in at least one stack being filled with the correct item

The idea is to have a current and a endstate before making any physical moves. Once you've got those, step through each slot and don't move current[slot] if current[slot] == endstate[slot].

If you know what your final end state looks like, could you not just skip any swap that would move an item that is already where endstate says it should be?

The idea being that you do the ugly stuff (moving the one space around a bunch of times to put it at the end) in memory, then just make sure the actual movement is not displacing an item already in its proper slot.

Briefly looking over the code you pointed out, you're doing multiple passes on what I'm guessing is actual movement of items. (I'm not certain of this.) I'm suggesting internalizing all this and then doing the physical movement. If you've got two tables, one unsorted and one sorted, you'll only need one pass of actual in-game item movement (the "expensive" part of the function) to put each item into its correct slot.

Its 1am and I'm probably rambling and/or vastly confused. Apologies.

Last edited by brontes : 10-01-09 at 11:40 PM.

10-02-09, 11:22 PM

Kemayo

A Cyclonian

Forum posts: 41

File comments: 129

Uploads: 11

Like I said, that's what it does. It knows the current state of the bags, and from that a new state is created. It then works out a list of moves that need to be made, and finally executes those moves.

The problem is just that it needs to be smarter about building the list of moves.

Originally posted by brontes
The idea is to have a current and a endstate before making any physical moves. Once you've got those, step through each slot and don't move current[slot] if current[slot] == endstate[slot].

If you know what your final end state looks like, could you not just skip any swap that would move an item that is already where endstate says it should be?

The idea being that you do the ugly stuff (moving the one space around a bunch of times to put it at the end) in memory, then just make sure the actual movement is not displacing an item already in its proper slot.

Briefly looking over the code you pointed out, you're doing multiple passes on what I'm guessing is actual movement of items. (I'm not certain of this.) I'm suggesting internalizing all this and then doing the physical movement. If you've got two tables, one unsorted and one sorted, you'll only need one pass of actual in-game item movement (the "expensive" part of the function) to put each item into its correct slot.

Its 1am and I'm probably rambling and/or vastly confused. Apologies.

10-20-09, 10:16 AM
C.D A Kobold Labourer Forum posts: 0 File comments: 1 Uploads: 0	Macro button Great addon. I'm just wondering if it's possible to somehow bind the crafting queue to a key so that when I push it, the item on top of the list is processed? Would be of great help. Thanks

Page 5 of 10

« First

Last »

Report this File

Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.

[Disable these notices]