(60Kb)

Download

Updated: 06-08-08 07:12 AM

Addon for:
ItemRack.

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	06-08-08 07:12 AM
Created:	unknown
Downloads:	199,363
Favorites:	315
MD5:

ItemRack 2.16 (Old version don't download)

Version: 2.16

by: Gello [More]

ItemRack 2 is out of beta! Thanks to everyone for using this, helping to make it better and most of all your patience.

This "Plugin-Ins & Patches" version of the mod is being depreciated as 2.x becomes the primary version of the mod. The official version of ItemRack is at:

http://www.wowinterface.com/downloads/info4148.html

2.2 and future versions will be posted there.

This 2.16 version will remain for some time mostly to keep comments, but please post new comments on the primary link above.

Thanks!

Comment Options

Page 14 of 17

« First

Last »

05-12-08, 10:05 PM
Burnum A Defias Bandit Forum posts: 2 File comments: 81 Uploads: 0	odd bug for me on 2.12 the little drop down item menus in the character sheet show up under the eputation, and Skills tabs. namely the main, off hand weapon totem slot (in my case because I'm a Shaman). As far as I know I don't have any mods playing with the tabs down there...

05-13-08, 06:59 AM

romracer

A Murloc Raider

Forum posts: 4

File comments: 49

Uploads: 1

Originally posted by Burnum
odd bug for me on 2.12

the little drop down item menus in the character sheet show up under the eputation, and Skills tabs. namely the main, off hand weapon totem slot (in my case because I'm a Shaman). As far as I know I don't have any mods playing with the tabs down there...

Unfortunately, it seems two of my fixes from 2.1e did not make it into 2.12. This is one of them.

The mainhand, offhand and ranged "quick swap" buttons display above the Character, Reputation, etc. tabs on the Character sheet after the user has left clicked on the mini map icon.
Fixed a tooltip display issue if you enable the option "Menu on shift key" (previously tooltips would not be displayed on items on the bar with this option on)

The first one can be fixed by editing ItemRack/ItemRack.xml and changing line 16 to read like so (we added the bit at the end):

Code:

<Frame name="ItemRackMenuFrame" frameStrata="HIGH" enableMouse="false" movable="true" parent="UIParent" hidden="true" clampedToScreen="true" topLevel="true">

The second one can be fixed by editing ItemRack/ItemRackButtons.lua and moving line 379 to line 373 (the old line 373 should become line 374). Such that it looks like this:

Code:

function ItemRack.OnEnterButton()
        ItemRack.InventoryTooltip()
        if ItemRack.IsTimerActive("ButtonsDocking") or (not IsShiftKeyDown() and ItemRackSettings.MenuOnShift=="ON") or ItemRackSettings.MenuOnRight=="ON" then
                return -- don't show menu while buttons docking
        end
        local button = this:GetID()
        ItemRack.DockMenuToButton(button)
        ItemRack.BuildMenu(button)
end

I have incorporated these into my local copy, but I have not been able to test it as the realms are still down. I will hold back on posting a "2.12a" version for at least a few days. Gello has been very responsive and will likely fix these and any remaining issues 2.4.2 brings soon. You can manually apply my above changes until then.

05-13-08, 09:23 AM
Gello A Molten Giant Forum posts: 521 File comments: 582 Uploads: 75	Ooh didn't see those in the diff. I'll post those changes tonight after servers come up and I can test the mod some. Thanks!

05-13-08, 10:23 AM
Athanyel A Kobold Labourer Forum posts: 0 File comments: 13 Uploads: 0	Gello and Rom, THANK YOU! I've been a huge fan of this mod and am really happy to see this taking off again. The missing information from the diffs is my bad. Sorry about that! -Ath (who is happily nuking his local copy of ItemRack) Last edited by Athanyel : 05-13-08 at 11:26 AM.

05-13-08, 11:28 AM
Steil A Cliff Giant Forum posts: 77 File comments: 49 Uploads: 0	Just to be nosy, when will events be in for this version? since they work in the other wouldn't it just be a bit of copypasta? are you waiting for a (mount) specific library so you don't have to add more mounts everttime blizz does? Or was there some kind of streamlining that was supposed to be put in place by blizzard that's not be done yet? I'm curious cause I did try this version before and I liked the changing gear from the character screen.

05-13-08, 12:00 PM

Gello

A Molten Giant

Forum posts: 521

File comments: 582

Uploads: 75

Events will be in much sooner than later. The set equip needed fixing bad (it sucked). It has to be stable and durable enough to handle multiple swaps happening at once (ie, rogue going into stealth off a mount crossing plagueland border). The existing set equip should be very stable for single set swaps. I've got code working now to handle queueing set swaps instead of the re-entrant mess from before. So all that's left is the UI and writing the mechanics.

As for why I don't want to copy/paste what exists, I wanted to go a different route for a couple reasons: 1) Making an event based on whether you have some buff or proc shouldn't require lua knowledge. 2) Every event goes through RunScript which is relatively slow.

Instead of every event defined by a script that runs on every trigger, events will be broken apart into categories (Buff, Stance, Zone, Scripts). Buff, Stance and Zone scripts will be embedded to act on them without a RunScript. If you want to set up an event for getting Nightfall proc, you choose 'Buff' as event type, 'Nightfall' as name of buff, and then check whether you want to swap back when the buff fades. This should make it a lot easier to make events and it should make the association of what's happening a lot more clear.

Originally posted by Steil
Just to be nosy, when will events be in for this version? since they work in the other wouldn't it just be a bit of copypasta? are you waiting for a (mount) specific library so you don't have to add more mounts everttime blizz does? Or was there some kind of streamlining that was supposed to be put in place by blizzard that's not be done yet? I'm curious cause I did try this version before and I liked the changing gear from the character screen.

05-13-08, 12:34 PM
Steil A Cliff Giant Forum posts: 77 File comments: 49 Uploads: 0	nice and thank you for the info.

05-13-08, 01:29 PM
vishnou00 A Kobold Labourer Forum posts: 0 File comments: 37 Uploads: 2	Is it me or the new item rack (2+) does not move sets in and out of the bank? To me it was the single most important feature of ItemRack, I never used event support.

05-13-08, 01:32 PM
Shadowed ... Forum posts: 387 File comments: 2513 Uploads: 83	Rather obscure of a bug, but unique gems cause issues with equipping sets. For example, if I socket a Falling Star in Set #1 in a Shoulder piece, and then equip a Falling star in Set #2 in Pants, if I equip #1 then switch to #2 it'll work fine, but if I then do #2 -> #1 it'll give the unique gem error and not swap the shoulders. If you re-equip #1 again it'll work fine.

05-13-08, 03:28 PM

forty2j

A Cobalt Mageweaver

Forum posts: 232

File comments: 260

Uploads: 0

Originally posted by vishnou00
Is it me or the new item rack (2+) does not move sets in and out of the bank?

To me it was the single most important feature of ItemRack, I never used event support.

Bank swapping definitely worked as recently as 2.11. I don't think I've done a bank swap in the couple days 2.12 was out.. and now we're at 2.13 already, and I haven't installed it yet.

05-13-08, 06:47 PM
Gello A Molten Giant Forum posts: 521 File comments: 582 Uploads: 75	Bank swapping works ok for me. Anyone else having problems? The recent versions use the new GetItemFamily() to determine if a bag is a real bag. It's possible that's not working so it's not seeing anything in bank bags. So three questions: 1) What language client are you on? 2) Do you have normal bags in your bank? 3) Try moving a banked set item from a bank bag to the bank "open space" (bag -1 technically). Does it notice it then?

05-14-08, 05:09 AM
GraemeF A Murloc Raider Forum posts: 4 File comments: 3 Uploads: 0	Bank swap with Baggins Bank swapping didn't work at all for me because I have Baggins set to hide the normal bank window. Once I disabled that option in Baggins it started working fine for all bank bags.

05-14-08, 08:45 AM
Intangir A Kobold Labourer Forum posts: 1 File comments: 35 Uploads: 1	what happened to the feature where a set would hide/show your helmet and cloak? i enjoyed that, i hide certain things on certain sets but not on others

05-14-08, 12:24 PM

vishnou00

A Kobold Labourer

Forum posts: 0

File comments: 37

Uploads: 2

The problem seemed more extensive then that, as if the whole bank awareness was gone (with the bank open, item menus from the paperdoll didn't list items that were in the bank).

Originally posted by Gello
1) What language client are you on?
2) Do you have normal bags in your bank?
3) Try moving a banked set item from a bank bag to the bank "open space" (bag -1 technically). Does it notice it then?

1) enUS
2) all normal bags
3) does't, but more on that later

As another commenters hinted, a bank bag addon (Bagnon) was interfering with ItemRack getting in "bank aware mode". I will come back to you if I find a more reliable trigger to get in bank mode (because 1.99 didn't have any issue with bag addon).

Another side bug that I just saw, the tooltip doesn't get random items (green item of the w/e) stat, as if suffixFactor (see ItemRandomSuffix and ItemString on wowwiki) was ignored. Not a big issue, since all the important parts to define a set are there: name (Conqueror's Epaulets), enchant (+5 Shadow Resistance), random enchant name (of Shadow Protection), and socketing information. Non-random enchant items have their stats even in the bank (they don't depend on random suffix).

========

Update:
The old item rack had a variable to keep track of opened and closed bank status, modified through a hook through BANKFRAME_OPENED and BANKFRAME_CLOSED events (still works in 2.4.2). The new one check if BankFrame is visible, obviously, other addons have different names for their bank frame.
A function I found that behaved differently with the bank closed and opened was GetContainerNumFreeSlots(-1). At the bank, it returns two values (number of free slot and slot type), away from the bank, it only returns 0. So you could check for the 2nd parameter being 0 instead so you could use select(2,GetContainerNumFreeSlots(-1)) instead of BankFrame:IsVisible() in place, with 0 being true and nil false, even though

Code:

function ItemRack.IsBankOpened()
    select(2,GetContainerNumFreeSlots(-1)) ~= nil
end

is much more sensible on the long term.

====

And damn, the new itemrack ate my 1.99 sets, and I had cleaned them up right after the backup.

Last edited by vishnou00 : 05-15-08 at 12:12 AM.

05-15-08, 08:37 AM
Gello A Molten Giant Forum posts: 521 File comments: 582 Uploads: 75	Oops yeah it assumes bank frame is visible. I'll go back to a flag. The suffix bit is an artifact of the way this mod deals with enchants/gems changing both intentionally and incidentally. It's a low priority fix right now but on the list. Show/hide helm/cloak is on the list too. Sorry about sets disappearing. The structure changed so much (and a sizable chunk of ItemRack 1.9x's code was keeping backward's compatability) that 2.x begins with a fresh slate.

Page 14 of 17

« First

Last »

Report this File

Category Jump: