Download
(168Kb)
Download
Updated: 12-28-10 03:41 PM
Patch for:
HandyNotes.
Pictures
File Info
Updated:12-28-10 03:41 PM
Created:12-14-10 08:13 AM
Downloads:3,232
Favorites:16
MD5:

HandyNotes (tempfix)

Version: 1.1.6c
by: Isharra [More]

The official HandyNotes release is out! It is version 1.2.0 so there should be no confusion when you upgrade. And please do go back to the official HandyNotes! I hope this addon helped you out.

All current work on the tempfix is halted.


This is a temporary patch for HandyNotes to work around the problems I was seeing with WoW patch 4.0.3a. The original HandyNotes 1.1.6 is available on Curse and WowInterface.

Cladhaire's changes to TomTom were incorporated so that Astrolabe 1.0 is used. This means that additional HandyNotes addons still need to be fixed separately if they call Astrolabe 0.4 themselves (see below.) If it works, Cladhaire deserves all the credit.

There is another attempt at a workaround HandyNotes (fanupdate) while it didn't solve my problem it should still work with the other HandyNotes addons as it was using Astrolabe-0.4 last I checked.

This is not intended as a fork in the codebase, just a workaround until the base addon is updated by the author.

Use /handynotes to access options.

You can add notes to the maps in 3 ways:

  • Alt-RightClick on the world map to add a note.
  • Use "/hnnew" without the quotes to add a note at your current location.
  • Use "/hnnew x,y" without the quotes to add a note at location x,y on your current zone's map.

The additional HandyNotes_* plugins won't work with this tempfix without being modified. Using these instructions with the official HandyNotes 1.1.6 won't work either. The FAQ changes should work with HandyNotes 1.2.0 when it's released as it will use Astrolabe-1.0.

See the FAQ for instructions on how to modify your HandyNotes_* plugins that aren't working.

Download the latest versions of SilverDragon, HandyNotes_Trainers, HandyNotes_Vendors and HandyNotes_Guild. They have been updated to work with HandyNotes 1.2.0.

Minimal testing with HandyNotes_SpecialNPCsEtc, HandyNotes_Charon and HandyNotes_Mailboxes since I don't use them normally but they load without error and seem to be adding the icons properly. HandyNotes_Mailboxes (tempfix) I've uploaded since I had to test the compat function changes required to support it.

rev 1.1.6c added "compat.IconsOnEdge = Astrolabe.IconsOnEdge" to hopefully fix icon on edge problem with the minimap.

rev 1.16b add functions to compat section to support HandyNotes_Mailboxes

rev 1.16a update Astrolabe-1.0 to r125

rev 1.16 initial release - Astrolabe-1.0 r123
Post A Reply Comment Options
Unread 12-17-10, 09:03 AM  
Toran
A Nerdscale Dorkin
 
Toran's Avatar
Premium Member

Forum posts: 143
File comments: 433
Uploads: 0
Thanks for this. I hacked up the handynotes modules to work on their own (per Isharra's comments on front page), and replaced all occurences of this:

Code:
local Astrolabe = DongleStub("Astrolabe-0.4")
with

Code:
local Astrolabe = DongleStub("Astrolabe-1.0")
Update: Only thing I've noticed so far is that the Handynotes Vendors, Handynotes Trainers, etc addons don't auto-add new vendors / trainers to the map anymore. Not sure why.
Last edited by Toran : 12-17-10 at 09:14 PM.
Report comment to moderator  
Reply With Quote
Unread 12-17-10, 05:52 PM  
imthedci
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Finally! My Notes don't stick to me anymore! Thank You so much!!
Report comment to moderator  
Reply With Quote
Unread 12-18-10, 08:50 AM  
Toran
A Nerdscale Dorkin
 
Toran's Avatar
Premium Member

Forum posts: 143
File comments: 433
Uploads: 0
Would love to hear if anyone is using this version plus any of the HandyNotes addons and able to get the vendors/auctioneers/trainers/etc to auto mark like they used to.
Report comment to moderator  
Reply With Quote
Unread 12-19-10, 11:04 AM  
Sariktor
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Originally posted by Toran
Would love to hear if anyone is using this version plus any of the HandyNotes addons and able to get the vendors/auctioneers/trainers/etc to auto mark like they used to.
You're in luck! I've been able to get the HandyNotes_* plugins to automark again. Be sure to copy/paste the TomTom Astrolabe work around into each of the following plugins as well. (I'm not sure if it will still work if not, I just added it as a 'just in case')

If applicable to you:

Open HandyNotes_CityGuide/addon.lua
Search:
Code:
local continent, zone, x, y = Astrolabe:GetCurrentPlayerPosition()
Replace with:
Code:
local continent, zone, x, y = compat:GetCurrentPlayerPosition()

Open HandyNotes_Mailboxes/HandyNotes_Mailboxes.lua
Search:
Code:
local c,z,x,y = Astolabe:GetCurrentPlayerPosition()
Replace with:
Code:
local c,z,x,y = compat:GetCurrentPlayerPosition()

Open HandyNotes_Trainers/addon.lua
Search:
Code:
local continent, zone, x, y = Astrolabe:GetCurrentPlayerPosition()
Replace with:
Code:
local continent, zone, x, y = compat:GetCurrentPlayerPosition()

Open HandyNotes_Vendors/addon.lua
Search:
Code:
local continent, zone, x, y = Astrolabe:GetCurrentPlayerPosition()
Replace with:
Code:
local continent, zone, x, y = compat:GetCurrentPlayerPosition()

Then save each of those files and enjoy your notes not following you and getting automarked
Report comment to moderator  
Reply With Quote
Unread 12-19-10, 02:07 PM  
Toran
A Nerdscale Dorkin
 
Toran's Avatar
Premium Member

Forum posts: 143
File comments: 433
Uploads: 0
You sir, are a genious. Nice work. I updated by blog with these changes to make sure others see it outside of the WoWInterface community (gave you credit, of course).

The changes worked perfectly. If the compat code isn't inserted in each of the HandyNotes_* addons, this won't work. Tried it and it was looking for the "compat" function. Added it in and all good.
Last edited by Toran : 12-19-10 at 02:08 PM.
Report comment to moderator  
Reply With Quote
Unread 12-19-10, 05:40 PM  
Sariktor
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Originally posted by Toran
You sir, are a genious. Nice work. I updated by blog with these changes to make sure others see it outside of the WoWInterface community (gave you credit, of course).

The changes worked perfectly. If the compat code isn't inserted in each of the HandyNotes_* addons, this won't work. Tried it and it was looking for the "compat" function. Added it in and all good.
I'm glad it worked for ya

I've also posted a link on the addon page on the Curse site so others may benefit from the tempfix.
Last edited by Sariktor : 12-19-10 at 05:49 PM.
Report comment to moderator  
Reply With Quote
Unread 12-20-10, 02:47 AM  
Tiegars
A Murloc Raider

Forum posts: 4
File comments: 1
Uploads: 0
Hi,

the addon have errors with Tomtom v1.0.7

Date: 2010-12-19 12:08:51
ID: -1
Error occured in: Global
Count: 1
Message: ..\AddOns\SilverDragon\handynotes.lua line 4:
Cannot find a library with name 'Astrolabe-0.4'
Debug:
[C]: ?
[C]: error()
...nterface\AddOns\TomTom\libs\Astrolabe\DongleStub.lua:17: DongleStub()
SilverDragon\handynotes.lua:4: in main chunk
AddOns:
Swatter, v5.10.4998 (CrouchingKangaroo)
ACP, v3.3.10
BankItems, v40000
BasicMinimap, v1.75
ButtonFacade, v4.0.340
ButtonFacadeEntropy, v4.0.62
Chatter, v1.0
Cromulent, vv1.5.7
Dominos, v1.20.2
DominosCast, v
DominosRoll, v
DominosXP, v
GatherMate2, v1.0.7
GupPet, v2.016
GupPetButtonFacade, v0.2
GupPetCollectMe, v
HandyNotes, v1.1.6b
Mapster, v1.4.0-1-gcc6fd16
MoveAnything, v11.4.5
OmniCC, v3.1.4
Postal, v3.4.4
QuestCompletist, v80
RangeColors, v
Recount, v
SilverDragon, vv2.4.1
TomTom, vv40000-1.0.7
BlizRuntimeLib_deDE v4.0.3.40000 <eu>
(ck=256)

and with Silverdragon 2.4.1

Date: 2010-12-20 09:46:57
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SilverDragon\handynotes.lua line 4:
Cannot find a library with name 'Astrolabe-0.4'
Debug:
[C]: ?
[C]: error()
...face\AddOns\HandyNotes\Libs\Astrolabe\DongleStub.lua:17: DongleStub()
SilverDragon\handynotes.lua:4: in main chunk
AddOns:
Swatter, v5.10.4998 (CrouchingKangaroo)
AckisRecipeList, v2.0.5
ACP, v3.3.10
BankItems, v40000
BasicMinimap, v1.75
ButtonFacade, v4.0.340
ButtonFacadeEntropy, v4.0.62
Chatter, v1.0
Cromulent, vv1.5.7
Dominos, v1.20.2
DominosCast, v
DominosRoll, v
DominosXP, v
GatherMate2, v1.0.7
GupPet, v2.016
GupPetButtonFacade, v0.2
GupPetCollectMe, v
HandyNotes, v1.1.6a
HealBot, v4.0.3.4
Mapster, v1.4.0-1-gcc6fd16
MoveAnything, v11.4.5
OmniCC, v3.1.4
Postal, v3.4.4
QuestCompletist, v80
RangeColors, v
Recount, v
SilverDragon, vv2.4.1
TipTac, v10.12.05
BlizRuntimeLib_deDE v4.0.3.40000 <eu>
(ck=280)


regards Tiegars
Report comment to moderator  
Reply With Quote
Unread 12-20-10, 12:54 PM  
Sariktor
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Originally posted by Tiegars
Hi,

the addon have errors with Tomtom v1.0.7

Date: 2010-12-19 12:08:51
ID: -1
Error occured in: Global
Count: 1
Message: ..\AddOns\SilverDragon\handynotes.lua line 4:
Cannot find a library with name 'Astrolabe-0.4'
Debug:
[C]: ?
[C]: error()
...nterface\AddOns\TomTom\libs\Astrolabe\DongleStub.lua:17: DongleStub()
SilverDragon\handynotes.lua:4: in main chunk

and with Silverdragon 2.4.1

Date: 2010-12-20 09:46:57
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SilverDragon\handynotes.lua line 4:
Cannot find a library with name 'Astrolabe-0.4'
Debug:
[C]: ?
[C]: error()
...face\AddOns\HandyNotes\Libs\Astrolabe\DongleStub.lua:17: DongleStub()
SilverDragon\handynotes.lua:4: in main chunk

regards Tiegars

Ok.. as you can tell from the error message "Message: ..\AddOns\SilverDragon\handynotes.lua line 4.. etc" both errors are being caused by the handynote plugin for SilverDragon and is quite an easy fix.

Open ~\SilverDragon\handynotes.lua. Search line 4 for:
Code:
local Astrolabe = DongleStub("Astrolabe-0.4")
and replace with:
Code:
local Astrolabe = DongleStub("Astrolabe-1.0")
This should correct your errors with SilverDragon.
Report comment to moderator  
Reply With Quote
Unread 12-20-10, 01:59 PM  
Davidious84
A Defias Bandit

Forum posts: 2
File comments: 3
Uploads: 0
I added the temp fix that you guys had posted here but it doesn't seem to work and I get the Error:

Date: 2010-12-20 14:46:07
ID: 1
Error occured in: Global
Count: 1
Message: ...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua line 916:
attempt to index global 'compat' (a nil value)
Debug:
(tail call): ?
...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua:916: AddSpecialNPCsEtcNote()
...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua:900: Opened_NPC()
...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua:682: ?()
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...\AddOns\DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...\AddOns\DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:119


Any help would be appreciated! thank you again for your time!.

The addon i'm using with handy notes is "Handy notes Special Npc etc" found at http://wow.curse.com/downloads/wow-addons/details/handynotes_specialnpcsetc.aspx
Was using this addon cause it seemed to do the work all the others did just all wrapped up into 1. Again any help would be appreciated.
Last edited by Davidious84 : 12-21-10 at 01:10 AM.
Report comment to moderator  
Reply With Quote
Unread 12-21-10, 12:45 PM  
Sariktor
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Originally posted by Davidious84
I added the temp fix that you guys had posted here but it doesn't seem to work and I get the Error:

Date: 2010-12-20 14:46:07
ID: 1
Error occured in: Global
Count: 1
Message: ...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua line 916:
attempt to index global 'compat' (a nil value)
Debug:
(tail call): ?
...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua:916: AddSpecialNPCsEtcNote()
...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua:900: Opened_NPC()
...dyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua:682: ?()
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...\AddOns\DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...\AddOns\DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:119


Any help would be appreciated! thank you again for your time!.

The addon i'm using with handy notes is "Handy notes Special Npc etc" found at http://wow.curse.com/downloads/wow-a...alnpcsetc.aspx
Was using this addon cause it seemed to do the work all the others did just all wrapped up into 1. Again any help would be appreciated.

Oh.. it's missing the workaround... Open HandyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua and add this near the top.
Code:
local compat = {}
HandyNotes.compat = compat

do
    local orig = GetCurrentMapAreaID()

    -- Create a lookup table from mapID to c,z pairs
    local mapcz = {}
    for cid, zlist in ipairs{GetMapContinents()} do
        for zid, mapid in ipairs{GetMapZones(cid)} do
            SetMapZoom(cid, zid)
            local mapid = GetCurrentMapAreaID()
            mapcz[mapid] = {cid, zid}
        end
    end

    SetMapByID(orig)

    -- Speed up minimap updates
    Astrolabe.MinimapUpdateTime = 0.1

    -- This function takes the mapID return from the Astrolabe function
    -- and converts it to a c,z,x,y tuple
    function compat:GetCurrentPlayerPosition()
        local map, floor, x, y = Astrolabe:GetCurrentPlayerPosition()
        local cz = mapcz[map]
        if cz then
            local c, z = unpack(cz)
            return c, z, x, y
        end
    end

    function compat:GetCurrentPlayerCoords()
        local map, floor, x, y = Astrolabe:GetCurrentPlayerPosition()
        return x, y
    end

    function compat:GetDirectionToIcon(...)
        return Astrolabe:GetDirectionToIcon(...)
    end

    function compat:GetDistanceToIcon(...)
        return Astrolabe:GetDistanceToIcon(...)
    end

    function compat:RemoveIconFromMinimap(...)
        return Astrolabe:RemoveIconFromMinimap(...)
    end

    function compat:IsIconOnEdge(...)
        return Astrolabe:IsIconOnEdge(...)
    end

    function compat:PlaceIconOnMinimap(icon, c, z, x, y)
        local mapId = Astrolabe:GetMapID(c, z)
        local floors = Astrolabe:GetNumFloors(mapId)
        local floor = floors == 0 and 0 or 1
        return Astrolabe:PlaceIconOnMinimap(icon, mapId, floor, x, y)
    end

    function compat:PlaceIconOnWorldMap(frame, icon, c, z, x, y)
        local mapId = Astrolabe:GetMapID(c, z)
        local floors = Astrolabe:GetNumFloors(mapId)
        local floor = floors == 0 and 0 or 1

        return Astrolabe:PlaceIconOnWorldMap(frame, icon, mapId, floor, x, y)
    end

end
Save and test. This should correct the error.
Report comment to moderator  
Reply With Quote
Unread 12-21-10, 03:13 PM  
Davidious84
A Defias Bandit

Forum posts: 2
File comments: 3
Uploads: 0
wOOt! it works beautifully! thank you so much! =D
Report comment to moderator  
Reply With Quote
Unread 12-21-10, 07:11 PM  
mooch360
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
I'm still having a problem specific to (it seems) handynotes_mailboxes, and only in the main cities. When I click on a mailbox, it deletes my previously marked mailbox and adds the new one. Any idea how to fix this bug?
Report comment to moderator  
Reply With Quote
Unread 12-21-10, 11:00 PM  
Toran
A Nerdscale Dorkin
 
Toran's Avatar
Premium Member

Forum posts: 143
File comments: 433
Uploads: 0
Originally posted by mooch360
I'm still having a problem specific to (it seems) handynotes_mailboxes, and only in the main cities. When I click on a mailbox, it deletes my previously marked mailbox and adds the new one. Any idea how to fix this bug?
Likewise - nice catch.
Report comment to moderator  
Reply With Quote
Unread 12-22-10, 04:50 AM  
-Raz-
A Kobold Labourer
 
-Raz-'s Avatar

Forum posts: 0
File comments: 49
Uploads: 0
was going to wait for the original author to put out an update, but had quite a few out of memory wow crashes lately

so gave this a try and havent had a single crash again, i guess wow doesnt like when you got 20+ icons glued to the minimap player arrow
Report comment to moderator  
Reply With Quote
Unread 12-22-10, 07:55 AM  
Isharra
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 37
Uploads: 2
Originally posted by -Raz-
was going to wait for the original author to put out an update, but had quite a few out of memory wow crashes lately

so gave this a try and havent had a single crash again, i guess wow doesnt like when you got 20+ icons glued to the minimap player arrow
I'm thrilled it's working for you!

I really appreciate the input everyone especially since there were no comments the first couple of days. I was afraid it only worked for me.

Sariktor, thanks so much for the work pointing out the fixes in the additional HandyNotes addons (I don't use them myself so I couldn't test reliably.)

Originally posted by Sariktor
Oh.. it's missing the workaround... Open HandyNotes_SpecialNPCsEtc\HandyNotes_SpecialNPCsEtc.lua and add this near the top.

It shouldn't be necessary to add the whole compat section, just reference it in the other addons. change
Code:
local HandyNotes = LibStub("AceAddon-3.0"):GetAddon("HandyNotes")
local Astrolabe = DongleStub("Astrolabe-0.4")
to
Code:
local HandyNotes = LibStub("AceAddon-3.0"):GetAddon("HandyNotes")
local compat = {}
compat = HandyNotes.compat
Obviously if the addon uses HN (or any other name) instead of "HandyNotes" as the variable name make the appropriate switch with compat. The advantage/disadvantage of this is that if compat changes in HandyNotes it's automatically updated in the other addons.

Then make the standard

Code:
Astrolabe:GetCurrentPlayerPosition()
to
Code:
compat:GetCurrentPlayerPosition()

Any other Astrolabe calls in the addons will also need to be updated.

handynotes_mailboxes has an additional call to Astrolabe:ComputeDistance, (which isn't added in the compat functions yet.) I'll try to work on this tonight or tomorrow once server maintenance is over.


And sorry for the delay in responding folks, I got Isharra to level 85, another to 83 and two more to level 82 since I posted this.

I need to kick my WoWInterface settings, I'm not receiving the email notifications I'm supposed to get when people leave a comment.
Last edited by Isharra : 12-23-10 at 01:47 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: