Quantcast
Download
(943 b)
Download
Updated: 08-25-09 10:35 PM
Pictures
File Info
Updated:08-25-09 10:35 PM
Created:08-25-09 01:18 AM
Downloads:1,538
Favorites:4
MD5:

Event Horizon - Death Knight Module

Version: 0.2.0
by: Tyno [More]

My first attempt at the Death Knight Module for the addon Event Horizon.

I'll add screenshots of the version with and without talents to help your decision in which to use. Here's the version without talents: DK Basic

Talents now hidden if you don't have them and moves arranged by their cooldowns.

Currently works with Event Horizon V0.11 and patch 3.2

It has now been added to the Event Horizon page in the optional downloads, this means go there for the latest version.

0.1.0 - First Attempt
0.1.1 - Fixed wrong spell ID
0.1.12 - Fixed minor spelling mistakes
0.2.0 - Arranged moves by cooldown and talents now functional
0.3.0 - Uploaded newest version to Event Horizon optional files, made CD moves optional and Death Coil dot
Archived Files (2)
File Name
Version
Size
Author
Date
0.1.12
926B
Tyno
08-25-09 03:21 AM
0.1.1
1kB
Tyno
08-25-09 01:52 AM


Post A Reply Comment Options
Unread 09-02-09, 04:10 AM  
Tyno
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 4
Uploads: 3
Update

Sorry about the long time to update, Uni work needed to be done.

1. Will do.

2. Done.

3. I have arranged spells in the order of priority, my DK is not 80 so I am not sure what it should look like.

4. Yeah hysteria dot is not needed, I use death coil a lot but if the dot is not being tracked I don't think it needs to be on the list really.

Death Coil is commented out since at 80 it is not something worth tracking for a lot of the time.

Thanks for taking the time to help.
Report comment to moderator  
Reply With Quote
Unread 08-27-09, 07:53 AM  
Taroven
A Cyclonian
AddOn Author - Click to view AddOns

Forum posts: 49
File comments: 837
Uploads: 14
Re: Add or Remove Spells

Thanks for taking the time to write and release this. Looks solid to me.

A few things:

1) Please re-upload as an optional addon for EventHorizon. You can do this via the Optional Files tab on the EventHorizon page, using the Upload Optional Addon link just below the tabs. This will greatly improve both the visibility and accessibility of the module.

I'd also suggest just naming the addon's WoWI entry as EventHorizon_DeathKnight.

2) Please change the gcdSpellID to Death Coil. GCD watching needs a spell that has no cooldown (and preferably cannot be locked out, but for most classes that's impossible) in order to be accurate.

3) As for the module itself, I'd highly recommend sorting spells by priority high-to-low rather than cooldown long-to-short, to keep in line with the other class modules. Doing this keeps the learning curve short and improves readability by putting the most pertinent stuff in one spot.

Also, you may want to consider adding a quick option for long cooldowns. EventHorizon isn't exactly great for watching anything longer than about 45 seconds, though there are exceptions here and there for the classes/specs that REALLY need a certain cooldown to stabilise their rotations (*cough* Feral Druids).

4) Tiny nitpick, the DoT effects of Hysteria and talented Death Coil are pretty moot. I'd leave the DoT lines for them commented out and up to user choice.

My recommendation, combining what I suggested above:
Code:
local config = EventHorizon.config
local LongCDs = true --Set to false or nil to remove the long-cooldown spells from the display

function EventHorizon:InitializeClass()

	self.config.gcdSpellID = 49895 --Death Coil

Icy Touch
Plague Strike
Death Coil DoT
Blade Barrier
Ghoul Frenzy
CoI (which can really go anywhere, I'd probably prefer CoI to be the final bar of the module due to its normal usage and priority in a PvE setting)

  if LongCDs then -- There are better options for tracking these, but we like to make things easy to switch over if those options aren't being used.
    <<<All cooldowns over 1 minute>>>
  end

	return true

end
Report comment to moderator  
Reply With Quote
Unread 08-25-09, 03:48 AM  
Tyno
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 4
Uploads: 3
Add or Remove Spells

If you want me to change any of the spells around or add ones that aren't there here would be the place to ask, though if you want to try its not hard to change it yourself in the config.lua there is a list of spells so you can add and remove whatever you like. I take no credit for EventHorizon or any other modules made for it, I just made a DK version to help me and thought others might like it.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: