Download
(155Kb)
Download
Updated: 04-27-10 04:34 PM
Pictures
File Info
Updated:04-27-10 04:34 PM
Created:11-11-08 06:07 AM
Downloads:13,385
Favorites:53
MD5:

ShadowGreenLight  Popular! (More than 5000 hits)

Version: v1.7.2
by: Mokhtar [More]

Preliminary : in WoW 3.0.3 SW:P suffers from a bug because of which the timing of SW:P cast or refresh becomes very important (see http://elitistjerks.com/f31/t26007-priest_preliminary_discussion_shadow_priest_talents_wotlk/p40/#post969559 for more information). GreenLight allows shadowpriest to check at a glance if all appropriate buffs and debuffs that will increase SW:P damage are present at the moment of the cast.

v1.7.2 :
- Added feature for warlock spellpower bug (only for default display)
- Fixed Nevermelting Ice Crystal

v1.7.1 :
- Hopefully fixed the FPS drop following 3.3.3 patch
- Hopefully fixed the Hide ooc feature

v1.7 :
- v1.6 haste bugfix for warlocks was just a setback...
- Talent scanning vastly less clunky due to LibGroupTalents awesome goodness
- Detection of current spec to hide SGL when not in appropriate spec
- Added a bunch of options for display bar plugin
- Tricks of the Trade is now properly 15%

v1.6 :
- Added warlock support
- Fixed some nil errors in time to profit computation
- Fixed a bug with max upgrade computation
- Fixed Arcane Empowerment bug
- Reworked upgrade management for better performances in case database gets bigger

v1.5.4 :
- Added Arcane Empowerment and modified rule for Improved scorch
- Hopefully fixed the lib not loading problem

v1.5.3 :
- v1.5.2 was packaged improperly by wowace, should be a fix

v1.5.2 :
- Added a sound alert (currently not very tested, use it at own risks)
- Added support for Nevermelting Ice Crystal
- Fixed Paladin Sanctified Retribution talent
- Hopefully (could not test) fixed Rogue Master Poisoner talent

v1.5.1 :
- Bugfix

v1.5 :
- Added a new display plugin using bars
- Config is now available through Blizz options
- Allowed for more customizing of look using SharedMedia (finally)

v1.4.2 :
- Fixed the way displayed upgrade is computed
- Added Twin Valkyrs buff

v1.4.1 :
- Fixed a bug

v1.4 :
- Fixed sanctified retribution to work with all ret pals auras
- Added multi target information retention

v1.3.1 :
- Fixed syntax error (drycoding is bad children, mmmkay ?)
- Hopefully fixed dependencies

v1.3 :
- Added Ulduar encounter-specific buffs

v1.2.3 :
- Hopefully fixed OptionaDeps
- Fixed a rare bug that caused SGL to error out

v1.2.2 :
- Fixed talent detection to actually work with dual spec
- Added improved shadowbolt
- Tooltip now lists raid upgrades available when ooc

v1.2.1 :
- Corrected Winter's Chill / Improved Scorch to 1% per stack
- Corrected talent detection for some talents that have moved with 3.1

v1.2 :
- Note that 3.1 will not change anything as to the usefulness of the addon, SWP may really crit now but crit rating is still only attributed when the dot is cast and not when refreshed by mind flay
- Modified numeric indicator to actually display a %increase. It may be a little bit harder to understand as the formula behind it is quite daunting but it will give you a better idea of the upgrade in your DPS
- Added a "time to profit" indicator : once again aiming at giving you the mean to decide if refreshing is really worth it. I considered the DPS loss incurred by the gcd used to refresh, the time displayed is the time it will take for your refresh compensating theloss of a gcd
- Added "bonus" feature (rogue tricks of the trade, wild magic potion, encounter-specific bonus like Loatheb spores, Malygos sparks, Thaddius charges : they definitely work now) : numeric indicator and border turn red if a bonus is available.
- Completely rehauled architecture to allow third party author to propose their own display as separate plugins (Kips I'm looking at you, see comment at the beginning of Display.lua file)

v1.1.2 :
- Fixed Moonkin Aura not being detected

v1.1.1 :
- Forgot to remove debug messages

v1.1 :
- Added tooltip showing buffs / debuffs up in combat
- Fixed recast indicator
- Fixed heart of the Crusader not being detected

v1.0.1 :
- Corrected a bug with debuffs not appearing for raid

v1.0 :
- Added numeric and recast indicator
- Added more configuration options
- Cleaned up code and made final display look better
Optional Files (0)


Post A Reply Comment Options
Unread 02-03-10, 11:17 AM  
Mokhtar
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 26
Uploads: 7
Originally posted by Pseudopod
[b]wtb affliction warlock equivalent How hard would it be btw, to change SW:P to Corruption?
I think you nailed it with your modifications (or at least off the top of my head I don't see any more...), some thoughts :
- ABout 4T10 set bonus I would flag it as a bonus upgrade (isBonus = true)
- About the corruption ranks : any spell with the same name will do
- About death's embrace I do not have a readymade solution, you would have to add a specific test for this...

About the bonus / not bonus thing, you have to understand the consequences : the mod computes the maximum upgrade available (given raid composition) and the current upgrade available. For standard display, color of background is a continuum from red to green indicating the ratio current upgrade / max upgrade.
Color of border indicates if there is a bonus upgrade currently available.

I may extend the addon to warlocks if I get enough interest on this...
Report comment to moderator  
Reply With Quote
Unread 02-03-10, 03:26 AM  
Pseudopod
A Deviate Faerie Dragon

Forum posts: 16
File comments: 104
Uploads: 0
wtb affliction warlock equivalent How hard would it be btw, to change SW:P to Corruption?
I think the database would be pretty much the same, though shadow weaving would morph into 4t10 set bonus that gives you 10% damage for 10 sec. - Devious Mind = spell id 70840
Code:
-- Shadow weave = 4t10
["Devious Minds"] = {
		name = GetSpellInfo(70840),
		maxCount = 1,
		upgradePerStack = 10,
		type = "Shadow Weaving",
		detectionUnit = "player",
		detectionType = "buff",
		upgradeType = "dmg",
	},

So if one also changed
local SPELL_SWP = GetSpellInfo(589)
to
local SPELL_SWP = GetSpellInfo(47813) -- r10 corruption *

what else would need to be changed?

*rank 3 is the first one with 18 seconds duration (6223), r1=172 so should I use rank 1, rank 3 or is rank 10 good too?

Patch day, realms are still down so I can't test :P

Though, I don't know how to implement Death's Embrace:
So +12% damage to corruption when the target <= 35% health.

edit: Now I tried my edits, no errors, though I commented out the 4t10 bonus cause I don't have it yet and it was always red because of it. (i also changed the if class == "PRIEST" then to WARLOCK )

I don't know if this is a general "how does this work exactly" question or if my editings have something to do with it:
As I'm running solo killing the Heroic Training Dummy, and I cast my corruption before shadow bolt (= my corr is missing 5% crit), the display is yellow and the text says 0/0 at the top. Then if I use my Nevermelting Ice Crystal, the display goes to green with red borders, upgrade amount says 16/0 and there's the skull. As my stacks decrease, the display goes to yellow again. But the display is yellow also when I cast my corruption after there's a Shadow Mastery debuff on the boss. Actually, if I only cast CoE to the dummy, it's yellow :P So what's the yellow frame? Is it just because I don't have any raid dps & buffs but my own?
Last edited by Pseudopod : 02-03-10 at 06:40 AM.
Report comment to moderator  
Reply With Quote
Unread 12-15-09, 11:04 AM  
Kelberot
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
This addon is GREAT, but I would love to see a hide option

I don't really need it for arenas (it's a distraction) but I need it for PvE...
Report comment to moderator  
Reply With Quote
Unread 09-27-09, 12:55 AM  
Raxnor
A Cliff Giant
 
Raxnor's Avatar

Forum posts: 72
File comments: 44
Uploads: 0
Originally posted by Darkkron
great idea!

suggestion, do you think you could add 1stly: when inner fire is in low charges? or removed? ie a green flam, that goes orange, then red next to it?

also maybe a highlighted (spelling???) border when trinks proc would be sweet as, that is ofcourse this doesnt take that into account already (eg sundial of the exhalted etc)

rock on dude!

p.s. an IDEAL partener addon for this is Event Horizon

soooooo good... all you need, with nUI+ ofcourse!
You can actually do that w/power auras, amazing mod
http://www.wowinterface.com/download...asClassic.html
once you manage how this addon works, you will be playing WoW on another lvl, been using it since '05 !
Report comment to moderator  
Reply With Quote
Unread 09-23-09, 07:48 PM  
Darkkron
A Deviate Faerie Dragon
 
Darkkron's Avatar

Forum posts: 9
File comments: 7
Uploads: 0
great idea!

suggestion, do you think you could add 1stly: when inner fire is in low charges? or removed? ie a green flam, that goes orange, then red next to it?

also maybe a highlighted (spelling???) border when trinks proc would be sweet as, that is ofcourse this doesnt take that into account already (eg sundial of the exhalted etc)

rock on dude!

p.s. an IDEAL partener addon for this is Event Horizon

soooooo good... all you need, with nUI+ ofcourse!
__________________
Bannana Stickers ftw
Last edited by Darkkron : 09-23-09 at 08:30 PM.
Report comment to moderator  
Reply With Quote
Unread 07-20-09, 10:45 AM  
Banur
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 137
Uploads: 5
Originally posted by Mokhtar
You maybe right, but honestly does this happen a lot in real conditions ? I know it will happen when testing on the dummies as you will tend to drop and get back into combat a lot but elsewhere ?
In raids and heros it's unlikely I noticed that while doing dailies and killing vrykul. Sometimes I'm pulling with SW:P if Shadowweaving is about to drop. It was just odd to see that and I reapplied SW:P in case the stack dropped due to lag.
Report comment to moderator  
Reply With Quote
Unread 07-07-09, 10:35 AM  
Mokhtar
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 26
Uploads: 7
Originally posted by Banur
I noticed that there is a misleading issue with the skull.
If you have the full stack allready, are ooc and open with SW:P it will be displayed but I think it shouldn't (since you have the full stack it isn't an upgrade).
Or is it right that it would be an upgrade?
You maybe right, but honestly does this happen a lot in real conditions ? I know it will happen when testing on the dummies as you will tend to drop and get back into combat a lot but elsewhere ?
Report comment to moderator  
Reply With Quote
Unread 07-05-09, 02:20 PM  
Banur
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 137
Uploads: 5
I noticed that there is a misleading issue with the skull.
If you have the full stack allready, are ooc and open with SW:P it will be displayed but I think it shouldn't (since you have the full stack it isn't an upgrade).
Or is it right that it would be an upgrade?
Last edited by Banur : 07-05-09 at 02:27 PM.
Report comment to moderator  
Reply With Quote
Unread 06-11-09, 03:05 PM  
Banur
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 137
Uploads: 5
There is a space in the lines 309/318/327/336 (the new ulduar stuff) in the core.lua: "GetSpell Info"
and something with the 'ShadowGreenLight' locale in the display.lua.

[BugSack:]
[2009/06/11 22:59:44-3296-x1]: ShadowGreenLight-v1.3\Core.lua:309: '}' expected (to close '{' at line 308) near 'Info'

[2009/06/11 22:59:44-3296-x1]: ShadowGreenLight-v1.3\Display.lua:395: attempt to index local 'ShadowGreenLight' (a nil value)

edit: Ahh well the display bug disappears after fixing the gaps.
Last edited by Banur : 06-11-09 at 03:14 PM.
Report comment to moderator  
Reply With Quote
Unread 06-10-09, 02:27 PM  
DJJoeJoe
A Murloc Raider
 
DJJoeJoe's Avatar
AddOn Compiler - Click to view compilations

Forum posts: 6
File comments: 172
Uploads: 1
Originally posted by Psychophan7
Does the addon take into account the raid composition?
Of course, that's the whole reason for this addon... It checks for what crit % buffs the raid CAN apply and goes off that.
__________________

Joetest - Ner'Zhul - Disciples of Death
Report comment to moderator  
Reply With Quote
Unread 06-10-09, 01:46 PM  
Psychophan7
A Chromatic Dragonspawn

Forum posts: 153
File comments: 47
Uploads: 0
Does the addon take into account the raid composition?
Report comment to moderator  
Reply With Quote
Unread 05-26-09, 09:25 AM  
Mokhtar
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 26
Uploads: 7
Originally posted by Banur
Would you mind adding a scaling option for the tooltip, because it's ab bit tiny on highest UI scale.
Sorry it's not in my plans, if you choose to have a tiny interface you have to live with it !
Report comment to moderator  
Reply With Quote
Unread 05-24-09, 04:14 PM  
Banur
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 7
File comments: 137
Uploads: 5
Would you mind adding a scaling option for the tooltip, because it's ab bit tiny on highest UI scale.
Report comment to moderator  
Reply With Quote
Unread 04-10-09, 02:10 AM  
Kandorr
A Kobold Labourer

Forum posts: 0
File comments: 25
Uploads: 0
Re: Re: Love this mod

Ah, very cool. Shoulda fig'd that one out.
Thanks for the explanation.
Report comment to moderator  
Reply With Quote
Unread 04-07-09, 09:27 AM  
Mokhtar
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 26
Uploads: 7
Re: Love this mod

Originally posted by Kandorr Anyway, quick question. Sometimes there is a skull in the square, sometimes there isn't. What's that mean?
It just means that the current upgrade judging from raid buffs / debuffs is superior to the upgrade you had when last casting SW:P.
Simply put : you should recast SW:P because it will tick harder (keep in mind recasting SW:P makes you lose a gcd, it might not be optimal to refresh it if the mob has 10 sec to live...)
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: