Download
(3Kb)
Download
Updated: 08-27-12 10:56 AM
Pictures
File Info
Updated:08-27-12 10:56 AM
Created:11-17-08 12:57 AM
Downloads:8,622
Favorites:136
MD5:

Damn Achievement Spam  Popular! (More than 5000 hits)

Version: v1.2.1
by: Shadowed [More]

Compacts the achievement messages for ones listed under the Dungeons & Raid or Player vs. Player category, see the screen shot for an example, no config or anything extra just drop it in and you're set.

tag v1.2
8a46d90db02c913a436f29554b37076f1802c3ab
Shadowed <[email protected]>
2012-08-27 09:40:05 -0700

Tagging as release 1.2

--------------------

Shadowed:
- Note tweak
- TOC bump
Optional Files (0)


Post A Reply Comment Options
Unread 11-18-08, 09:29 PM  
Veyska
A Kobold Labourer
 
Veyska's Avatar

Forum posts: 1
File comments: 56
Uploads: 0
"<Single player> have earned the achievement [<achievement>]!"

Verb case for single player earning an achievement perhaps? Looking good otherwise that I've seen. :-)
Report comment to moderator  
Reply With Quote
Unread 11-18-08, 10:45 PM  
Shadowed
...
Featured Addon Author

Forum posts: 387
File comments: 2513
Uploads: 83
Yea it should also show brackets around a single player, I'll fix that.
Report comment to moderator  
Reply With Quote
Unread 12-03-08, 05:22 AM  
Bifidus
A Kobold Labourer

Forum posts: 0
File comments: 52
Uploads: 3
Is there a way to just delete everything about achievements, even mine ?
I mean : i really don't care about that part of the game, so it's just spam for me.
The standard UI don't let me ignore them (others are ignored, but i still receive all of guildmates).
Report comment to moderator  
Reply With Quote
Unread 12-04-08, 10:59 AM  
Shadowed
...
Featured Addon Author

Forum posts: 387
File comments: 2513
Uploads: 83
Download this, open DamnAchievementSpam.lua

Find

Code:
local orig_ChatFrame_MessageEventHandler = ChatFrame_MessageEventHandler
function ChatFrame_MessageEventHandler(self, event, ...)
	-- Not an achievement, don't care about it
	if( event ~= "CHAT_MSG_GUILD_ACHIEVEMENT" and event ~= "CHAT_MSG_ACHIEVEMENT" ) then
		return orig_ChatFrame_MessageEventHandler(self, event, ...)
	end
	
	local msg, author = select(1, ...)
	local achievementID = string.match(msg, "|Hachievement:([0-9]+):(.+)|h")
	achievementID = tonumber(achievementID)
	
	-- Are we filtering this achievement?
	if( achievementID and filterList[achievementID] ) then
		local type = string.sub(event, 10)
		chats[type][self] = true
		
		-- Add this person to the list as having gotten it
		achievements[type][achievementID] = achievements[type][achievementID] or {}
		table.insert(achievements[type][achievementID], author)
		
		-- Start this to run in 0.50 seconds or so if we haven't
		if( not timeouts[type][achievementID] ) then
			TOTAL_TIMEOUTS = TOTAL_TIMEOUTS + 0.50
		end
		
		timeouts[type][achievementID] = timeouts[type][achievementID] or 0.50
		
		-- Annnd start the countdown
		frame:Show()
		
		-- Now block the new one from showing
		return true
	end
		
	return orig_ChatFrame_MessageEventHandler(self, event, msg, select(2, ...))
end
Replace with

Code:
-- Do we need to filter them?
local orig_ChatFrame_MessageEventHandler = ChatFrame_MessageEventHandler
function ChatFrame_MessageEventHandler(self, event, ...)
	-- Not an achievement, don't care about it
	if( event ~= "CHAT_MSG_GUILD_ACHIEVEMENT" and event ~= "CHAT_MSG_ACHIEVEMENT" ) then
		return orig_ChatFrame_MessageEventHandler(self, event, ...)
	end
	
	return true
end
That should block all achievements including your own.
Report comment to moderator  
Reply With Quote
Unread 04-05-09, 02:52 PM  
djhappyjack
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Hi, I love your addon. However, I would like to shorten "...have/has earned the achievement..." To simply: "[Player] ! [Achievement]". How would I go about doing that? I've seen it in a custom ui and I would like to integrate it into my ui.

Thank You.
Report comment to moderator  
Reply With Quote
Unread 05-27-09, 12:43 PM  
magus424
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 13
Uploads: 2
When only one person gets an achievement, I keep seeing their name duplicated, for instance:

SomeGuy, SomeGuy have earned the achievement [Halls of Lightning]!

I did some fiddling in the lua, and have a patch that seems to fix it

Code:
--- DamnAchievementSpam.lua.orig        2009-05-27 11:18:31.575000000 -0700
+++ DamnAchievementSpam.lua     2009-02-01 16:29:30.365750000 -0800
@@ -50,7 +50,15 @@
 
                -- Add this person to the list as having gotten it
                achievements[type][achievementID] = achievements[type][achievementID] or {}
-               table.insert(achievements[type][achievementID], author)
+               local found = false
+               for pid, player in pairs(achievements[type][achievementID]) do
+                       if( player == author ) then
+                               found = true
+                       end
+               end
+               if( not found ) then
+                       table.insert(achievements[type][achievementID], author)
+               end
 
                -- Set the total number of timers we're running
                if( not timeouts[type][achievementID] ) then
Report comment to moderator  
Reply With Quote
Unread 05-27-09, 01:00 PM  
Shadowed
...
Featured Addon Author

Forum posts: 387
File comments: 2513
Uploads: 83
How weird, I'm not sure why that would be happening but applied your patch, thanks.
Report comment to moderator  
Reply With Quote
Unread 06-10-09, 11:25 PM  
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view AddOns

Forum posts: 32
File comments: 642
Uploads: 4
Originally posted by Bifidus
Is there a way to just delete everything about achievements, even mine ?
I mean : i really don't care about that part of the game, so it's just spam for me.
The standard UI don't let me ignore them (others are ignored, but i still receive all of guildmates).
You can turn this off in the "settings" of your chat frame. Just unselect "Guild Announcements" from the list of things that are shown in the "General" tab.
Last edited by xtoq : 06-12-09 at 12:39 AM.
Report comment to moderator  
Reply With Quote
Unread 06-10-09, 11:26 PM  
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view AddOns

Forum posts: 32
File comments: 642
Uploads: 4
Feature request!

Originally posted by Veyska
"<Single player> have earned the achievement [<achievement>]!"

Verb case for single player earning an achievement perhaps? Looking good otherwise that I've seen. :-)
lol

Can we get compression of multiple achievements by the same person? For example somone in my guild just got the argent tourney achievements and it spammed like this:

Alyssia has earned the achievement [Blah blah blah blah]!
Alyssia has earned the achievement [Blah blah blah blah]!
Alyssia has earned the achievement [Blah blah blah blah]!
Alyssia has earned the achievement [Blah blah blah blah]!

I think it would be better if it was like so:

Alyssia has earned the achievements [Achievement 1] [Achievement 2] [Achievement 3] [Achievement 4]!

Can we get class coloring for the names in the achievements? Pretty please? =)

EDIT: Ok, now the coloring works, I guess you have to have the addon see someone now. Even though it was a guildie...
Last edited by xtoq : 06-11-09 at 07:40 PM.
Report comment to moderator  
Reply With Quote
Unread 06-14-09, 08:50 AM  
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view AddOns

Forum posts: 32
File comments: 642
Uploads: 4
Also, I haven't seen this again, but a guildie just cleared 25 Naxx for the first time the other day, and when he got his "KT's Defeat" and the "Fall of Naxxramas" only one showed up in the DAS compression. I haven't seen this happen before, or again, so I can't tell you if it was a glitch, if it was those achievements or what.
Report comment to moderator  
Reply With Quote
Unread 06-14-09, 12:06 PM  
dssurge
A Kobold Labourer

Forum posts: 0
File comments: 20
Uploads: 0
This happens quite frequently to me when someone multi-cheeves or a lot of people get achievements all at once. If multiple people complete an achievement, but theres an extra thrown in there, it seems to break it as well.

player x earns [Fall of Naxxramas]!
player x earns [Just Can't Get Enough]!
player y earns [Fall of Naxxramas]!

Only the Fall of Naxx achievement will show up for both players in this case.
Last edited by dssurge : 06-14-09 at 12:07 PM.
Report comment to moderator  
Reply With Quote
Unread 06-14-09, 12:57 PM  
Shadowed
...
Featured Addon Author

Forum posts: 387
File comments: 2513
Uploads: 83
I can't think of a reason why this would happen, I'll see about setting up test cases and fixing it thought.
Last edited by Shadowed : 06-15-09 at 02:35 PM.
Report comment to moderator  
Reply With Quote
Unread 06-15-09, 02:35 PM  
Shadowed
...
Featured Addon Author

Forum posts: 387
File comments: 2513
Uploads: 83
Actually I take that back, I'm just going to rewrite this so the bug will be fixed next push.
Report comment to moderator  
Reply With Quote
Unread 06-16-09, 02:15 AM  
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view AddOns

Forum posts: 32
File comments: 642
Uploads: 4
Sweet. I'll try it out tomorrow. Still the thing about the class colors bugs me, sometimes they are colored and sometimes they aren't. Does DAS not do anything if there is only one person and one ach? Because that is when I'm seeing class coloring, but the rest of the time I'm not.
__________________
There is absolutely no evidence to support the theory that life is serious.
Report comment to moderator  
Reply With Quote
Unread 06-16-09, 03:31 AM  
Shadowed
...
Featured Addon Author

Forum posts: 387
File comments: 2513
Uploads: 83
Not going to add compression of a single player earning multple achievements. I do not do class coloring, it's another mod that does it and I'm not going to support that mod.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.