Criminal

Might want to subtitute the word 'Criminal' for 'Molinari' in the description. =)

loler, in before edit

Doesn't work.
Even with no other addons on.

enGB and current patch (3.3.2)

ruRU same.

I got that error upon logging in. I'm not sure why I (and others, it sounds like) are getting that and you're not.

As for lockboxes, I'd just listen to your lock-picking trainer, go to where he suggests, and pick-pocket people -- they'll give you plenty of lock boxes.

Thank you for this though -- once it's working, it'll be quite nice.

I'm getting the same error Jzar reported...it occurs on login...I use swatter to catch all my errors and didn't notice this error existed until I opened swatter to look for a different error...it never actually pops up on my screen...

Date: 2010-03-07 03:26:05
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Criminal\Criminal.lua line 9:
invalid option in `format'
Debug:
[C]: ?
[C]: format()
Criminal\Criminal.lua:9: in main chunk

posted a bug report with the error I get if I only have Criminal loaded and all other addons disabled...hope it helps...thanks for making this....hope you getting it working soon so I can be a happy rogue

Fix: Line 9, just change '%s %(.*%)' after the string.format to '%s %%(.*%%)'

Voila!

And so it does. Thank you for providing me with some good sample code for tracking down some more thorough documentation on Lua patterns than I've previously found. I've copied a few tricky functions that use patterns for my addons, but never really delved into understanding them.

My apologies if I sounded cocky and just came across as stupid. I'm not sure what motivated me to try putting extra % symbols in there, but it made the error go away, and then your mod worked fine.

Here's the replacement that after some digging, I believe does what you intend: '%s (%s)'

According to the lua-users wiki, string.format takes a formatstring as its first argument, not a Lua pattern. Thus you just have to tell it what types of data it should insert into the string, and the first two returned arguments from GetSpellInfo are both strings. You don't have to actually match the characters in the strings it returns.

If I'm still wrong, please forgive me; I'm really curious now what the correct solution to this puzzle is.

Upon actually finally getting to someplace where I can find lockboxes, I find that my fix didn't fix anything. Upon further investigation, it turns out that the second returned argument from GetSpellInfo(1810) is "Journeyman" on my rogue atm. I'm guessing you're using this to try to verify that the rogue is high-enough to actually pick the lockbox. But even if the rank of Lock picking returned as "125" instead of "Journeyman", the lockbox would still say what it requires, which wouldn't equal the rogue's exact skill except very rarely, wouldn't it?

I've now changed mine formatstring to '%s' and am ignoring all but the first argument returned from GetSpellInfo and it works fine for lockboxes I'm high enough to pick. I'm not sure how you'd actually check if I'm high enough level for a box, but I hope you can get it working!