Go to Page... |
Updated: | 06-12-10 02:46 PM |
Created: | 12-03-08 04:31 PM |
Downloads: | 20,067 |
Favorites: | 230 |
MD5: | |
Categories: | TradeSkill Mods, ToolTip |
GatherSage2 is a re-write of the original GatherSage. Almost all of the original GatherSage functionality made its way into GatherSage2 and a lot more was added.
GatherSage2 shows what level is required to mine, pick, smelt, prospect, mill, or skin a resource (vein, deposit, ore, animal, plant, etc). The tooltip will show all skills for which the resource can be gathered or used up (i.e. an herb that can be both picked and milled).
It also shows you your current skill, how many skill ups you have gained since you logged in, and the difference between the skill you need to work with the resource and the skill you currently have.
It displays this information in the tooltip when you mouse over a resource in the world, minimap, inventory, auction house, mailbox, guild bank, and pretty much anywhere the item can be displayed. It will also show you if that resource has a chance of yielding special items (such as stone, gems, or other herbs).
A lot of testing has gone into making sure GatherSage2 does not interfere with other addons you may have loaded. Please report any problems found.
There is a readme.txt file that contains detailed information on GatherSage2
Comment Options |
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-02-09, 02:36 AM | ||
A Kobold Labourer
Forum posts: 1
File comments: 17
Uploads: 0
|
Re: Re: Re: Re: Tooltip text joining bug?
So I guess the next logical step would be to start commenting out parts of the ProcessTooltip function (and/or dummying them out by hard-setting variables) to see which part is triggering things. More as time permits. |
|
|
RHuebner |
View Public Profile |
Send a private message to RHuebner |
Find More Posts by RHuebner |
Add RHuebner to Your Buddy List |
03-02-09, 06:36 AM | |
A Kobold Labourer
Forum posts: 1
File comments: 17
Uploads: 0
|
Re: Re: Re: Re: Re: Tooltip text joining bug?
Found the culprit. It's Auctioneer. I'm currently running AuctioneerSuite-5.3.4014.zip, which contains several associated pieces. If either the Auctioneer core addon or the Informant addon are enabled, along with GS2, then the tooltips get messed up. If neither Auctioneer-core or Informant are loaded, GS2 is safe, and as shown earlier, if GS2 isn't loaded, then Auctioneer and Informant are safe.
This makes sense functionally, as both Auctioneer-core and Informant do major tooltip work. They both add a secondary tooltip box below the normal tooltip, or combine to share a secondary box if both are enabled. Auctioneer-core uses this to display AH price analysis info, and Informant displays general info like vendor availability & prices, associated quests, etc. If neither is loaded, the secondary tooltip box isn't displayed, and a bunch of gnarly tooltip processing is presumably avoided. Of course, now that I've tracked it down, the Auctioneer team decided to just now today release a new version, with some tooltip behavior changes even, so more testing with the new version is now needed. But whether the problem still exists or not, Auctioneer is one of my most crucial must-have addons, so I'm just going to have to live with the bug. With any luck, you might be able to reproduce the problem now and fix it on your end if you feel like it. I found I was able to reproduce the problem fairly quickly by opening my bags and scrubbing the mouse pointer back and forth over the bag contents and action bars for a while to force a high volume of tooltip traffic. |
|
RHuebner |
View Public Profile |
Send a private message to RHuebner |
Find More Posts by RHuebner |
Add RHuebner to Your Buddy List |
03-02-09, 07:55 PM | ||
|
Re: Re: Re: Re: Re: Re: Tooltip text joining bug?
I'll have to set some time aside to try to reproduce it with various Auctioneer modules enabled/disabled and then dig through the Auctioneer code to see how they are messing with the GameTooltip. I can usually work around the problem with other addons once I know what they are doing. Thanks for debugging it a bit for me |
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-05-09, 08:57 PM | |
|
Re: Tooltip text joining bug?
Just a little more info from the basic testing I have done. As you said this is easily reproducible so it will make it easier to try to track down the cause.
I did notice Auctioneer has some tooltip library it uses to basically abstract the regular GameTooltip and some extended tooltip they use. They do this so the API calls are the same, but they operate on one of the 2 tooltip objects depending in what is loaded. I noticed they do a lot of re-anchoring so that might be the cause, although I have not really had a chance to dig into it yet. Basically when the lines get pushed together, the two FontStrings (left and right) are still set correctly, it just looks like the right FontString is repositioned to push up against the left FontString. GS2 does not ever move the right FontString, but it does reposition the left FontString when it hides the tooltip textures. It simply repositions them to where they are suppose to be when the textures are hidden (the same position as in the GameTooltip XML file). I thought I read in some of the Auctioneer code comments that it tries to re-align the right font text to be left justified rather than right justified; something I need to check out more closely. I'll also have to see what this extended tooltip thing is it references. I wonder if this happens with it enabled? |
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-06-09, 04:01 AM | ||
A Kobold Labourer
Forum posts: 1
File comments: 17
Uploads: 0
|
Re: Re: Tooltip text joining bug?
In a related note, the new version of Auctioneer adds an option to only show this secondary (/extended?) tooltip box when you hold the Alt key. Since I only need to see the Auctioneer data occasionally (and the secondary tooltip box can be annoyingly big when you don't need it), I've turned this on, and found it cuts down on the amount of tooltip corruption encountered. Which makes sense; the less often you show the Auctioneer tooltip info, the less collisions there are with GS2, and the closer you are to the situation where Auctioneer isn't loaded at all. Just another data point, confirming the bug is behaving as expected. |
|
|
RHuebner |
View Public Profile |
Send a private message to RHuebner |
Find More Posts by RHuebner |
Add RHuebner to Your Buddy List |
03-06-09, 01:56 PM | |
An Aku'mai Servant
Forum posts: 34
File comments: 90
Uploads: 0
|
Just wondering if this one works like Gatherer...where it will show where nodes are and such?
Thanks |
|
Duchess |
View Public Profile |
Send a private message to Duchess |
Find More Posts by Duchess |
Add Duchess to Your Buddy List |
03-06-09, 05:53 PM | ||
|
|
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-07-09, 01:04 PM | |
|
Re: Re: Re: Tooltip text joining bug?
*** REMOVED THIS POST AS I THINK I RESOLVED THE ISSUE AND DIDN'T WANT TO CONFUSE PEOPLE WITH OTHER "HACK" FIXES ***
Last edited by kellewic : 03-07-09 at 06:14 PM.
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-07-09, 06:20 PM | |
|
Auctioneer tooltip issue
I think I resolved this issue and a new version (2009-03-07) is pending approval from the powers that be...
Basically, I just took the fixRight() function from Auctioneer's tooltip library and incorporated it into my tooltip library. I then call this function for every processTooltip() call regardless of whether GatherSage2 will actually process the tooltip. I did this since a lot of spell and item tooltips were being corrupted somehow. Calling this function corrects the issue as far as I can tell. I still don't know the exact cause since it seemed to happen at random times and I suspect it's something internal that the game is doing since you would think the same Lua code being called the same way would produce the same results. There are some other changes in this version that I never released:
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-08-09, 12:45 AM | |
A Kobold Labourer
Forum posts: 1
File comments: 17
Uploads: 0
|
Re: Auctioneer tooltip issue
I'm sorry to say that it's still happening to me with this version. Ironically, GS2's own tooltip change (the skill required line) is the most commonly hit, followed by the top 3 lines of DrDamage's DPS analysis and Recount's total damage/DPS summary tooltip. Since I enabled Auctioneer's new "only show with Alt key" option, it doesn't seem to be happening as much to the normal class skill buttons, but that may just be luck considering how weirdly random this glitch's effects are.
What was the hack workaround you deleted? I'd like to give it a try if it might give any further clue on what works and what doesn't. |
|
RHuebner |
View Public Profile |
Send a private message to RHuebner |
Find More Posts by RHuebner |
Add RHuebner to Your Buddy List |
03-08-09, 05:21 AM | ||
|
Using your latest version, I'm still getting errors when mousing over various items.
Love this addon, but the errors are getting out of hand, heh. On average, during a couple hours of play, I'll get between 5-15 of these errors. |
|
|
smedeley |
View Public Profile |
Send a private message to smedeley |
Find More Posts by smedeley |
Add smedeley to Your Buddy List |
03-08-09, 11:15 AM | ||
|
Re: Re: Auctioneer tooltip issue
You can try opening up Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua and commenting out line 1058 that should read: Code:
fixRight(p) I've only been seeing this weirdness in the last few weeks. I don't recall this being the case before then.
Last edited by kellewic : 03-08-09 at 11:15 AM.
|
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-08-09, 11:54 AM | ||
|
I guess the only thing I can do in that instance is advise you to change line 647 in GS2_Main.lua from: Code:
skillLevelRequired = itemRef["skill"][1] Code:
skillLevelRequired = tonumber(itemRef["skill"][1]) or 0 The error shows how many addons are grabbing on to GameTooltip events. It looks like it starts on a mouseover on a bag item and then goes through like 4 mods before it even hits the tooltip mod to show the tooltip (why the hell is MobInfo2 even in there for a bag item?) and then GS2 kicks off to modify the tooltip and errors out. I've been running this version for many weeks and have never seen an actual error like this, but you are running several mods I do not run so who knows what is going on in the background. |
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |
03-08-09, 01:02 PM | |
|
Tooltip bug
OK, more information... as far as I can tell, this is not related to any other mod. I have unloaded everything except GS2 and I can still reproduce the bug by quickly mousing over all my bag items, however, this does not mess up all the tooltips. Most of the time, it will simply mess up 1 or 2 of them and the rest are fine. The really weird part is when I run the following when moused over a corrupted tooltip:
Code:
/run GatherSage2:Tooltip_FixRightFontStrings(GameTooltip) I can't explain it except that I do not remember this behaviour in 3.08. Does anyone recall this happening before the 3.09 patch was applied? It may very well be a GatherSage2 bug only, but I can't explain why the right FontStrings would reposition themselves to the wrong position after running the above code since GatherSage2 relies on the GameTooltip:OnShow() event and if I am hovering over an item, the OnShow event has already fired so something else is moving those right FontStrings. I suspect it's the game itself since I have no other mods loaded at this point, but I am not ruling out some tooltip behaviour change in the new patch that is causing GatherSage2 to do weird things. Another strange thing is if I only mouse over items that GatherSage2 knows about, I don't see the bug appear (I did this for 5 minutes just mousing back and fourth over 4 ores). The second I mouse over something it doesn't know about, then I instantly see the bug. This is with just GatherSage2 loaded. Can anyone confirm this for me? *** EDIT *** OK, I may have fixed this. If you all can add the following line in GS2_Main.lua at line 832: Code:
self:Tooltip_FixRightFontStrings(tooltip) Code:
-- Wrap all lines that match these texts. WrapLongLines( tooltip, strconcat(L["USE"], ": "), [["Commonly found .*%."]], [["Commonly obtained .*%."]], [["Rarely found .*%."]], [["Rarely obtained .*%."]] ) self:Tooltip_HideAllTextures(tooltip, true) self:Tooltip_FixRightFontStrings(tooltip) tooltip:Show() *** ANOTHER EDIT *** I've searched and searched and cannot find any documented change to how GameTooltip works. I really don't know why this bug suddenly manifested itself. I'm not ruling out that it is my fault, but I sure can't find the cause yet.
Last edited by kellewic : 03-08-09 at 05:32 PM.
|
|
kellewic |
View Public Profile |
Send a private message to kellewic |
Find More Posts by kellewic |
Add kellewic to Your Buddy List |