World of Warcraft AddOns » Optional » Plug-Ins & Patches » Ara Broker Reputations Alts
  • Addon Info.
  • Change Log
  • Comments (18)
    • Download
    (2Kb)
    Download
    Updated: 07-13-11 09:43 AM
    Addon for:
    Ara Broker Reputations.
    Pictures
    File Info
    Updated:07-13-11 09:43 AM
    Created:05-25-11 12:07 PM
    Downloads:2,698
    Favorites:22
    MD5:

    Ara Broker Reputations Alts

    Version: r2
    by: Aranarth [More]

    This is a little plugin for Ara Broker Reputations (requires r10 or above).

    It records and display alternative characters reputation next to the hovered faction.

    r2
    - Fixed alts factions to correctly save (and display) but I'm afraid you will have to log your alts again.


    r1
    - Initial release.
    Post A Reply Comment Options
    Page 2 of 2 < 1 2
    Unread 03-26-13, 09:42 PM  
    credomane
    A Kobold Labourer

    Forum posts: 0
    File comments: 1
    Uploads: 0
    I really love this addon and its sister addon. However, there is a major flaw in this addon that I've fixed.

    GetNumFactions() cannot be relied on to return the correct number of factions the character has. What this functions really does is return the number of lines in your faction display. Factions under a collapsed header are not counted at all. Hence the problems I and others were having. The scanning functions was terminating before actually scanning all factions resulting in missing data.

    Blizzard really needs to rename this function to GetNumFactionLines() or something similar and add one that does what the current function sounds like it does. There is a way, however, to scan all reputations regardless of their expanded/collapsed state. The patched version can be found on my website here and shall remain there more or less indefinitely unless the patch become official. If I knew how to upload it here as a patch or something without creating another addon with "(fixed)" in the title I would.

    To demonstrate the difference I added two slash commands. /repscan and /repscanold using the new and old scanning methods, respectively. On my main toon /repscan returns 105 factions while /repscanold returns only 33. Even with everything expanded it still doesn't quite get them all. [edit]Scratch that now that I fixed my counting issue /repscan and /repscanold match now with everything expanded.[/edit]

    You will need to log into all of your characters to get the missing factions added but that should be obvious, right?

    @Aranarth or current addon maintainer: I'm not worried about getting credit at all. If you wish to implement my fix as an official fix, unmodified or otherwise, by all means please do!

    [edit]
    Updated my patch.
    • Fixed a possible nil operation. One out of my 5 character ran into it every single time the rest had no problem.
    • Fixed counting bug. Now only counts the factions and headers that have rep. Before I was mistakingly counting them all.
    Last edited by credomane : 03-26-13 at 10:21 PM.
    Report comment to moderator  
    Reply With Quote
    Unread 06-24-13, 05:57 PM  
    samvx
    A Defias Bandit
     
    samvx's Avatar
    AddOn Author - Click to view AddOns

    Forum posts: 3
    File comments: 118
    Uploads: 3
    Link Broken Dude
    Originally Posted by credomane
    I really love this addon and its sister addon. However, there is a major flaw in this addon that I've fixed.

    GetNumFactions() cannot be relied on to return the correct number of factions the character has. What this functions really does is return the number of lines in your faction display. Factions under a collapsed header are not counted at all. Hence the problems I and others were having. The scanning functions was terminating before actually scanning all factions resulting in missing data.

    Blizzard really needs to rename this function to GetNumFactionLines() or something similar and add one that does what the current function sounds like it does. There is a way, however, to scan all reputations regardless of their expanded/collapsed state. The patched version can be found on my website here and shall remain there more or less indefinitely unless the patch become official. If I knew how to upload it here as a patch or something without creating another addon with "(fixed)" in the title I would.

    To demonstrate the difference I added two slash commands. /repscan and /repscanold using the new and old scanning methods, respectively. On my main toon /repscan returns 105 factions while /repscanold returns only 33. Even with everything expanded it still doesn't quite get them all. [edit]Scratch that now that I fixed my counting issue /repscan and /repscanold match now with everything expanded.[/edit]

    You will need to log into all of your characters to get the missing factions added but that should be obvious, right?

    @Aranarth or current addon maintainer: I'm not worried about getting credit at all. If you wish to implement my fix as an official fix, unmodified or otherwise, by all means please do!

    [edit]
    Updated my patch.
    • Fixed a possible nil operation. One out of my 5 character ran into it every single time the rest had no problem.
    • Fixed counting bug. Now only counts the factions and headers that have rep. Before I was mistakingly counting them all.
    Report comment to moderator  
    Reply With Quote
    Unread 07-31-18, 08:11 PM  
    Lightstylez
    A Kobold Labourer

    Forum posts: 1
    File comments: 3
    Uploads: 0
    Anyone know an up to date addon like this? Can't find anything similar, was super useful back in the day.
    Report comment to moderator  
    Reply With Quote
    Post A Reply
    Page 2 of 2 < 1 2


    Report this file Report this File

    Category Jump: