(4Kb)

Updated: 08-16-18 01:34 PM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	Battle for Azeroth (8.0.1)
Updated:	08-16-18 01:34 PM
Created:	12-27-08 08:46 PM
Downloads:	85,212
Favorites:	309
MD5:
Categories:	Action Bar Mods, Buff, Debuff, Spell

rButtonTemplate

Version: 800.20180816

by: zork [More]

Intro

rButtonTemplate is a framework to theme Blizzard action, aura and item buttons. It does nothing on its own, needs a theme like rButtonTemplate_Zork.

API documentation

rButtonTemplate API documentation

Quick-Links

rActionBar, rActionBar_Zork, rBuffFrame, rBuffFrame_Zork, rButtonTemplate, rButtonTemplate_Zork

Git

https://github.com/zorker/rothui/tre...ButtonTemplate

https://github.com/zorker/rothui/com...ButtonTemplate

Optional Files (20)

File Name	Version	Size	Author	Date	Type
rButtonTemplate Zork	800.20180901	14kB	zork	09-02-18 03:34 AM	Addon
rButtonTemplate Gm	801-2018081101	4kB	gmarco	08-11-18 04:55 AM	Addon
rButtonTemplate Default	700.20161004	23kB	zork	10-04-16 06:24 AM	Addon
rActionbuttonstyler - Stylo	1.3	80kB	Ellementz	11-29-10 02:09 PM	Addon
rActionButtonStyler - Ailment	1.0	22kB	Ellementz	11-14-10 06:23 PM	Addon
rActionButtonStyler - Streets	1.2	24kB	Ellementz	11-09-10 02:59 PM	Addon
rActionbuttonstyler - Dae	1.0	3kB	mrDaeron	11-05-10 09:22 AM	Addon
rActionButtonStyler - Dajova	rev3	6kB	richerich	07-06-10 06:25 PM	Addon
rActionButtonStyler ichik	1.0	8kB	ichik	04-25-10 01:32 PM	Patch
rActionButtonStyler - TheDaily...	1.0	2kB	Crunchii	12-06-09 12:47 PM	Addon
rActionButtonStyler - 1px0r	1.0	3kB	Qaun	08-18-09 11:37 AM	Addon
rActionButtonStyler - Lolzen	1.0	10kB	Lolzen	07-06-09 12:02 PM	Addon
rActionButtonStyler - Smart Na...	v1	16kB	pHishr	06-17-09 06:57 PM	Addon
rActionButtonStyler - pHish	v1.3	18kB	pHishr	02-19-09 12:10 PM	Addon
rActionButtonStyler - round skin	001	21kB	zork	01-23-09 03:24 AM	Addon
rActionButtonStyler - Slim	1.0	5kB	Wimpface	01-22-09 09:38 AM	Addon
rActionButtonStyler - Stoneh	003	6kB	st0nedpenguin	01-20-09 08:16 PM	Patch
rActionButtonStyler - simplebu...	001	15kB	zork	01-20-09 03:59 PM	Addon
rActionButtonStyler - roth skin	001	10kB	zork	01-20-09 03:58 PM	Addon
rActionButtonStyler - Xsai	0.1	7kB	Tydor	01-17-09 10:12 AM	Addon

Comment Options

Page 22 of 29

« First

Last »

08-01-09, 04:00 AM

zork

A Pyroguard Emberseer

Forum posts: 1740

File comments: 3728

Uploads: 77

Additionally I am currently working on a workaround for the onUpdate func. The problem is that this function is called so often and you can only hook it. The CPU usage of that function is just insane. If you hook it the CPU usage gets visible. But I think its not possible to fix it only completly disabling the function would do it, but that is not allowed the function is secured.

Hmm...that is interesting. I seem to be allowed to rewrite the Blizzard function. This is good since the old bastard gets simply replaced.

I will release an updated version tomorrow. Went down from 140 to 13 CPU usage...the blizzard function just calls itself to often again. Tested it in combat and still no error messages. Good.

__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

Last edited by zork : 08-01-09 at 04:23 AM.

08-01-09, 03:45 AM

zork

A Pyroguard Emberseer

Forum posts: 1740

File comments: 3728

Uploads: 77

Ok this is easy. Dominos has a own functionality to keep KeyBinds active while in combat. So the rActionButtonStyler_AB_hotkey() function is not needed, thus the function call can be commented out. Additional the initial "hide" of the hotkey needs to be commented out aswell this is in the rActionButtonStyler_AB_style() function.

So for easier use.

Change line 46 from (comment out the initial setup)

Code:

  ho:Hide()

Code:

  --ho:Hide()

and change line 187 from (comment out the function call)

Code:

hooksecurefunc("ActionButton_UpdateHotkeys", rActionButtonStyler_AB_hotkey)

Code:

--hooksecurefunc("ActionButton_UpdateHotkeys", rActionButtonStyler_AB_hotkey)

Thats it.

__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

Last edited by zork : 08-01-09 at 03:46 AM.

07-31-09, 08:25 PM
MastaM00 A Kobold Labourer Forum posts: 0 File comments: 3 Uploads: 0	Has there been any movement on the missing keybinding text issue with Dominos? I tried commenting out the hide call and adding a show to no avail. --hotkey:Hide() hotkey:Show()

07-21-09, 07:20 AM
Rintrah A Defias Bandit Forum posts: 2 File comments: 17 Uploads: 0	Alright, thanks a lot. Again, I don't mean to sound like an ass hating on your mod - I really like it. Sounds like its out of your control due to blizz api, but range check isn't something I'm really worried about so that will be fine for me.

07-21-09, 06:58 AM

zork

A Pyroguard Emberseer

Forum posts: 1740

File comments: 3728

Uploads: 77

What pretty much kills any fps are so called "OnUpdate" functions. Those are loops that call themself on a given timer. Whats the problem on this with buttons is that any button on screen has such a OnUpdate function. Normal addons may use 1-2 of these functions but the Blizzard actionbars use this for every button on screen.

When does it get used. One word: "range-check". Everything else on your buttons can be handled by so called events, but the range-check can not.
If you set the timer to high your range check will look kinda laggy. If you set it to low you will kill your fps.

What you can do is to comment out this line

Code:

hooksecurefunc("ActionButton_OnUpdate",   rActionButtonStyler_AB_onupdate)

make it

Code:

--hooksecurefunc("ActionButton_OnUpdate",   rActionButtonStyler_AB_onupdate)

This will remove any onUpdate functionality from rButtonStyler. Btw...RedRange uses the same technique.

__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

07-20-09, 02:01 PM

Rintrah

A Defias Bandit

Forum posts: 2

File comments: 17

Uploads: 0

Originally posted by zork
This is no big deal since the performance stays the same since the default function would also be used without any addons. You just could not track it, since it is a Blizzard function.

I'm sure you know what you're talking about, but my experience is different. I keep coming back to your buttonstyler, but if I'm running rbarstyler alone doing an FPS-intensive fight like Algalon everything runs smooth. If I enable rbuttonstyler with no other changes I get a huge FPS hit (~10-12 fps change, which matters a lot in a raid setting like Algalon where there is particles everywhere). If rbuttonstyler using no more cpu than the blizzard function this would no be happening, no? Is it reapplying all texture button textures when any single update happens? ie, one button pushed = highlight = mod updates all buttons? I don't mean to sound like a ui snob and pretty ignorant about how mods work, i just really like this addon but find it unusable due to performance hit, maybe i'm just paranoid and retarded I D K

07-15-09, 04:42 AM

zork

A Pyroguard Emberseer

Forum posts: 1740

File comments: 3728

Uploads: 77

Are you using the latest version? Make sure you do not use a version that has

Code:

RANGE_INDICATOR = "";

still in there. When Blizzard released the new questlog items this entry gave me errors. But since I removed it the error was gone.

__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

07-14-09, 06:43 PM

-ReD-

A Murloc Raider

Forum posts: 5

File comments: 19

Uploads: 0

Originally posted by zork
Questhelper?

I am not sure of what you mean, but I am not using questhelper, what I mean is that when you pick up a quest (eg. a daily quest) that needs you to use an item in a certain place, the item icon appears besides the quest being tracked in the track log under your minimap, to avoid wasting time looking for it in the bags. However, everytime I try to click on that button I get that error message.

07-14-09, 10:19 AM

zork

A Pyroguard Emberseer

Forum posts: 1740

File comments: 3728

Uploads: 77

Questhelper?

__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

07-14-09, 09:57 AM
-ReD- A Murloc Raider Forum posts: 5 File comments: 19 Uploads: 0	Hello, I have recently started using this addon, however everytime I click on the quest items that appear right next the quest tracking log, I get the following message "ractionbuttonstyler has been blocked from an action only available to blizzard UI". Anyone knows a fix for this?

06-20-09, 10:53 AM
tophero21 A Cliff Giant Forum posts: 71 File comments: 26 Uploads: 0	note - i found that the setting did not seem to stick, by default the bindings will go back to being hidden regardless and you have to re-open your dominos settings and deselect/select the option again. seeing if i can get this figured out...

06-18-09, 04:05 PM
tophero21 A Cliff Giant Forum posts: 71 File comments: 26 Uploads: 0	you just have to comment out the line that says hotkey:Hide() and put in hotkey:Show() below it, not the whole part that he posted. I did this while in-game, reloaded ui to pick up the change and then found that I also had to open up the dominos options and deselect/reselect the show bindings box to get them to show.

06-07-09, 12:21 AM

Qupe

A Warpwood Thunder Caller

Forum posts: 92

File comments: 523

Uploads: 3

Originally posted by MoonWitch
No clue man, just thought I'd post how I solved the issue. I still have all my textures >.< But that piece of code doesn't affect texturing, only the hotkey display. Perhaps you commented out too much?

I probably did, what exact portion did you comment out?

06-06-09, 08:29 AM

MoonWitch

A Firelord

Forum posts: 455

File comments: 162

Uploads: 9

Originally posted by Qupe
So is this a working fix? I tried commenting that section of code out and it did show binding text but it removed the texture from my bars.

No clue man, just thought I'd post how I solved the issue. I still have all my textures >.< But that piece of code doesn't affect texturing, only the hotkey display. Perhaps you commented out too much?

06-01-09, 01:46 PM

Qupe

A Warpwood Thunder Caller

Forum posts: 92

File comments: 523

Uploads: 3

So is this a working fix? I tried commenting that section of code out and it did show binding text but it removed the texture from my bars.

Originally posted by MoonWitch
Sooo I was wrong, I must have missed a piece of code. I'll get it right though.

Disabling this piece solves the issue:

Code:

local function rActionButtonStyler_AB_hotkey(self, actionButtonType) if (not actionButtonType) then actionButtonType = "ACTIONBUTTON"; end local hotkey = _G[self:GetName().."HotKey"] local key = GetBindingKey(actionButtonType..self:GetID()) or GetBindingKey("CLICK "..self:GetName()..":LeftButton"); local text = GetBindingText(key, "KEY_", 1); hotkey:SetText(text); --hotkey:Hide() hotkey:Show() end

Now other then take the text of the hotkey and placing it there again, what else does this do? I can't seem to detect how taking this out affects it.

Page 22 of 29

« First

Last »

Report this File

Category Jump: