minipet reborn

Lordfather has recently updated his minipet addon, can be found at warcraftpets.com. Don't know wich is better but makes the name "reborn" mean that his version sucks instead of being long time from last update.

One of these days I'll download this and make a comparison of the two, when/if I do I'll post the results here =)

<--- a dancing banana

(And the thing with ace libraries, if you are using one addon with it you can just as well use more since even though the file sizes are bigger they share libraries. At first cleanup all unused libraries are dropped.)

First of all, allow me to say that I support people working on the same kinds of mod ideas. Wholeheartedly at that. In fact, if you take a look around some of the WoWI comments, I can be found doing just that.

It's just that with this one, you said that Lord Farlander's mod is worse for using libraries. I want to catch you on that fallacy; have you actually done any profiling and do you have the numbers to show that your mod is more efficient than his? Libraries don't always make for an inefficient mod, in some cases they can improve efficiency.

One thing I can say is that the way you've approached the functions loads them all into the global namespace, this is generally known as polution and it's not considered a good thing to do. Instead of doing what you've done, ou're better off using a local Minipet table, and then putting all of your functions inside that table. So instead of MPthis and MPthat all being loaded into the global namespace, you could have Minipet.this and Minipet.that, and only Minipet would be loaded into the global namespace.

With some cleanup work, I do think this could be better than Lord Farlander's mod, I see the potential. At the moment though, I don't think it is. But that's just my opinion. I think you should keep working at it, I do think you can achieve the kind of goals you seek.

--

In fact, instead of using the one global approach, you could just localise everything. But if you wanted to do that then you'd have to remove the XML and go down the CreateFrame() approach, which is generally considered a more current system anyway. The XML approach is considered obsolete these days because of CreateFrame(), but really... at the end of the day it's your choice. I'm just trying to help you out here.