World of Warcraft AddOns » Stand-Alone Addons » Chat Mods » TalentSpecSpamFilter
  • Addon Info.
  • Change Log
  • Comments (22)
    • Download
    (4Kb)
    Download
    Updated: 02-27-11 01:03 PM
    Pictures
    File Info
    Updated:02-27-11 01:03 PM
    Created:02-13-11 12:00 PM
    Downloads:2,526
    Favorites:23
    MD5:

    TalentSpecSpamFilter

    Version: v3
    by: Mortilus [More]

    By Azmenen of Kargath

    TalentSpecSpamFilter is an addon that consolidates the "learned/unlearned" information from 20 lines of ability-learning spam into condensed summaries. In other words, TalentSpecSpamFilter turns this
    You have unlearned [Wild Growth].
    You have unlearned [Tree of Life].
    You have unlearned [Swiftmend].
    You have unlearned [Meditation].
    You have unlearned [Gift of Nature].
    You have unlearned [Disentanglement].
    You have learned a new ability: [Aggression].
    You have learned a new ability: [Vengeance].
    You have learned a new ability: [Mangle].
    You have learned a new ability: [Mangle].
    You have learned a new ability: [Feral Instinct].
    You have learned a new ability: [Feral Charge].
    You have learned a new ability: [Feral Charge].
    You have learned a new ability: [Berserk].

    into this

    You have unlearned [Wild Growth], [Tree of Life], [Swiftmend], [Meditation], [Gift of Nature], [Disentanglement].
    You have learned a new ability: [Aggression], [Vengeance], [Mangle], [Mangle], [Feral Instinct], [Feral Charge], [Feral Charge], [Berserk].

    TalentSpecSpamFilter has no in-game config because it doesn't need one. Just install it into your World of Warcraft AddOns folder, and it just works.

    3
    • Fixed a bug where TSSF would only print 1 message per spell per spec switch. So if you are a Druid with Bear mainspec and Kitty offspec and you switch, you would previously only see 1 message for any shared abilities (such as Mangle, Feral Charge, etc).
    • Fixed a bug where the check for printing learned spells and abilities also included unlearned spells.



    2
    • Fixed a bug where TSSF would end the printed messages with a comma.
    • Fixed a bug where TSSF would print its messages on login, with no abilities learned or unlearned. Don't know why this didn't happen on my client - Thanks aremyr and froidre!
    • Fixed a bug where TSSF would repeat messages on some clients (Spanish) - Thanks Mazarbul!
    • Fixed a bug where TSSF would print both messages when leveling up and an ability is learned (correct behavior is only one message printed).



    1
    • Initial Release.
    Post A Reply Comment Options
    Page 1 of 2 1 2 >
    Unread 02-13-11, 04:15 PM  
    froidre
    A Kobold Labourer

    Forum posts: 1
    File comments: 7
    Uploads: 0
    Great concept, but it should not echo this text on each login:

    You have unlearned.
    You have learned a new ability.
    Report comment to moderator  
    Reply With Quote
    Unread 02-13-11, 11:27 PM  
    Mortilus
    A Deviate Faerie Dragon
    AddOn Author - Click to view AddOns

    Forum posts: 12
    File comments: 207
    Uploads: 7
    Originally posted by froidre
    Great concept, but it should not echo this text on each login:

    You have unlearned.
    You have learned a new ability.
    Strange, that does not happen to me when i login ... i tried two characters (not including my "tester" character) and did not have it happen

    do you have any way to reproduce it?
    Last edited by Mortilus : 02-13-11 at 11:28 PM.
    Report comment to moderator  
    Reply With Quote
    Unread 02-14-11, 08:58 AM  
    aremyr
    A Kobold Labourer

    Forum posts: 0
    File comments: 12
    Uploads: 0
    Same for me.



    and yes, i can reproduce it everytime i log in
    Report comment to moderator  
    Reply With Quote
    Unread 02-14-11, 11:00 AM  
    Mortilus
    A Deviate Faerie Dragon
    AddOn Author - Click to view AddOns

    Forum posts: 12
    File comments: 207
    Uploads: 7
    Hello aremyr and froidre!

    First off, thank you (both of you) very much for the feedback

    Secondly, I have a version that I believe will fix the issue, could I get one (or both) of you to test it before I release it, so I know it works?

    Thirdly, aremyr, I see you're on a German client. May I ask, when you switch specs without TSSF active, is the learned/unlearned text in English or is it in German? I ask because TSSF should be localizing to whatever language the client uses, every time the UI is reloaded. Your screenshot indicates that TSSF is just using English, which is wrong, and weird.
    Report comment to moderator  
    Reply With Quote
    Unread 02-14-11, 11:05 AM  
    Mazarbul
    A Kobold Labourer

    Forum posts: 0
    File comments: 32
    Uploads: 0
    Everytime I switch specs, the spell links are duplicated. I mean, If I learn Mortal Strike, it says I have learned it twice.

    Playing in Spanish. No error messages.
    Report comment to moderator  
    Reply With Quote
    Unread 02-14-11, 11:15 AM  
    Mortilus
    A Deviate Faerie Dragon
    AddOn Author - Click to view AddOns

    Forum posts: 12
    File comments: 207
    Uploads: 7
    Originally posted by Mazarbul
    Everytime I switch specs, the spell links are duplicated. I mean, If I learn Mortal Strike, it says I have learned it twice.

    Playing in Spanish. No error messages.
    interesting, I am pretty sure I know a way to fix that. I'll toss it into the next version. Would you be interested in testing it?

    Also, same question to you as to aremyr: Are the learned/unlearned messages from TSSF coming up in English or Spanish?
    Report comment to moderator  
    Reply With Quote
    Unread 02-14-11, 12:44 PM  
    aremyr
    A Kobold Labourer

    Forum posts: 0
    File comments: 12
    Uploads: 0
    Originally posted by Mortilus
    Thirdly, aremyr, I see you're on a German client. May I ask, when you switch specs without TSSF active, is the learned/unlearned text in English or is it in German? I ask because TSSF should be localizing to whatever language the client uses, every time the UI is reloaded. Your screenshot indicates that TSSF is just using English, which is wrong, and weird.
    Sure i can test it, no problem. But while i do play on a german realm, i'm using the enGB client; so i guess that the localization isn't really the problem.
    Report comment to moderator  
    Reply With Quote
    Unread 02-14-11, 07:34 PM  
    froidre
    A Kobold Labourer

    Forum posts: 1
    File comments: 7
    Uploads: 0
    Originally posted by Mortilus
    [b]... could I get one (or both) of you to test it before I release it?
    Definitely, where can I pick it up?
    Report comment to moderator  
    Reply With Quote
    Unread 02-16-11, 10:50 AM  
    shaggy7
    A Kobold Labourer

    Forum posts: 0
    File comments: 10
    Uploads: 0
    When I log in to a character I get TSSF lines for unlearned and learned with no spells associated. This is part of logging in, and happens before I can do anything in-game, I haven't attempted a respec or even attempted to move.

    I looked at your code, and a temporary fix for that problem would be to change lines 172-173 to the following:

    Code:
    if (table.getn(TSSF_addon.unlearned) > 0) then
	DEFAULT_CHAT_FRAME:AddMessage(TSSF_addon.patternFragments[1][1] .. TSSF_addon.print(TSSF_addon.unlearned), 1, 1, 0);
end

if (table.getn(TSSF_addon.learned) > 0) then
	DEFAULT_CHAT_FRAME:AddMessage(TSSF_addon.patternFragments[2][1] .. TSSF_addon.print(TSSF_addon.learned) .. TSSF_addon.print(TSSF_addon.learnedspell), 1, 1, 0);
end
    I do not know why this mod is being triggered by some login-related event, which is ultimately the root of the problem. However, that will serve as a functional work-around whereby it will not print a message if that particular array has nothing in it. The less-obvious, but more-complete, solution is to simply not be triggered by some event which would lead to empty arrays being thrown into your little printing function.
    Report comment to moderator  
    Reply With Quote
    Unread 02-16-11, 11:24 PM  
    Mortilus
    A Deviate Faerie Dragon
    AddOn Author - Click to view AddOns

    Forum posts: 12
    File comments: 207
    Uploads: 7
    Originally posted by shaggy7
    When I log in to a character I get TSSF lines for unlearned and learned with no spells associated. This is part of logging in, and happens before I can do anything in-game, I haven't attempted a respec or even attempted to move.
    Yup, I've got that fixed and it's tested, seems okay so I'm going to post it soon


    I do not know why this mod is being triggered by some login-related event, which is ultimately the root of the problem.
    Yeah, I have no idea why it's happening to you guys. It doesn't happen to me, on any of my characters. I've implemented the "don't print it" fix, which should be sufficient. Perhaps when the UI is loaded, Blizzard has "hidden" system messages that load the localized global constants, which could trigger my addon?
    Report comment to moderator  
    Reply With Quote
    Unread 02-17-11, 10:58 AM  
    Mortilus
    A Deviate Faerie Dragon
    AddOn Author - Click to view AddOns

    Forum posts: 12
    File comments: 207
    Uploads: 7
    Version 2 is out!
    • Fixed a bug where TSSF would end the printed messages with a comma.
    • Fixed a bug where TSSF would print its messages on login, with no abilities learned or unlearned. Don't know why this didn't happen on my client - Thanks aremyr and froidre!
    • Fixed a bug where TSSF would repeat messages on some clients (Spanish) - Thanks Mazarbul!
    • Fixed a bug where TSSF would print both messages when leveling up and an ability is learned (correct behavior is only one message printed).
    Report comment to moderator  
    Reply With Quote
    Unread 02-17-11, 12:11 PM  
    Mazarbul
    A Kobold Labourer

    Forum posts: 0
    File comments: 32
    Uploads: 0
    Glad you fixed. I'll try it now.

    Originally posted by Mortilus
    interesting, I am pretty sure I know a way to fix that. I'll toss it into the next version. Would you be interested in testing it?

    Also, same question to you as to aremyr: Are the learned/unlearned messages from TSSF coming up in English or Spanish?
    1) Im not sure if I can. What should I do?
    2) In Spanish.
    Last edited by Mazarbul : 02-17-11 at 12:12 PM.
    Report comment to moderator  
    Reply With Quote
    Unread 02-17-11, 12:28 PM  
    Mazarbul
    A Kobold Labourer

    Forum posts: 0
    File comments: 32
    Uploads: 0
    Sorry for doublepost, but it works well now.
    Report comment to moderator  
    Reply With Quote
    Unread 02-17-11, 10:47 PM  
    Mortilus
    A Deviate Faerie Dragon
    AddOn Author - Click to view AddOns

    Forum posts: 12
    File comments: 207
    Uploads: 7
    Originally posted by Mazarbul
    Sorry for doublepost, but it works well now.
    Excellent
    Report comment to moderator  
    Reply With Quote
    Unread 02-24-11, 09:50 PM  
    aremyr
    A Kobold Labourer

    Forum posts: 0
    File comments: 12
    Uploads: 0
    Got something new for you, that's what happens when i switch between my two feral specs:


    The addon kinda forgets a couple of spells :/
    Report comment to moderator  
    Reply With Quote
    Post A Reply
    Page 1 of 2 1 2 >


    Report this file Report this File

    Category Jump: